Quantum\Libraries\Database\Sleekdb\Statements\Model

Complexity

Total Complexity

7

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	prop()	0	6	2
A	save()	0	11	2
A	create()	0	4	1
A	delete()	0	4	1
A	deleteMany()	0	3	1

<?php

/**
 * Quantum PHP Framework
 *
 * An open source software development framework for PHP
 *
 * @package Quantum
 * @author Arman Ag. <arman.ag@softberg.org>
 * @copyright Copyright (c) 2018 Softberg LLC (https://softberg.org)
 * @link http://quantum.softberg.org/
 * @since 2.6.0
 */

namespace Quantum\Libraries\Database\Sleekdb\Statements;

use Quantum\Libraries\Database\DbalInterface;

/**
 * Trait Model
 * @package Quantum\Libraries\Database\Sleekdb\Statements
 */
trait Model
{

    /**
     * @inheritDoc
     */
    public function create(): DbalInterface
    {
        $this->isNew = true;

The property isNew does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this;

The expression return $this returns the type Quantum\Libraries\Database\Sleekdb\Statements\Model which is incompatible with the type-hinted return Quantum\Libraries\Database\DbalInterface.

    }

    /**
     * @inheritDoc
     */
    public function prop(string $key, $value = null)
    {
        if ($value) {
            $this->modifiedFields[$key] = $value;

The property modifiedFields does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        } else {
            return $this->modifiedFields[$key] ?? null;
        }
    }

    /**
     * @inheritDoc
     * @throws \SleekDB\Exceptions\IOException
     * @throws \SleekDB\Exceptions\InvalidConfigurationException
     * @throws \Quantum\Exceptions\DatabaseException
     * @throws \SleekDB\Exceptions\InvalidArgumentException
     */
    public function save(): bool
    {
        $ormMode = $this->getOrmModel();

It seems like getOrmModel() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($this->isNew) {
            $ormMode->insert($this->modifiedFields);
        } else {
            $ormMode->update($this->modifiedFields);
        }

        return true;
    }

    /**
     * @inheritDoc
     * @throws \Quantum\Exceptions\DatabaseException
     * @throws \SleekDB\Exceptions\IOException
     * @throws \SleekDB\Exceptions\InvalidArgumentException
     * @throws \SleekDB\Exceptions\InvalidConfigurationException
     */
    public function delete(): bool
    {
        $pk = $this->getOrmModel()->getPrimaryKey();
        return $this->getOrmModel()->deleteById($this->data[$pk]);
    }

    /**
     * @inheritDoc
     * @throws \Quantum\Exceptions\DatabaseException
     * @throws \SleekDB\Exceptions\IOException
     * @throws \SleekDB\Exceptions\InvalidArgumentException
     * @throws \SleekDB\Exceptions\InvalidConfigurationException
     */
    public function deleteMany(): bool
    {
        return $this->getBuilder()->getQuery()->delete();

It seems like getBuilder() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}