Quantum\Libraries\Session\Factories\SessionFactory

Complexity

Total Complexity

6

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getAdapterClass()	0	7	2
A	get()	0	7	2
A	createInstance()	0	11	2

<?php

/**
 * Quantum PHP Framework
 *
 * An open source software development framework for PHP
 *
 * @package Quantum
 * @author Arman Ag. <arman.ag@softberg.org>
 * @copyright Copyright (c) 2018 Softberg LLC (https://softberg.org)
 * @link http://quantum.softberg.org/
 * @since 2.9.5
 */

namespace Quantum\Libraries\Session\Factories;

use Quantum\Libraries\Session\Adapters\Database\DatabaseSessionAdapter;
use Quantum\Libraries\Session\Adapters\Native\NativeSessionAdapter;
use Quantum\Libraries\Session\Exceptions\SessionException;
use Quantum\Libraries\Config\Exceptions\ConfigException;
use Quantum\Libraries\Session\Session;
use Quantum\Di\Exceptions\DiException;
use Quantum\Exceptions\BaseException;
use Quantum\Loader\Setup;
use ReflectionException;

/**
 * Class SessionFactory
 * @package Quantum\Libraries\Session
 */
class SessionFactory
{

    /**
     * Supported adapters
     */
    const ADAPTERS = [
        Session::NATIVE => NativeSessionAdapter::class,
        Session::DATABASE => DatabaseSessionAdapter::class,
    ];

    /**
     * @var Session|null
     */
    private static $instance = null;

    /**
     * @param array|null $storage
     * @return Session
     * @throws BaseException
     * @throws ConfigException
     * @throws DiException
     * @throws ReflectionException
     */
    public static function get(?array $storage = null): Session
    {
        if (self::$instance === null) {
            return self::$instance = self::createInstance($storage);

The call to Quantum\Libraries\Session\Factories\SessionFactory::createInstance() has too many arguments starting with $storage.

        }

        return self::$instance;
    }

    /**
     * @return Session
     * @throws BaseException
     * @throws ConfigException
     * @throws DiException
     * @throws ReflectionException
     */
    private static function createInstance(): Session
    {
        if (!config()->has('session')) {
            config()->import(new Setup('Config', 'session'));
        }

        $adapter = config()->get('session.current');

        $adapterClass = self::getAdapterClass($adapter);

It seems like $adapter can also be of type null; however, parameter $adapter of Quantum\Libraries\Session\Factories\SessionFactory::getAdapterClass() does only seem to accept string, maybe add an additional type check?

        return new Session(new $adapterClass(config()->get('session.' . $adapter)));
    }

    /**
     * @param string $adapter
     * @return string
     * @throws BaseException
     */
    private static function getAdapterClass(string $adapter): string
    {
        if (!array_key_exists($adapter, self::ADAPTERS)) {
            throw SessionException::adapterNotSupported($adapter);
        }

        return self::ADAPTERS[$adapter];
    }
}