Total Complexity | 41 |
Total Lines | 297 |
Duplicated Lines | 0 % |
Changes | 4 | ||
Bugs | 0 | Features | 0 |
Complex classes like BasePaginator often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use BasePaginator, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
5 | abstract class BasePaginator implements PaginatorInterface |
||
6 | { |
||
7 | /** |
||
8 | * @var string |
||
9 | */ |
||
10 | protected const PAGINATION_CLASS = 'pagination'; |
||
11 | |||
12 | /** |
||
13 | * @var string |
||
14 | */ |
||
15 | protected const PAGINATION_CLASS_ACTIVE = 'active'; |
||
16 | |||
17 | /** |
||
18 | * @var string |
||
19 | */ |
||
20 | protected const PER_PAGE = 'per_page'; |
||
21 | |||
22 | /** |
||
23 | * @var string |
||
24 | */ |
||
25 | protected const PAGE = 'page'; |
||
26 | |||
27 | /** |
||
28 | * @var int |
||
29 | */ |
||
30 | protected const FIRST_PAGE_NUMBER = 1; |
||
31 | |||
32 | /** |
||
33 | * @var int |
||
34 | */ |
||
35 | protected $total; |
||
36 | |||
37 | /** |
||
38 | * @var string |
||
39 | */ |
||
40 | protected $baseUrl; |
||
41 | |||
42 | /** |
||
43 | * @var int |
||
44 | */ |
||
45 | protected $perPage; |
||
46 | |||
47 | /** |
||
48 | * @var int |
||
49 | */ |
||
50 | protected $page; |
||
51 | |||
52 | /** |
||
53 | * @return int |
||
54 | */ |
||
55 | public function currentPageNumber(): int |
||
56 | { |
||
57 | return $this->page; |
||
58 | } |
||
59 | |||
60 | /** |
||
61 | * @param bool $withBaseUrl |
||
62 | * @return string|null |
||
63 | */ |
||
64 | public function currentPageLink(bool $withBaseUrl = false): ?string |
||
65 | { |
||
66 | return $this->getPageLink($this->page, $withBaseUrl); |
||
67 | } |
||
68 | |||
69 | /** |
||
70 | * @return int|null |
||
71 | */ |
||
72 | public function previousPageNumber(): ?int |
||
73 | { |
||
74 | $previous = null; |
||
75 | if ($this->page > 1) { |
||
76 | $previous = $this->page - 1; |
||
77 | } elseif ($this->page == 1) { |
||
78 | $previous = $this->page; |
||
79 | } |
||
80 | |||
81 | return $previous; |
||
82 | } |
||
83 | |||
84 | /** |
||
85 | * @param bool $withBaseUrl |
||
86 | * @return string|null |
||
87 | */ |
||
88 | public function previousPageLink(bool $withBaseUrl = false): ?string |
||
89 | { |
||
90 | return $this->getPageLink($this->previousPageNumber(), $withBaseUrl); |
||
91 | } |
||
92 | |||
93 | /** |
||
94 | * @return int|null |
||
95 | */ |
||
96 | public function nextPageNumber(): ?int |
||
97 | { |
||
98 | $next = null; |
||
99 | if ($this->page < $this->lastPageNumber()) { |
||
100 | $next = $this->page + 1; |
||
101 | } elseif ($this->page == $this->lastPageNumber()) { |
||
102 | $next = $this->page; |
||
103 | } |
||
104 | return $next; |
||
105 | } |
||
106 | |||
107 | /** |
||
108 | * @param bool $withBaseUrl |
||
109 | * @return string|null |
||
110 | */ |
||
111 | public function nextPageLink(bool $withBaseUrl = false): ?string |
||
112 | { |
||
113 | return $this->getPageLink($this->nextPageNumber(), $withBaseUrl); |
||
114 | } |
||
115 | |||
116 | /** |
||
117 | * @param bool $withBaseUrl |
||
118 | * @return string|null |
||
119 | */ |
||
120 | public function firstPageLink(bool $withBaseUrl = false): ?string |
||
121 | { |
||
122 | return $this->getPageLink(self::FIRST_PAGE_NUMBER, $withBaseUrl); |
||
123 | } |
||
124 | |||
125 | /** |
||
126 | * @return int |
||
127 | */ |
||
128 | public function lastPageNumber(): int |
||
129 | { |
||
130 | return (int)ceil($this->total() / $this->perPage); |
||
131 | } |
||
132 | |||
133 | /** |
||
134 | * @param bool $withBaseUrl |
||
135 | * @return string|null |
||
136 | */ |
||
137 | public function lastPageLink(bool $withBaseUrl = false): ?string |
||
138 | { |
||
139 | return $this->getPageLink($this->lastPageNumber(), $withBaseUrl); |
||
140 | } |
||
141 | |||
142 | /** |
||
143 | * @return int |
||
144 | */ |
||
145 | public function perPage(): int |
||
146 | { |
||
147 | return $this->perPage; |
||
148 | } |
||
149 | |||
150 | /** |
||
151 | * @return int |
||
152 | */ |
||
153 | public function total(): int |
||
154 | { |
||
155 | return $this->total; |
||
156 | } |
||
157 | |||
158 | /** |
||
159 | * @param bool $withBaseUrl |
||
160 | * @return array |
||
161 | */ |
||
162 | public function links(bool $withBaseUrl = false): array |
||
170 | } |
||
171 | |||
172 | /** |
||
173 | * @param bool $withBaseUrl |
||
174 | * @return string |
||
175 | */ |
||
176 | protected function getUri(bool $withBaseUrl = false): string |
||
177 | { |
||
178 | $routeUrl = preg_replace('/([?&](page|per_page)=\d+)/', '', route_uri()); |
||
179 | $routeUrl = preg_replace('/&/', '?', $routeUrl, 1); |
||
180 | $url = $routeUrl; |
||
181 | |||
182 | if ($withBaseUrl) { |
||
183 | $url = $this->baseUrl . $routeUrl; |
||
184 | } |
||
185 | |||
186 | $delimiter = strpos($url, '?') ? '&' : '?'; |
||
187 | return $url . $delimiter; |
||
188 | } |
||
189 | |||
190 | protected function getPageLink($pageNumber, $withBaseUrl = false): ?string |
||
196 | } |
||
197 | |||
198 | /** |
||
199 | * @param bool $withBaseUrl |
||
200 | * @param $pageItemsCount |
||
201 | * @return string|null |
||
202 | */ |
||
203 | public function getPagination(bool $withBaseUrl = false, $pageItemsCount = null): ?string |
||
204 | { |
||
205 | if (!is_null($pageItemsCount) && $pageItemsCount < 3) { |
||
233 | } |
||
234 | |||
235 | /** |
||
236 | * @param $pagination |
||
237 | * @param $currentPage |
||
238 | * @param $totalPages |
||
239 | * @param $pageItemsCount |
||
240 | * @param $withBaseUrl |
||
241 | * @return mixed|string |
||
242 | */ |
||
243 | protected function getPageItems($pagination, $currentPage, $totalPages, $pageItemsCount, $withBaseUrl = false) |
||
244 | { |
||
245 | $startPage = max(1, $currentPage - ceil(($pageItemsCount - 3) / 2)); |
||
246 | $endPage = min($totalPages, $startPage + $pageItemsCount - 3); |
||
247 | $startPage = max(1, $endPage - $pageItemsCount + 3); |
||
248 | |||
249 | if ($startPage > 1) { |
||
250 | $pagination .= '<li><a href="' . $this->firstPageLink() . '">1</a></li>'; |
||
251 | if ($startPage > 2) { |
||
252 | $pagination .= '<li><span>...</span></li>'; |
||
253 | } |
||
254 | } |
||
255 | |||
256 | $links = $this->links($withBaseUrl); |
||
257 | $pagination = $this->getItemsLinks($pagination, $startPage, $endPage, $currentPage, $links, $withBaseUrl); |
||
|
|||
258 | |||
259 | if ($endPage < $totalPages) { |
||
260 | if ($endPage < $totalPages - 1) { |
||
261 | $pagination .= '<li><span>...</span></li>'; |
||
262 | } |
||
263 | |||
264 | $pagination .= '<li><a href="' . $links[$totalPages - 1] . '">' . $totalPages . '</a></li>'; |
||
265 | } |
||
266 | return $pagination; |
||
267 | } |
||
268 | |||
269 | /** |
||
270 | * @param string|null $nextPageLink |
||
271 | * @return string |
||
272 | */ |
||
273 | protected function getNextPageItem(?string $nextPageLink): string |
||
274 | { |
||
275 | $link = ''; |
||
276 | if (!empty($nextPageLink)){ |
||
277 | $link = '<li><a href="' . $nextPageLink . '">Next »</a></li>'; |
||
278 | } |
||
279 | return $link; |
||
280 | } |
||
281 | |||
282 | /** |
||
283 | * @param string|null $previousPageLink |
||
284 | * @return string |
||
285 | */ |
||
286 | protected function getPreviousPageItem(?string $previousPageLink): string |
||
293 | } |
||
294 | |||
295 | protected function getItemsLinks($pagination, $startPage, $endPage, $currentPage, array $links) |
||
302 | } |
||
303 | } |
This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.
If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. Please note the @ignore annotation hint above.