BlogController - Code Metrics - sofiafahle/anax-mvc-content2 - Measure and Improve Code Quality continuously with Scrutinizer

BlogController A
last analyzed 2016-03-14 20:36 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	288
Duplicated Lines	48.96 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
wmc	22
c	3
b	0
f	1
lcom	1
cbo	5
dl	141
loc	288
rs	10

15 Methods

Rating	Name	Duplication	Size	Complexity
A	initialize()	0	5	1
A	setupAction()	0	6	1
A	indexAction()	0	10	1
A	listAction()	10	10	1
A	viewAction()	15	15	2
A	addAction()	15	15	1
A	updateAction()	21	21	2
A	deleteAction()	0	10	2
A	softDeleteAction()	15	15	2
A	restoreAction()	13	13	2
A	activateAction()	0	13	2
A	inactivateAction()	15	15	2
A	activeAction()	13	13	1
A	inactiveAction()	12	12	1
A	trashAction()	12	12	1

How to fix Duplicated Code

<?php

namespace Anax\Blog;
 
/**
 * A controller for a blog and its posts.
 *
 */
class BlogController implements \Anax\DI\IInjectionAware
{
    use \Anax\DI\TInjectable,
        \Anax\MVC\TRedirectHelpers;
	
	public $blog;
	
	/**
	 * Initialize the controller.
	 *
	 * @return void
	 */
	public function initialize()
	{
		$this->blog = new \Anax\Blog\Blog();
		$this->blog->setDI($this->di);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
	}
	
	public function setupAction()
	{
		require('setup.php');
		
		$this->redirectTo('blog/list');
	}
	
	public function indexAction()
	{
		$all = $this->blog->findAllOrder('id', 'DESC');
	 
		$this->theme->setTitle("A blog");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$this->views->add('blog/view-blog', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
			'posts' => $all,
			'title' => "A Blog",
		]);
	}
	
	/**
	 * List all blogposts.
	 *
	 * @return void
	 */
	public function listAction()

	{
		$all = $this->blog->findAll();
	 
		$this->theme->setTitle("List all posts");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$this->views->add('blog/list', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
			'posts' => $all,
			'title' => "All blogposts",
		]);
	}
	
	/**
	 * View blogpost with slug.
	 *
	 * @param int $slug of post to display
	 *
	 * @return void
	 */
	public function viewAction($slug = null)

	{
		$blog = $this->blog->findWhere('slug', $slug);
		
		if (empty($blog)) {
			die('No such post!');
		}
		
		$post = $blog[0];	 
	 
		$this->theme->setTitle("View post with id");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$this->views->add('blog/view-post', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
			'post' => $post,
		]);
	}
	
	/**
	 * Add new blogpost.
	 *
	 *
	 * @return void
	 */
	public function addAction()

	{
		
		$form = new \Anax\Blog\CFormAddPost();
        $form->setDI($this->di);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		
		// Check the status of the form
        $form->check();
	 
		$this->di->theme->setTitle("Add blogpost");
        $this->di->views->add('default/page', [
            'title' => "Add a blogpost",
            'content' => $form->getHTML()
        ]);
	}
	
	/**
	 * Edit a blogpost.
	 *
	 * @param string $id of post to edit.
	 *
	 * @return void
	 */
	public function updateAction($id = null)

	{
		
		if (!$id) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
			$this->redirectTo('blog');
		}
		
		$blog = $this->blog->find($id);
		
		$form = new \Anax\Blog\CFormUpdatePost($blog);
        $form->setDI($this->di);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		
		// Check the status of the form
        $form->check();
	 
		$this->di->theme->setTitle("Update blogpost");
        $this->di->views->add('default/page', [
            'title' => "Update a blogpost",
            'content' => $form->getHTML()
        ]);
	}
	
	/**
	 * Delete blogpost.
	 *
	 * @param integer $id of post to delete.
	 *
	 * @return void
	 */
	public function deleteAction($id = null)
	{
		if (!isset($id)) {
			die("Missing id");
		}
	 
		$res = $this->blog->delete($id);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
	 
		$this->redirectTo('blog/list');
	}
	
	/**
	 * Delete (soft) blogpost.
	 *
	 * @param integer $id of post to delete.
	 *
	 * @return void
	 */
	public function softDeleteAction($id = null)

	{
		if (!isset($id)) {
			die("Missing id");
		}
	 
		$now = gmdate('Y-m-d H:i:s');
	 
		$blog = $this->blog->find($id);
	 
		$blog->deleted = $now;
		$blog->save();
	
		$this->redirectTo('blog/trash');
	}
	
	/**
	 * Restore (soft) deleted blogpost.
	 *
	 * @param integer $id of post to restore.
	 *
	 * @return void
	 */
	public function restoreAction($id = null)

	{
		if (!isset($id)) {
			die("Missing id");
		}
	 
		$blog = $this->blog->find($id);
	 
		$blog->deleted = null;
		$blog->save();
	 
		$this->redirectTo('blog');
	}
	
	/**
	 * Activate blogpost.
	 *
	 * @param integer $id of upost to activate.
	 *
	 * @return void
	 */
	public function activateAction($id = null)
	{
		if (!isset($id)) {
			die("Missing id");
		}
	 
		$blog = $this->blog->find($id);
	 
		$blog->inactivated = null;
		$blog->save();
	 
		$this->redirectTo('blog/list');
	}
	
	/**
	 * Inactivate blogpost.
	 *
	 * @param integer $id of post to inactivate.
	 *
	 * @return void
	 */
	public function inactivateAction($id = null)

	{
		if (!isset($id)) {
			die("Missing id");
		}
		
		$now = gmdate('Y-m-d H:i:s');
	 
		$blog = $this->blog->find($id);
	 
		$blog->inactivated = $now;
		$blog->save();
	 
		$this->redirectTo('blog/inactive');
	}
	
	/**
	 * List all active and not deleted blogposts.
	 *
	 * @return void
	 */
	public function activeAction()

	{
		$all = $this->blog->query()
			->where('inactivated IS NULL')
			->andWhere('deleted is NULL')
			->execute();
	 
		$this->theme->setTitle("Posts that are active");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$this->views->add('blog/active', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
			'posts' => $all,
			'title' => "Blogposts that are active",
		]);
	}
	
	/**
	 * List all inactive blogposts.
	 *
	 * @return void
	 */
	public function inactiveAction()

	{
		$all = $this->blog->query()
			->where('inactivated IS NOT NULL')
			->execute();
	 
		$this->theme->setTitle("Posts that are inactive");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$this->views->add('blog/inactive', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
			'posts' => $all,
			'title' => "Blogposts that are inactive",
		]);
	}
	
	/**
	 * List all deleted blogposts.
	 *
	 * @return void
	 */
	public function trashAction()

	{
		$all = $this->blog->query()
			->where('deleted IS NOT NULL')
			->execute();
	 
		$this->theme->setTitle("Posts that are deleted");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$this->views->add('blog/deleted', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
			'posts' => $all,
			'title' => "Blogposts that are deleted",
		]);
	}
	 
}

1			<?php
2
3			namespace Anax\Blog;
4
5			/**
6			* A controller for a blog and its posts.
7			*
8			*/
9			class BlogController implements \Anax\DI\IInjectionAware
10			{
11			use \Anax\DI\TInjectable,
12			\Anax\MVC\TRedirectHelpers;
13
14			public $blog;
15
16			/**
17			* Initialize the controller.
18			*
19			* @return void
20			*/
21			public function initialize()
22			{
23			$this->blog = new \Anax\Blog\Blog();
24			$this->blog->setDI($this->di);
			0 ignored issues – show Bug introduced 2016-03-13 11:56 UTC by Report Bug Copy Issue Report It seems like `$this->di` can also be of type `array` or `null`; however, `Anax\DI\TInjectable::setDI()` does only seem to accept `object<Anax\DI\class>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
25			}
26
27			public function setupAction()
28			{
29			require('setup.php');
30
31			$this->redirectTo('blog/list');
32			}
33
34			public function indexAction()
35			{
36			$all = $this->blog->findAllOrder('id', 'DESC');
37
38			$this->theme->setTitle("A blog");
			0 ignored issues – show Documentation introduced 2016-03-13 11:56 UTC by Report Bug Copy Issue Report The property `theme` does not exist on `object<Anax\Blog\BlogController>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...

sofiafahle / anax-mvc-content2

BlogController A last analyzed 2016-03-14 20:36 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

15 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

BlogController A
last analyzed 2016-03-14 20:36 UTC