soarecostin /
blade-form-components
| Conditions | 13 |
| Paths | 28 |
| Total Lines | 41 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 7 | public function glueAttributes($attributesList = null) |
||
| 8 | { |
||
| 9 | if (is_null($attributesList) && isset($this->attributesList)) { |
||
| 10 | $attributesList = $this->attributesList; |
||
|
|
|||
| 11 | } |
||
| 12 | |||
| 13 | $pairs = []; |
||
| 14 | foreach ($attributesList as $attr) { |
||
| 15 | if (isset($this->{$attr})) { |
||
| 16 | |||
| 17 | // Edge cases |
||
| 18 | if ($attr == 'autocomplete') { |
||
| 19 | $pairs[] = sprintf('%s="%s"', $attr, $this->{$attr} ? 'on' : 'off'); |
||
| 20 | continue; |
||
| 21 | } |
||
| 22 | |||
| 23 | if ($attr == 'class' && is_array($this->{$attr})) { |
||
| 24 | $pairs[] = sprintf('%s="%s"', $attr, implode(' ', $this->{$attr})); |
||
| 25 | continue; |
||
| 26 | } |
||
| 27 | |||
| 28 | // Required, disabled, readonly: true/false |
||
| 29 | if (is_bool($this->{$attr})) { |
||
| 30 | if ($this->{$attr} == true) { |
||
| 31 | $pairs[] = $attr; |
||
| 32 | } |
||
| 33 | continue; |
||
| 34 | } |
||
| 35 | |||
| 36 | $pairs[] = sprintf('%s="%s"', $attr, $this->{$attr}); |
||
| 37 | } |
||
| 38 | } |
||
| 39 | |||
| 40 | if (isset($this->customAttributes)) { |
||
| 41 | foreach ($this->customAttributes as $attrName => $attrVal) { |
||
| 42 | $pairs[] = sprintf('%s="%s"', $attrName, $attrVal); |
||
| 43 | } |
||
| 44 | } |
||
| 45 | |||
| 46 | return implode(' ', $pairs); |
||
| 47 | } |
||
| 48 | } |
||
| 49 |
Loading history...
In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:
Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: