Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
15 | class LibGuidesSearch extends AbstractLibAppsSearchDomain |
||
16 | { |
||
17 | /** |
||
18 | * Search for `$query` within the LibGuides |
||
19 | * |
||
20 | * @param string $query |
||
21 | * @return SearchResult[] Ordered by descending relevance |
||
22 | */ |
||
23 | public function search($query) |
||
49 | |||
50 | /** |
||
51 | * Calculate relevance score for a particular search result |
||
52 | * |
||
53 | * @param mixed[] $guide |
||
54 | * @param string $query |
||
55 | * @return Relevance |
||
56 | */ |
||
57 | View Code Duplication | protected function relevance($guide, $query) |
|
69 | } |
||
70 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.