Conditions | 14 |
Paths | 100 |
Total Lines | 113 |
Code Lines | 79 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
32 | public static function getLevel($params, $smarty) |
||
33 | { |
||
34 | $key = false; |
||
35 | $value = false; |
||
36 | foreach ($params as $k => $v) { |
||
37 | switch ($k) { |
||
38 | case 'key': |
||
39 | $key = $v; |
||
40 | break; |
||
41 | case 'value': |
||
42 | $value = $v; |
||
43 | break; |
||
44 | } |
||
45 | } |
||
46 | if ($key === false || $value == false) { |
||
47 | return ""; |
||
48 | } |
||
49 | |||
50 | if (empty(self::$levels)) { |
||
51 | self::$levels = [ |
||
52 | 'average_grading_turn_around' => [ |
||
53 | 'warning' => [ |
||
54 | new Level(3, 14, Comparison::GT()), |
||
55 | new Level(2, 7, Comparison::GT()) |
||
56 | ], |
||
57 | 'highlight' => [ |
||
58 | new Level (3, 3, Comparison::LT()), |
||
59 | new Level (2, 7, Comparison::LT()) |
||
60 | ] |
||
61 | ], |
||
62 | 'average_assignment_lead_time' => [ |
||
63 | 'warning' => [ |
||
64 | new Level(3, 1, Comparison::LT()), |
||
65 | new Level(2, 2, Comparison::LT()) |
||
66 | ], |
||
67 | 'highlight' => [ |
||
68 | new Level(3, 10, Comparison::GT()), |
||
69 | new Level(2, 7, Comparison::GT()) |
||
70 | ] |
||
71 | ], |
||
72 | 'average_submissions_graded' => [ |
||
73 | 'warning' => [ |
||
74 | new Level(3, 0.5, Comparison::LT()), |
||
75 | new Level(2, 0.75, Comparison::LT()) |
||
76 | ], |
||
77 | 'highlight' => [ |
||
78 | new Level(3, 1.0, Comparison::GTE()), |
||
79 | new Level(2, 0.9, Comparison::GT()) |
||
80 | ] |
||
81 | ], |
||
82 | 'dateless_assignment_count' => [ |
||
83 | 'warning' => [ |
||
84 | new Level(3, 20, Comparison::GT()), |
||
85 | new Level(2, 10, Comparison::GT()) |
||
86 | ], |
||
87 | 'highlight' => [ |
||
88 | new Level(3, 1, Comparison::LT()), |
||
89 | new Level(2, 5, Comparison::LT()) |
||
90 | ] |
||
91 | ], |
||
92 | 'gradeable_assignment_count' => [ |
||
93 | 'warning' => [ |
||
94 | new Level(3, 0, Comparison::LTE()) |
||
95 | ] |
||
96 | ], |
||
97 | 'graded_assignment_count' => [ |
||
98 | 'warning' => [ |
||
99 | new Level(3, 0, Comparison::LTE()) |
||
100 | ] |
||
101 | ], |
||
102 | 'created_after_due_count' => [ |
||
103 | 'warning' => [ |
||
104 | new Level(3, 10, Comparison::GT()), |
||
105 | new Level(2, 5, Comparison::GT()) |
||
106 | ], |
||
107 | 'highlight' => [ |
||
108 | new Level(3, 1, Comparison::LT()), |
||
109 | new Level(2, 5, Comparison::LT()) |
||
110 | ] |
||
111 | ], |
||
112 | 'zero_point_assignment_count' => [ |
||
113 | 'warning' => [ |
||
114 | new Level(3, 10, Comparison::GTE()), |
||
115 | new Level(2, 0, Comparison::GT()) |
||
116 | ] |
||
117 | ] |
||
118 | ]; |
||
119 | } |
||
120 | |||
121 | foreach (self::$levels[$key] as $mode => $modeLevels) { |
||
122 | foreach ($modeLevels as $level) { |
||
123 | $match = false; |
||
124 | switch ($level->comparison->getValue()) { |
||
125 | case Comparison::GT: |
||
126 | $match = $value > $level->value; |
||
127 | break; |
||
128 | case Comparison::GTE: |
||
129 | $match = $value >= $level->value; |
||
130 | break; |
||
131 | case Comparison::LT: |
||
132 | $match = $value < $level->value; |
||
133 | break; |
||
134 | case Comparison::LTE: |
||
135 | $match = $value <= $level->value; |
||
136 | break; |
||
137 | } |
||
138 | if ($match) { |
||
139 | return " class=\"$mode level-{$level->level}\""; |
||
140 | } |
||
141 | } |
||
142 | } |
||
143 | return ""; |
||
144 | } |
||
145 | } |
||
146 |