Issues in assign-user-roles.php (master) - Issues in master - smtech/canvas-management - Measure and Improve Code Quality continuously with Scrutinizer

Issues (70)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

custom-preferences/assign-user-roles.php (2 issues)

Labels

Deprecated Code 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

require_once('common.inc.php');

use Battis\BootstrapSmarty\NotificationMessage;

$toolbox->cache_pushKey(basename(__FILE__, '.php'));
$toolbox->getCache()->setLifetime(60 * 60);

define('STEP_INSTRUCTIONS', 1);
define('STEP_LISTING', 2);
define('STEP_RESULT', 3);

$step = (empty($_REQUEST['step']) ? STEP_INSTRUCTIONS : $_REQUEST['step']);

switch ($step) {
    case STEP_LISTING:
    case STEP_RESULT:
        try {
            $users = $toolbox->cache_get('users');
            if ($users === false) {
                $users = array();
                $response = $toolbox->api_get('/accounts/1/users');
                foreach ($response as $user) {
                    $users[$user['id']] = $user;
                }
                $toolbox->cache_set('users', $users);
            }
        } catch (Exception $e) {
            $toolbox->exceptionErrorMessage($e);
            $step = STEP_INSTRUCTIONS;
        }

        if ($step == STEP_LISTING || $step == STEP_RESULT) {
            $ROLES = array(
                'faculty',
                'staff',
                'student',
                'advisor',
                'no-menu',
                'alum',
                'departed'
            );

            if ($step == STEP_RESULT) {
                foreach ($_REQUEST['users'] as $id => $data) {
                    if ($data['dirty']) {
                        if (empty($id) || empty($data['role'])) {
                            $toolbox->smarty_addMessage(
                                'Error',
                                "Empty ID ($id) or role ({$data['role']})",
                                NotificationMessage::ERROR

                            );
                        } else {
                            $updated = false;
                            if ($response = $customPrefs->query("
                                SELECT *
                                    FROM `users`
                                    WHERE
                                        `id` = '$id'
                            ")) {
                                if ($response->num_rows > 0) {
                                    $updated = $customPrefs->query("
                                        UPDATE `users`
                                            SET `role` = '{$data['role']}'
                                            WHERE `id` = '$id'
                                    ");
                                } else {
                                    $updated = $customPrefs->query("
                                        INSERT
                                            INTO `users`
                                            (`id`, `role`) VALUES ('$id', '{$data['role']}')
                                    ");
                                }
                            }
                            if ($updated) {
                                $toolbox->smarty_addMessage(
                                    $users[$id]['name'],
                                    "is now {$data['role']}.",
                                    NotificationMessage::GOOD

                                );
                            } else {
                                $toolbox->smarty_addMessage(
                                    $users[$id]['name'],
                                    "was not updated to {$data['role']}. " . $customPrefs->error,
                                    NotificationMessage::WARNING
                                );
                            }
                        }
                    }
                }
            }

            $assignedUsers = array();
            $unassignedUsers = array();

            foreach ($users as $user) {
                if (!empty($user['sis_user_id'])) {
                    if ($response = $customPrefs->query("
                        SELECT *
                            FROM `users`
                            WHERE
                                `id` = '{$user['id']}'
                    ")) {
                        if ($row = $response->fetch_assoc()) {
                            $row['groups'] = unserialize($row['groups']);
                            if (!empty($row['groups'])) {
                                $groupResponse = $customPrefs->query("
                                    SELECT *
                                        FROM `groups`
                                        WHERE
                                            `id` = '" . implode("' OR `id` = '", $row['groups']) . "'
                                ");
                                $groups = array();
                                while ($groupRow = $groupResponse->fetch_assoc()) {
                                    $groups[$groupRow['id']] = $groupRow;
                                }
                                $row['groups'] = $groups;
                            }
                            $assignedUsers[$row['role']][$user['id']]['custom-prefs'] = $row;
                            $assignedUsers[$row['role']][$user['id']]['user'] = $user;
                        } else {
                            $unassignedUsers[0][$user['id']]['user'] = $user;
                        }
                    }
                }
            }

            $toolbox->smarty_assign('roles', $ROLES);
            $toolbox->smarty_assign('assignedUsers', $assignedUsers);
            $toolbox->smarty_assign('unassignedUsers', $unassignedUsers);
            $toolbox->smarty_assign('formHidden', array('step' => STEP_RESULT));
            $toolbox->smarty_display(basename(__FILE__, '.php') . '/listing.tpl');
            break;
        }

        /* continue into STEP_INSTRUCTIONS */

    case STEP_INSTRUCTIONS:
    default:
        $toolbox->smarty_assign('formHidden', array('step' => STEP_LISTING));
        $toolbox->smarty_display(basename(__FILE__, '.php') . '/instructions.tpl');
        exit;
}


1			<?php
2
3			require_once('common.inc.php');
4
5			use Battis\BootstrapSmarty\NotificationMessage;
6
7			$toolbox->cache_pushKey(basename(__FILE__, '.php'));
8			$toolbox->getCache()->setLifetime(60 * 60);
9
10			define('STEP_INSTRUCTIONS', 1);
11			define('STEP_LISTING', 2);
12			define('STEP_RESULT', 3);
13
14			$step = (empty($_REQUEST['step']) ? STEP_INSTRUCTIONS : $_REQUEST['step']);
15
16			switch ($step) {
17			case STEP_LISTING:
18			case STEP_RESULT:
19			try {
20			$users = $toolbox->cache_get('users');
21			if ($users === false) {
22			$users = array();
23			$response = $toolbox->api_get('/accounts/1/users');
24			foreach ($response as $user) {
25			$users[$user['id']] = $user;
26			}
27			$toolbox->cache_set('users', $users);
28			}
29			} catch (Exception $e) {
30			$toolbox->exceptionErrorMessage($e);
31			$step = STEP_INSTRUCTIONS;
32			}
33
34			if ($step == STEP_LISTING \|\| $step == STEP_RESULT) {
35			$ROLES = array(
36			'faculty',
37			'staff',
38			'student',
39			'advisor',
40			'no-menu',
41			'alum',
42			'departed'
43			);
44
45			if ($step == STEP_RESULT) {
46			foreach ($_REQUEST['users'] as $id => $data) {
47			if ($data['dirty']) {
48			if (empty($id) \|\| empty($data['role'])) {
49			$toolbox->smarty_addMessage(
50			'Error',
51			"Empty ID ($id) or role ({$data['role']})",
52			NotificationMessage::ERROR
			0 ignored issues – show Deprecated Code introduced 2016-08-22 18:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The constant `Battis\BootstrapSmarty\NotificationMessage::ERROR` has been deprecated with message: Use `DANGER` instead for consistency with Bootstrap This class constant has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the constant will be removed from the class and what other constant to use instead. Loading history...
53			);
54			} else {
55			$updated = false;
56			if ($response = $customPrefs->query("
57			SELECT *
58			FROM `users`
59			WHERE
60			`id` = '$id'
61			")) {
62			if ($response->num_rows > 0) {
63			$updated = $customPrefs->query("
64			UPDATE `users`
65			SET `role` = '{$data['role']}'
66			WHERE `id` = '$id'
67			");
68			} else {
69			$updated = $customPrefs->query("
70			INSERT
71			INTO `users`
72			(`id`, `role`) VALUES ('$id', '{$data['role']}')
73			");
74			}
75			}
76			if ($updated) {
77			$toolbox->smarty_addMessage(
78			$users[$id]['name'],
79			"is now {$data['role']}.",
80			NotificationMessage::GOOD
			0 ignored issues – show Deprecated Code introduced 2016-08-22 18:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The constant `Battis\BootstrapSmarty\NotificationMessage::GOOD` has been deprecated with message: Use `SUCCESS` instead for consistency with Bootstrap This class constant has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the constant will be removed from the class and what other constant to use instead. Loading history...
81			);
82			} else {
83			$toolbox->smarty_addMessage(
84			$users[$id]['name'],
85			"was not updated to {$data['role']}. " . $customPrefs->error,
86			NotificationMessage::WARNING
87			);
88			}
89			}
90			}
91			}
92			}
93
94			$assignedUsers = array();
95			$unassignedUsers = array();
96
97			foreach ($users as $user) {
98			if (!empty($user['sis_user_id'])) {
99			if ($response = $customPrefs->query("
100			SELECT *
101			FROM `users`
102			WHERE
103			`id` = '{$user['id']}'
104			")) {
105			if ($row = $response->fetch_assoc()) {
106			$row['groups'] = unserialize($row['groups']);
107			if (!empty($row['groups'])) {
108			$groupResponse = $customPrefs->query("
109			SELECT *
110			FROM `groups`
111			WHERE
112			`id` = '" . implode("' OR `id` = '", $row['groups']) . "'
113			");
114			$groups = array();
115			while ($groupRow = $groupResponse->fetch_assoc()) {
116			$groups[$groupRow['id']] = $groupRow;
117			}
118			$row['groups'] = $groups;
119			}
120			$assignedUsers[$row['role']][$user['id']]['custom-prefs'] = $row;
121			$assignedUsers[$row['role']][$user['id']]['user'] = $user;
122			} else {
123			$unassignedUsers[0][$user['id']]['user'] = $user;
124			}
125			}
126			}
127			}
128
129			$toolbox->smarty_assign('roles', $ROLES);
130			$toolbox->smarty_assign('assignedUsers', $assignedUsers);
131			$toolbox->smarty_assign('unassignedUsers', $unassignedUsers);
132			$toolbox->smarty_assign('formHidden', array('step' => STEP_RESULT));
133			$toolbox->smarty_display(basename(__FILE__, '.php') . '/listing.tpl');
134			break;
135			}
136
137			/* continue into STEP_INSTRUCTIONS */
138
139			case STEP_INSTRUCTIONS:
140			default:
141			$toolbox->smarty_assign('formHidden', array('step' => STEP_LISTING));
142			$toolbox->smarty_display(basename(__FILE__, '.php') . '/instructions.tpl');
143			exit;
144			}
145

smtech / canvas-management

Issues (70)

Security Analysis not enabled

custom-preferences/assign-user-roles.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like