smrealms / smr

src/htdocs/js/smr15.js

(function() {
"use strict";

	window.voteSite = function(snUrl) {
		// Must not redirect the current page until after the external vote
		// site URL has been opened in a new tab. Use setTimeout to do this.
		setTimeout(function() {
			window.location = snUrl;
		}, 0);
	};

	function doCalc(type, totalDest) {
		var df = document.FORM;
		var inputs = df.querySelectorAll('input[name*="' + type + '"]');
		var total = 0;
		inputs.forEach(function(input) {
			total += Number(input.value);
		});
		df[totalDest].value = total;
	};

	// Recalculate total number of ports, summing over level
	window.levelCalc = function() {
		doCalc('port', 'totalLevel');
	};

	// Recalculate sum of port race percentages
	window.raceCalc = function() {
		doCalc('race', 'totalRace');
	};

	// Set the total number of ports to zero
	window.setZero = function() {
		var df = document.FORM;
		var inputs = df.querySelectorAll('input[name*="port"]');
		inputs.forEach(function(input) {
			input.value = 0;
		});
		df.totalLevel.value = 0;
	};

	// Set the port race distribution to be equal
	window.setEqual = function() {
		var df = document.FORM;
		var inputs = df.querySelectorAll('input[name*="race"]');
		var baseValue = Math.floor(100 / inputs.length);
		var leftover = 100 - inputs.length * baseValue;
		inputs.forEach(function(input) {
			if (leftover > 0) {
				input.value = baseValue + 1;
				leftover -= 1;
			} else {
				input.value = baseValue;
			}
		});
		df.totalRace.value = 100;
	};

	var body, currentlyFlashing=false, flashColour, origColour, intervalFlash, timeoutStopFlash;

	function stopFlash() {
		clearInterval(intervalFlash);
		body.style.backgroundColor = origColour;

The variable body seems to be never initialized.

		currentlyFlashing = false;
	};

	function bgFlash() {
		var body = document.getElementsByTagName('body')[0];
		if(body.style.backgroundColor === origColour) {
			body.style.backgroundColor = flashColour;
		}
		else {
			body.style.backgroundColor = origColour;
		}
	};

	window.triggerAttackBlink = function(colour) {
		if(origColour == null) {

Comparing origColour to null using the == operator is not safe. Consider using === instead.

			origColour = document.getElementsByTagName('body')[0].style.backgroundColor;
		}
		flashColour = '#'+colour;
		clearTimeout(timeoutStopFlash);
		if (currentlyFlashing === false) {
			currentlyFlashing = true;
			//flash 3 times
			bgFlash();
			intervalFlash = setInterval(bgFlash,500);
		}
		timeoutStopFlash = setTimeout(stopFlash,3500);
	};
})();

// Used by shop_hardware.php
function recalcOnKeyUp(transaction, hardwareTypeID, cost) {
	var form = document.getElementById(transaction + hardwareTypeID);
	form.total.value = form.amount.value * cost;
}

// Used by planet_defense.php
function showWeaponInfo(select) {
	var target = $(select).data('target');
	var show = $("option:selected", select).data('show');
	$(target).children().addClass('hide');
	$(show).removeClass('hide');
}

// Used by game_join.php
function showRaceInfo(select) {
	var race_id = $("option:selected", select).val();
	document.getElementById('race_image').src = "images/race/race" + race_id + ".jpg";
	var desc = document.getElementById('race_descr');
	$(desc).children().addClass('hide');
	$(".race_descr" + race_id, desc).removeClass('hide');
	createRaceRadarChart(race_id);
}

// Used by game_join.php
function createRaceRadarChart(race_id) {

	// Each array key is the race ID
	var races = {
		2: [[5.2,  10.0, 5.8,  8.1,  5.2],  'Alskant',    '#FF00FF'],
		3: [[8.3,  5.0,  10.0, 3.3,  8.3],  'Creonti',    '#FF8000'],
		4: [[9.5,  4.9,  9.5,  7.7,  9.5],  'Human',      '#0000FF'],
		5: [[8.0,  6.1,  9.7,  10.0, 8.0],  'Ik\'Thorne', '#BFBFFF'],
		6: [[8.1,  4.7,  8.8,  4.3,  8.1],  'Salvene',    '#00AA00'],
		7: [[10.0, 5.7,  8.7,  9.1,  10.0], 'Thevian',    '#800000'],
		8: [[7.2, 6.3,   7.9,  6.2,  7.2],  'WQ Human',   '#804040'],
		9: [[9.5, 4.9,   8.0,  5.1,  9.5],  'Nijarin',    '#FF8080']
	};

	var data = [
		{
			type: 'scatterpolar',
			r: races[race_id][0],
			theta: ['Hunting', 'Trading', 'Combat', 'Utility', 'Hunting'],
			fill: 'toself',
			name: races[race_id][1],
			line: {color: races[race_id][2]},
			title: {
				text: races[race_id][1]
			}
		}
	];

	var layout = {
		showlegend: true,
		polar: {
			radialaxis: {
				visible: true,
				showgrid: true,
				range: [0, 10],
				color: '#fff',
			},
			bgcolor: '#111'
		},
		paper_bgcolor: '#06240E',
		font: {
			color: '#fff'
		},
		margin: { l: 170, r: 170, t: 0, b: 0 },
		coloraxis: '#000'
	};

	Plotly.newPlot('graphframe', data, layout, {staticPlot: true});

The variable Plotly seems to be never declared. If this is a global, consider adding a /** global: Plotly */ comment.

}

// Used by alliance_create.php and alliance_stat.php
function togglePassword(select) {
	var showPassword = $(select).val() === "password";
	// We need to both toggle the element display (for the user) and toggle the
	// disabled property (for the form submission).
	if (showPassword) {
		$("#password-display").show();
	} else {
		$("#password-display").hide();
	}
	$("#password-input").prop("disabled", !showPassword);
}

// Used by message_view.php
function toggleScoutGroup(senderID) {
	$('#group'+senderID).toggle();
}