We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
@@ -26,7 +26,7 @@ |
||
26 | 26 | * Not intended to be used outside the DI context. |
27 | 27 | */ |
28 | 28 | public static function mysqliFactory(DatabaseProperties $dbProperties): mysqli { |
29 | - if (!mysqli_report(MYSQLI_REPORT_ERROR | MYSQLI_REPORT_STRICT)) { |
|
29 | + if (!mysqli_report(MYSQLI_REPORT_ERROR|MYSQLI_REPORT_STRICT)) { |
|
30 | 30 | throw new RuntimeException('Failed to enable mysqli error reporting'); |
31 | 31 | } |
32 | 32 | $mysql = new mysqli( |
@@ -70,7 +70,7 @@ |
||
70 | 70 | 'illusion' => $ship->canHaveIllusion() ? 'Yes' : '', |
71 | 71 | 'jump' => $ship->canHaveJump() ? 'Yes' : '', |
72 | 72 | 'scrambler' => $ship->canHaveDCS() ? 'Yes' : '', |
73 | - 'locs' => implode('', array_map(fn(string $name): string => '<div>' . $name . '</div>', $shipLocs)), |
|
73 | + 'locs' => implode('', array_map(fn(string $name) : string => '<div>' . $name . '</div>', $shipLocs)), |
|
74 | 74 | ]; |
75 | 75 | return $stat; |
76 | 76 | } |
@@ -14,7 +14,7 @@ |
||
14 | 14 | public const TIME_BETWEEN_VOTING = 84600; // 23.5 hours |
15 | 15 | |
16 | 16 | /** @var ?array<int, int> */ |
17 | - private static ?array $CACHE_TIMEOUTS = null; |
|
17 | + private static ? array $CACHE_TIMEOUTS = null; |
|
18 | 18 | |
19 | 19 | /** @var array<string, mixed> */ |
20 | 20 | public readonly array $data; |
@@ -2886,7 +2886,7 @@ discard block |
||
2886 | 2886 | 'Starting Sector' => $this->getSectorID(), |
2887 | 2887 | ]; |
2888 | 2888 | |
2889 | - $this->missions[$missionID] =& $mission; |
|
2889 | + $this->missions[$missionID] = & $mission; |
|
2890 | 2890 | $this->setupMissionStep($missionID); |
2891 | 2891 | $this->rebuildMission($missionID); |
2892 | 2892 | |
@@ -2948,7 +2948,7 @@ discard block |
||
2948 | 2948 | if (!$this->hasMission($missionID)) { |
2949 | 2949 | throw new Exception('Unknown mission: ' . $missionID); |
2950 | 2950 | } |
2951 | - $mission =& $this->missions[$missionID]; |
|
2951 | + $mission = & $this->missions[$missionID]; |
|
2952 | 2952 | if ($mission['Task'] === false || $mission['Task']['Step'] != 'Claim') { |
2953 | 2953 | throw new Exception('Cannot claim mission: ' . $missionID . ', for step: ' . $mission['On Step']); |
2954 | 2954 | } |
@@ -123,7 +123,7 @@ |
||
123 | 123 | * |
124 | 124 | * @param array<string, mixed> $data |
125 | 125 | */ |
126 | -function replaceMissionTemplate(string|int|PlotGroup &$template, string $key, array $data): void { |
|
126 | +function replaceMissionTemplate(string|int|PlotGroup&$template, string $key, array $data): void { |
|
127 | 127 | if (!is_string($template)) { |
128 | 128 | return; |
129 | 129 | } |
@@ -121,7 +121,7 @@ |
||
121 | 121 | * Can be used to convert any type of notice into an exception. |
122 | 122 | */ |
123 | 123 | function exception_error_handler(int $errno, string $errstr, string $errfile, int $errline): bool { |
124 | - if (!(error_reporting() & $errno)) { |
|
124 | + if (!(error_reporting()&$errno)) { |
|
125 | 125 | return false; // error is suppressed |
126 | 126 | } |
127 | 127 | throw new ErrorException($errstr, $errno, E_ERROR, $errfile, $errline); |
@@ -17,7 +17,7 @@ |
||
17 | 17 | * @param array<\AbstractSmrPlayer> $defenders |
18 | 18 | */ |
19 | 19 | public function __construct( |
20 | - private readonly ?array $results = null, |
|
20 | + private readonly ? array $results = null, |
|
21 | 21 | private readonly array $attackers = [], |
22 | 22 | private readonly array $defenders = [] |
23 | 23 | ) {} |
@@ -128,7 +128,7 @@ |
||
128 | 128 | AND receiver_delete = ' . $db->escapeBoolean(false) . ' |
129 | 129 | ORDER BY send_time DESC'); |
130 | 130 | foreach ($dbResult->records() as $dbRecord) { |
131 | - $groupBox =& $messageBox['GroupedMessages'][$dbRecord->getInt('sender_id')]; |
|
131 | + $groupBox = & $messageBox['GroupedMessages'][$dbRecord->getInt('sender_id')]; |
|
132 | 132 | // Limit the number of messages in each group |
133 | 133 | if (!isset($groupBox['Messages']) || count($groupBox['Messages']) < MESSAGE_SCOUT_GROUP_LIMIT) { |
134 | 134 | $groupBox['Messages'][] = displayMessage($dbRecord->getInt('message_id'), $dbRecord->getInt('account_id'), $dbRecord->getInt('sender_id'), $player->getGameID(), $dbRecord->getString('message_text'), $dbRecord->getInt('send_time'), $dbRecord->getBoolean('msg_read'), MSG_SCOUT, $player->getAccount()); |
@@ -38,8 +38,7 @@ discard block |
||
38 | 38 | $shareFrom[$fromAccountId] = [ |
39 | 39 | 'Player ID' => $otherPlayer == null ? '-' : $otherPlayer->getPlayerID(), |
40 | 40 | 'Player Name' => $otherPlayer == null ? |
41 | - '<b>Account</b>: ' . SmrAccount::getAccount($fromAccountId)->getHofDisplayName() : |
|
42 | - $otherPlayer->getDisplayName(), |
|
41 | + '<b>Account</b>: ' . SmrAccount::getAccount($fromAccountId)->getHofDisplayName() : $otherPlayer->getDisplayName(), |
|
43 | 42 | 'All Games' => $gameId == 0 ? '<span class="green">YES</span>' : '<span class="red">NO</span>', |
44 | 43 | 'Game ID' => $gameId, |
45 | 44 | ]; |
@@ -59,8 +58,7 @@ discard block |
||
59 | 58 | $shareTo[$toAccountId] = [ |
60 | 59 | 'Player ID' => $otherPlayer == null ? '-' : $otherPlayer->getPlayerID(), |
61 | 60 | 'Player Name' => $otherPlayer == null ? |
62 | - '<b>Account</b>: ' . SmrAccount::getAccount($toAccountId)->getHofDisplayName() : |
|
63 | - $otherPlayer->getDisplayName(), |
|
61 | + '<b>Account</b>: ' . SmrAccount::getAccount($toAccountId)->getHofDisplayName() : $otherPlayer->getDisplayName(), |
|
64 | 62 | 'All Games' => $gameId == 0 ? '<span class="green">YES</span>' : '<span class="red">NO</span>', |
65 | 63 | 'Game ID' => $gameId, |
66 | 64 | ]; |