Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Branch master (0a752f)
by Dan
03:57
created
htdocs/map_galaxy.php 1 patch
Braces   +6 added lines, -8 removed lines patch added patch discarded remove patch
@@ -35,8 +35,7 @@  discard block
 block discarded – undo
35 35
 			header('location: /error.php?msg=Invalid sector ID');
36 36
 			exit;
37 37
 		}
38
-	}
39
-	else if (isset($_REQUEST['galaxy_id'])) {
38
+	} else if (isset($_REQUEST['galaxy_id'])) {
40 39
 		$galaxyID = $_REQUEST['galaxy_id'];
41 40
 		if (!is_numeric($galaxyID)) {
42 41
 			header('location: /error.php?msg=Galaxy ID was not a number.');
@@ -44,8 +43,7 @@  discard block
 block discarded – undo
44 43
 		}
45 44
 		try {
46 45
 			$galaxy = SmrGalaxy::getGalaxy(SmrSession::getGameID(), $galaxyID);
47
-		}
48
-		catch (Exception $e) {
46
+		} catch (Exception $e) {
49 47
 			header('location: /error.php?msg=Invalid galaxy ID');
50 48
 			exit;
51 49
 		}
@@ -93,8 +91,9 @@  discard block
 block discarded – undo
93 91
 
94 92
 	$template->assign('Title', 'Galaxy Map');
95 93
 
96
-	if ($account->getCssLink() != null)
97
-		$template->assign('ExtraCSSLink', $account->getCssLink());
94
+	if ($account->getCssLink() != null) {
95
+			$template->assign('ExtraCSSLink', $account->getCssLink());
96
+	}
98 97
 	$template->assign('CSSLink', $account->getCssUrl());
99 98
 	$template->assign('CSSColourLink', $account->getCssColourUrl());
100 99
 	$template->assign('FontSize', $account->getFontSize() - 20);
@@ -110,7 +109,6 @@  discard block
 block discarded – undo
110 109
 	$template->assign('AJAX_ENABLE_REFRESH', false);
111 110
 
112 111
 	$template->display('GalaxyMap.inc');
113
-}
114
-catch (Throwable $e) {
112
+} catch (Throwable $e) {
115 113
 	handleException($e);
116 114
 }
Please login to merge, or discard this patch.
engine/Default/forces_drop_processing.php 1 patch
Braces   +52 added lines, -46 removed lines patch added patch discarded remove patch
@@ -125,8 +125,7 @@  discard block
 block discarded – undo
125 125
 	if ($change_combat_drones > 0) {
126 126
 		$ship->decreaseCDs($change_combat_drones, true);
127 127
 		$forces->addCDs($change_combat_drones);
128
-	}
129
-	else {
128
+	} else {
130 129
 		$ship->increaseCDs(-$change_combat_drones, true);
131 130
 		$forces->takeCDs(-$change_combat_drones);
132 131
 	}
@@ -136,8 +135,7 @@  discard block
 block discarded – undo
136 135
 	if ($change_scout_drones > 0) {
137 136
 		$ship->decreaseSDs($change_scout_drones);
138 137
 		$forces->addSDs($change_scout_drones);
139
-	}
140
-	else {
138
+	} else {
141 139
 		$ship->increaseSDs(-$change_scout_drones);
142 140
 		$forces->takeSDs(-$change_scout_drones);
143 141
 	}
@@ -151,8 +149,7 @@  discard block
 block discarded – undo
151 149
 			$ship->decloak();
152 150
 			$player->giveTurns(1);
153 151
 		}
154
-	}
155
-	else {
152
+	} else {
156 153
 		$ship->increaseMines(-$change_mines);
157 154
 		$forces->takeMines(-$change_mines);
158 155
 	}
@@ -161,61 +158,70 @@  discard block
 block discarded – undo
161 158
 // message to send out
162 159
 if ($forces->getOwnerID() != $player->getAccountID() && $forces->getOwner()->isForceDropMessages()) {
163 160
 	$mines_message = '';
164
-	if ($change_mines > 0)
165
-		$mines_message = 'added ' . $change_mines . ' mine';
166
-	elseif ($change_mines < 0)
167
-		$mines_message = 'removed ' . abs($change_mines) . ' mine';
161
+	if ($change_mines > 0) {
162
+			$mines_message = 'added ' . $change_mines . ' mine';
163
+	} elseif ($change_mines < 0) {
164
+			$mines_message = 'removed ' . abs($change_mines) . ' mine';
165
+	}
168 166
 	//add s to mine if necesary
169
-	if (abs($change_mines) > 1)
170
-		$mines_message .= 's';
167
+	if (abs($change_mines) > 1) {
168
+			$mines_message .= 's';
169
+	}
171 170
 
172
-	if ($change_combat_drones > 0)
173
-		$combat_drones_message = ($change_mines <= 0 ? 'added ' : '') . $change_combat_drones . ' combat drone';
174
-	elseif ($change_combat_drones < 0)
175
-		$combat_drones_message = ($change_mines >= 0 ? 'removed ' : '') . abs($change_combat_drones) . ' combat drone';
171
+	if ($change_combat_drones > 0) {
172
+			$combat_drones_message = ($change_mines <= 0 ? 'added ' : '') . $change_combat_drones . ' combat drone';
173
+	} elseif ($change_combat_drones < 0) {
174
+			$combat_drones_message = ($change_mines >= 0 ? 'removed ' : '') . abs($change_combat_drones) . ' combat drone';
175
+	}
176 176
 	//add s to drone if necesary
177
-	if (abs($change_combat_drones) > 1)
178
-		$combat_drones_message .= 's';
177
+	if (abs($change_combat_drones) > 1) {
178
+			$combat_drones_message .= 's';
179
+	}
179 180
 
180 181
 	if ($change_scout_drones > 0) {
181 182
 		$scout_drones_message = '';
182
-		if ((isset($combat_drones_message) && $change_combat_drones < 0) || (!isset($combat_drones_message) && $change_mines <= 0))
183
-			$scout_drones_message = 'added ';
183
+		if ((isset($combat_drones_message) && $change_combat_drones < 0) || (!isset($combat_drones_message) && $change_mines <= 0)) {
184
+					$scout_drones_message = 'added ';
185
+		}
184 186
 		$scout_drones_message .= $change_scout_drones . ' scout drone';
185
-	}
186
-	elseif ($change_scout_drones < 0) {
187
+	} elseif ($change_scout_drones < 0) {
187 188
 		$scout_drones_message = '';
188
-		if ((isset($combat_drones_message) && $change_combat_drones > 0) || (!isset($combat_drones_message) && $change_mines >= 0))
189
-			$scout_drones_message = 'removed ';
189
+		if ((isset($combat_drones_message) && $change_combat_drones > 0) || (!isset($combat_drones_message) && $change_mines >= 0)) {
190
+					$scout_drones_message = 'removed ';
191
+		}
190 192
 		$scout_drones_message .= abs($change_scout_drones) . ' scout drone';
191 193
 	}
192 194
 	//add s to drone if necesary
193
-	if (abs($change_scout_drones) > 1)
194
-		$scout_drones_message .= 's';
195
+	if (abs($change_scout_drones) > 1) {
196
+			$scout_drones_message .= 's';
197
+	}
195 198
 
196 199
 	// now compile it together
197 200
 	$message = $player->getPlayerName() . ' has ' . $mines_message;
198 201
 
199
-	if (!empty($mines_message) && isset($combat_drones_message) && !isset($scout_drones_message))
200
-		$message .= ' and ' . $combat_drones_message;
201
-	elseif (!empty($mines_message) && isset($combat_drones_message))
202
-		$message .= ', ' . $combat_drones_message;
203
-	elseif (empty($mines_message) && isset($combat_drones_message))
204
-		$message .= $combat_drones_message;
205
-
206
-	if (!empty($mines_message) && isset($combat_drones_message) && isset($scout_drones_message))
207
-		$message .= ', and ' . $scout_drones_message;
208
-	elseif ((!empty($mines_message) || isset($combat_drones_message)) && isset($scout_drones_message))
209
-		$message .= ' and ' . $scout_drones_message;
210
-	elseif (empty($mines_message) && !isset($combat_drones_message) && isset($scout_drones_message))
211
-		$message .= $scout_drones_message;
212
-
213
-	if ($change_mines >= 0 && $change_combat_drones >= 0 && $change_scout_drones >= 0)
214
-		$message .= ' to';
215
-	elseif ($change_mines <= 0 && $change_combat_drones <= 0 && $change_scout_drones <= 0)
216
-		$message .= ' from';
217
-	else
218
-		$message .= ' from/to';
202
+	if (!empty($mines_message) && isset($combat_drones_message) && !isset($scout_drones_message)) {
203
+			$message .= ' and ' . $combat_drones_message;
204
+	} elseif (!empty($mines_message) && isset($combat_drones_message)) {
205
+			$message .= ', ' . $combat_drones_message;
206
+	} elseif (empty($mines_message) && isset($combat_drones_message)) {
207
+			$message .= $combat_drones_message;
208
+	}
209
+
210
+	if (!empty($mines_message) && isset($combat_drones_message) && isset($scout_drones_message)) {
211
+			$message .= ', and ' . $scout_drones_message;
212
+	} elseif ((!empty($mines_message) || isset($combat_drones_message)) && isset($scout_drones_message)) {
213
+			$message .= ' and ' . $scout_drones_message;
214
+	} elseif (empty($mines_message) && !isset($combat_drones_message) && isset($scout_drones_message)) {
215
+			$message .= $scout_drones_message;
216
+	}
217
+
218
+	if ($change_mines >= 0 && $change_combat_drones >= 0 && $change_scout_drones >= 0) {
219
+			$message .= ' to';
220
+	} elseif ($change_mines <= 0 && $change_combat_drones <= 0 && $change_scout_drones <= 0) {
221
+			$message .= ' from';
222
+	} else {
223
+			$message .= ' from/to';
224
+	}
219 225
 
220 226
 	$message .= ' your stack in sector ' . Globals::getSectorBBLink($forces->getSectorID());
221 227
 
Please login to merge, or discard this patch.
templates/Default/engine/Default/preferences.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -316,8 +316,8 @@
 block discarded – undo
316 316
 					foreach (Globals::getAvailableTemplates() as $AvailableTemplate => $ColourSchemes) {
317 317
 						foreach ($ColourSchemes as $ColourScheme) {
318 318
 							$selected = ($ThisAccount->getTemplate() == $AvailableTemplate &&
319
-							             $ThisAccount->getColourScheme() == $ColourScheme &&
320
-							             $ThisAccount->isDefaultCSSEnabled()) ? 'selected' : '';
319
+										 $ThisAccount->getColourScheme() == $ColourScheme &&
320
+										 $ThisAccount->isDefaultCSSEnabled()) ? 'selected' : '';
321 321
 							$name = $AvailableTemplate . ' - ' . $ColourScheme;
322 322
 							?><option value="<?php echo $name; ?>" <?php echo $selected; ?>><?php echo $name; ?></option><?php
323 323
 						}
Please login to merge, or discard this patch.
templates/Default/engine/Default/combat_log_viewer.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -20,11 +20,11 @@
 block discarded – undo
20 20
 	$this->includeTemplate('includes/ForceFullCombatResults.inc', array('FullForceCombatResults'=>$CombatResults));
21 21
 } else if ($CombatResultsType == 'PORT') {
22 22
 	$this->includeTemplate('includes/PortFullCombatResults.inc', array('FullPortCombatResults'=>$CombatResults,
23
-	                                                                  'MinimalDisplay'=>false,
24
-	                                                                  'AlreadyDestroyed'=>false));
23
+																	  'MinimalDisplay'=>false,
24
+																	  'AlreadyDestroyed'=>false));
25 25
 } else if ($CombatResultsType == 'PLANET') {
26 26
 	$this->includeTemplate('includes/PlanetFullCombatResults.inc', array('FullPlanetCombatResults'=>$CombatResults,
27
-	                                                                    'MinimalDisplay'=>false,
28
-	                                                                    'AlreadyDestroyed'=>false));
27
+																		'MinimalDisplay'=>false,
28
+																		'AlreadyDestroyed'=>false));
29 29
 }
30 30
 ?>
Please login to merge, or discard this patch.
templates/Default/engine/Default/includes/PortTraderTeamCombatResults.inc 1 patch
Spacing   +52 added lines, -52 removed lines patch added patch discarded remove patch
@@ -1,10 +1,10 @@  discard block
 block discarded – undo
1 1
 <?php
2
-foreach($TraderTeamCombatResults['Traders'] as $AccountID => $TraderResults) {
3
-	$ShootingPlayer =& $TraderResults['Player'];
4
-	$TotalDamage =& $TraderResults['TotalDamage'];
5
-	if($MinimalDisplay && !$ThisPlayer->equals($ShootingPlayer)) {
2
+foreach ($TraderTeamCombatResults['Traders'] as $AccountID => $TraderResults) {
3
+	$ShootingPlayer = & $TraderResults['Player'];
4
+	$TotalDamage = & $TraderResults['TotalDamage'];
5
+	if ($MinimalDisplay && !$ThisPlayer->equals($ShootingPlayer)) {
6 6
 		echo $ShootingPlayer->getDisplayName();
7
-		if($TotalDamage > 0) {
7
+		if ($TotalDamage > 0) {
8 8
 			?> hits for a total of <span class="red"><?php echo $TotalDamage ?></span> damage in this round of combat<?php
9 9
 		} else {
10 10
 			?> does no damage this round<?php
@@ -12,129 +12,129 @@  discard block
 block discarded – undo
12 12
 		continue;
13 13
 	}
14 14
 
15
-	if($TraderResults['DeadBeforeShot']) {
15
+	if ($TraderResults['DeadBeforeShot']) {
16 16
 		echo $ShootingPlayer->getDisplayName() ?> died before they were able to attack!<br /><?php
17 17
 	} else {
18
-		if(isset($TraderResults['Weapons']) && is_array($TraderResults['Weapons'])) {
19
-			foreach($TraderResults['Weapons'] as $WeaponResults) {
20
-				$ShootingWeapon =& $WeaponResults['Weapon'];
21
-				$ShotHit =& $WeaponResults['Hit'];
22
-				$ActualDamage =& $WeaponResults['ActualDamage'];
23
-				$WeaponDamage =& $WeaponResults['WeaponDamage'];
24
-				$TargetPort =& $WeaponResults['TargetPort'];
18
+		if (isset($TraderResults['Weapons']) && is_array($TraderResults['Weapons'])) {
19
+			foreach ($TraderResults['Weapons'] as $WeaponResults) {
20
+				$ShootingWeapon = & $WeaponResults['Weapon'];
21
+				$ShotHit = & $WeaponResults['Hit'];
22
+				$ActualDamage = & $WeaponResults['ActualDamage'];
23
+				$WeaponDamage = & $WeaponResults['WeaponDamage'];
24
+				$TargetPort = & $WeaponResults['TargetPort'];
25 25
 				$DamageTypes = 0;
26
-				if($ActualDamage['Shield'] > 0){ $DamageTypes = $DamageTypes+1; }
27
-				if($ActualDamage['NumCDs'] > 0){ $DamageTypes = $DamageTypes+1; }
28
-				if($ActualDamage['Armour'] > 0){ $DamageTypes = $DamageTypes+1; }
26
+				if ($ActualDamage['Shield'] > 0) { $DamageTypes = $DamageTypes + 1; }
27
+				if ($ActualDamage['NumCDs'] > 0) { $DamageTypes = $DamageTypes + 1; }
28
+				if ($ActualDamage['Armour'] > 0) { $DamageTypes = $DamageTypes + 1; }
29 29
 				
30
-				echo $ShootingPlayer->getDisplayName() ?> fires their <?php echo $ShootingWeapon->getName() ?> at <?php if($ShotHit && $ActualDamage['TargetAlreadyDead']){ ?>the remnants of <?php } echo $TargetPort->getDisplayName();
31
-				if(!$ActualDamage['TargetAlreadyDead']) {
32
-					if(!$ShotHit) {
30
+				echo $ShootingPlayer->getDisplayName() ?> fires their <?php echo $ShootingWeapon->getName() ?> at <?php if ($ShotHit && $ActualDamage['TargetAlreadyDead']) { ?>the remnants of <?php } echo $TargetPort->getDisplayName();
31
+				if (!$ActualDamage['TargetAlreadyDead']) {
32
+					if (!$ShotHit) {
33 33
 						?> and misses every critical system<?php
34
-					} else if($ActualDamage['TotalDamage'] == 0) {
35
-						if($WeaponDamage['Shield'] > 0) {
36
-							if($ActualDamage['HasCDs']) {
34
+					} else if ($ActualDamage['TotalDamage'] == 0) {
35
+						if ($WeaponDamage['Shield'] > 0) {
36
+							if ($ActualDamage['HasCDs']) {
37 37
 								?> which proves ineffective against their combat drones<?php
38 38
 							} else {
39 39
 								?> which proves ineffective against it's armour<?php
40 40
 							}
41
-						} else if($WeaponDamage['Armour'] > 0) {
41
+						} else if ($WeaponDamage['Armour'] > 0) {
42 42
 							?> which is deflected by their shields<?php
43 43
 						} else {
44 44
 							?> but it cannot do any damage<?php
45 45
 						}
46 46
 					} else {
47 47
 						?> destroying <?php
48
-						if($ActualDamage['Shield'] > 0) {
48
+						if ($ActualDamage['Shield'] > 0) {
49 49
 							?><span class="shields"><?php echo number_format($ActualDamage['Shield']) ?></span> shields<?php
50 50
 							$this->doDamageTypeReductionDisplay($DamageTypes);
51 51
 						}
52
-						if($ActualDamage['NumCDs'] > 0) {
52
+						if ($ActualDamage['NumCDs'] > 0) {
53 53
 							?><span class="cds"><?php echo number_format($ActualDamage['NumCDs']) ?></span> combat drones<?php
54 54
 							$this->doDamageTypeReductionDisplay($DamageTypes);
55 55
 						}
56
-						if($ActualDamage['Armour'] > 0) {
56
+						if ($ActualDamage['Armour'] > 0) {
57 57
 							?><span class="red"><?php echo number_format($ActualDamage['Armour']) ?></span> plates of armour<?php
58 58
 						}
59 59
 					}
60 60
 				} ?>.
61 61
 				<br /><?php
62
-				if($ActualDamage['KillingShot']) {
63
-					$this->includeTemplate('includes/PortKillMessage.inc',array('KillResults'=>$WeaponResults['KillResults'],'TargetPort'=>$TargetPort,'ShootingPlayer'=>$ShootingPlayer));
62
+				if ($ActualDamage['KillingShot']) {
63
+					$this->includeTemplate('includes/PortKillMessage.inc', array('KillResults'=>$WeaponResults['KillResults'], 'TargetPort'=>$TargetPort, 'ShootingPlayer'=>$ShootingPlayer));
64 64
 				}
65 65
 			}
66 66
 		}
67
-		if(isset($TraderResults['Drones'])) {
68
-			$Drones =& $TraderResults['Drones'];
69
-			$ActualDamage =& $Drones['ActualDamage'];
70
-			$WeaponDamage =& $Drones['WeaponDamage'];
71
-			$TargetPort =& $Drones['TargetPort'];
67
+		if (isset($TraderResults['Drones'])) {
68
+			$Drones = & $TraderResults['Drones'];
69
+			$ActualDamage = & $Drones['ActualDamage'];
70
+			$WeaponDamage = & $Drones['WeaponDamage'];
71
+			$TargetPort = & $Drones['TargetPort'];
72 72
 			$DamageTypes = 0;
73
-			if($ActualDamage['Shield'] > 0){ $DamageTypes = $DamageTypes+1; }
74
-			if($ActualDamage['NumCDs'] > 0){ $DamageTypes = $DamageTypes+1; }
75
-			if($ActualDamage['Armour'] > 0){ $DamageTypes = $DamageTypes+1; }
73
+			if ($ActualDamage['Shield'] > 0) { $DamageTypes = $DamageTypes + 1; }
74
+			if ($ActualDamage['NumCDs'] > 0) { $DamageTypes = $DamageTypes + 1; }
75
+			if ($ActualDamage['Armour'] > 0) { $DamageTypes = $DamageTypes + 1; }
76 76
 			
77 77
 			echo $ShootingPlayer->getDisplayName();
78
-			if($WeaponDamage['Launched'] == 0) {
78
+			if ($WeaponDamage['Launched'] == 0) {
79 79
 				?> fails to launch their combat drones<?php
80 80
 			} else {
81 81
 				?> launches <span class="cds"><?php echo $WeaponDamage['Launched'] ?></span> combat drones at <?php
82
-				if($ActualDamage['TargetAlreadyDead']) {
82
+				if ($ActualDamage['TargetAlreadyDead']) {
83 83
 					?>the debris that was once <?php
84 84
 				}
85 85
 				echo $TargetPort->getDisplayName();
86 86
 				
87
-				if(!$ActualDamage['TargetAlreadyDead']) {
88
-					if($ActualDamage['TotalDamage'] == 0) {
89
-						if($WeaponDamage['Shield'] > 0) {
90
-							if($ActualDamage['HasCDs']) {
87
+				if (!$ActualDamage['TargetAlreadyDead']) {
88
+					if ($ActualDamage['TotalDamage'] == 0) {
89
+						if ($WeaponDamage['Shield'] > 0) {
90
+							if ($ActualDamage['HasCDs']) {
91 91
 								?> which prove ineffective against their combat drones<?php
92 92
 							} else {
93 93
 								?> which proves ineffective against it's armour<?php
94 94
 							}
95 95
 						}
96
-						if($ActualDamage['Armour'] > 0) {
96
+						if ($ActualDamage['Armour'] > 0) {
97 97
 							?> which is deflected by their shields<?php
98 98
 						} else {
99 99
 							?> but they cannot do any damage<?php
100 100
 						}
101 101
 					} else {
102 102
 						?> destroying <?php
103
-						if($ActualDamage['Shield'] > 0) {
103
+						if ($ActualDamage['Shield'] > 0) {
104 104
 							?><span class="shields"><?php echo number_format($ActualDamage['Shield']) ?></span> shields<?php
105 105
 							$this->doDamageTypeReductionDisplay($DamageTypes);
106 106
 						}
107
-						if($ActualDamage['NumCDs'] > 0) {
107
+						if ($ActualDamage['NumCDs'] > 0) {
108 108
 							?><span class="cds"><?php echo number_format($ActualDamage['NumCDs']) ?></span> combat drones<?php
109 109
 							$this->doDamageTypeReductionDisplay($DamageTypes);
110 110
 						}
111
-						if($ActualDamage['Armour'] > 0) {
111
+						if ($ActualDamage['Armour'] > 0) {
112 112
 							?><span class="red"><?php echo number_format($ActualDamage['Armour']) ?></span> plates of armour<?php
113 113
 						}
114 114
 					}
115 115
 				}
116 116
 			} ?>.
117 117
 			<br /><?php
118
-			if($ActualDamage['KillingShot']) {
119
-				$this->includeTemplate('includes/PortKillMessage.inc',array('KillResults'=>$Drones['KillResults'],'TargetPort'=>$TargetPort,'ShootingPlayer'=>$ShootingPlayer));
118
+			if ($ActualDamage['KillingShot']) {
119
+				$this->includeTemplate('includes/PortKillMessage.inc', array('KillResults'=>$Drones['KillResults'], 'TargetPort'=>$TargetPort, 'ShootingPlayer'=>$ShootingPlayer));
120 120
 			}
121 121
 		}
122 122
 	}
123 123
 	echo $ShootingPlayer->getDisplayName();
124
-	if($TotalDamage > 0) {
124
+	if ($TotalDamage > 0) {
125 125
 		?> hits for a total of <span class="red"><?php echo $TotalDamage ?></span> damage in this round of combat<?php
126 126
 	} else {
127 127
 		?> does no damage this round<?php
128
-		if(!$TraderResults['DeadBeforeShot']) {
128
+		if (!$TraderResults['DeadBeforeShot']) {
129 129
 			?>. Maybe they should go back to the academy<?php
130 130
 		}
131 131
 	} ?>.<br /><br /><?php
132 132
 }
133 133
 $TotalDamage = $TraderTeamCombatResults['TotalDamage']; ?>
134
-This fleet <?php if($TotalDamage > 0){ ?>hits for a total of <span class="red"><?php echo $TotalDamage ?></span> damage in this round of combat<?php } else{ ?>does no damage this round. You call that a fleet? They need a better recruiter<?php } ?>.<br />
134
+This fleet <?php if ($TotalDamage > 0) { ?>hits for a total of <span class="red"><?php echo $TotalDamage ?></span> damage in this round of combat<?php } else { ?>does no damage this round. You call that a fleet? They need a better recruiter<?php } ?>.<br />
135 135
 
136 136
 <?php
137 137
 $Downgrades = $TraderTeamCombatResults['Downgrades'];
138
-if ($Downgrades != 0 ) {
138
+if ($Downgrades != 0) {
139 139
 	?>The port has lost <?php echo $Downgrades . ' ' . pluralise('level', $Downgrades); ?>.<?php
140 140
 } ?>
Please login to merge, or discard this patch.
templates/Default/engine/Default/includes/ForcesCombatResults.inc 1 patch
Spacing   +28 added lines, -28 removed lines patch added patch discarded remove patch
@@ -1,38 +1,38 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if(isset($ForcesCombatResults['Results']) && is_array($ForcesCombatResults['Results'])) {
3
-	foreach($ForcesCombatResults['Results'] as $ForceType => $ForceResults) {
4
-		$ShootingWeapon =& $ForceResults['Weapon'];
5
-		$ShotHit =& $ForceResults['Hit'];
6
-		$ActualDamage =& $ForceResults['ActualDamage'];
7
-		$WeaponDamage =& $ForceResults['WeaponDamage'];
8
-		$TargetPlayer =& $ForceResults['TargetPlayer'];
2
+if (isset($ForcesCombatResults['Results']) && is_array($ForcesCombatResults['Results'])) {
3
+	foreach ($ForcesCombatResults['Results'] as $ForceType => $ForceResults) {
4
+		$ShootingWeapon = & $ForceResults['Weapon'];
5
+		$ShotHit = & $ForceResults['Hit'];
6
+		$ActualDamage = & $ForceResults['ActualDamage'];
7
+		$WeaponDamage = & $ForceResults['WeaponDamage'];
8
+		$TargetPlayer = & $ForceResults['TargetPlayer'];
9 9
 		$DamageTypes = 0;
10
-		if($ActualDamage['Shield'] > 0){ $DamageTypes = $DamageTypes+1; }
11
-		if($ActualDamage['NumCDs'] > 0){ $DamageTypes = $DamageTypes+1; }
12
-		if($ActualDamage['Armour'] > 0){ $DamageTypes = $DamageTypes+1; } ?>
10
+		if ($ActualDamage['Shield'] > 0) { $DamageTypes = $DamageTypes + 1; }
11
+		if ($ActualDamage['NumCDs'] > 0) { $DamageTypes = $DamageTypes + 1; }
12
+		if ($ActualDamage['Armour'] > 0) { $DamageTypes = $DamageTypes + 1; } ?>
13 13
 		
14 14
 		<span class="cds"><?php echo isset($ActualDamage['Launched']) ? $ActualDamage['Launched'] : $WeaponDamage['Launched']; ?></span><?php
15
-		if($ForceType == 'Mines') {
15
+		if ($ForceType == 'Mines') {
16 16
 			?> mines kamikaze themselves against <?php
17
-		} else if($ForceType == 'Drones') {
17
+		} else if ($ForceType == 'Drones') {
18 18
 			?> combat drones launch at <?php
19
-		} else if($ForceType == 'Scouts') {
19
+		} else if ($ForceType == 'Scouts') {
20 20
 			?> scout drones kamikaze themselves against <?php
21 21
 		}
22 22
 		
23
-		if($ShotHit && $ActualDamage['TargetAlreadyDead']){ ?> the debris that was once <?php }
23
+		if ($ShotHit && $ActualDamage['TargetAlreadyDead']) { ?> the debris that was once <?php }
24 24
 		echo $TargetPlayer->getDisplayName();
25
-		if(!$ActualDamage['TargetAlreadyDead']) {
26
-			if(!$ShotHit) {
25
+		if (!$ActualDamage['TargetAlreadyDead']) {
26
+			if (!$ShotHit) {
27 27
 				?> and misses<?php
28
-			} else if($ActualDamage['TotalDamage'] == 0) {
29
-				if($WeaponDamage['Shield'] > 0) {
30
-					if($ActualDamage['HasCDs']) {
28
+			} else if ($ActualDamage['TotalDamage'] == 0) {
29
+				if ($WeaponDamage['Shield'] > 0) {
30
+					if ($ActualDamage['HasCDs']) {
31 31
 						?> which proves ineffective against their combat drones<?php
32 32
 					} else {
33 33
 						?> which washes harmlessly over their hull<?php
34 34
 					}
35
-				} else if($WeaponDamage['Armour'] > 0) {
35
+				} else if ($WeaponDamage['Armour'] > 0) {
36 36
 					?> which is deflected by their shields<?php
37 37
 				} else {
38 38
 					?> but it cannot do any damage<?php
@@ -40,27 +40,27 @@  discard block
 block discarded – undo
40 40
 			} else {
41 41
 				?> destroying <?php
42 42
 			}
43
-			if($ActualDamage['Shield'] > 0) {
43
+			if ($ActualDamage['Shield'] > 0) {
44 44
 				?><span class="shields"><?php echo number_format($ActualDamage['Shield']) ?></span> shields<?php
45 45
 				$this->doDamageTypeReductionDisplay($DamageTypes);
46 46
 			}
47
-			if($ActualDamage['NumCDs'] > 0) {
47
+			if ($ActualDamage['NumCDs'] > 0) {
48 48
 				?><span class="cds"><?php echo number_format($ActualDamage['NumCDs']) ?></span> drones<?php
49 49
 				$this->doDamageTypeReductionDisplay($DamageTypes);
50 50
 			}
51
-			if($ActualDamage['Armour'] > 0) {
51
+			if ($ActualDamage['Armour'] > 0) {
52 52
 				?><span class="red"><?php echo number_format($ActualDamage['Armour']) ?></span> plates of armour<?php
53 53
 			}
54 54
 		} ?>.
55 55
 		<br /><?php
56
-		if($ActualDamage['KillingShot']) {
57
-			$this->includeTemplate('includes/TraderCombatKillMessage.inc',array('KillResults'=>$ForceResults['KillResults'],'TargetPlayer'=>$TargetPlayer));
56
+		if ($ActualDamage['KillingShot']) {
57
+			$this->includeTemplate('includes/TraderCombatKillMessage.inc', array('KillResults'=>$ForceResults['KillResults'], 'TargetPlayer'=>$TargetPlayer));
58 58
 		}
59 59
 	}
60 60
 }
61
-if(isset($ForcesCombatResults['ForcesDestroyed']) && $ForcesCombatResults['ForcesDestroyed']) {
61
+if (isset($ForcesCombatResults['ForcesDestroyed']) && $ForcesCombatResults['ForcesDestroyed']) {
62 62
 	?>Forces are <span class="red">DESTROYED!</span><br /><?php
63 63
 }
64 64
 
65
-$TotalDamage =& $ForcesCombatResults['TotalDamage'] ?>
66
-The forces <?php if($TotalDamage > 0){ ?>hit for a total of <span class="red"><?php echo number_format($TotalDamage) ?></span> damage in this round of combat<?php } else{ ?>do no damage this round<?php } ?>.
67 65
\ No newline at end of file
66
+$TotalDamage = & $ForcesCombatResults['TotalDamage'] ?>
67
+The forces <?php if ($TotalDamage > 0) { ?>hit for a total of <span class="red"><?php echo number_format($TotalDamage) ?></span> damage in this round of combat<?php } else { ?>do no damage this round<?php } ?>.
68 68
\ No newline at end of file
Please login to merge, or discard this patch.
templates/Default/engine/Default/includes/SectorMap.inc 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@
 block discarded – undo
102 102
 						if (!$UniGen) {
103 103
 							$CanScanSector = ($ThisShip->hasScanner() && $isLinkedSector) || $isCurrentSector;
104 104
 							$ShowFriendlyForces = isset($HideAlliedForces) && $HideAlliedForces ?
105
-							                      $Sector->hasPlayerForces($MapPlayer) : $Sector->hasFriendlyForces($MapPlayer);
105
+												  $Sector->hasPlayerForces($MapPlayer) : $Sector->hasFriendlyForces($MapPlayer);
106 106
 							if (($CanScanSector && ($Sector->hasForces() || $Sector->hasPlayers())) || $ShowFriendlyForces || $Sector->hasFriendlyTraders($MapPlayer)) { ?>
107 107
 								<div class="lmtf"><?php
108 108
 									if ($CanScanSector && $Sector->hasEnemyTraders($MapPlayer)) {
Please login to merge, or discard this patch.
templates/Default/engine/Default/includes/TraderTeamCombatResults.inc 1 patch
Spacing   +50 added lines, -50 removed lines patch added patch discarded remove patch
@@ -1,130 +1,130 @@
 block discarded – undo
1 1
 <?php
2
-if(is_array($TraderTeamCombatResults['Traders'])) {
3
-	foreach($TraderTeamCombatResults['Traders'] as $AccountID => $TraderResults) {
4
-		$ShootingPlayer =& $TraderResults['Player'];
5
-		$TotalDamage =& $TraderResults['TotalDamage'];
2
+if (is_array($TraderTeamCombatResults['Traders'])) {
3
+	foreach ($TraderTeamCombatResults['Traders'] as $AccountID => $TraderResults) {
4
+		$ShootingPlayer = & $TraderResults['Player'];
5
+		$TotalDamage = & $TraderResults['TotalDamage'];
6 6
 	
7
-		if($TraderResults['DeadBeforeShot']) {
7
+		if ($TraderResults['DeadBeforeShot']) {
8 8
 			echo $ShootingPlayer->getDisplayName() ?> died before they were able to attack!<br /><?php
9 9
 		} else {
10
-			if(isset($TraderResults['Weapons']) && is_array($TraderResults['Weapons'])) {
11
-				foreach($TraderResults['Weapons'] as $WeaponResults) {
12
-					$ShootingWeapon =& $WeaponResults['Weapon'];
13
-					$ShotHit =& $WeaponResults['Hit'];
14
-					$ActualDamage =& $WeaponResults['ActualDamage'];
15
-					$WeaponDamage =& $WeaponResults['WeaponDamage'];
16
-					$TargetPlayer =& $WeaponResults['TargetPlayer'];
10
+			if (isset($TraderResults['Weapons']) && is_array($TraderResults['Weapons'])) {
11
+				foreach ($TraderResults['Weapons'] as $WeaponResults) {
12
+					$ShootingWeapon = & $WeaponResults['Weapon'];
13
+					$ShotHit = & $WeaponResults['Hit'];
14
+					$ActualDamage = & $WeaponResults['ActualDamage'];
15
+					$WeaponDamage = & $WeaponResults['WeaponDamage'];
16
+					$TargetPlayer = & $WeaponResults['TargetPlayer'];
17 17
 					$DamageTypes = 0;
18
-					if($ActualDamage['Shield'] > 0){ $DamageTypes = $DamageTypes+1; }
19
-					if($ActualDamage['NumCDs'] > 0){ $DamageTypes = $DamageTypes+1; }
20
-					if($ActualDamage['Armour'] > 0){ $DamageTypes = $DamageTypes+1; }
18
+					if ($ActualDamage['Shield'] > 0) { $DamageTypes = $DamageTypes + 1; }
19
+					if ($ActualDamage['NumCDs'] > 0) { $DamageTypes = $DamageTypes + 1; }
20
+					if ($ActualDamage['Armour'] > 0) { $DamageTypes = $DamageTypes + 1; }
21 21
 					
22 22
 					echo $ShootingPlayer->getDisplayName() ?> fires their <?php echo $ShootingWeapon->getName() ?> at <?php
23
-					if($ShotHit && $ActualDamage['TargetAlreadyDead']) {
23
+					if ($ShotHit && $ActualDamage['TargetAlreadyDead']) {
24 24
 						?>the debris that was once <?php
25 25
 					}
26 26
 					echo $TargetPlayer->getDisplayName();
27
-					if(!$ActualDamage['TargetAlreadyDead']) {
28
-						if(!$ShotHit) {
27
+					if (!$ActualDamage['TargetAlreadyDead']) {
28
+						if (!$ShotHit) {
29 29
 							?> and misses<?php
30
-						} else if($ActualDamage['TotalDamage'] == 0) {
31
-							if($WeaponDamage['Shield'] > 0) {
32
-								if($ActualDamage['HasCDs']) {
30
+						} else if ($ActualDamage['TotalDamage'] == 0) {
31
+							if ($WeaponDamage['Shield'] > 0) {
32
+								if ($ActualDamage['HasCDs']) {
33 33
 									?> which proves ineffective against their combat drones<?php
34 34
 								} else {
35 35
 									?> which washes harmlessly over their hull<?php
36 36
 								}
37
-							} else if($WeaponDamage['Armour'] > 0) {
37
+							} else if ($WeaponDamage['Armour'] > 0) {
38 38
 								?> which is deflected by their shields<?php
39 39
 							} else {
40 40
 								?> but it cannot do any damage<?php
41 41
 							}
42 42
 						} else {
43 43
 							?> destroying <?php
44
-							if($ActualDamage['Shield'] > 0) {
44
+							if ($ActualDamage['Shield'] > 0) {
45 45
 								?><span class="shields"><?php echo number_format($ActualDamage['Shield']) ?></span> shields<?php
46 46
 								$this->doDamageTypeReductionDisplay($DamageTypes);
47 47
 							}
48
-							if($ActualDamage['NumCDs'] > 0) {
48
+							if ($ActualDamage['NumCDs'] > 0) {
49 49
 								?><span class="cds"><?php echo number_format($ActualDamage['NumCDs']) ?></span> combat drones<?php
50 50
 								$this->doDamageTypeReductionDisplay($DamageTypes);
51 51
 							}
52
-							if($ActualDamage['Armour'] > 0) {
52
+							if ($ActualDamage['Armour'] > 0) {
53 53
 								?><span class="red"><?php echo number_format($ActualDamage['Armour']) ?></span> plates of armour<?php
54 54
 							}
55 55
 						}
56 56
 					} ?>.
57 57
 					<br /><?php
58
-					if($ActualDamage['KillingShot']) {
59
-						$this->includeTemplate('includes/TraderCombatKillMessage.inc',array('KillResults'=>$WeaponResults['KillResults'],'TargetPlayer'=>$TargetPlayer,'ShootingPlayer'=>$ShootingPlayer));
58
+					if ($ActualDamage['KillingShot']) {
59
+						$this->includeTemplate('includes/TraderCombatKillMessage.inc', array('KillResults'=>$WeaponResults['KillResults'], 'TargetPlayer'=>$TargetPlayer, 'ShootingPlayer'=>$ShootingPlayer));
60 60
 					}
61 61
 				}
62 62
 			}
63
-			if(isset($TraderResults['Drones'])) {
64
-				$Drones =& $TraderResults['Drones'];
65
-				$ActualDamage =& $Drones['ActualDamage'];
66
-				$WeaponDamage =& $Drones['WeaponDamage'];
67
-				$TargetPlayer =& $Drones['TargetPlayer'];
63
+			if (isset($TraderResults['Drones'])) {
64
+				$Drones = & $TraderResults['Drones'];
65
+				$ActualDamage = & $Drones['ActualDamage'];
66
+				$WeaponDamage = & $Drones['WeaponDamage'];
67
+				$TargetPlayer = & $Drones['TargetPlayer'];
68 68
 				$DamageTypes = 0;
69
-				if($ActualDamage['Shield'] > 0){ $DamageTypes = $DamageTypes+1; }
70
-				if($ActualDamage['NumCDs'] > 0){ $DamageTypes = $DamageTypes+1; }
71
-				if($ActualDamage['Armour'] > 0){ $DamageTypes = $DamageTypes+1; }
69
+				if ($ActualDamage['Shield'] > 0) { $DamageTypes = $DamageTypes + 1; }
70
+				if ($ActualDamage['NumCDs'] > 0) { $DamageTypes = $DamageTypes + 1; }
71
+				if ($ActualDamage['Armour'] > 0) { $DamageTypes = $DamageTypes + 1; }
72 72
 	
73 73
 				echo $ShootingPlayer->getDisplayName();
74
-				if($WeaponDamage['Launched'] == 0) {
74
+				if ($WeaponDamage['Launched'] == 0) {
75 75
 					?> fails to launch their combat drones<?php
76 76
 				} else {
77 77
 					?> launches <span class="cds"><?php echo $WeaponDamage['Launched'] ?></span> combat drones at <?php
78
-					if($ActualDamage['TargetAlreadyDead']) {
78
+					if ($ActualDamage['TargetAlreadyDead']) {
79 79
 						?>the debris that was once <?php
80 80
 					}
81 81
 					echo $TargetPlayer->getDisplayName();
82
-					if(!$ActualDamage['TargetAlreadyDead']) {
83
-						if($ActualDamage['TotalDamage'] == 0) {
84
-							if($WeaponDamage['Shield'] > 0) {
85
-								if($ActualDamage['HasCDs']) {
82
+					if (!$ActualDamage['TargetAlreadyDead']) {
83
+						if ($ActualDamage['TotalDamage'] == 0) {
84
+							if ($WeaponDamage['Shield'] > 0) {
85
+								if ($ActualDamage['HasCDs']) {
86 86
 									?> which prove ineffective against their combat drones<?php
87 87
 								} else {
88 88
 									?> which washes harmlessly over their hull<?php
89 89
 								}
90 90
 							}
91
-							if($ActualDamage['Armour'] > 0) {
91
+							if ($ActualDamage['Armour'] > 0) {
92 92
 								?> which is deflected by their shields<?php
93 93
 							} else {
94 94
 								?> but they cannot do any damage<?php
95 95
 							}
96 96
 						} else {
97 97
 							?> destroying <?php
98
-							if($ActualDamage['Shield'] > 0) {
98
+							if ($ActualDamage['Shield'] > 0) {
99 99
 								?><span class="shields"><?php echo number_format($ActualDamage['Shield']) ?></span> shields<?php
100 100
 								$this->doDamageTypeReductionDisplay($DamageTypes);
101 101
 							}
102
-							if($ActualDamage['NumCDs'] > 0) {
102
+							if ($ActualDamage['NumCDs'] > 0) {
103 103
 								?><span class="cds"><?php echo number_format($ActualDamage['NumCDs']) ?></span> combat drones<?php
104 104
 								$this->doDamageTypeReductionDisplay($DamageTypes);
105 105
 							}
106
-							if($ActualDamage['Armour'] > 0) {
106
+							if ($ActualDamage['Armour'] > 0) {
107 107
 								?><span class="red"><?php echo number_format($ActualDamage['Armour']) ?></span> plates of armour<?php
108 108
 							}
109 109
 						}
110 110
 					}
111 111
 				} ?>.
112 112
 				<br /><?php
113
-				if($ActualDamage['KillingShot']) {
114
-					$this->includeTemplate('includes/TraderCombatKillMessage.inc',array('KillResults'=>$Drones['KillResults'],'TargetPlayer'=>$TargetPlayer,'ShootingPlayer'=>$ShootingPlayer));
113
+				if ($ActualDamage['KillingShot']) {
114
+					$this->includeTemplate('includes/TraderCombatKillMessage.inc', array('KillResults'=>$Drones['KillResults'], 'TargetPlayer'=>$TargetPlayer, 'ShootingPlayer'=>$ShootingPlayer));
115 115
 				}
116 116
 			}
117 117
 		}
118 118
 		echo $ShootingPlayer->getDisplayName();
119
-		if($TotalDamage > 0) {
119
+		if ($TotalDamage > 0) {
120 120
 			?> hits for a total of <span class="red"><?php echo $TotalDamage ?></span> damage in this round of combat<?php
121 121
 		} else {
122 122
 			?> does no damage this round.<?php
123
-			if(!$TraderResults['DeadBeforeShot']) {
123
+			if (!$TraderResults['DeadBeforeShot']) {
124 124
 				?> Maybe they should go back to the academy<?php
125 125
 			}
126 126
 		} ?>.<br /><br /><?php
127 127
 	}
128 128
 }
129 129
 $TotalDamage = $TraderTeamCombatResults['TotalDamage']; ?>
130
-This fleet <?php if($TotalDamage > 0){ ?>hits for a total of <span class="red"><?php echo $TotalDamage ?></span> damage in this round of combat<?php } else{ ?>does no damage this round. You call that a fleet? They need a better recruiter<?php } ?>.<br />
131 130
\ No newline at end of file
131
+This fleet <?php if ($TotalDamage > 0) { ?>hits for a total of <span class="red"><?php echo $TotalDamage ?></span> damage in this round of combat<?php } else { ?>does no damage this round. You call that a fleet? They need a better recruiter<?php } ?>.<br />
132 132
\ No newline at end of file
Please login to merge, or discard this patch.
templates/Default/engine/Default/map_local.php 1 patch
Braces   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,10 @@
 block discarded – undo
10 10
 		<td style="width: 80%" class="center">
11 11
 			Local Map of the Known <span class="big bold"><?php echo $GalaxyName ?></span> Galaxy
12 12
 			<br /><br />
13
-			<?php if (isset($Error)) echo $Error; ?>
13
+			<?php if (isset($Error)) {
14
+	echo $Error;
15
+}
16
+?>
14 17
 		</td>
15 18
 		<td style="width: 10%"></td>
16 19
 	</tr>
Please login to merge, or discard this patch.