Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Failed Conditions
Pull Request — master (#1018)
by Dan
04:41
created
src/engine/Default/shop_goods.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -50,9 +50,9 @@
 block discarded – undo
50 50
 			//get base for ports that dont happen to trade that good
51 51
 			$GOODS = Globals::getGoods();
52 52
 			$fine = $totalFine = $port->getLevel() *
53
-			    (($ship->getCargo(GOODS_SLAVES) * $GOODS[GOODS_SLAVES]['BasePrice']) +
54
-			     ($ship->getCargo(GOODS_WEAPONS) * $GOODS[GOODS_WEAPONS]['BasePrice']) +
55
-			     ($ship->getCargo(GOODS_NARCOTICS) * $GOODS[GOODS_NARCOTICS]['BasePrice']));
53
+				(($ship->getCargo(GOODS_SLAVES) * $GOODS[GOODS_SLAVES]['BasePrice']) +
54
+				 ($ship->getCargo(GOODS_WEAPONS) * $GOODS[GOODS_WEAPONS]['BasePrice']) +
55
+				 ($ship->getCargo(GOODS_NARCOTICS) * $GOODS[GOODS_NARCOTICS]['BasePrice']));
56 56
 			$player->increaseHOF($ship->getCargo(GOODS_SLAVES) + $ship->getCargo(GOODS_WEAPONS) + $ship->getCargo(GOODS_NARCOTICS), array('Trade', 'Search', 'Caught', 'Goods Confiscated'), HOF_PUBLIC);
57 57
 			$player->increaseHOF($totalFine, array('Trade', 'Search', 'Caught', 'Amount Fined'), HOF_PUBLIC);
58 58
 			$template->assign('TotalFine', $totalFine);
Please login to merge, or discard this patch.
src/templates/Default/admin/Default/ip_view_results.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@
 block discarded – undo
74 74
 	</center><?php
75 75
 
76 76
 } elseif (in_array($type, ['search', 'alliance_ips', 'wild_log', 'wild_in',
77
-                           'compare', 'compare_log', 'wild_ip', 'wild_host'])) { ?>
77
+						   'compare', 'compare_log', 'wild_ip', 'wild_host'])) { ?>
78 78
 
79 79
 	<center>
80 80
 		<?php echo $Summary; ?><br /><br />
Please login to merge, or discard this patch.
src/templates/Default/engine/Default/beta_functions.php 1 patch
Braces   +14 added lines, -4 removed lines patch added patch discarded remove patch
@@ -76,8 +76,13 @@  discard block
 block discarded – undo
76 76
 	<input type="number" name="amount" value="0" min="<?php echo MIN_GLOBAL_RELATIONS; ?>" max="<?php echo MAX_GLOBAL_RELATIONS; ?>" style="width:75px" />&nbsp;
77 77
 	<select name="race"><?php
78 78
 		foreach (Globals::getRaces() as $race) {
79
-			if ($race['Race ID'] == $ThisPlayer->getRaceID()) continue;
80
-			if ($race['Race ID'] == RACE_NEUTRAL) continue; ?>
79
+			if ($race['Race ID'] == $ThisPlayer->getRaceID()) {
80
+				continue;
81
+			}
82
+			if ($race['Race ID'] == RACE_NEUTRAL) {
83
+				continue;
84
+			}
85
+			?>
81 86
 			<option value="<?php echo $race['Race ID']; ?>"><?php echo $race['Race Name']; ?></option><?php
82 87
 		} ?>
83 88
 	</select>&nbsp;&nbsp;
@@ -88,8 +93,13 @@  discard block
 block discarded – undo
88 93
 <form method="POST" action="<?php echo $ChangeRaceHREF; ?>">
89 94
 	<select name="race"><?php
90 95
 		foreach (Globals::getRaces() as $race) {
91
-			if ($race['Race ID'] == $ThisPlayer->getRaceID()) continue;
92
-			if ($race['Race ID'] == RACE_NEUTRAL) continue; ?>
96
+			if ($race['Race ID'] == $ThisPlayer->getRaceID()) {
97
+				continue;
98
+			}
99
+			if ($race['Race ID'] == RACE_NEUTRAL) {
100
+				continue;
101
+			}
102
+			?>
93 103
 			<option value="<?php echo $race['Race ID']; ?>"><?php echo $race['Race Name']; ?></option><?php
94 104
 		} ?>
95 105
 	</select>&nbsp;&nbsp;
Please login to merge, or discard this patch.
src/templates/Default/engine/Default/map_local.php 1 patch
Braces   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,10 @@
 block discarded – undo
10 10
 		<td style="width: 80%" class="center">
11 11
 			Local Map of the Known <span class="big bold"><?php echo $GalaxyName ?></span> Galaxy
12 12
 			<br /><br />
13
-			<?php if (isset($Error)) echo $Error; ?>
13
+			<?php if (isset($Error)) {
14
+	echo $Error;
15
+}
16
+?>
14 17
 		</td>
15 18
 		<td style="width: 10%"></td>
16 19
 	</tr>
Please login to merge, or discard this patch.
src/templates/Default/engine/Default/preferences.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -337,8 +337,8 @@
 block discarded – undo
337 337
 					foreach (Globals::getAvailableTemplates() as $Template) {
338 338
 						foreach (Globals::getAvailableColourSchemes($Template) as $ColourScheme) {
339 339
 							$selected = ($ThisAccount->getTemplate() == $Template &&
340
-							             $ThisAccount->getColourScheme() == $ColourScheme &&
341
-							             $ThisAccount->isDefaultCSSEnabled()) ? 'selected' : '';
340
+										 $ThisAccount->getColourScheme() == $ColourScheme &&
341
+										 $ThisAccount->isDefaultCSSEnabled()) ? 'selected' : '';
342 342
 							$name = $Template . ' - ' . $ColourScheme;
343 343
 							?><option value="<?php echo $name; ?>" <?php echo $selected; ?>><?php echo $name; ?></option><?php
344 344
 						}
Please login to merge, or discard this patch.
src/htdocs/login_processing.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
 			exit;
70 70
 		}
71 71
 		$account->addAuthMethod($_SESSION['socialLogin']->getLoginType(),
72
-		                        $_SESSION['socialLogin']->getUserID());
72
+								$_SESSION['socialLogin']->getUserID());
73 73
 		session_destroy();
74 74
 	}
75 75
 
Please login to merge, or discard this patch.
src/htdocs/login_create_processing.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -150,7 +150,7 @@
 block discarded – undo
150 150
 	$account->increaseSmrRewardCredits(2 * CREDITS_PER_DOLLAR); // Give $2 worth of "reward" credits for joining.
151 151
 	if ($socialLogin) {
152 152
 		$account->addAuthMethod($_SESSION['socialLogin']->getLoginType(),
153
-		                        $_SESSION['socialLogin']->getUserID());
153
+								$_SESSION['socialLogin']->getUserID());
154 154
 		if ($validatedBySocial) {
155 155
 			$account->setValidated(true);
156 156
 			$account->update();
Please login to merge, or discard this patch.
src/tools/discord/commands/turns.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@
 block discarded – undo
3 3
 function get_turns_message($player) {
4 4
 	// turns only update when the player is active, so calculate current turns
5 5
 	$turns = min($player->getTurns() + $player->getTurnsGained(time(), true),
6
-	             $player->getMaxTurns());
6
+				 $player->getMaxTurns());
7 7
 	$msg = $player->getPlayerName() . " has $turns/" . $player->getMaxTurns() . " turns.";
8 8
 
9 9
 	// Calculate time to max turns if under the max
Please login to merge, or discard this patch.
src/tools/npc/npc.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
 		}
120 120
 
121 121
 		try {
122
-			$TRADE_ROUTE =& $GLOBALS['TRADE_ROUTE'];
122
+			$TRADE_ROUTE = & $GLOBALS['TRADE_ROUTE'];
123 123
 			debug('Action #' . $actions);
124 124
 
125 125
 			//We have to reload player on each loop
@@ -138,14 +138,14 @@  discard block
 block discarded – undo
138 138
 			}
139 139
 
140 140
 			if (!isset($TRADE_ROUTE)) { //We only want to change trade route if there isn't already one set.
141
-				$TRADE_ROUTES =& findRoutes($player);
142
-				$TRADE_ROUTE =& changeRoute($TRADE_ROUTES);
141
+				$TRADE_ROUTES = & findRoutes($player);
142
+				$TRADE_ROUTE = & changeRoute($TRADE_ROUTES);
143 143
 			}
144 144
 
145 145
 			if ($player->isDead()) {
146 146
 				debug('Some evil person killed us, let\'s move on now.');
147 147
 				$previousContainer = null; //We died, we don't care what we were doing beforehand.
148
-				$TRADE_ROUTE =& changeRoute($TRADE_ROUTES); //Change route
148
+				$TRADE_ROUTE = & changeRoute($TRADE_ROUTES); //Change route
149 149
 				processContainer(create_container('death_processing.php'));
150 150
 			}
151 151
 			if ($player->getNewbieTurns() <= NEWBIE_TURNS_WARNING_LIMIT && $player->getNewbieWarning()) {
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
 								processContainer(tradeGoods($goodID, $player, $port));
228 228
 							} else {
229 229
 								//Move to next route or fed.
230
-								if (($TRADE_ROUTE =& changeRoute($TRADE_ROUTES)) === false) {
230
+								if (($TRADE_ROUTE = & changeRoute($TRADE_ROUTES)) === false) {
231 231
 									debug('Changing Route Failed');
232 232
 									processContainer(plotToFed($player));
233 233
 								} else {
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
 							processContainer(tradeGoods($goodID, $player, $port));
255 255
 						} else {
256 256
 							//Move to next route or fed.
257
-							if (($TRADE_ROUTE =& changeRoute($TRADE_ROUTES)) === false) {
257
+							if (($TRADE_ROUTE = & changeRoute($TRADE_ROUTES)) === false) {
258 258
 								debug('Changing Route Failed');
259 259
 								processContainer(plotToFed($player));
260 260
 							} else {
@@ -586,9 +586,9 @@  discard block
 block discarded – undo
586 586
 		return $false;
587 587
 	}
588 588
 	$routeKey = array_rand($tradeRoutes);
589
-	$tradeRoute =& $tradeRoutes[$routeKey];
589
+	$tradeRoute = & $tradeRoutes[$routeKey];
590 590
 	unset($tradeRoutes[$routeKey]);
591
-	$GLOBALS['TRADE_ROUTE'] =& $tradeRoute;
591
+	$GLOBALS['TRADE_ROUTE'] = & $tradeRoute;
592 592
 	debug('Switched route', $tradeRoute);
593 593
 	return $tradeRoute;
594 594
 }
Please login to merge, or discard this patch.