We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
@@ -30,13 +30,13 @@ |
||
| 30 | 30 | const USER_SCORE_NAME = 'User Score'; |
| 31 | 31 | $hofTypes = array(DONATION_NAME=>true, USER_SCORE_NAME=>true); |
| 32 | 32 | foreach ($dbResult->records() as $dbRecord) { |
| 33 | - $hof =& $hofTypes; |
|
| 33 | + $hof = & $hofTypes; |
|
| 34 | 34 | $typeList = explode(':', $dbRecord->getString('type')); |
| 35 | 35 | foreach ($typeList as $type) { |
| 36 | 36 | if (!isset($hof[$type])) { |
| 37 | 37 | $hof[$type] = array(); |
| 38 | 38 | } |
| 39 | - $hof =& $hof[$type]; |
|
| 39 | + $hof = & $hof[$type]; |
|
| 40 | 40 | } |
| 41 | 41 | $hof = true; |
| 42 | 42 | } |
@@ -387,13 +387,13 @@ |
||
| 387 | 387 | $dbResult = $this->db->read('SELECT type,sum(amount) as amount FROM player_hof WHERE ' . $this->SQL . ' AND game_id IN (SELECT game_id FROM game WHERE ignore_stats = \'FALSE\') GROUP BY type'); |
| 388 | 388 | $this->HOF = array(); |
| 389 | 389 | foreach ($dbResult->records() as $dbRecord) { |
| 390 | - $hof =& $this->HOF; |
|
| 390 | + $hof = & $this->HOF; |
|
| 391 | 391 | $typeList = explode(':', $dbRecord->getString('type')); |
| 392 | 392 | foreach ($typeList as $type) { |
| 393 | 393 | if (!isset($hof[$type])) { |
| 394 | 394 | $hof[$type] = array(); |
| 395 | 395 | } |
| 396 | - $hof =& $hof[$type]; |
|
| 396 | + $hof = & $hof[$type]; |
|
| 397 | 397 | } |
| 398 | 398 | $hof = $dbRecord->getFloat('amount'); |
| 399 | 399 | } |
@@ -30,13 +30,13 @@ |
||
| 30 | 30 | const USER_SCORE_NAME = 'User Score'; |
| 31 | 31 | $hofTypes = array(DONATION_NAME=>true, USER_SCORE_NAME=>true); |
| 32 | 32 | foreach ($dbResult->records() as $dbRecord) { |
| 33 | - $hof =& $hofTypes; |
|
| 33 | + $hof = & $hofTypes; |
|
| 34 | 34 | $typeList = explode(':', $dbRecord->getString('type')); |
| 35 | 35 | foreach ($typeList as $type) { |
| 36 | 36 | if (!isset($hof[$type])) { |
| 37 | 37 | $hof[$type] = array(); |
| 38 | 38 | } |
| 39 | - $hof =& $hof[$type]; |
|
| 39 | + $hof = & $hof[$type]; |
|
| 40 | 40 | } |
| 41 | 41 | $hof = true; |
| 42 | 42 | } |
@@ -101,7 +101,7 @@ |
||
| 101 | 101 | $ship = new AbstractSmrShip($this->player); |
| 102 | 102 | $this->expectException(\Exception::class); |
| 103 | 103 | $this->expectExceptionMessage('Ship does not have the supported hardware!'); |
| 104 | - $ship->setIllusion(SHIP_TYPE_THIEF, 12, 13);; |
|
| 104 | + $ship->setIllusion(SHIP_TYPE_THIEF, 12, 13); ; |
|
| 105 | 105 | } |
| 106 | 106 | |
| 107 | 107 | public function test_hardware() : void { |
@@ -19,8 +19,8 @@ discard block |
||
| 19 | 19 | 1 => array("pipe", "w") // stdout is a pipe that the child will write to |
| 20 | 20 | ); |
| 21 | 21 | $engine = proc_open(UCI_CHESS_ENGINE, $descriptorSpec, $pipes); |
| 22 | - $toEngine =& $pipes[0]; |
|
| 23 | - $fromEngine =& $pipes[1]; |
|
| 22 | + $toEngine = & $pipes[0]; |
|
| 23 | + $fromEngine = & $pipes[1]; |
|
| 24 | 24 | |
| 25 | 25 | function readFromEngine(bool $block = true) : void { |
| 26 | 26 | global $fromEngine; |
@@ -84,5 +84,5 @@ discard block |
||
| 84 | 84 | function debug($message, $debugObject = null) { |
| 85 | 85 | echo date('Y-m-d H:i:s - ') . $message . ($debugObject !== null ? EOL . var_export($debugObject, true) : '') . EOL; |
| 86 | 86 | $db = Smr\Database::getInstance(); |
| 87 | - $db->write('INSERT INTO npc_logs (script_id, npc_id, time, message, debug_info, var) VALUES (' . (defined('SCRIPT_ID') ? SCRIPT_ID : 0) . ', 0, NOW(),' . $db->escapeString($message) . ',' . $db->escapeString(var_export($debugObject,true)) . ',' . $db->escapeString('') . ')'); |
|
| 87 | + $db->write('INSERT INTO npc_logs (script_id, npc_id, time, message, debug_info, var) VALUES (' . (defined('SCRIPT_ID') ? SCRIPT_ID : 0) . ', 0, NOW(),' . $db->escapeString($message) . ',' . $db->escapeString(var_export($debugObject, true)) . ',' . $db->escapeString('') . ')'); |
|
| 88 | 88 | } |
@@ -76,7 +76,10 @@ discard block |
||
| 76 | 76 | <input type="number" name="amount" value="0" min="<?php echo MIN_GLOBAL_RELATIONS; ?>" max="<?php echo MAX_GLOBAL_RELATIONS; ?>" style="width:75px" /> |
| 77 | 77 | <select name="race"><?php |
| 78 | 78 | foreach (Smr\Race::getPlayableNames() as $raceID => $raceName) { |
| 79 | - if ($raceID == $ThisPlayer->getRaceID()) continue; ?> |
|
| 79 | + if ($raceID == $ThisPlayer->getRaceID()) { |
|
| 80 | + continue; |
|
| 81 | + } |
|
| 82 | + ?> |
|
| 80 | 83 | <option value="<?php echo $raceID; ?>"><?php echo $raceName; ?></option><?php |
| 81 | 84 | } ?> |
| 82 | 85 | </select> |
@@ -87,7 +90,10 @@ discard block |
||
| 87 | 90 | <form method="POST" action="<?php echo $ChangeRaceHREF; ?>"> |
| 88 | 91 | <select name="race"><?php |
| 89 | 92 | foreach (Smr\Race::getPlayableNames() as $raceID => $raceName) { |
| 90 | - if ($raceID == $ThisPlayer->getRaceID()) continue; ?> |
|
| 93 | + if ($raceID == $ThisPlayer->getRaceID()) { |
|
| 94 | + continue; |
|
| 95 | + } |
|
| 96 | + ?> |
|
| 91 | 97 | <option value="<?php echo $raceID; ?>"><?php echo $raceName; ?></option><?php |
| 92 | 98 | } ?> |
| 93 | 99 | </select> |
@@ -44,7 +44,7 @@ discard block |
||
| 44 | 44 | // Send vote announcement to members of the player's council (war votes) |
| 45 | 45 | // or both races' councils (peace votes). |
| 46 | 46 | $councilMembers = Council::getRaceCouncil($player->getGameID(), |
| 47 | - $player->getRaceID()); |
|
| 47 | + $player->getRaceID()); |
|
| 48 | 48 | if ($type == 'PEACE') { |
| 49 | 49 | $otherCouncil = Council::getRaceCouncil($player->getGameID(), $race_id); |
| 50 | 50 | $councilMembers = array_merge($councilMembers, $otherCouncil); |
@@ -54,15 +54,15 @@ discard block |
||
| 54 | 54 | $color = ($type == 'PEACE' ? 'dgreen' : 'red'); |
| 55 | 55 | $type_fancy = "<span class=\"$color\">$type</span>"; |
| 56 | 56 | $message = $player->getLevelName() . " " . $player->getBBLink() |
| 57 | - . " has initiated a vote for $type_fancy with the [race=$race_id]!" |
|
| 58 | - . "You have " . format_time(TIME_FOR_COUNCIL_VOTE) |
|
| 59 | - . " to cast your vote."; |
|
| 57 | + . " has initiated a vote for $type_fancy with the [race=$race_id]!" |
|
| 58 | + . "You have " . format_time(TIME_FOR_COUNCIL_VOTE) |
|
| 59 | + . " to cast your vote."; |
|
| 60 | 60 | |
| 61 | 61 | foreach ($councilMembers as $accountID) { |
| 62 | 62 | // don't send to the player who started the vote |
| 63 | 63 | if ($player->getAccountID() != $accountID) { |
| 64 | 64 | SmrPlayer::sendMessageFromRace($player->getRaceID(), $player->getGameID(), |
| 65 | - $accountID, $message, $time); |
|
| 65 | + $accountID, $message, $time); |
|
| 66 | 66 | } |
| 67 | 67 | } |
| 68 | 68 | |
@@ -37,7 +37,7 @@ |
||
| 37 | 37 | |
| 38 | 38 | // Set the body of the e-mail |
| 39 | 39 | set_mail_body($mail, $var['newsletter_html'], $var['newsletter_text'], |
| 40 | - Smr\Request::get('salutation')); |
|
| 40 | + Smr\Request::get('salutation')); |
|
| 41 | 41 | |
| 42 | 42 | if (Smr\Request::get('to_email') == '*') { |
| 43 | 43 | // Send the newsletter to all players. |
@@ -21,7 +21,7 @@ |
||
| 21 | 21 | create_error('Join Date is not valid!'); |
| 22 | 22 | } |
| 23 | 23 | $start = empty(Smr\Request::get('game_start')) ? $join : |
| 24 | - DateTime::createFromFormat('d/m/Y|', Smr\Request::get('game_start')); |
|
| 24 | + DateTime::createFromFormat('d/m/Y|', Smr\Request::get('game_start')); |
|
| 25 | 25 | if ($start === false) { |
| 26 | 26 | create_error('Start Date is not valid!'); |
| 27 | 27 | } |
@@ -20,8 +20,7 @@ |
||
| 20 | 20 | if ($join === false) { |
| 21 | 21 | create_error('Join Date is not valid!'); |
| 22 | 22 | } |
| 23 | -$start = empty(Smr\Request::get('game_start')) ? $join : |
|
| 24 | - DateTime::createFromFormat('d/m/Y|', Smr\Request::get('game_start')); |
|
| 23 | +$start = empty(Smr\Request::get('game_start')) ? $join : DateTime::createFromFormat('d/m/Y|', Smr\Request::get('game_start')); |
|
| 25 | 24 | if ($start === false) { |
| 26 | 25 | create_error('Start Date is not valid!'); |
| 27 | 26 | } |