Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Failed Conditions
Pull Request — master (#819)
by Dan
03:39
created
config/SmrMySqlSecrets.sample.inc 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,8 @@
 block discarded – undo
2 2
 trait SmrMySqlSecrets {
3 3
 	protected static $databaseName = 'smr_live';
4 4
 	private static $host = 'smr-mysql'; // must match MYSQL_HOST in .env
5
-	private static $user = 'smr';       // must match MYSQL_USER in .env
6
-	private static $password = 'smr';   // must match MYSQL_PASSWORD in .env
5
+	private static $user = 'smr'; // must match MYSQL_USER in .env
6
+	private static $password = 'smr'; // must match MYSQL_PASSWORD in .env
7 7
 
8 8
 	// Set to null to use defaults
9 9
 	private static $port = null;
Please login to merge, or discard this patch.
admin/Default/1.6/game_edit_processing.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,7 @@
 block discarded – undo
2 2
 
3 3
 // Get the dates ("|" sets hr/min/sec to 0)
4 4
 $join = DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_join']);
5
-$start = empty($_REQUEST['game_start']) ? $join :
6
-         DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_start']);
5
+$start = empty($_REQUEST['game_start']) ? $join : DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_start']);
7 6
 $end = DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_end']);
8 7
 
9 8
 $game = SmrGame::getGame($var['game_id']);
Please login to merge, or discard this patch.
engine/Default/planet_attack_processing.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -49,12 +49,12 @@
 block discarded – undo
49 49
 }
50 50
 
51 51
 foreach ($attackers as $attacker) {
52
-	$playerResults =& $attacker->shootPlanet($planet, false);
53
-	$results['Attackers']['Traders'][$attacker->getAccountID()] =& $playerResults;
52
+	$playerResults = & $attacker->shootPlanet($planet, false);
53
+	$results['Attackers']['Traders'][$attacker->getAccountID()] = & $playerResults;
54 54
 	$results['Attackers']['TotalDamage'] += $playerResults['TotalDamage'];
55 55
 }
56 56
 $results['Attackers']['Downgrades'] = $planet->checkForDowngrade($results['Attackers']['TotalDamage']);
57
-$results['Planet'] =& $planet->shootPlayers($attackers);
57
+$results['Planet'] = & $planet->shootPlayers($attackers);
58 58
 
59 59
 $account->log(LOG_TYPE_PLANET_BUSTING, 'Player attacks planet, the planet does ' . $results['Planet']['TotalDamage'] . ', their team does ' . $results['Attackers']['TotalDamage'] . ' and downgrades: ' . var_export($results['Attackers']['Downgrades'], true), $planet->getSectorID());
60 60
 
Please login to merge, or discard this patch.
engine/Default/port_attack_processing.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -45,12 +45,12 @@
 block discarded – undo
45 45
 }
46 46
 
47 47
 foreach ($attackers as $attacker) {
48
-	$playerResults =& $attacker->shootPort($port);
49
-	$results['Attackers']['Traders'][$attacker->getAccountID()] =& $playerResults;
48
+	$playerResults = & $attacker->shootPort($port);
49
+	$results['Attackers']['Traders'][$attacker->getAccountID()] = & $playerResults;
50 50
 	$results['Attackers']['TotalDamage'] += $playerResults['TotalDamage'];
51 51
 }
52 52
 $results['Attackers']['Downgrades'] = $port->checkForDowngrade($results['Attackers']['TotalDamage']);
53
-$results['Port'] =& $port->shootPlayers($attackers);
53
+$results['Port'] = & $port->shootPlayers($attackers);
54 54
 
55 55
 $account->log(LOG_TYPE_PORT_RAIDING, 'Player attacks port, the port does ' . $results['Port']['TotalDamage'] . ', their team does ' . $results['Attackers']['TotalDamage'] . ' and downgrades ' . $results['Attackers']['Downgrades'] . ' levels.', $port->getSectorID());
56 56
 
Please login to merge, or discard this patch.
engine/Default/trader_attack_processing.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -41,8 +41,8 @@
 block discarded – undo
41 41
 
42 42
 function teamAttack(&$results, $fightingPlayers, $attack, $defend) {
43 43
 	foreach ($fightingPlayers[$attack] as $accountID => $teamPlayer) {
44
-		$playerResults =& $teamPlayer->shootPlayers($fightingPlayers[$defend]);
45
-		$results[$attack]['Traders'][$teamPlayer->getAccountID()] =& $playerResults;
44
+		$playerResults = & $teamPlayer->shootPlayers($fightingPlayers[$defend]);
45
+		$results[$attack]['Traders'][$teamPlayer->getAccountID()] = & $playerResults;
46 46
 		$results[$attack]['TotalDamage'] += $playerResults['TotalDamage'];
47 47
 
48 48
 		// Award assists (if there are multiple attackers)
Please login to merge, or discard this patch.
engine/Default/forces_attack_processing.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -72,18 +72,18 @@
 block discarded – undo
72 72
 
73 73
 // If mines are bumped, the forces shoot first. Otherwise player shoots first.
74 74
 if ($bump) {
75
-	$results['Forces'] =& $forces->shootPlayers($attackers, $bump);
75
+	$results['Forces'] = & $forces->shootPlayers($attackers, $bump);
76 76
 }
77 77
 
78 78
 $results['Attackers'] = array('TotalDamage' => 0);
79 79
 foreach ($attackers as $attacker) {
80
-	$playerResults =& $attacker->shootForces($forces);
81
-	$results['Attackers']['Traders'][$attacker->getAccountID()] =& $playerResults;
80
+	$playerResults = & $attacker->shootForces($forces);
81
+	$results['Attackers']['Traders'][$attacker->getAccountID()] = & $playerResults;
82 82
 	$results['Attackers']['TotalDamage'] += $playerResults['TotalDamage'];
83 83
 }
84 84
 
85 85
 if (!$bump) {
86
-	$results['Forces'] =& $forces->shootPlayers($attackers, $bump);
86
+	$results['Forces'] = & $forces->shootPlayers($attackers, $bump);
87 87
 	$forces->updateExpire();
88 88
 }
89 89
 
Please login to merge, or discard this patch.
engine/Default/hall_of_fame_new.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -20,13 +20,13 @@
 block discarded – undo
20 20
 const USER_SCORE_NAME = 'User Score';
21 21
 $hofTypes = array(DONATION_NAME=>true, USER_SCORE_NAME=>true);
22 22
 while ($db->nextRecord()) {
23
-	$hof =& $hofTypes;
23
+	$hof = & $hofTypes;
24 24
 	$typeList = explode(':', $db->getField('type'));
25 25
 	foreach ($typeList as $type) {
26 26
 		if (!isset($hof[$type])) {
27 27
 			$hof[$type] = array();
28 28
 		}
29
-		$hof =& $hof[$type];
29
+		$hof = & $hof[$type];
30 30
 	}
31 31
 	$hof = true;
32 32
 }
Please login to merge, or discard this patch.
engine/Default/hall_of_fame_player_detail.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -20,13 +20,13 @@
 block discarded – undo
20 20
 const USER_SCORE_NAME = 'User Score';
21 21
 $hofTypes = array(DONATION_NAME=>true, USER_SCORE_NAME=>true);
22 22
 while ($db->nextRecord()) {
23
-	$hof =& $hofTypes;
23
+	$hof = & $hofTypes;
24 24
 	$typeList = explode(':', $db->getField('type'));
25 25
 	foreach ($typeList as $type) {
26 26
 		if (!isset($hof[$type])) {
27 27
 			$hof[$type] = array();
28 28
 		}
29
-		$hof =& $hof[$type];
29
+		$hof = & $hof[$type];
30 30
 	}
31 31
 	$hof = true;
32 32
 }
Please login to merge, or discard this patch.
lib/Default/SmrForce.class.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -446,20 +446,20 @@
 block discarded – undo
446 446
 
447 447
 		if ($this->hasMines()) {
448 448
 			$thisMines = new SmrMines($this->getGameID(), $this->getMines());
449
-			$results['Results']['Mines'] =& $thisMines->shootPlayerAsForce($this, $targetPlayers[array_rand($targetPlayers)], $minesAreAttacker);
449
+			$results['Results']['Mines'] = & $thisMines->shootPlayerAsForce($this, $targetPlayers[array_rand($targetPlayers)], $minesAreAttacker);
450 450
 			$results['TotalDamage'] += $results['Results']['Mines']['ActualDamage']['TotalDamage'];
451 451
 		}
452 452
 
453 453
 		if ($this->hasCDs()) {
454 454
 			$thisCDs = new SmrCombatDrones($this->getGameID(), $this->getCDs());
455
-			$results['Results']['Drones'] =& $thisCDs->shootPlayerAsForce($this, $targetPlayers[array_rand($targetPlayers)]);
455
+			$results['Results']['Drones'] = & $thisCDs->shootPlayerAsForce($this, $targetPlayers[array_rand($targetPlayers)]);
456 456
 			$results['TotalDamage'] += $results['Results']['Drones']['ActualDamage']['TotalDamage'];
457 457
 		}
458 458
 
459 459
 		if (!$minesAreAttacker) {
460 460
 			if ($this->hasSDs()) {
461 461
 				$thisSDs = new SmrScoutDrones($this->getGameID(), $this->getSDs());
462
-				$results['Results']['Scouts'] =& $thisSDs->shootPlayerAsForce($this, $targetPlayers[array_rand($targetPlayers)]);
462
+				$results['Results']['Scouts'] = & $thisSDs->shootPlayerAsForce($this, $targetPlayers[array_rand($targetPlayers)]);
463 463
 				$results['TotalDamage'] += $results['Results']['Scouts']['ActualDamage']['TotalDamage'];
464 464
 			}
465 465
 		}
Please login to merge, or discard this patch.