Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#1010)
by Dan
06:10
created
src/lib/Default/AbstractSmrShip.class.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -924,14 +924,14 @@
 block discarded – undo
924 924
 
925 925
 	public function isFederal() {
926 926
 		return $this->getShipTypeID() == SHIP_TYPE_FEDERAL_DISCOVERY ||
927
-		       $this->getShipTypeID() == SHIP_TYPE_FEDERAL_WARRANT ||
928
-		       $this->getShipTypeID() == SHIP_TYPE_FEDERAL_ULTIMATUM;
927
+			   $this->getShipTypeID() == SHIP_TYPE_FEDERAL_WARRANT ||
928
+			   $this->getShipTypeID() == SHIP_TYPE_FEDERAL_ULTIMATUM;
929 929
 	}
930 930
 
931 931
 	public function isUnderground() {
932 932
 		return $this->getShipTypeID() == SHIP_TYPE_THIEF ||
933
-		       $this->getShipTypeID() == SHIP_TYPE_ASSASSIN ||
934
-		       $this->getShipTypeID() == SHIP_TYPE_DEATH_CRUISER;
933
+			   $this->getShipTypeID() == SHIP_TYPE_ASSASSIN ||
934
+			   $this->getShipTypeID() == SHIP_TYPE_DEATH_CRUISER;
935 935
 	}
936 936
 
937 937
 	public function shootPlayers(array $targetPlayers) {
Please login to merge, or discard this patch.
src/lib/Default/AbstractMenu.class.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 		$menuItems[] = array('Link'=>Globals::getPlanetListHREF($alliance_id), 'Text'=>'Defense');
42 42
 		$menuItems[] = array('Link'=>Globals::getPlanetListFinancialHREF($alliance_id), 'Text'=>'Financial');
43 43
 		// make the selected index bold
44
-		$boldItem =& $menuItems[$selected_index]['Text'];
44
+		$boldItem = & $menuItems[$selected_index]['Text'];
45 45
 		$boldItem = '<span class="bold">' . $boldItem . '</span>';
46 46
 		$template->assign('MenuItems', $menuItems);
47 47
 	}
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
 			'Text' => 'Game News',
142 142
 		];
143 143
 		// make the selected index bold
144
-		$boldItem =& $menuItems[$selected_index]['Text'];
144
+		$boldItem = & $menuItems[$selected_index]['Text'];
145 145
 		$boldItem = '<b>' . $boldItem . '</b>';
146 146
 		$template->assign('MenuItems', $menuItems);
147 147
 	}
Please login to merge, or discard this patch.
src/lib/Default/DummyShip.class.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
 			if ($db->nextRecord()) {
71 71
 				$return = unserialize($db->getField('info'));
72 72
 				$return->regenerate($player);
73
-				self::$CACHED_DUMMY_SHIPS[$player->getPlayerName()] =& $return;
73
+				self::$CACHED_DUMMY_SHIPS[$player->getPlayerName()] = & $return;
74 74
 			} else {
75 75
 				self::$CACHED_DUMMY_SHIPS[$player->getPlayerName()] = new DummyShip($player);
76 76
 			}
Please login to merge, or discard this patch.
src/admin/Default/game_delete_processing.php 1 patch
Braces   +26 added lines, -10 removed lines patch added patch discarded remove patch
@@ -141,16 +141,25 @@  discard block
 block discarded – undo
141 141
 			$owner = $db->getInt('owner_id');
142 142
 
143 143
 			$db2->query('SELECT * FROM planet_has_building WHERE game_id = ' . $game_id . ' AND sector_id = ' . $sector . ' AND construction_id = 1');
144
-			if ($db2->nextRecord()) $gens = $db2->getInt('amount');
145
-			else $gens = 0;
144
+			if ($db2->nextRecord()) {
145
+				$gens = $db2->getInt('amount');
146
+			} else {
147
+				$gens = 0;
148
+			}
146 149
 
147 150
 			$db2->query('SELECT * FROM planet_has_building WHERE game_id = ' . $game_id . ' AND sector_id = ' . $sector . ' AND construction_id = 2');
148
-			if ($db2->nextRecord()) $hangs = $db2->getInt('amount');
149
-			else $hangs = 0;
151
+			if ($db2->nextRecord()) {
152
+				$hangs = $db2->getInt('amount');
153
+			} else {
154
+				$hangs = 0;
155
+			}
150 156
 
151 157
 			$db2->query('SELECT * FROM planet_has_building WHERE game_id = ' . $game_id . ' AND sector_id = ' . $sector . ' AND construction_id = 3');
152
-			if ($db2->nextRecord()) $turs = $db2->getInt('amount');
153
-			else $turs = 0;
158
+			if ($db2->nextRecord()) {
159
+				$turs = $db2->getInt('amount');
160
+			} else {
161
+				$turs = 0;
162
+			}
154 163
 
155 164
 			// insert into history db
156 165
 			$history_db_sql[] = 'INSERT INTO planet (game_id, sector_id, owner_id, generators, hangers, turrets) VALUES ' .
@@ -187,14 +196,21 @@  discard block
 block discarded – undo
187 196
 			$smrCredits = 0;
188 197
 			$db2->query('SELECT sum(amount) as bounty_am, sum(smr_credits) as bounty_cred FROM bounty WHERE game_id = ' . $game_id . ' AND account_id = ' . $acc_id . ' AND claimer_id = 0');
189 198
 			if ($db2->nextRecord()) {
190
-				if (is_int($db2->getField('bounty_am'))) $amount = $db2->getInt('bounty_am');
191
-				if (is_int($db2->getField('bounty_cred'))) $smrCredits = $db2->getInt('bounty_cred');
199
+				if (is_int($db2->getField('bounty_am'))) {
200
+					$amount = $db2->getInt('bounty_am');
201
+				}
202
+				if (is_int($db2->getField('bounty_cred'))) {
203
+					$smrCredits = $db2->getInt('bounty_cred');
204
+				}
192 205
 
193 206
 			}
194 207
 
195 208
 			$db2->query('SELECT * FROM ship_has_name WHERE game_id = ' . $game_id . ' AND account_id = ' . $acc_id);
196
-			if ($db2->nextRecord()) $ship_name = $db2->getField('ship_name');
197
-			else $ship_name = 'None';
209
+			if ($db2->nextRecord()) {
210
+				$ship_name = $db2->getField('ship_name');
211
+			} else {
212
+				$ship_name = 'None';
213
+			}
198 214
 
199 215
 			// insert into history db
200 216
 			$history_db_sql[] = 'INSERT INTO player (account_id, game_id, player_name, player_id, experience, ship, race, alignment, alliance_id, kills, deaths, bounty, bounty_cred, ship_name) ' .
Please login to merge, or discard this patch.
src/lib/Default/help.inc.php 1 patch
Braces   +30 added lines, -22 removed lines patch added patch discarded remove patch
@@ -22,16 +22,18 @@  discard block
 block discarded – undo
22 22
 		$db2->query('SELECT * FROM manual WHERE parent_topic_id = ' . $db2->escapeNumber($parent_topic_id) . ' AND order_id = ' . $db2->escapeNumber($order_id - 1));
23 23
 
24 24
 		// no result?
25
-		if (!$db2->getNumRows())
26
-			$db2->query('SELECT * FROM manual WHERE topic_id = ' . $db2->escapeNumber($parent_topic_id));
25
+		if (!$db2->getNumRows()) {
26
+					$db2->query('SELECT * FROM manual WHERE topic_id = ' . $db2->escapeNumber($parent_topic_id));
27
+		}
27 28
 
28 29
 		echo ('<th width="32">');
29 30
 		if ($db2->nextRecord()) {
30 31
 			$previous_topic_id = $db2->getInt('topic_id');
31 32
 			$previous_topic = stripslashes($db2->getField('topic'));
32 33
 			echo ('<a href="/manual.php?' . $previous_topic_id . '"><img src="/images/help/previous.jpg" width="32" height="32" border="0"></a>');
33
-		} else
34
-			echo ('<img src="/images/help/empty.jpg" width="32" height="32">');
34
+		} else {
35
+					echo ('<img src="/images/help/empty.jpg" width="32" height="32">');
36
+		}
35 37
 		echo ('</th>');
36 38
 
37 39
 		// **************************
@@ -43,8 +45,9 @@  discard block
 block discarded – undo
43 45
 			$up_topic_id = $db2->getInt('topic_id');
44 46
 			$up_topic = stripslashes($db2->getField('topic'));
45 47
 			echo ('<a href="/manual.php?' . $up_topic_id . '"><img src="/images/help/up.jpg" width="32" height="32" border="0"></a>');
46
-		} else
47
-			echo ('<img src="/images/help/empty.jpg" width="32" height="32">');
48
+		} else {
49
+					echo ('<img src="/images/help/empty.jpg" width="32" height="32">');
50
+		}
48 51
 		echo ('</th>');
49 52
 
50 53
 		// **************************
@@ -52,8 +55,9 @@  discard block
 block discarded – undo
52 55
 		// **************************
53 56
 		$db2->query('SELECT * FROM manual WHERE parent_topic_id = ' . $db2->escapeNumber($topic_id) . ' AND order_id = 1');
54 57
 
55
-		if (!$db2->getNumRows())
56
-			$db2->query('SELECT * FROM manual WHERE parent_topic_id = ' . $db2->escapeNumber($parent_topic_id) . ' AND order_id = ' . $db2->escapeNumber($order_id + 1));
58
+		if (!$db2->getNumRows()) {
59
+					$db2->query('SELECT * FROM manual WHERE parent_topic_id = ' . $db2->escapeNumber($parent_topic_id) . ' AND order_id = ' . $db2->escapeNumber($order_id + 1));
60
+		}
57 61
 
58 62
 		$seenParentIDs = array(0);
59 63
 		$curr_parent_topic_id = $parent_topic_id;
@@ -72,8 +76,7 @@  discard block
 block discarded – undo
72 76
 			$next_topic_id = $db2->getInt('topic_id');
73 77
 			$next_topic = stripslashes($db2->getField('topic'));
74 78
 			echo ('<a href="/manual.php?' . $next_topic_id . '"><img src="/images/help/next.jpg" width="32" height="32" border="0"></a>');
75
-		}
76
-		else {
79
+		} else {
77 80
 			echo ('<img src="/images/help/empty.jpg" width="32" height="32">');
78 81
 		}
79 82
 		echo ('</th>');
@@ -85,18 +88,22 @@  discard block
 block discarded – undo
85 88
 
86 89
 		echo ('<tr>');
87 90
 		echo ('<td colspan="5">');
88
-		if (isset($previous_topic_id) && $previous_topic_id > 0)
89
-			echo ('<b>Previous:</b> <a href="/manual.php?' . $previous_topic_id . '">' . get_numbering($previous_topic_id) . $previous_topic . '</a>&nbsp;&nbsp;&nbsp;');
90
-		if (isset($up_topic_id) && $up_topic_id > 0)
91
-			echo ('<b>Up:</b> <a href="/manual.php?' . $up_topic_id . '">' . get_numbering($up_topic_id) . $up_topic . '</a>&nbsp;&nbsp;&nbsp;');
92
-		if (isset($next_topic_id) && $next_topic_id > 0)
93
-			echo ('<b>Next:</b> <a href="/manual.php?' . $next_topic_id . '">' . get_numbering($next_topic_id) . $next_topic . '</a>');
91
+		if (isset($previous_topic_id) && $previous_topic_id > 0) {
92
+					echo ('<b>Previous:</b> <a href="/manual.php?' . $previous_topic_id . '">' . get_numbering($previous_topic_id) . $previous_topic . '</a>&nbsp;&nbsp;&nbsp;');
93
+		}
94
+		if (isset($up_topic_id) && $up_topic_id > 0) {
95
+					echo ('<b>Up:</b> <a href="/manual.php?' . $up_topic_id . '">' . get_numbering($up_topic_id) . $up_topic . '</a>&nbsp;&nbsp;&nbsp;');
96
+		}
97
+		if (isset($next_topic_id) && $next_topic_id > 0) {
98
+					echo ('<b>Next:</b> <a href="/manual.php?' . $next_topic_id . '">' . get_numbering($next_topic_id) . $next_topic . '</a>');
99
+		}
94 100
 		echo ('</tr>');
95 101
 
96 102
 		echo ('</table>');
97
-	} else
98
-		echo ('Invalid Topic!');
99
-}
103
+	} else {
104
+			echo ('Invalid Topic!');
105
+	}
106
+	}
100 107
 
101 108
 function echo_content($topic_id) {
102 109
 	// database object
@@ -114,9 +121,10 @@  discard block
 block discarded – undo
114 121
 		echo ('<h1>' . get_numbering($topic_id) . $topic . '</h1>');
115 122
 		echo ('<p>' . $text . '<p>');
116 123
 		echo ('</div>');
117
-	} else
118
-		echo ('Invalid Topic!');
119
-}
124
+	} else {
125
+			echo ('Invalid Topic!');
126
+	}
127
+	}
120 128
 
121 129
 function echo_subsection($topic_id) {
122 130
 	// database object
Please login to merge, or discard this patch.