StoredDestination::__construct() - Code Metrics - Inspection of "Lots of miscellaneous fixes and updates" - smrealms/smr - Measure and Improve Code Quality continuously with Scrutinizer

smr

Failed Conditions

Pull Request — main (#1498)

by Dan

created 2022-12-30 18:43 UTC

StoredDestination::__construct() A

↳ Parent: StoredDestination

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	0

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	0
c	1
b	0
f	0
nc	1
nop	4
dl	0
loc	6
rs	10

<?php declare(strict_types=1);

namespace Smr;

/**
 * Data class for course plotting destinations stored by the player.
 */
class StoredDestination {

	public function __construct(
		public readonly string $label,
		public readonly int $sectorID,
		public readonly int $offsetTop,
		public readonly int $offsetLeft,
	) {}

	/**
	 * Returns the name to display for this destination, e.g. "#42 - UG".
	 */
	public function getDisplayName(): string {
		$name = '#' . $this->sectorID;
		if (!empty($this->label)) {
			$name .= ' - ' . $this->label;
		}
		return $name;
	}

}


1			<?php declare(strict_types=1);
2
3			namespace Smr;
4
5			/**
6			* Data class for course plotting destinations stored by the player.
7			*/
8			class StoredDestination {
9
10			public function __construct(
11			public readonly string $label,
12			public readonly int $sectorID,
13			public readonly int $offsetTop,
14			public readonly int $offsetLeft,
15			) {}
16
17			/**
18			* Returns the name to display for this destination, e.g. "#42 - UG".
19			*/
20			public function getDisplayName(): string {
21			$name = '#' . $this->sectorID;
22			if (!empty($this->label)) {
23			$name .= ' - ' . $this->label;
24			}
25			return $name;
26			}
27
28			}
29

smrealms / smr

Scrutinizer GitHub App not installed

Pull Request — main (#1498)

StoredDestination::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like