smrealms / smr

src/lib/Default/help.inc.php

Braces +30 added lines, -22 removed lines

@@ -22,16 +22,18 @@ 
 		$db2->query('SELECT * FROM manual WHERE parent_topic_id = ' . $db2->escapeNumber($parent_topic_id) . ' AND order_id = ' . $db2->escapeNumber($order_id - 1));
 
 		// no result?
-		if (!$db2->getNumRows())
-			$db2->query('SELECT * FROM manual WHERE topic_id = ' . $db2->escapeNumber($parent_topic_id));
+		if (!$db2->getNumRows()) {
+					$db2->query('SELECT * FROM manual WHERE topic_id = ' . $db2->escapeNumber($parent_topic_id));
+		}
 
 		echo ('<th width="32">');
 		if ($db2->nextRecord()) {
 			$previous_topic_id = $db2->getInt('topic_id');
 			$previous_topic = stripslashes($db2->getField('topic'));
 			echo ('<a href="/manual.php?' . $previous_topic_id . '"><img src="/images/help/previous.jpg" width="32" height="32" border="0"></a>');
-		} else
-			echo ('<img src="/images/help/empty.jpg" width="32" height="32">');
+		} else {
+					echo ('<img src="/images/help/empty.jpg" width="32" height="32">');
+		}
 		echo ('</th>');
 
 		// **************************
@@ -43,8 +45,9 @@ 
 			$up_topic_id = $db2->getInt('topic_id');
 			$up_topic = stripslashes($db2->getField('topic'));
 			echo ('<a href="/manual.php?' . $up_topic_id . '"><img src="/images/help/up.jpg" width="32" height="32" border="0"></a>');
-		} else
-			echo ('<img src="/images/help/empty.jpg" width="32" height="32">');
+		} else {
+					echo ('<img src="/images/help/empty.jpg" width="32" height="32">');
+		}
 		echo ('</th>');
 
 		// **************************
@@ -52,8 +55,9 @@ 
 		// **************************
 		$db2->query('SELECT * FROM manual WHERE parent_topic_id = ' . $db2->escapeNumber($topic_id) . ' AND order_id = 1');
 
-		if (!$db2->getNumRows())
-			$db2->query('SELECT * FROM manual WHERE parent_topic_id = ' . $db2->escapeNumber($parent_topic_id) . ' AND order_id = ' . $db2->escapeNumber($order_id + 1));
+		if (!$db2->getNumRows()) {
+					$db2->query('SELECT * FROM manual WHERE parent_topic_id = ' . $db2->escapeNumber($parent_topic_id) . ' AND order_id = ' . $db2->escapeNumber($order_id + 1));
+		}
 
 		$seenParentIDs = array(0);
 		$curr_parent_topic_id = $parent_topic_id;
@@ -72,8 +76,7 @@ 
 			$next_topic_id = $db2->getInt('topic_id');
 			$next_topic = stripslashes($db2->getField('topic'));
 			echo ('<a href="/manual.php?' . $next_topic_id . '"><img src="/images/help/next.jpg" width="32" height="32" border="0"></a>');
-		}
-		else {
+		} else {
 			echo ('<img src="/images/help/empty.jpg" width="32" height="32">');
 		}
 		echo ('</th>');
@@ -85,18 +88,22 @@ 
 
 		echo ('<tr>');
 		echo ('<td colspan="5">');
-		if (isset($previous_topic_id) && $previous_topic_id > 0)
-			echo ('<b>Previous:</b> <a href="/manual.php?' . $previous_topic_id . '">' . get_numbering($previous_topic_id) . $previous_topic . '</a>&nbsp;&nbsp;&nbsp;');
-		if (isset($up_topic_id) && $up_topic_id > 0)
-			echo ('<b>Up:</b> <a href="/manual.php?' . $up_topic_id . '">' . get_numbering($up_topic_id) . $up_topic . '</a>&nbsp;&nbsp;&nbsp;');
-		if (isset($next_topic_id) && $next_topic_id > 0)
-			echo ('<b>Next:</b> <a href="/manual.php?' . $next_topic_id . '">' . get_numbering($next_topic_id) . $next_topic . '</a>');
+		if (isset($previous_topic_id) && $previous_topic_id > 0) {
+					echo ('<b>Previous:</b> <a href="/manual.php?' . $previous_topic_id . '">' . get_numbering($previous_topic_id) . $previous_topic . '</a>&nbsp;&nbsp;&nbsp;');
+		}
+		if (isset($up_topic_id) && $up_topic_id > 0) {
+					echo ('<b>Up:</b> <a href="/manual.php?' . $up_topic_id . '">' . get_numbering($up_topic_id) . $up_topic . '</a>&nbsp;&nbsp;&nbsp;');
+		}
+		if (isset($next_topic_id) && $next_topic_id > 0) {
+					echo ('<b>Next:</b> <a href="/manual.php?' . $next_topic_id . '">' . get_numbering($next_topic_id) . $next_topic . '</a>');
+		}
 		echo ('</tr>');
 
 		echo ('</table>');
-	} else
-		echo ('Invalid Topic!');
-}
+	} else {
+			echo ('Invalid Topic!');
+	}
+	}
 
 function echo_content($topic_id) {
 	// database object
@@ -114,9 +121,10 @@ 
 		echo ('<h1>' . get_numbering($topic_id) . $topic . '</h1>');
 		echo ('<p>' . $text . '<p>');
 		echo ('</div>');
-	} else
-		echo ('Invalid Topic!');
-}
+	} else {
+			echo ('Invalid Topic!');
+	}
+	}
 
 function echo_subsection($topic_id) {
 	// database object

src/lib/Default/SmrPlanet.class.php

Indentation +1 added lines, -1 removed lines

@@ -735,7 +735,7 @@
 		if ($buildingTypeID === null) {
 			$structs = $this->typeInfo::STRUCTURES;
 			return array_combine(array_keys($structs),
-			                     array_column($structs, 'max_amount'));
+								 array_column($structs, 'max_amount'));
 		}
 		return $this->getStructureTypes($buildingTypeID)->maxAmount();
 	}

test/SmrTest/lib/DefaultGame/SmrPlanetIntegrationTest.php

Spacing +2 added lines, -2 removed lines

@@ -230,13 +230,13 @@
 		$planet->increaseBuilding(PLANET_HANGAR, 4);
 		$this->assertTrue($planet->hasBuilding(PLANET_HANGAR));
 		$this->assertSame(4, $planet->getBuilding(PLANET_HANGAR));
-		$this->assertSame(4/3, $planet->getLevel());
+		$this->assertSame(4 / 3, $planet->getLevel());
 
 		// Destroy some hangars
 		$planet->destroyBuilding(PLANET_HANGAR, 2);
 		$this->assertTrue($planet->hasBuilding(PLANET_HANGAR));
 		$this->assertSame(2, $planet->getBuilding(PLANET_HANGAR));
-		$this->assertSame(2/3, $planet->getLevel());
+		$this->assertSame(2 / 3, $planet->getLevel());
 	}
 
 }

src/lib/Default/AbstractSmrShip.class.php

Indentation +4 added lines, -4 removed lines

@@ -912,14 +912,14 @@
 
 	public function isFederal() : bool {
 		return $this->getShipTypeID() === SHIP_TYPE_FEDERAL_DISCOVERY ||
-		       $this->getShipTypeID() === SHIP_TYPE_FEDERAL_WARRANT ||
-		       $this->getShipTypeID() === SHIP_TYPE_FEDERAL_ULTIMATUM;
+			   $this->getShipTypeID() === SHIP_TYPE_FEDERAL_WARRANT ||
+			   $this->getShipTypeID() === SHIP_TYPE_FEDERAL_ULTIMATUM;
 	}
 
 	public function isUnderground() : bool {
 		return $this->getShipTypeID() === SHIP_TYPE_THIEF ||
-		       $this->getShipTypeID() === SHIP_TYPE_ASSASSIN ||
-		       $this->getShipTypeID() === SHIP_TYPE_DEATH_CRUISER;
+			   $this->getShipTypeID() === SHIP_TYPE_ASSASSIN ||
+			   $this->getShipTypeID() === SHIP_TYPE_DEATH_CRUISER;
 	}
 
 	public function shootPlayers(array $targetPlayers) : array {

test/SmrTest/lib/DefaultGame/AbstractSmrShipTest.php

Spacing +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
 		$ship = new AbstractSmrShip($this->player);
 		$this->expectException(\Exception::class);
 		$this->expectExceptionMessage('Ship does not have the supported hardware!');
-		$ship->setIllusion(SHIP_TYPE_THIEF, 12, 13);;
+		$ship->setIllusion(SHIP_TYPE_THIEF, 12, 13); ;
 	}
 
 	public function test_hardware() {

src/tools/npc/npc.php

Spacing +8 added lines, -8 removed lines

@@ -116,7 +116,7 @@ 
 		}
 
 		try {
-			$TRADE_ROUTE =& $GLOBALS['TRADE_ROUTE'];
+			$TRADE_ROUTE = & $GLOBALS['TRADE_ROUTE'];
 			debug('Action #' . $actions);
 
 			//We have to reload player on each loop
@@ -140,14 +140,14 @@ 
 			}
 
 			if (!isset($TRADE_ROUTE)) { //We only want to change trade route if there isn't already one set.
-				$TRADE_ROUTES =& findRoutes($player);
-				$TRADE_ROUTE =& changeRoute($TRADE_ROUTES);
+				$TRADE_ROUTES = & findRoutes($player);
+				$TRADE_ROUTE = & changeRoute($TRADE_ROUTES);
 			}
 
 			if ($player->isDead()) {
 				debug('Some evil person killed us, let\'s move on now.');
 				$previousContainer = null; //We died, we don't care what we were doing beforehand.
-				$TRADE_ROUTE =& changeRoute($TRADE_ROUTES); //Change route
+				$TRADE_ROUTE = & changeRoute($TRADE_ROUTES); //Change route
 				processContainer(Page::create('death_processing.php'));
 			}
 			if ($player->getNewbieTurns() <= NEWBIE_TURNS_WARNING_LIMIT && $player->getNewbieWarning()) {
@@ -223,7 +223,7 @@ 
 								processContainer(tradeGoods($goodID, $player, $port));
 							} else {
 								//Move to next route or fed.
-								if (($TRADE_ROUTE =& changeRoute($TRADE_ROUTES)) === false) {
+								if (($TRADE_ROUTE = & changeRoute($TRADE_ROUTES)) === false) {
 									debug('Changing Route Failed');
 									processContainer(plotToFed($player));
 								} else {
@@ -250,7 +250,7 @@ 
 							processContainer(tradeGoods($goodID, $player, $port));
 						} else {
 							//Move to next route or fed.
-							if (($TRADE_ROUTE =& changeRoute($TRADE_ROUTES)) === false) {
+							if (($TRADE_ROUTE = & changeRoute($TRADE_ROUTES)) === false) {
 								debug('Changing Route Failed');
 								processContainer(plotToFed($player));
 							} else {
@@ -582,9 +582,9 @@ 
 		return $false;
 	}
 	$routeKey = array_rand($tradeRoutes);
-	$tradeRoute =& $tradeRoutes[$routeKey];
+	$tradeRoute = & $tradeRoutes[$routeKey];
 	unset($tradeRoutes[$routeKey]);
-	$GLOBALS['TRADE_ROUTE'] =& $tradeRoute;
+	$GLOBALS['TRADE_ROUTE'] = & $tradeRoute;
 	debug('Switched route', $tradeRoute);
 	return $tradeRoute;
 }

src/lib/Default/smr.inc.php

Braces +3 added lines, -2 removed lines

@@ -375,8 +375,9 @@
 
 		if (!$player->isDead() && $player->getNewbieTurns() <= NEWBIE_TURNS_WARNING_LIMIT &&
 			$player->getNewbieWarning() &&
-			$var['url'] != 'newbie_warning_processing.php')
-			Page::create('newbie_warning_processing.php')->go();
+			$var['url'] != 'newbie_warning_processing.php') {
+					Page::create('newbie_warning_processing.php')->go();
+		}
 	}
 
 	// Initialize the template

src/admin/Default/1.6/universe_create_planets.php

Indentation +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
 
 // Form to make planet changes
 $container = Page::create('1.6/universe_create_save_processing.php',
-                              '1.6/universe_create_sectors.php', $var);
+							  '1.6/universe_create_sectors.php', $var);
 $template->assign('CreatePlanetsFormHREF', $container->href());
 
 // HREF to cancel and return to the previous page

src/admin/Default/1.6/universe_create_locations.php

Indentation +1 added lines, -1 removed lines

@@ -94,7 +94,7 @@
 
 // Form to make location changes
 $container = Page::create('1.6/universe_create_save_processing.php',
-                              '1.6/universe_create_sectors.php', $var);
+							  '1.6/universe_create_sectors.php', $var);
 $template->assign('CreateLocationsFormHREF', $container->href());
 
 // HREF to cancel and return to the previous page