Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — master ( 56fef3...c9bc3d )
by Dan
05:33
created
src/admin/Default/1.6/game_create_processing.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
 	create_error('Join Date is not valid!');
20 20
 }
21 21
 $start = empty(Request::get('game_start')) ? $join :
22
-         DateTime::createFromFormat('d/m/Y|', Request::get('game_start'));
22
+		 DateTime::createFromFormat('d/m/Y|', Request::get('game_start'));
23 23
 if ($start === false) {
24 24
 	create_error('Start Date is not valid!');
25 25
 }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -18,8 +18,7 @@
 block discarded – undo
18 18
 if ($join === false) {
19 19
 	create_error('Join Date is not valid!');
20 20
 }
21
-$start = empty(Request::get('game_start')) ? $join :
22
-         DateTime::createFromFormat('d/m/Y|', Request::get('game_start'));
21
+$start = empty(Request::get('game_start')) ? $join : DateTime::createFromFormat('d/m/Y|', Request::get('game_start'));
23 22
 if ($start === false) {
24 23
 	create_error('Start Date is not valid!');
25 24
 }
Please login to merge, or discard this patch.
src/admin/Default/1.6/universe_create_locations.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@
 block discarded – undo
87 87
 
88 88
 // Form to make location changes
89 89
 $container = create_container('1.6/universe_create_save_processing.php',
90
-                              '1.6/universe_create_sectors.php', $var);
90
+							  '1.6/universe_create_sectors.php', $var);
91 91
 $template->assign('CreateLocationsFormHREF', SmrSession::getNewHREF($container));
92 92
 
93 93
 // HREF to cancel and return to the previous page
Please login to merge, or discard this patch.
src/admin/Default/1.6/game_edit_processing.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@
 block discarded – undo
3 3
 // Get the dates ("|" sets hr/min/sec to 0)
4 4
 $join = DateTime::createFromFormat('d/m/Y|', Request::get('game_join'));
5 5
 $start = empty(Request::get('game_start')) ? $join :
6
-         DateTime::createFromFormat('d/m/Y|', Request::get('game_start'));
6
+		 DateTime::createFromFormat('d/m/Y|', Request::get('game_start'));
7 7
 $end = DateTime::createFromFormat('d/m/Y|', Request::get('game_end'));
8 8
 
9 9
 $game = SmrGame::getGame($var['game_id']);
Please login to merge, or discard this patch.
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,7 @@
 block discarded – undo
2 2
 
3 3
 // Get the dates ("|" sets hr/min/sec to 0)
4 4
 $join = DateTime::createFromFormat('d/m/Y|', Request::get('game_join'));
5
-$start = empty(Request::get('game_start')) ? $join :
6
-         DateTime::createFromFormat('d/m/Y|', Request::get('game_start'));
5
+$start = empty(Request::get('game_start')) ? $join : DateTime::createFromFormat('d/m/Y|', Request::get('game_start'));
7 6
 $end = DateTime::createFromFormat('d/m/Y|', Request::get('game_end'));
8 7
 
9 8
 $game = SmrGame::getGame($var['game_id']);
Please login to merge, or discard this patch.
src/admin/Default/1.6/universe_create_planets.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
 
30 30
 // Form to make planet changes
31 31
 $container = create_container('1.6/universe_create_save_processing.php',
32
-                              '1.6/universe_create_sectors.php', $var);
32
+							  '1.6/universe_create_sectors.php', $var);
33 33
 $template->assign('CreatePlanetsFormHREF', SmrSession::getNewHREF($container));
34 34
 
35 35
 // HREF to cancel and return to the previous page
Please login to merge, or discard this patch.
src/admin/Default/1.6/check_map.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
 	}
21 21
 }
22 22
 $missingLocs = array_diff(array_keys(SmrLocation::getAllLocations()),
23
-                          array_keys($existingLocs));
23
+						  array_keys($existingLocs));
24 24
 $missingLocNames = [];
25 25
 foreach ($missingLocs as $locID) {
26 26
 	$missingLocNames[] = SmrLocation::getLocation($locID)->getName();
Please login to merge, or discard this patch.
src/admin/Default/1.6/universe_create_sector_details.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
 $template->assign('SelectedPortRaceID', $selectedPortRaceID);
26 26
 
27 27
 $sectorLocationIDs = array_pad(array_keys($editSector->getLocations()),
28
-                               UNI_GEN_LOCATION_SLOTS, 0);
28
+							   UNI_GEN_LOCATION_SLOTS, 0);
29 29
 $template->assign('SectorLocationIDs', $sectorLocationIDs);
30 30
 
31 31
 if ($editSector->hasWarp()) {
Please login to merge, or discard this patch.
src/admin/Default/newsletter_send_processing.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
 
36 36
 // Set the body of the e-mail
37 37
 set_mail_body($mail, $var['newsletter_html'], $var['newsletter_text'],
38
-              Request::get('salutation'));
38
+			  Request::get('salutation'));
39 39
 
40 40
 if (Request::get('to_email') == '*') {
41 41
 	// Send the newsletter to all players.
Please login to merge, or discard this patch.
src/admin/Default/enable_game_processing.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -7,4 +7,4 @@
 block discarded – undo
7 7
 $msg = '<span class="green">SUCCESS: </span>Enabled game ' . $game->getDisplayName();
8 8
 
9 9
 forward(create_container('skeleton.php', 'enable_game.php',
10
-                         array('processing_msg' => $msg)));
10
+						 array('processing_msg' => $msg)));
Please login to merge, or discard this patch.
src/admin/Default/game_delete_processing.php 2 patches
Spacing   +78 added lines, -78 removed lines patch added patch discarded remove patch
@@ -21,14 +21,14 @@  discard block
 block discarded – undo
21 21
 	$game_id = $var['delete_game_id'];
22 22
 
23 23
 	if ($save) {
24
-		$db->query('SELECT * FROM alliance WHERE game_id = '.$db->escapeNumber($game_id));
24
+		$db->query('SELECT * FROM alliance WHERE game_id = ' . $db->escapeNumber($game_id));
25 25
 
26 26
 		while ($db->nextRecord()) {
27 27
 			$id = $db->getInt('alliance_id');
28 28
 			//we need info for forces
29 29
 			//populate alliance list
30 30
 			$db2->query('SELECT * FROM player
31
-						WHERE alliance_id = '.$db2->escapeNumber($id).'
31
+						WHERE alliance_id = '.$db2->escapeNumber($id) . '
32 32
 							AND game_id = '.$db2->escapeNumber($game_id));
33 33
 			$list = array(0);
34 34
 			while ($db2->nextRecord()) {
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 			}
37 37
 			$db2->query('SELECT sum(mines) as sum_m, sum(combat_drones) as cds, sum(scout_drones) as sds
38 38
 						FROM sector_has_forces
39
-						WHERE owner_id IN ('.$db2->escapeArray($list).') AND game_id = '.$db2->escapeNumber($game_id));
39
+						WHERE owner_id IN ('.$db2->escapeArray($list) . ') AND game_id = ' . $db2->escapeNumber($game_id));
40 40
 			if ($db2->nextRecord()) {
41 41
 
42 42
 				$mines = $db2->getInt('sum_m');
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 			$deaths = $db->getInt('alliance_deaths');
57 57
 			// insert into history db
58 58
 			$history_db_sql[] = 'INSERT INTO alliance (game_id, alliance_id, leader_id, kills, deaths, alliance_name, mines, cds, sds) ' .
59
-								'VALUES ('.$db->escapeNumber($game_id).', '.$db->escapeNumber($id).', '.$db->escapeNumber($leader).', '.$db->escapeNumber($kills).', '.$db->escapeNumber($deaths).', ' . $db->escapeString($name) . ', '.$db->escapeNumber($mines).', '.$db->escapeNumber($cds).', '.$db->escapeNumber($sds).')';
59
+								'VALUES (' . $db->escapeNumber($game_id) . ', ' . $db->escapeNumber($id) . ', ' . $db->escapeNumber($leader) . ', ' . $db->escapeNumber($kills) . ', ' . $db->escapeNumber($deaths) . ', ' . $db->escapeString($name) . ', ' . $db->escapeNumber($mines) . ', ' . $db->escapeNumber($cds) . ', ' . $db->escapeNumber($sds) . ')';
60 60
 
61 61
 		}
62 62
 
@@ -65,56 +65,56 @@  discard block
 block discarded – undo
65 65
 	// these table is nothing worth without the players
66 66
 	//$smr_db_sql[] = 'DELETE FROM account_has_logs WHERE game_id = '.$game_id;
67 67
 
68
-	$smr_db_sql[] = 'UPDATE active_session SET game_id = 0 WHERE game_id = '.$db->escapeNumber($game_id);
69
-	$smr_db_sql[] = 'DELETE FROM alliance WHERE game_id = '.$db->escapeNumber($game_id);
70
-	$smr_db_sql[] = 'DELETE FROM alliance_bank_transactions WHERE game_id = '.$db->escapeNumber($game_id);
71
-	$smr_db_sql[] = 'DELETE FROM alliance_has_roles WHERE game_id = '.$db->escapeNumber($game_id);
72
-	$smr_db_sql[] = 'DELETE FROM alliance_thread WHERE game_id = '.$db->escapeNumber($game_id);
73
-	$smr_db_sql[] = 'DELETE FROM alliance_thread_topic WHERE game_id = '.$db->escapeNumber($game_id);
68
+	$smr_db_sql[] = 'UPDATE active_session SET game_id = 0 WHERE game_id = ' . $db->escapeNumber($game_id);
69
+	$smr_db_sql[] = 'DELETE FROM alliance WHERE game_id = ' . $db->escapeNumber($game_id);
70
+	$smr_db_sql[] = 'DELETE FROM alliance_bank_transactions WHERE game_id = ' . $db->escapeNumber($game_id);
71
+	$smr_db_sql[] = 'DELETE FROM alliance_has_roles WHERE game_id = ' . $db->escapeNumber($game_id);
72
+	$smr_db_sql[] = 'DELETE FROM alliance_thread WHERE game_id = ' . $db->escapeNumber($game_id);
73
+	$smr_db_sql[] = 'DELETE FROM alliance_thread_topic WHERE game_id = ' . $db->escapeNumber($game_id);
74 74
 
75 75
 	if ($save) {
76 76
 
77
-		$db->query('SELECT * FROM alliance_vs_alliance WHERE game_id = '.$db->escapeNumber($game_id));
77
+		$db->query('SELECT * FROM alliance_vs_alliance WHERE game_id = ' . $db->escapeNumber($game_id));
78 78
 		while ($db->nextRecord()) {
79 79
 
80 80
 			$alliance_1 = $db->getInt('alliance_id_1');
81 81
 			$alliance_2 = $db->getInt('alliance_id_2');
82 82
 			$kills = $db->getInt('kills');
83 83
 			$history_db_sql[] = 'INSERT INTO alliance_vs_alliance (game_id, alliance_id_1, alliance_id_2, kills) ' .
84
-								'VALUES ('.$game_id.', '.$alliance_1.', '.$alliance_2.', '.$kills.')';
84
+								'VALUES (' . $game_id . ', ' . $alliance_1 . ', ' . $alliance_2 . ', ' . $kills . ')';
85 85
 
86 86
 		}
87 87
 
88 88
 	}
89 89
 
90 90
 
91
-	$smr_db_sql[] = 'DELETE FROM alliance_vs_alliance WHERE game_id = '.$db->escapeNumber($game_id);
92
-	$smr_db_sql[] = 'DELETE FROM anon_bank WHERE game_id = '.$db->escapeNumber($game_id);
93
-	$smr_db_sql[] = 'DELETE FROM anon_bank_transactions WHERE game_id = '.$db->escapeNumber($game_id);
94
-	$smr_db_sql[] = 'DELETE FROM bar_tender WHERE game_id = '.$db->escapeNumber($game_id);
95
-	$smr_db_sql[] = 'DELETE FROM blackjack WHERE game_id = '.$db->escapeNumber($game_id);
96
-	$smr_db_sql[] = 'DELETE FROM galactic_post_applications WHERE game_id = '.$db->escapeNumber($game_id);
97
-	$smr_db_sql[] = 'DELETE FROM galactic_post_article WHERE game_id = '.$db->escapeNumber($game_id);
98
-	$smr_db_sql[] = 'DELETE FROM galactic_post_paper WHERE game_id = '.$db->escapeNumber($game_id);
99
-	$smr_db_sql[] = 'DELETE FROM galactic_post_paper_content WHERE game_id = '.$db->escapeNumber($game_id);
100
-	$smr_db_sql[] = 'DELETE FROM galactic_post_writer WHERE game_id = '.$db->escapeNumber($game_id);
101
-	$smr_db_sql[] = 'DELETE FROM game_galaxy WHERE game_id = '.$db->escapeNumber($game_id);
91
+	$smr_db_sql[] = 'DELETE FROM alliance_vs_alliance WHERE game_id = ' . $db->escapeNumber($game_id);
92
+	$smr_db_sql[] = 'DELETE FROM anon_bank WHERE game_id = ' . $db->escapeNumber($game_id);
93
+	$smr_db_sql[] = 'DELETE FROM anon_bank_transactions WHERE game_id = ' . $db->escapeNumber($game_id);
94
+	$smr_db_sql[] = 'DELETE FROM bar_tender WHERE game_id = ' . $db->escapeNumber($game_id);
95
+	$smr_db_sql[] = 'DELETE FROM blackjack WHERE game_id = ' . $db->escapeNumber($game_id);
96
+	$smr_db_sql[] = 'DELETE FROM galactic_post_applications WHERE game_id = ' . $db->escapeNumber($game_id);
97
+	$smr_db_sql[] = 'DELETE FROM galactic_post_article WHERE game_id = ' . $db->escapeNumber($game_id);
98
+	$smr_db_sql[] = 'DELETE FROM galactic_post_paper WHERE game_id = ' . $db->escapeNumber($game_id);
99
+	$smr_db_sql[] = 'DELETE FROM galactic_post_paper_content WHERE game_id = ' . $db->escapeNumber($game_id);
100
+	$smr_db_sql[] = 'DELETE FROM galactic_post_writer WHERE game_id = ' . $db->escapeNumber($game_id);
101
+	$smr_db_sql[] = 'DELETE FROM game_galaxy WHERE game_id = ' . $db->escapeNumber($game_id);
102 102
 
103 103
 	if ($save) {
104 104
 		$game = SmrGame::getGame($game_id);
105 105
 		// insert into history db
106 106
 		$history_db_sql[] = 'INSERT INTO game (game_id, end_date, start_date, game_name, speed, type) VALUES ' .
107
-								'('.$db->escapeNumber($game_id).', '.$game->getEndTime().', '.$game->getStartTime().', ' . $db->escapeString($game->getGameName()) . ', '.$game->getGameSpeed().', '.$db->escapeString($game->getGameType()).')';
107
+								'(' . $db->escapeNumber($game_id) . ', ' . $game->getEndTime() . ', ' . $game->getStartTime() . ', ' . $db->escapeString($game->getGameName()) . ', ' . $game->getGameSpeed() . ', ' . $db->escapeString($game->getGameType()) . ')';
108 108
 	}
109 109
 
110
-	$smr_db_sql[] = 'DELETE FROM location WHERE game_id = '.$db->escapeNumber($game_id);
111
-	$smr_db_sql[] = 'DELETE FROM mb_exceptions WHERE value LIKE '.$db->escapeString($game_id.'%');
112
-	$smr_db_sql[] = 'DELETE FROM message WHERE game_id = '.$db->escapeNumber($game_id);
113
-	$smr_db_sql[] = 'DELETE FROM message_notify WHERE game_id = '.$db->escapeNumber($game_id);
110
+	$smr_db_sql[] = 'DELETE FROM location WHERE game_id = ' . $db->escapeNumber($game_id);
111
+	$smr_db_sql[] = 'DELETE FROM mb_exceptions WHERE value LIKE ' . $db->escapeString($game_id . '%');
112
+	$smr_db_sql[] = 'DELETE FROM message WHERE game_id = ' . $db->escapeNumber($game_id);
113
+	$smr_db_sql[] = 'DELETE FROM message_notify WHERE game_id = ' . $db->escapeNumber($game_id);
114 114
 
115 115
 	if ($save) {
116 116
 
117
-		$db->query('SELECT * FROM news WHERE game_id = '.$game_id.' AND type = \'regular\'');
117
+		$db->query('SELECT * FROM news WHERE game_id = ' . $game_id . ' AND type = \'regular\'');
118 118
 		$id = 1;
119 119
 
120 120
 		while ($db->nextRecord()) {
@@ -124,17 +124,17 @@  discard block
 block discarded – undo
124 124
 			$msg = $db->getField('news_message');
125 125
 
126 126
 			// insert into history db
127
-			$history_db_sql[] = 'INSERT INTO news (game_id, news_id, time, message) VALUES ('.$game_id.', '.$id.', '.$time.', ' . $db->escapeString($msg) . ')';
127
+			$history_db_sql[] = 'INSERT INTO news (game_id, news_id, time, message) VALUES (' . $game_id . ', ' . $id . ', ' . $time . ', ' . $db->escapeString($msg) . ')';
128 128
 			$id++;
129 129
 
130 130
 		}
131 131
 	}
132 132
 
133
-	$smr_db_sql[] = 'DELETE FROM news WHERE game_id = '.$db->escapeNumber($game_id);
133
+	$smr_db_sql[] = 'DELETE FROM news WHERE game_id = ' . $db->escapeNumber($game_id);
134 134
 
135 135
 	if ($save) {
136 136
 
137
-		$db->query('SELECT * FROM planet WHERE game_id = '.$db->escapeNumber($game_id));
137
+		$db->query('SELECT * FROM planet WHERE game_id = ' . $db->escapeNumber($game_id));
138 138
 
139 139
 		while ($db->nextRecord()) {
140 140
 
@@ -142,34 +142,34 @@  discard block
 block discarded – undo
142 142
 			$sector = $db->getInt('sector_id');
143 143
 			$owner = $db->getInt('owner_id');
144 144
 
145
-			$db2->query('SELECT * FROM planet_has_building WHERE game_id = '.$game_id.' AND sector_id = '.$sector.' AND construction_id = 1');
145
+			$db2->query('SELECT * FROM planet_has_building WHERE game_id = ' . $game_id . ' AND sector_id = ' . $sector . ' AND construction_id = 1');
146 146
 			if ($db2->nextRecord()) $gens = $db2->getInt('amount');
147 147
 			else $gens = 0;
148 148
 
149
-			$db2->query('SELECT * FROM planet_has_building WHERE game_id = '.$game_id.' AND sector_id = '.$sector.' AND construction_id = 2');
149
+			$db2->query('SELECT * FROM planet_has_building WHERE game_id = ' . $game_id . ' AND sector_id = ' . $sector . ' AND construction_id = 2');
150 150
 			if ($db2->nextRecord()) $hangs = $db2->getInt('amount');
151 151
 			else $hangs = 0;
152 152
 
153
-			$db2->query('SELECT * FROM planet_has_building WHERE game_id = '.$game_id.' AND sector_id = '.$sector.' AND construction_id = 3');
153
+			$db2->query('SELECT * FROM planet_has_building WHERE game_id = ' . $game_id . ' AND sector_id = ' . $sector . ' AND construction_id = 3');
154 154
 			if ($db2->nextRecord()) $turs = $db2->getInt('amount');
155 155
 			else $turs = 0;
156 156
 
157 157
 			// insert into history db
158 158
 			$history_db_sql[] = 'INSERT INTO planet (game_id, sector_id, owner_id, generators, hangers, turrets) VALUES ' .
159
-								'('.$game_id.', '.$sector.', '.$owner.', '.$gens.', '.$hangs.', '.$turs.')';
159
+								'(' . $game_id . ', ' . $sector . ', ' . $owner . ', ' . $gens . ', ' . $hangs . ', ' . $turs . ')';
160 160
 
161 161
 		}
162 162
 
163 163
 	}
164 164
 
165
-	$smr_db_sql[] = 'DELETE FROM planet WHERE game_id = '.$db->escapeNumber($game_id);
166
-	$smr_db_sql[] = 'DELETE FROM planet_is_building WHERE game_id = '.$db->escapeNumber($game_id);
167
-	$smr_db_sql[] = 'DELETE FROM planet_has_cargo WHERE game_id = '.$db->escapeNumber($game_id);
168
-	$smr_db_sql[] = 'DELETE FROM planet_has_building WHERE game_id = '.$db->escapeNumber($game_id);
165
+	$smr_db_sql[] = 'DELETE FROM planet WHERE game_id = ' . $db->escapeNumber($game_id);
166
+	$smr_db_sql[] = 'DELETE FROM planet_is_building WHERE game_id = ' . $db->escapeNumber($game_id);
167
+	$smr_db_sql[] = 'DELETE FROM planet_has_cargo WHERE game_id = ' . $db->escapeNumber($game_id);
168
+	$smr_db_sql[] = 'DELETE FROM planet_has_building WHERE game_id = ' . $db->escapeNumber($game_id);
169 169
 
170 170
 	if ($save) {
171 171
 
172
-		$db->query('SELECT * FROM player WHERE game_id = '.$game_id);
172
+		$db->query('SELECT * FROM player WHERE game_id = ' . $game_id);
173 173
 
174 174
 		while ($db->nextRecord()) {
175 175
 
@@ -187,48 +187,48 @@  discard block
 block discarded – undo
187 187
 
188 188
 			$amount = 0;
189 189
 			$smrCredits = 0;
190
-			$db2->query('SELECT sum(amount) as bounty_am, sum(smr_credits) as bounty_cred FROM bounty WHERE game_id = '.$game_id.' AND account_id = '.$acc_id.' AND claimer_id = 0');
190
+			$db2->query('SELECT sum(amount) as bounty_am, sum(smr_credits) as bounty_cred FROM bounty WHERE game_id = ' . $game_id . ' AND account_id = ' . $acc_id . ' AND claimer_id = 0');
191 191
 			if ($db2->nextRecord()) {
192 192
 				if (is_int($db2->getField('bounty_am'))) $amount = $db2->getInt('bounty_am');
193 193
 				if (is_int($db2->getField('bounty_cred'))) $smrCredits = $db2->getInt('bounty_cred');
194 194
 
195 195
 			}
196 196
 
197
-			$db2->query('SELECT * FROM ship_has_name WHERE game_id = '.$game_id.' AND account_id = '.$acc_id);
197
+			$db2->query('SELECT * FROM ship_has_name WHERE game_id = ' . $game_id . ' AND account_id = ' . $acc_id);
198 198
 			if ($db2->nextRecord()) $ship_name = $db2->getField('ship_name');
199 199
 			else $ship_name = 'None';
200 200
 
201 201
 			// insert into history db
202 202
 			$history_db_sql[] = 'INSERT INTO player (account_id, game_id, player_name, player_id, experience, ship, race, alignment, alliance_id, kills, deaths, bounty, bounty_cred, ship_name) ' .
203
-								'VALUES ('.$acc_id.', '.$game_id.', ' . $db->escapeString($name) . ', '.$id.', '.$exp.', '.$ship.', '.$race.', '.$align.', '.$alli.', '.$kills.', '.$deaths.', '.$amount.','.$smrCredits.', ' . $db->escapeString($ship_name) . ')';
203
+								'VALUES (' . $acc_id . ', ' . $game_id . ', ' . $db->escapeString($name) . ', ' . $id . ', ' . $exp . ', ' . $ship . ', ' . $race . ', ' . $align . ', ' . $alli . ', ' . $kills . ', ' . $deaths . ', ' . $amount . ',' . $smrCredits . ', ' . $db->escapeString($ship_name) . ')';
204 204
 
205 205
 		}
206 206
 
207 207
 	}
208 208
 
209
-	$smr_db_sql[] = 'DELETE FROM player WHERE game_id = '.$db->escapeNumber($game_id);
210
-	$smr_db_sql[] = 'DELETE FROM bounty WHERE game_id = '.$db->escapeNumber($game_id);
211
-	$smr_db_sql[] = 'DELETE FROM player_has_ticker WHERE game_id = '.$db->escapeNumber($game_id);
212
-	$smr_db_sql[] = 'DELETE FROM player_has_ticket WHERE game_id = '.$db->escapeNumber($game_id);
213
-	$smr_db_sql[] = 'DELETE FROM player_has_alliance_role WHERE game_id = '.$db->escapeNumber($game_id);
214
-	$smr_db_sql[] = 'DELETE FROM player_has_drinks WHERE game_id = '.$db->escapeNumber($game_id);
215
-	$smr_db_sql[] = 'DELETE FROM player_has_relation WHERE game_id = '.$db->escapeNumber($game_id);
216
-	$smr_db_sql[] = 'DELETE FROM player_has_unread_messages WHERE game_id = '.$db->escapeNumber($game_id);
217
-	$smr_db_sql[] = 'DELETE FROM player_plotted_course WHERE game_id = '.$db->escapeNumber($game_id);
218
-	$smr_db_sql[] = 'DELETE FROM player_read_thread WHERE game_id = '.$db->escapeNumber($game_id);
219
-	$smr_db_sql[] = 'DELETE FROM player_visited_port WHERE game_id = '.$db->escapeNumber($game_id);
220
-	$smr_db_sql[] = 'DELETE FROM player_visited_sector WHERE game_id = '.$db->escapeNumber($game_id);
221
-	$smr_db_sql[] = 'DELETE FROM player_votes_pact WHERE game_id = '.$db->escapeNumber($game_id);
222
-	$smr_db_sql[] = 'DELETE FROM player_votes_relation WHERE game_id = '.$db->escapeNumber($game_id);
223
-	$smr_db_sql[] = 'DELETE FROM plot_cache WHERE game_id = '.$db->escapeNumber($game_id);
224
-	$smr_db_sql[] = 'DELETE FROM port WHERE game_id = '.$db->escapeNumber($game_id);
225
-	$smr_db_sql[] = 'DELETE FROM port_has_goods WHERE game_id = '.$db->escapeNumber($game_id);
226
-	$smr_db_sql[] = 'DELETE FROM race_has_relation WHERE game_id = '.$db->escapeNumber($game_id);
227
-	$smr_db_sql[] = 'DELETE FROM race_has_voting WHERE game_id = '.$db->escapeNumber($game_id);
209
+	$smr_db_sql[] = 'DELETE FROM player WHERE game_id = ' . $db->escapeNumber($game_id);
210
+	$smr_db_sql[] = 'DELETE FROM bounty WHERE game_id = ' . $db->escapeNumber($game_id);
211
+	$smr_db_sql[] = 'DELETE FROM player_has_ticker WHERE game_id = ' . $db->escapeNumber($game_id);
212
+	$smr_db_sql[] = 'DELETE FROM player_has_ticket WHERE game_id = ' . $db->escapeNumber($game_id);
213
+	$smr_db_sql[] = 'DELETE FROM player_has_alliance_role WHERE game_id = ' . $db->escapeNumber($game_id);
214
+	$smr_db_sql[] = 'DELETE FROM player_has_drinks WHERE game_id = ' . $db->escapeNumber($game_id);
215
+	$smr_db_sql[] = 'DELETE FROM player_has_relation WHERE game_id = ' . $db->escapeNumber($game_id);
216
+	$smr_db_sql[] = 'DELETE FROM player_has_unread_messages WHERE game_id = ' . $db->escapeNumber($game_id);
217
+	$smr_db_sql[] = 'DELETE FROM player_plotted_course WHERE game_id = ' . $db->escapeNumber($game_id);
218
+	$smr_db_sql[] = 'DELETE FROM player_read_thread WHERE game_id = ' . $db->escapeNumber($game_id);
219
+	$smr_db_sql[] = 'DELETE FROM player_visited_port WHERE game_id = ' . $db->escapeNumber($game_id);
220
+	$smr_db_sql[] = 'DELETE FROM player_visited_sector WHERE game_id = ' . $db->escapeNumber($game_id);
221
+	$smr_db_sql[] = 'DELETE FROM player_votes_pact WHERE game_id = ' . $db->escapeNumber($game_id);
222
+	$smr_db_sql[] = 'DELETE FROM player_votes_relation WHERE game_id = ' . $db->escapeNumber($game_id);
223
+	$smr_db_sql[] = 'DELETE FROM plot_cache WHERE game_id = ' . $db->escapeNumber($game_id);
224
+	$smr_db_sql[] = 'DELETE FROM port WHERE game_id = ' . $db->escapeNumber($game_id);
225
+	$smr_db_sql[] = 'DELETE FROM port_has_goods WHERE game_id = ' . $db->escapeNumber($game_id);
226
+	$smr_db_sql[] = 'DELETE FROM race_has_relation WHERE game_id = ' . $db->escapeNumber($game_id);
227
+	$smr_db_sql[] = 'DELETE FROM race_has_voting WHERE game_id = ' . $db->escapeNumber($game_id);
228 228
 
229 229
 	if ($save) {
230 230
 
231
-		$db->query('SELECT * FROM sector WHERE game_id = '.$game_id);
231
+		$db->query('SELECT * FROM sector WHERE game_id = ' . $game_id);
232 232
 
233 233
 		while ($db->nextRecord()) {
234 234
 
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
 			$gal_id = $db->getInt('galaxy_id');
239 239
 
240 240
 			$db2->query('SELECT sum(mines) as sum_mines, sum(combat_drones) as cds, sum(scout_drones) as sds FROM sector_has_forces ' .
241
-						'WHERE sector_id = '.$sector.' AND game_id = '.$game_id.' GROUP BY sector_id');
241
+						'WHERE sector_id = ' . $sector . ' AND game_id = ' . $game_id . ' GROUP BY sector_id');
242 242
 			if ($db2->nextRecord()) {
243 243
 
244 244
 				$mines = $db2->getInt('sum_mines');
@@ -258,32 +258,32 @@  discard block
 block discarded – undo
258 258
 
259 259
 			// insert into history db
260 260
 			$history_db_sql[] = 'INSERT INTO sector (game_id, sector_id, gal_id, mines, kills, combat, scouts) ' .
261
-								'VALUES ('.$game_id.','. $sector.','. $gal_id.','. $mines.','. $kills.','. $cds.','. $sds.')';
261
+								'VALUES (' . $game_id . ',' . $sector . ',' . $gal_id . ',' . $mines . ',' . $kills . ',' . $cds . ',' . $sds . ')';
262 262
 
263 263
 		}
264 264
 
265 265
 	}
266 266
 
267
-	$smr_db_sql[] = 'DELETE FROM sector WHERE game_id = '.$game_id;
268
-	$smr_db_sql[] = 'DELETE FROM sector_has_forces WHERE game_id = '.$game_id;
269
-	$smr_db_sql[] = 'DELETE FROM ship_has_cargo WHERE game_id = '.$game_id;
270
-	$smr_db_sql[] = 'DELETE FROM ship_has_hardware WHERE game_id = '.$game_id;
271
-	$smr_db_sql[] = 'DELETE FROM ship_has_name WHERE game_id = '.$game_id;
272
-	$smr_db_sql[] = 'DELETE FROM ship_has_illusion WHERE game_id = '.$game_id;
273
-	$smr_db_sql[] = 'DELETE FROM ship_has_weapon WHERE game_id = '.$game_id;
274
-	$smr_db_sql[] = 'DELETE FROM ship_is_cloaked WHERE game_id = '.$game_id;
275
-	$smr_db_sql[] = 'UPDATE game SET end_time='.SmrSession::getTime().' WHERE game_id = '.$game_id.' AND end_time > '.SmrSession::getTime(); // Do not delete game placeholder, just make sure game is finished
276
-	$smr_db_sql[] = 'UPDATE active_session SET game_id = 0 WHERE game_id = '.$game_id;
267
+	$smr_db_sql[] = 'DELETE FROM sector WHERE game_id = ' . $game_id;
268
+	$smr_db_sql[] = 'DELETE FROM sector_has_forces WHERE game_id = ' . $game_id;
269
+	$smr_db_sql[] = 'DELETE FROM ship_has_cargo WHERE game_id = ' . $game_id;
270
+	$smr_db_sql[] = 'DELETE FROM ship_has_hardware WHERE game_id = ' . $game_id;
271
+	$smr_db_sql[] = 'DELETE FROM ship_has_name WHERE game_id = ' . $game_id;
272
+	$smr_db_sql[] = 'DELETE FROM ship_has_illusion WHERE game_id = ' . $game_id;
273
+	$smr_db_sql[] = 'DELETE FROM ship_has_weapon WHERE game_id = ' . $game_id;
274
+	$smr_db_sql[] = 'DELETE FROM ship_is_cloaked WHERE game_id = ' . $game_id;
275
+	$smr_db_sql[] = 'UPDATE game SET end_time=' . SmrSession::getTime() . ' WHERE game_id = ' . $game_id . ' AND end_time > ' . SmrSession::getTime(); // Do not delete game placeholder, just make sure game is finished
276
+	$smr_db_sql[] = 'UPDATE active_session SET game_id = 0 WHERE game_id = ' . $game_id;
277 277
 
278 278
 	// now do the sql stuff
279
-	foreach($smr_db_sql as $sql) {
279
+	foreach ($smr_db_sql as $sql) {
280 280
 
281 281
 		$db->query($sql);
282 282
 
283 283
 	}
284 284
 
285 285
 	$db = new SmrHistoryMySqlDatabase();
286
-	foreach($history_db_sql as $sql) {
286
+	foreach ($history_db_sql as $sql) {
287 287
 
288 288
 		$db->query($sql);
289 289
 
Please login to merge, or discard this patch.
Braces   +37 added lines, -17 removed lines patch added patch discarded remove patch
@@ -11,8 +11,7 @@  discard block
 block discarded – undo
11 11
 $action = Request::get('action');
12 12
 if (Request::get('save') == 'Yes') {
13 13
 	$save = true;
14
-}
15
-else {
14
+} else {
16 15
 	$save = false;
17 16
 }
18 17
 
@@ -42,8 +41,7 @@  discard block
 block discarded – undo
42 41
 				$mines = $db2->getInt('sum_m');
43 42
 				$cds = $db2->getInt('cds');
44 43
 				$sds = $db2->getInt('sds');
45
-			}
46
-			else {
44
+			} else {
47 45
 				$mines = 0;
48 46
 				$cds = 0;
49 47
 				$sds = 0;
@@ -143,16 +141,25 @@  discard block
 block discarded – undo
143 141
 			$owner = $db->getInt('owner_id');
144 142
 
145 143
 			$db2->query('SELECT * FROM planet_has_building WHERE game_id = '.$game_id.' AND sector_id = '.$sector.' AND construction_id = 1');
146
-			if ($db2->nextRecord()) $gens = $db2->getInt('amount');
147
-			else $gens = 0;
144
+			if ($db2->nextRecord()) {
145
+				$gens = $db2->getInt('amount');
146
+			} else {
147
+				$gens = 0;
148
+			}
148 149
 
149 150
 			$db2->query('SELECT * FROM planet_has_building WHERE game_id = '.$game_id.' AND sector_id = '.$sector.' AND construction_id = 2');
150
-			if ($db2->nextRecord()) $hangs = $db2->getInt('amount');
151
-			else $hangs = 0;
151
+			if ($db2->nextRecord()) {
152
+				$hangs = $db2->getInt('amount');
153
+			} else {
154
+				$hangs = 0;
155
+			}
152 156
 
153 157
 			$db2->query('SELECT * FROM planet_has_building WHERE game_id = '.$game_id.' AND sector_id = '.$sector.' AND construction_id = 3');
154
-			if ($db2->nextRecord()) $turs = $db2->getInt('amount');
155
-			else $turs = 0;
158
+			if ($db2->nextRecord()) {
159
+				$turs = $db2->getInt('amount');
160
+			} else {
161
+				$turs = 0;
162
+			}
156 163
 
157 164
 			// insert into history db
158 165
 			$history_db_sql[] = 'INSERT INTO planet (game_id, sector_id, owner_id, generators, hangers, turrets) VALUES ' .
@@ -189,14 +196,21 @@  discard block
 block discarded – undo
189 196
 			$smrCredits = 0;
190 197
 			$db2->query('SELECT sum(amount) as bounty_am, sum(smr_credits) as bounty_cred FROM bounty WHERE game_id = '.$game_id.' AND account_id = '.$acc_id.' AND claimer_id = 0');
191 198
 			if ($db2->nextRecord()) {
192
-				if (is_int($db2->getField('bounty_am'))) $amount = $db2->getInt('bounty_am');
193
-				if (is_int($db2->getField('bounty_cred'))) $smrCredits = $db2->getInt('bounty_cred');
199
+				if (is_int($db2->getField('bounty_am'))) {
200
+					$amount = $db2->getInt('bounty_am');
201
+				}
202
+				if (is_int($db2->getField('bounty_cred'))) {
203
+					$smrCredits = $db2->getInt('bounty_cred');
204
+				}
194 205
 
195 206
 			}
196 207
 
197 208
 			$db2->query('SELECT * FROM ship_has_name WHERE game_id = '.$game_id.' AND account_id = '.$acc_id);
198
-			if ($db2->nextRecord()) $ship_name = $db2->getField('ship_name');
199
-			else $ship_name = 'None';
209
+			if ($db2->nextRecord()) {
210
+				$ship_name = $db2->getField('ship_name');
211
+			} else {
212
+				$ship_name = 'None';
213
+			}
200 214
 
201 215
 			// insert into history db
202 216
 			$history_db_sql[] = 'INSERT INTO player (account_id, game_id, player_name, player_id, experience, ship, race, alignment, alliance_id, kills, deaths, bounty, bounty_cred, ship_name) ' .
@@ -244,9 +258,15 @@  discard block
 block discarded – undo
244 258
 				$mines = $db2->getInt('sum_mines');
245 259
 				$cds = $db2->getInt('cds');
246 260
 				$sds = $db2->getInt('sds');
247
-				if (!is_numeric($mines)) $mines = 0;
248
-				if (!is_numeric($cds)) $cds = 0;
249
-				if (!is_numeric($sds)) $sds = 0;
261
+				if (!is_numeric($mines)) {
262
+					$mines = 0;
263
+				}
264
+				if (!is_numeric($cds)) {
265
+					$cds = 0;
266
+				}
267
+				if (!is_numeric($sds)) {
268
+					$sds = 0;
269
+				}
250 270
 
251 271
 			} else {
252 272
 
Please login to merge, or discard this patch.