Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#1049)
by
unknown
05:18
created
src/lib/Default/Page.class.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -163,7 +163,7 @@
 block discarded – undo
163 163
 
164 164
 		// transfer this value to next container
165 165
 		if (!isset($var[$source])) {
166
-			throw new Exception('Could not find "' . $source. '" in var!');
166
+			throw new Exception('Could not find "' . $source . '" in var!');
167 167
 		}
168 168
 		if ($dest === null) {
169 169
 			$dest = $source;
Please login to merge, or discard this patch.
src/lib/Default/hof.inc.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -55,9 +55,9 @@
 block discarded – undo
55 55
 	$session = Smr\Session::getInstance();
56 56
 	$account = $session->getAccount();
57 57
 	if (($vis == HOF_PRIVATE && $account->getAccountID() != $accountID) ||
58
-	    ($vis == HOF_ALLIANCE && isset($gameID) &&
59
-	     !SmrGame::getGame($gameID)->hasEnded() &&
60
-	     !SmrPlayer::getPlayer($accountID, $gameID)->sameAlliance($session->getPlayer())))
58
+		($vis == HOF_ALLIANCE && isset($gameID) &&
59
+		 !SmrGame::getGame($gameID)->hasEnded() &&
60
+		 !SmrPlayer::getPlayer($accountID, $gameID)->sameAlliance($session->getPlayer())))
61 61
 	{
62 62
 		return '-';
63 63
 	} else {
Please login to merge, or discard this patch.
src/tools/npc/chess.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -19,8 +19,8 @@  discard block
 block discarded – undo
19 19
 		1 => array("pipe", "w")  // stdout is a pipe that the child will write to
20 20
 	);
21 21
 	$engine = proc_open(UCI_CHESS_ENGINE, $descriptorSpec, $pipes);
22
-	$toEngine =& $pipes[0];
23
-	$fromEngine =& $pipes[1];
22
+	$toEngine = & $pipes[0];
23
+	$fromEngine = & $pipes[1];
24 24
 
25 25
 	function readFromEngine($block = true) {
26 26
 		global $fromEngine;
@@ -84,5 +84,5 @@  discard block
 block discarded – undo
84 84
 function debug($message, $debugObject = null) {
85 85
 	echo date('Y-m-d H:i:s - ') . $message . ($debugObject !== null ? EOL . var_export($debugObject, true) : '') . EOL;
86 86
 	$db = Smr\Database::getInstance();
87
-	$db->query('INSERT INTO npc_logs (script_id, npc_id, time, message, debug_info, var) VALUES (' . (defined('SCRIPT_ID') ? SCRIPT_ID : 0) . ', 0, NOW(),' . $db->escapeString($message) . ',' . $db->escapeString(var_export($debugObject,true)) . ',' . $db->escapeString('') . ')');
87
+	$db->query('INSERT INTO npc_logs (script_id, npc_id, time, message, debug_info, var) VALUES (' . (defined('SCRIPT_ID') ? SCRIPT_ID : 0) . ', 0, NOW(),' . $db->escapeString($message) . ',' . $db->escapeString(var_export($debugObject, true)) . ',' . $db->escapeString('') . ')');
88 88
 }
Please login to merge, or discard this patch.
src/engine/Default/message_view.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -130,7 +130,7 @@
 block discarded – undo
130 130
 					AND receiver_delete = ' . $db->escapeBoolean(false) . '
131 131
 					ORDER BY send_time DESC');
132 132
 	while ($db->nextRecord()) {
133
-		$groupBox =& $messageBox['GroupedMessages'][$db->getInt('sender_id')];
133
+		$groupBox = & $messageBox['GroupedMessages'][$db->getInt('sender_id')];
134 134
 		// Limit the number of messages in each group
135 135
 		if (!isset($groupBox['Messages']) || count($groupBox['Messages']) < MESSAGE_SCOUT_GROUP_LIMIT) {
136 136
 			displayMessage($groupBox, $db->getInt('message_id'), $db->getInt('account_id'), $db->getInt('sender_id'), $player->getGameID(), stripslashes($db->getField('message_text')), $db->getInt('send_time'), $db->getBoolean('msg_read'), MSG_SCOUT, $player->getAccount());
Please login to merge, or discard this patch.
src/engine/Default/history_games.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
 $db = Smr\Database::getInstance();
18 18
 $db->switchDatabases($var['HistoryDatabase']);
19 19
 $db->query('SELECT start_date, type, end_date, game_name, speed, game_id ' .
20
-           'FROM game WHERE game_id = ' . $db->escapeNumber($game_id));
20
+		   'FROM game WHERE game_id = ' . $db->escapeNumber($game_id));
21 21
 $db->requireRecord();
22 22
 $template->assign('GameName', $game_name);
23 23
 $template->assign('Start', date($account->getDateFormat(), $db->getInt('start_date')));
Please login to merge, or discard this patch.
src/lib/Default/DummyPlayer.class.php 1 patch
Braces   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -48,8 +48,9 @@  discard block
 block discarded – undo
48 48
 	}
49 49
 
50 50
 	public function setAllianceID($ID) {
51
-		if ($this->allianceID == $ID)
52
-			return;
51
+		if ($this->allianceID == $ID) {
52
+					return;
53
+		}
53 54
 		$this->allianceID = $ID;
54 55
 	}
55 56
 
@@ -85,8 +86,7 @@  discard block
 block discarded – undo
85 86
 						AND id = ' . $db->escapeString($name) . ' LIMIT 1');
86 87
 		if ($db->nextRecord()) {
87 88
 			return $db->getObject('info');
88
-		}
89
-		else {
89
+		} else {
90 90
 			return new DummyPlayer();
91 91
 		}
92 92
 	}
Please login to merge, or discard this patch.
src/engine/Default/combat_simulator.php 1 patch
Braces   +14 added lines, -8 removed lines patch added patch discarded remove patch
@@ -12,10 +12,11 @@  discard block
 block discarded – undo
12 12
 $realAttackers = array();
13 13
 $attackers = array();
14 14
 $i = 1;
15
-if (isset($_POST['attackers']))
15
+if (isset($_POST['attackers'])) {
16 16
 	foreach ($_POST['attackers'] as $attackerName) {
17 17
 		if ($attackerName == 'none')
18 18
 			continue;
19
+}
19 20
 		if (isset($usedNames[$attackerName])) {
20 21
 			$duplicates = true;
21 22
 			continue;
@@ -27,17 +28,19 @@  discard block
 block discarded – undo
27 28
 		++$i;
28 29
 	}
29 30
 
30
-for (;$i <= 10; ++$i)
31
+for (;$i <= 10; ++$i) {
31 32
 	$attackers[$i] = null;
33
+}
32 34
 $template->assign('Attackers', $attackers);
33 35
 
34 36
 $i = 1;
35 37
 $realDefenders = array();
36 38
 $defenders = array();
37
-if (isset($_POST['defenders']))
39
+if (isset($_POST['defenders'])) {
38 40
 	foreach ($_POST['defenders'] as $defenderName) {
39 41
 		if ($defenderName == 'none')
40 42
 			continue;
43
+}
41 44
 		if (isset($usedNames[$defenderName])) {
42 45
 			$duplicates = true;
43 46
 			continue;
@@ -49,8 +52,9 @@  discard block
 block discarded – undo
49 52
 		++$i;
50 53
 	}
51 54
 
52
-for (;$i <= 10; ++$i)
55
+for (;$i <= 10; ++$i) {
53 56
 	$defenders[$i] = null;
57
+}
54 58
 $template->assign('Defenders', $defenders);
55 59
 
56 60
 $template->assign('Duplicates', $duplicates);
@@ -65,12 +69,14 @@  discard block
 block discarded – undo
65 69
 		while (count($realAttackers) > 0 && count($realDefenders) > 0) {
66 70
 			runAnAttack($realAttackers, $realDefenders);
67 71
 			foreach ($realAttackers as $key => &$teamPlayer) {
68
-				if ($teamPlayer->isDead())
69
-					unset($realAttackers[$key]);
72
+				if ($teamPlayer->isDead()) {
73
+									unset($realAttackers[$key]);
74
+				}
70 75
 			} unset($teamPlayer);
71 76
 			foreach ($realDefenders as $key => &$teamPlayer) {
72
-				if ($teamPlayer->isDead())
73
-					unset($realDefenders[$key]);
77
+				if ($teamPlayer->isDead()) {
78
+									unset($realDefenders[$key]);
79
+				}
74 80
 			} unset($teamPlayer);
75 81
 		}
76 82
 	}
Please login to merge, or discard this patch.