Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Failed Conditions
Pull Request — main (#1494)
by Dan
10:59 queued 05:29
created
src/lib/Smr/HallOfFame.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -67,9 +67,9 @@
 block discarded – undo
67 67
 		$session = Session::getInstance();
68 68
 		$account = $session->getAccount();
69 69
 		if (($vis == HOF_PRIVATE && $account->getAccountID() != $accountID) ||
70
-		    ($vis == HOF_ALLIANCE && isset($gameID) &&
71
-		     !SmrGame::getGame($gameID)->hasEnded() &&
72
-		     !SmrPlayer::getPlayer($accountID, $gameID)->sameAlliance($session->getPlayer()))) {
70
+			($vis == HOF_ALLIANCE && isset($gameID) &&
71
+			 !SmrGame::getGame($gameID)->hasEnded() &&
72
+			 !SmrPlayer::getPlayer($accountID, $gameID)->sameAlliance($session->getPlayer()))) {
73 73
 			return '-';
74 74
 		}
75 75
 		return $amount;
Please login to merge, or discard this patch.
src/lib/Smr/Database.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 	 * Not intended to be used outside the DI context.
27 27
 	 */
28 28
 	public static function mysqliFactory(DatabaseProperties $dbProperties): mysqli {
29
-		if (!mysqli_report(MYSQLI_REPORT_ERROR | MYSQLI_REPORT_STRICT)) {
29
+		if (!mysqli_report(MYSQLI_REPORT_ERROR|MYSQLI_REPORT_STRICT)) {
30 30
 			throw new RuntimeException('Failed to enable mysqli error reporting');
31 31
 		}
32 32
 		$mysql = new mysqli(
Please login to merge, or discard this patch.
src/htdocs/ship_list.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
 		'illusion' => $ship->canHaveIllusion() ? 'Yes' : '',
71 71
 		'jump' => $ship->canHaveJump() ? 'Yes' : '',
72 72
 		'scrambler' => $ship->canHaveDCS() ? 'Yes' : '',
73
-		'locs' => implode('', array_map(fn(string $name): string => '<div>' . $name . '</div>', $shipLocs)),
73
+		'locs' => implode('', array_map(fn(string $name) : string => '<div>' . $name . '</div>', $shipLocs)),
74 74
 	];
75 75
 	return $stat;
76 76
 }
Please login to merge, or discard this patch.
src/lib/Smr/VoteLink.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
 	public const TIME_BETWEEN_VOTING = 84600; // 23.5 hours
15 15
 
16 16
 	/** @var ?array<int, int> */
17
-	private static ?array $CACHE_TIMEOUTS = null;
17
+	private static ? array $CACHE_TIMEOUTS = null;
18 18
 
19 19
 	/** @var array<string, mixed> */
20 20
 	public readonly array $data;
Please login to merge, or discard this patch.
src/lib/Default/AbstractSmrShip.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -754,14 +754,14 @@
 block discarded – undo
754 754
 
755 755
 	public function isFederal(): bool {
756 756
 		return $this->getTypeID() === SHIP_TYPE_FEDERAL_DISCOVERY ||
757
-		       $this->getTypeID() === SHIP_TYPE_FEDERAL_WARRANT ||
758
-		       $this->getTypeID() === SHIP_TYPE_FEDERAL_ULTIMATUM;
757
+			   $this->getTypeID() === SHIP_TYPE_FEDERAL_WARRANT ||
758
+			   $this->getTypeID() === SHIP_TYPE_FEDERAL_ULTIMATUM;
759 759
 	}
760 760
 
761 761
 	public function isUnderground(): bool {
762 762
 		return $this->getTypeID() === SHIP_TYPE_THIEF ||
763
-		       $this->getTypeID() === SHIP_TYPE_ASSASSIN ||
764
-		       $this->getTypeID() === SHIP_TYPE_DEATH_CRUISER;
763
+			   $this->getTypeID() === SHIP_TYPE_ASSASSIN ||
764
+			   $this->getTypeID() === SHIP_TYPE_DEATH_CRUISER;
765 765
 	}
766 766
 
767 767
 	/**
Please login to merge, or discard this patch.
src/lib/Default/missions.inc.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -123,7 +123,7 @@
 block discarded – undo
123 123
  *
124 124
  * @param array<string, mixed> $data
125 125
  */
126
-function replaceMissionTemplate(string|int|PlotGroup &$template, string $key, array $data): void {
126
+function replaceMissionTemplate(string|int|PlotGroup&$template, string $key, array $data): void {
127 127
 	if (!is_string($template)) {
128 128
 		return;
129 129
 	}
Please login to merge, or discard this patch.
src/templates/Default/engine/Default/includes/Head.inc.php 1 patch
Braces   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,5 +1,8 @@
 block discarded – undo
1 1
 <meta http-equiv="Content-type" content="text/html; charset=utf-8" />
2
-<title><?php echo PAGE_TITLE; ?><?php if (isset($GameName)) echo ": $GameName"; ?></title>
2
+<title><?php echo PAGE_TITLE; ?><?php if (isset($GameName)) {
3
+	echo ": $GameName";
4
+}
5
+?></title>
3 6
 <meta http-equiv="pragma" content="no-cache" /><?php
4 7
 if ($ThisAccount->isDefaultCSSEnabled()) { ?>
5 8
 	<link rel="stylesheet" type="text/css" href="<?php echo $CSSLink; ?>" />
Please login to merge, or discard this patch.
src/pages/Admin/CombatSimulator.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
 	 * @param array<\AbstractSmrPlayer> $defenders
18 18
 	 */
19 19
 	public function __construct(
20
-		private readonly ?array $results = null,
20
+		private readonly ? array $results = null,
21 21
 		private readonly array $attackers = [],
22 22
 		private readonly array $defenders = []
23 23
 	) {}
Please login to merge, or discard this patch.
src/pages/Admin/UniGen/CreateGameProcessor.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -28,8 +28,7 @@
 block discarded – undo
28 28
 		if ($join === false) {
29 29
 			create_error('Join Date is not valid!');
30 30
 		}
31
-		$start = empty(Request::get('game_start')) ? $join :
32
-			DateTime::createFromFormat('d/m/Y|', Request::get('game_start'));
31
+		$start = empty(Request::get('game_start')) ? $join : DateTime::createFromFormat('d/m/Y|', Request::get('game_start'));
33 32
 		if ($start === false) {
34 33
 			create_error('Start Date is not valid!');
35 34
 		}
Please login to merge, or discard this patch.