Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#998)
by Dan
05:35
created
src/lib/Default/AbstractSmrShip.class.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
310 310
 	public function setWeaponLocations(array $orderArray) {
311 311
 		$weapons = $this->weapons;
312 312
 		foreach ($orderArray as $newOrder => $oldOrder) {
313
-			$this->weapons[$newOrder] =& $weapons[$oldOrder];
313
+			$this->weapons[$newOrder] = & $weapons[$oldOrder];
314 314
 		}
315 315
 		$this->hasChangedWeapons = true;
316 316
 	}
@@ -939,14 +939,14 @@  discard block
 block discarded – undo
939 939
 		}
940 940
 		$results['DeadBeforeShot'] = false;
941 941
 		foreach ($this->weapons as $orderID => $weapon) {
942
-			$results['Weapons'][$orderID] =& $weapon->shootPlayer($thisPlayer, array_rand_value($targetPlayers));
942
+			$results['Weapons'][$orderID] = & $weapon->shootPlayer($thisPlayer, array_rand_value($targetPlayers));
943 943
 			if ($results['Weapons'][$orderID]['Hit']) {
944 944
 				$results['TotalDamage'] += $results['Weapons'][$orderID]['ActualDamage']['TotalDamage'];
945 945
 			}
946 946
 		}
947 947
 		if ($this->hasCDs()) {
948 948
 			$thisCDs = new SmrCombatDrones($this->getGameID(), $this->getCDs());
949
-			$results['Drones'] =& $thisCDs->shootPlayer($thisPlayer, array_rand_value($targetPlayers));
949
+			$results['Drones'] = & $thisCDs->shootPlayer($thisPlayer, array_rand_value($targetPlayers));
950 950
 			$results['TotalDamage'] += $results['Drones']['ActualDamage']['TotalDamage'];
951 951
 		}
952 952
 		$thisPlayer->increaseExperience(IRound($results['TotalDamage'] * self::EXP_PER_DAMAGE_PLAYER));
@@ -964,7 +964,7 @@  discard block
 block discarded – undo
964 964
 		}
965 965
 		$results['DeadBeforeShot'] = false;
966 966
 		foreach ($this->weapons as $orderID => $weapon) {
967
-			$results['Weapons'][$orderID] =& $weapon->shootForces($thisPlayer, $forces);
967
+			$results['Weapons'][$orderID] = & $weapon->shootForces($thisPlayer, $forces);
968 968
 			if ($results['Weapons'][$orderID]['Hit']) {
969 969
 				$results['TotalDamage'] += $results['Weapons'][$orderID]['ActualDamage']['TotalDamage'];
970 970
 				$thisPlayer->increaseHOF($results['Weapons'][$orderID]['ActualDamage']['NumMines'], array('Combat', 'Forces', 'Mines', 'Killed'), HOF_PUBLIC);
@@ -978,7 +978,7 @@  discard block
 block discarded – undo
978 978
 		}
979 979
 		if ($this->hasCDs()) {
980 980
 			$thisCDs = new SmrCombatDrones($this->getGameID(), $this->getCDs());
981
-			$results['Drones'] =& $thisCDs->shootForces($thisPlayer, $forces);
981
+			$results['Drones'] = & $thisCDs->shootForces($thisPlayer, $forces);
982 982
 			$results['TotalDamage'] += $results['Drones']['ActualDamage']['TotalDamage'];
983 983
 			$thisPlayer->increaseHOF($results['Drones']['ActualDamage']['NumMines'], array('Combat', 'Forces', 'Mines', 'Killed'), HOF_PUBLIC);
984 984
 			$thisPlayer->increaseHOF($results['Drones']['ActualDamage']['Mines'], array('Combat', 'Forces', 'Mines', 'Damage Done'), HOF_PUBLIC);
@@ -1003,14 +1003,14 @@  discard block
 block discarded – undo
1003 1003
 		}
1004 1004
 		$results['DeadBeforeShot'] = false;
1005 1005
 		foreach ($this->weapons as $orderID => $weapon) {
1006
-			$results['Weapons'][$orderID] =& $weapon->shootPort($thisPlayer, $port);
1006
+			$results['Weapons'][$orderID] = & $weapon->shootPort($thisPlayer, $port);
1007 1007
 			if ($results['Weapons'][$orderID]['Hit']) {
1008 1008
 				$results['TotalDamage'] += $results['Weapons'][$orderID]['ActualDamage']['TotalDamage'];
1009 1009
 			}
1010 1010
 		}
1011 1011
 		if ($this->hasCDs()) {
1012 1012
 			$thisCDs = new SmrCombatDrones($this->getGameID(), $this->getCDs());
1013
-			$results['Drones'] =& $thisCDs->shootPort($thisPlayer, $port);
1013
+			$results['Drones'] = & $thisCDs->shootPort($thisPlayer, $port);
1014 1014
 			$results['TotalDamage'] += $results['Drones']['ActualDamage']['TotalDamage'];
1015 1015
 		}
1016 1016
 		$thisPlayer->increaseExperience(IRound($results['TotalDamage'] * self::EXP_PER_DAMAGE_PORT));
@@ -1041,14 +1041,14 @@  discard block
 block discarded – undo
1041 1041
 		}
1042 1042
 		$results['DeadBeforeShot'] = false;
1043 1043
 		foreach ($this->weapons as $orderID => $weapon) {
1044
-			$results['Weapons'][$orderID] =& $weapon->shootPlanet($thisPlayer, $planet, $delayed);
1044
+			$results['Weapons'][$orderID] = & $weapon->shootPlanet($thisPlayer, $planet, $delayed);
1045 1045
 			if ($results['Weapons'][$orderID]['Hit']) {
1046 1046
 				$results['TotalDamage'] += $results['Weapons'][$orderID]['ActualDamage']['TotalDamage'];
1047 1047
 			}
1048 1048
 		}
1049 1049
 		if ($this->hasCDs()) {
1050 1050
 			$thisCDs = new SmrCombatDrones($this->getGameID(), $this->getCDs());
1051
-			$results['Drones'] =& $thisCDs->shootPlanet($thisPlayer, $planet, $delayed);
1051
+			$results['Drones'] = & $thisCDs->shootPlanet($thisPlayer, $planet, $delayed);
1052 1052
 			$results['TotalDamage'] += $results['Drones']['ActualDamage']['TotalDamage'];
1053 1053
 		}
1054 1054
 		$thisPlayer->increaseExperience(IRound($results['TotalDamage'] * self::EXP_PER_DAMAGE_PLANET));
Please login to merge, or discard this patch.
src/lib/Default/SmrPlanet.class.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1166,7 +1166,7 @@  discard block
 block discarded – undo
1166 1166
 		$results['DeadBeforeShot'] = false;
1167 1167
 		$weapons = $this->getWeapons();
1168 1168
 		foreach ($weapons as $orderID => $weapon) {
1169
-			$results['Weapons'][$orderID] =& $weapon->shootPlayerAsPlanet($this, array_rand_value($targetPlayers));
1169
+			$results['Weapons'][$orderID] = & $weapon->shootPlayerAsPlanet($this, array_rand_value($targetPlayers));
1170 1170
 			if ($results['Weapons'][$orderID]['Hit']) {
1171 1171
 				$results['TotalDamage'] += $results['Weapons'][$orderID]['ActualDamage']['TotalDamage'];
1172 1172
 				$results['TotalDamagePerTargetPlayer'][$results['Weapons'][$orderID]['TargetPlayer']->getAccountID()] += $results['Weapons'][$orderID]['ActualDamage']['TotalDamage'];
@@ -1174,7 +1174,7 @@  discard block
 block discarded – undo
1174 1174
 		}
1175 1175
 		if ($this->hasCDs()) {
1176 1176
 			$thisCDs = new SmrCombatDrones($this->getGameID(), $this->getCDs(), true);
1177
-			$results['Drones'] =& $thisCDs->shootPlayerAsPlanet($this, array_rand_value($targetPlayers));
1177
+			$results['Drones'] = & $thisCDs->shootPlayerAsPlanet($this, array_rand_value($targetPlayers));
1178 1178
 			$results['TotalDamage'] += $results['Drones']['ActualDamage']['TotalDamage'];
1179 1179
 			$results['TotalDamagePerTargetPlayer'][$results['Drones']['TargetPlayer']->getAccountID()] += $results['Drones']['ActualDamage']['TotalDamage'];
1180 1180
 		}
Please login to merge, or discard this patch.
src/lib/Default/AbstractSmrPort.class.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1219,7 +1219,7 @@  discard block
 block discarded – undo
1219 1219
 			do {
1220 1220
 				$targetPlayer = array_rand_value($targetPlayers);
1221 1221
 			} while ($results['TotalShotsPerTargetPlayer'][$targetPlayer->getAccountID()] > min($results['TotalShotsPerTargetPlayer']));
1222
-			$results['Weapons'][$orderID] =& $weapon->shootPlayerAsPort($this, $targetPlayer);
1222
+			$results['Weapons'][$orderID] = & $weapon->shootPlayerAsPort($this, $targetPlayer);
1223 1223
 			$results['TotalShotsPerTargetPlayer'][$targetPlayer->getAccountID()]++;
1224 1224
 			if ($results['Weapons'][$orderID]['Hit']) {
1225 1225
 				$results['TotalDamage'] += $results['Weapons'][$orderID]['ActualDamage']['TotalDamage'];
@@ -1228,7 +1228,7 @@  discard block
 block discarded – undo
1228 1228
 		}
1229 1229
 		if ($this->hasCDs()) {
1230 1230
 			$thisCDs = new SmrCombatDrones($this->getGameID(), $this->getCDs(), true);
1231
-			$results['Drones'] =& $thisCDs->shootPlayerAsPort($this, array_rand_value($targetPlayers));
1231
+			$results['Drones'] = & $thisCDs->shootPlayerAsPort($this, array_rand_value($targetPlayers));
1232 1232
 			$results['TotalDamage'] += $results['Drones']['ActualDamage']['TotalDamage'];
1233 1233
 			$results['TotalDamagePerTargetPlayer'][$results['Drones']['TargetPlayer']->getAccountID()] += $results['Drones']['ActualDamage']['TotalDamage'];
1234 1234
 		}
Please login to merge, or discard this patch.
src/lib/Default/SmrForce.class.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -460,20 +460,20 @@
 block discarded – undo
460 460
 
461 461
 		if ($this->hasMines()) {
462 462
 			$thisMines = new SmrMines($this->getGameID(), $this->getMines());
463
-			$results['Results']['Mines'] =& $thisMines->shootPlayerAsForce($this, array_rand_value($targetPlayers), $minesAreAttacker);
463
+			$results['Results']['Mines'] = & $thisMines->shootPlayerAsForce($this, array_rand_value($targetPlayers), $minesAreAttacker);
464 464
 			$results['TotalDamage'] += $results['Results']['Mines']['ActualDamage']['TotalDamage'];
465 465
 		}
466 466
 
467 467
 		if ($this->hasCDs()) {
468 468
 			$thisCDs = new SmrCombatDrones($this->getGameID(), $this->getCDs());
469
-			$results['Results']['Drones'] =& $thisCDs->shootPlayerAsForce($this, array_rand_value($targetPlayers));
469
+			$results['Results']['Drones'] = & $thisCDs->shootPlayerAsForce($this, array_rand_value($targetPlayers));
470 470
 			$results['TotalDamage'] += $results['Results']['Drones']['ActualDamage']['TotalDamage'];
471 471
 		}
472 472
 
473 473
 		if (!$minesAreAttacker) {
474 474
 			if ($this->hasSDs()) {
475 475
 				$thisSDs = new SmrScoutDrones($this->getGameID(), $this->getSDs());
476
-				$results['Results']['Scouts'] =& $thisSDs->shootPlayerAsForce($this, array_rand_value($targetPlayers));
476
+				$results['Results']['Scouts'] = & $thisSDs->shootPlayerAsForce($this, array_rand_value($targetPlayers));
477 477
 				$results['TotalDamage'] += $results['Results']['Scouts']['ActualDamage']['TotalDamage'];
478 478
 			}
479 479
 		}
Please login to merge, or discard this patch.