Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Failed Conditions
Pull Request — master (#1088)
by Dan
06:55
created
src/lib/Default/AbstractSmrPlayer.class.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
 		while ($this->db->nextRecord()) {
326 326
 			try {
327 327
 				$otherPlayer = SmrPlayer::getPlayer($this->db->getInt('from_account_id'),
328
-				                                    $this->getGameID(), $forceUpdate);
328
+													$this->getGameID(), $forceUpdate);
329 329
 			} catch (PlayerNotFoundException $e) {
330 330
 				// Skip players that have not joined this game
331 331
 				continue;
@@ -885,9 +885,9 @@  discard block
 block discarded – undo
885 885
 	 */
886 886
 	public function canFight() : bool {
887 887
 		return !($this->hasNewbieTurns() ||
888
-		         $this->isDead() ||
889
-		         $this->isLandedOnPlanet() ||
890
-		         $this->hasFederalProtection());
888
+				 $this->isDead() ||
889
+				 $this->isLandedOnPlanet() ||
890
+				 $this->hasFederalProtection());
891 891
 	}
892 892
 
893 893
 	public function setDead(bool $bool) : void {
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -1694,7 +1694,7 @@  discard block
 block discarded – undo
1694 1694
 			create_error('The saved sector must be in the box!');
1695 1695
 		}
1696 1696
 
1697
-		$storedDestinations =& $this->getStoredDestinations();
1697
+		$storedDestinations = & $this->getStoredDestinations();
1698 1698
 		foreach ($storedDestinations as &$sd) {
1699 1699
 			if ($sd['SectorID'] == $sectorID) {
1700 1700
 				$sd['OffsetTop'] = $offsetTop;
@@ -2014,13 +2014,13 @@  discard block
 block discarded – undo
2014 2014
 			$this->db->query('SELECT type,amount FROM player_hof WHERE ' . $this->SQL);
2015 2015
 			$this->HOF = array();
2016 2016
 			while ($this->db->nextRecord()) {
2017
-				$hof =& $this->HOF;
2017
+				$hof = & $this->HOF;
2018 2018
 				$typeList = explode(':', $this->db->getField('type'));
2019 2019
 				foreach ($typeList as $type) {
2020 2020
 					if (!isset($hof[$type])) {
2021 2021
 						$hof[$type] = array();
2022 2022
 					}
2023
-					$hof =& $hof[$type];
2023
+					$hof = & $hof[$type];
2024 2024
 				}
2025 2025
 				$hof = $this->db->getFloat('amount');
2026 2026
 			}
@@ -2099,8 +2099,8 @@  discard block
 block discarded – undo
2099 2099
 		}
2100 2100
 		self::$HOFVis[$hofType] = $visibility;
2101 2101
 
2102
-		$hof =& $this->HOF;
2103
-		$hofChanged =& $this->hasHOFChanged;
2102
+		$hof = & $this->HOF;
2103
+		$hofChanged = & $this->hasHOFChanged;
2104 2104
 		$new = false;
2105 2105
 		foreach ($typeList as $type) {
2106 2106
 			if (!isset($hofChanged[$type])) {
@@ -2110,8 +2110,8 @@  discard block
 block discarded – undo
2110 2110
 				$hof[$type] = array();
2111 2111
 				$new = true;
2112 2112
 			}
2113
-			$hof =& $hof[$type];
2114
-			$hofChanged =& $hofChanged[$type];
2113
+			$hof = & $hof[$type];
2114
+			$hofChanged = & $hofChanged[$type];
2115 2115
 		}
2116 2116
 		if ($hofChanged == null) {
2117 2117
 			$hofChanged = self::HOF_CHANGED;
@@ -2780,7 +2780,7 @@  discard block
 block discarded – undo
2780 2780
 			'Starting Sector' => $this->getSectorID()
2781 2781
 		);
2782 2782
 
2783
-		$this->missions[$missionID] =& $mission;
2783
+		$this->missions[$missionID] = & $mission;
2784 2784
 		$this->setupMissionStep($missionID);
2785 2785
 		$this->rebuildMission($missionID);
2786 2786
 
@@ -2830,7 +2830,7 @@  discard block
 block discarded – undo
2830 2830
 
2831 2831
 	public function claimMissionReward(int $missionID) : string {
2832 2832
 		$this->getMissions();
2833
-		$mission =& $this->missions[$missionID];
2833
+		$mission = & $this->missions[$missionID];
2834 2834
 		if ($mission === false) {
2835 2835
 			throw new Exception('Unknown mission: ' . $missionID);
2836 2836
 		}
Please login to merge, or discard this patch.
src/lib/Default/SmrSector.class.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -561,7 +561,7 @@
 block discarded – undo
561 561
 	 */
562 562
 	public function setWarp(SmrSector $warp) : void {
563 563
 		if ($this->getWarp() == $warp->getSectorID() &&
564
-		    $warp->getWarp() == $this->getSectorID()) {
564
+			$warp->getWarp() == $this->getSectorID()) {
565 565
 			// Warps are already set correctly!
566 566
 			return;
567 567
 		}
Please login to merge, or discard this patch.
src/tools/discord/GameLink.class.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@
 block discarded – undo
5 5
  */
6 6
 class GameLink
7 7
 {
8
-	public bool $valid = false;  // identifies if the message is linked to game data
8
+	public bool $valid = false; // identifies if the message is linked to game data
9 9
 	public SmrPlayer $player;
10 10
 
11 11
 	function __construct(Discord\Parts\Channel\Message $message) {
Please login to merge, or discard this patch.
src/lib/Default/AbstractSmrShip.class.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -735,14 +735,14 @@
 block discarded – undo
735 735
 
736 736
 	public function isFederal() : bool {
737 737
 		return $this->getTypeID() === SHIP_TYPE_FEDERAL_DISCOVERY ||
738
-		       $this->getTypeID() === SHIP_TYPE_FEDERAL_WARRANT ||
739
-		       $this->getTypeID() === SHIP_TYPE_FEDERAL_ULTIMATUM;
738
+			   $this->getTypeID() === SHIP_TYPE_FEDERAL_WARRANT ||
739
+			   $this->getTypeID() === SHIP_TYPE_FEDERAL_ULTIMATUM;
740 740
 	}
741 741
 
742 742
 	public function isUnderground() : bool {
743 743
 		return $this->getTypeID() === SHIP_TYPE_THIEF ||
744
-		       $this->getTypeID() === SHIP_TYPE_ASSASSIN ||
745
-		       $this->getTypeID() === SHIP_TYPE_DEATH_CRUISER;
744
+			   $this->getTypeID() === SHIP_TYPE_ASSASSIN ||
745
+			   $this->getTypeID() === SHIP_TYPE_DEATH_CRUISER;
746 746
 	}
747 747
 
748 748
 	public function shootPlayers(array $targetPlayers) : array {
Please login to merge, or discard this patch.