Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Failed Conditions
Pull Request — master (#1088)
by Dan
06:55
created
src/lib/Default/smr.inc.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -375,8 +375,9 @@
 block discarded – undo
375 375
 
376 376
 		if (!$player->isDead() && $player->getNewbieTurns() <= NEWBIE_TURNS_WARNING_LIMIT &&
377 377
 			$player->getNewbieWarning() &&
378
-			$var['url'] != 'newbie_warning_processing.php')
379
-			Page::create('newbie_warning_processing.php')->go();
378
+			$var['url'] != 'newbie_warning_processing.php') {
379
+					Page::create('newbie_warning_processing.php')->go();
380
+		}
380 381
 	}
381 382
 
382 383
 	// Initialize the template
Please login to merge, or discard this patch.
src/admin/Default/1.6/universe_create_planets.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
 
34 34
 // Form to make planet changes
35 35
 $container = Page::create('1.6/universe_create_save_processing.php',
36
-                              '1.6/universe_create_sectors.php', $var);
36
+							  '1.6/universe_create_sectors.php', $var);
37 37
 $template->assign('CreatePlanetsFormHREF', $container->href());
38 38
 
39 39
 // HREF to cancel and return to the previous page
Please login to merge, or discard this patch.
src/admin/Default/1.6/universe_create_locations.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@
 block discarded – undo
94 94
 
95 95
 // Form to make location changes
96 96
 $container = Page::create('1.6/universe_create_save_processing.php',
97
-                              '1.6/universe_create_sectors.php', $var);
97
+							  '1.6/universe_create_sectors.php', $var);
98 98
 $template->assign('CreateLocationsFormHREF', $container->href());
99 99
 
100 100
 // HREF to cancel and return to the previous page
Please login to merge, or discard this patch.
src/admin/Default/enable_game_processing.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -7,4 +7,4 @@
 block discarded – undo
7 7
 $msg = '<span class="green">SUCCESS: </span>Enabled game ' . $game->getDisplayName();
8 8
 
9 9
 Page::create('skeleton.php', 'enable_game.php',
10
-             array('processing_msg' => $msg))->go();
10
+			 array('processing_msg' => $msg))->go();
Please login to merge, or discard this patch.
src/lib/Default/AbstractMenu.class.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 		$menuItems[] = array('Link'=>Globals::getPlanetListHREF($alliance_id), 'Text'=>'Defense');
41 41
 		$menuItems[] = array('Link'=>Globals::getPlanetListFinancialHREF($alliance_id), 'Text'=>'Financial');
42 42
 		// make the selected index bold
43
-		$boldItem =& $menuItems[$selected_index]['Text'];
43
+		$boldItem = & $menuItems[$selected_index]['Text'];
44 44
 		$boldItem = '<span class="bold">' . $boldItem . '</span>';
45 45
 
46 46
 		$template = Smr\Template::getInstance();
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
 			'Text' => 'Game News',
147 147
 		];
148 148
 		// make the selected index bold
149
-		$boldItem =& $menuItems[$selected_index]['Text'];
149
+		$boldItem = & $menuItems[$selected_index]['Text'];
150 150
 		$boldItem = '<b>' . $boldItem . '</b>';
151 151
 
152 152
 		$template = Smr\Template::getInstance();
Please login to merge, or discard this patch.
src/lib/Default/Page.class.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -163,7 +163,7 @@
 block discarded – undo
163 163
 
164 164
 		// transfer this value to next container
165 165
 		if (!isset($var[$source])) {
166
-			throw new Exception('Could not find "' . $source. '" in var!');
166
+			throw new Exception('Could not find "' . $source . '" in var!');
167 167
 		}
168 168
 		if ($dest === null) {
169 169
 			$dest = $source;
Please login to merge, or discard this patch.
src/lib/Default/hof.inc.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -55,9 +55,9 @@
 block discarded – undo
55 55
 	$session = Smr\Session::getInstance();
56 56
 	$account = $session->getAccount();
57 57
 	if (($vis == HOF_PRIVATE && $account->getAccountID() != $accountID) ||
58
-	    ($vis == HOF_ALLIANCE && isset($gameID) &&
59
-	     !SmrGame::getGame($gameID)->hasEnded() &&
60
-	     !SmrPlayer::getPlayer($accountID, $gameID)->sameAlliance($session->getPlayer())))
58
+		($vis == HOF_ALLIANCE && isset($gameID) &&
59
+		 !SmrGame::getGame($gameID)->hasEnded() &&
60
+		 !SmrPlayer::getPlayer($accountID, $gameID)->sameAlliance($session->getPlayer())))
61 61
 	{
62 62
 		return '-';
63 63
 	} else {
Please login to merge, or discard this patch.
src/tools/npc/chess.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -19,8 +19,8 @@  discard block
 block discarded – undo
19 19
 		1 => array("pipe", "w")  // stdout is a pipe that the child will write to
20 20
 	);
21 21
 	$engine = proc_open(UCI_CHESS_ENGINE, $descriptorSpec, $pipes);
22
-	$toEngine =& $pipes[0];
23
-	$fromEngine =& $pipes[1];
22
+	$toEngine = & $pipes[0];
23
+	$fromEngine = & $pipes[1];
24 24
 
25 25
 	function readFromEngine($block = true) {
26 26
 		global $fromEngine;
@@ -84,5 +84,5 @@  discard block
 block discarded – undo
84 84
 function debug($message, $debugObject = null) {
85 85
 	echo date('Y-m-d H:i:s - ') . $message . ($debugObject !== null ? EOL . var_export($debugObject, true) : '') . EOL;
86 86
 	$db = Smr\Database::getInstance();
87
-	$db->query('INSERT INTO npc_logs (script_id, npc_id, time, message, debug_info, var) VALUES (' . (defined('SCRIPT_ID') ? SCRIPT_ID : 0) . ', 0, NOW(),' . $db->escapeString($message) . ',' . $db->escapeString(var_export($debugObject,true)) . ',' . $db->escapeString('') . ')');
87
+	$db->query('INSERT INTO npc_logs (script_id, npc_id, time, message, debug_info, var) VALUES (' . (defined('SCRIPT_ID') ? SCRIPT_ID : 0) . ', 0, NOW(),' . $db->escapeString($message) . ',' . $db->escapeString(var_export($debugObject, true)) . ',' . $db->escapeString('') . ')');
88 88
 }
Please login to merge, or discard this patch.
src/engine/Default/message_view.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -130,7 +130,7 @@
 block discarded – undo
130 130
 					AND receiver_delete = ' . $db->escapeBoolean(false) . '
131 131
 					ORDER BY send_time DESC');
132 132
 	while ($db->nextRecord()) {
133
-		$groupBox =& $messageBox['GroupedMessages'][$db->getInt('sender_id')];
133
+		$groupBox = & $messageBox['GroupedMessages'][$db->getInt('sender_id')];
134 134
 		// Limit the number of messages in each group
135 135
 		if (!isset($groupBox['Messages']) || count($groupBox['Messages']) < MESSAGE_SCOUT_GROUP_LIMIT) {
136 136
 			displayMessage($groupBox, $db->getInt('message_id'), $db->getInt('account_id'), $db->getInt('sender_id'), $player->getGameID(), stripslashes($db->getField('message_text')), $db->getInt('send_time'), $db->getBoolean('msg_read'), MSG_SCOUT, $player->getAccount());
Please login to merge, or discard this patch.