DatabaseProperties::__construct() - Code Metrics - Inspection of "Remove global variables" - smrealms/smr - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#1038)

by Dan

created 2021-04-11 12:29 UTC

DatabaseProperties::__construct() A

↳ Parent: DatabaseProperties

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	7
nc	1
nop	1
dl	0
loc	9
rs	10
c	0
b	0
f	0

<?php declare(strict_types=1);

namespace Smr;

use Dotenv\Dotenv;

class DatabaseProperties {
	private const CONFIG_HOST = "MYSQL_HOST";
	private const CONFIG_USER = "MYSQL_USER";
	private const CONFIG_PASSWORD = "MYSQL_PASSWORD";
	private const CONFIG_DATABASE = "MYSQL_DATABASE";
	private string $host;
	private string $user;
	private string $password;
	private string $databaseName;

	public function __construct(Dotenv $config) {
		$array = $config->load();
		self::validateConfig($config);
		[
			self::CONFIG_HOST => $this->host,
			self::CONFIG_USER => $this->user,
			self::CONFIG_PASSWORD => $this->password,
			self::CONFIG_DATABASE => $this->databaseName,
		] = $array;
	}

	private static function validateConfig(Dotenv $config) {
		$config->required([
			self::CONFIG_HOST,
			self::CONFIG_USER,
			self::CONFIG_PASSWORD,
			self::CONFIG_DATABASE,
		])->notEmpty();
	}

	public function getHost(): string {
		return $this->host;
	}

	public function getUser(): string {
		return $this->user;
	}

	public function getPassword(): string {
		return $this->password;
	}

	public function getDatabaseName(): string {
		return $this->databaseName;
	}
}


1			<?php declare(strict_types=1);
2
3			namespace Smr;
4
5			use Dotenv\Dotenv;
6
7			class DatabaseProperties {
8			private const CONFIG_HOST = "MYSQL_HOST";
9			private const CONFIG_USER = "MYSQL_USER";
10			private const CONFIG_PASSWORD = "MYSQL_PASSWORD";
11			private const CONFIG_DATABASE = "MYSQL_DATABASE";
12			private string $host;
13			private string $user;
14			private string $password;
15			private string $databaseName;
16
17			public function __construct(Dotenv $config) {
18			$array = $config->load();
19			self::validateConfig($config);
20			[
21			self::CONFIG_HOST => $this->host,
22			self::CONFIG_USER => $this->user,
23			self::CONFIG_PASSWORD => $this->password,
24			self::CONFIG_DATABASE => $this->databaseName,
25			] = $array;
26			}
27
28			private static function validateConfig(Dotenv $config) {
29			$config->required([
30			self::CONFIG_HOST,
31			self::CONFIG_USER,
32			self::CONFIG_PASSWORD,
33			self::CONFIG_DATABASE,
34			])->notEmpty();
35			}
36
37			public function getHost(): string {
38			return $this->host;
39			}
40
41			public function getUser(): string {
42			return $this->user;
43			}
44
45			public function getPassword(): string {
46			return $this->password;
47			}
48
49			public function getDatabaseName(): string {
50			return $this->databaseName;
51			}
52			}
53

smrealms / smr

Scrutinizer GitHub App not installed

Pull Request — master (#1038)

DatabaseProperties::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like