smrealms / smr

src/engine/Default/chat_sharing.php

Spacing +2 added lines, -4 removed lines

@@ -19,8 +19,7 @@ 
 	$shareFrom[$fromAccountId] = array(
 		'Player ID'   => $otherPlayer == null ? '-' : $otherPlayer->getPlayerID(),
 		'Player Name' => $otherPlayer == null ?
-		                 '<b>Account</b>: ' . SmrAccount::getAccount($fromAccountId)->getHofDisplayName() :
-		                 $otherPlayer->getDisplayName(),
+		                 '<b>Account</b>: ' . SmrAccount::getAccount($fromAccountId)->getHofDisplayName() : $otherPlayer->getDisplayName(),
 		'All Games'   => $gameId == 0 ? '<span class="green">YES</span>' : '<span class="red">NO</span>',
 		'Game ID'     => $gameId,
 	);
@@ -40,8 +39,7 @@ 
 	$shareTo[$toAccountId] = array(
 		'Player ID'   => $otherPlayer == null ? '-' : $otherPlayer->getPlayerID(),
 		'Player Name' => $otherPlayer == null ?
-		                 '<b>Account</b>: ' . SmrAccount::getAccount($toAccountId)->getHofDisplayName() :
-		                 $otherPlayer->getDisplayName(),
+		                 '<b>Account</b>: ' . SmrAccount::getAccount($toAccountId)->getHofDisplayName() : $otherPlayer->getDisplayName(),
 		'All Games'   => $gameId == 0 ? '<span class="green">YES</span>' : '<span class="red">NO</span>',
 		'Game ID'     => $gameId,
 	);

src/lib/Default/AbstractMenu.class.php

Spacing +2 added lines, -2 removed lines

@@ -40,7 +40,7 @@ 
 		$menuItems[] = array('Link'=>Globals::getPlanetListHREF($alliance_id), 'Text'=>'Defense');
 		$menuItems[] = array('Link'=>Globals::getPlanetListFinancialHREF($alliance_id), 'Text'=>'Financial');
 		// make the selected index bold
-		$boldItem =& $menuItems[$selected_index]['Text'];
+		$boldItem = & $menuItems[$selected_index]['Text'];
 		$boldItem = '<span class="bold">' . $boldItem . '</span>';
 
 		$template = Smr\Template::getInstance();
@@ -146,7 +146,7 @@ 
 			'Text' => 'Game News',
 		];
 		// make the selected index bold
-		$boldItem =& $menuItems[$selected_index]['Text'];
+		$boldItem = & $menuItems[$selected_index]['Text'];
 		$boldItem = '<b>' . $boldItem . '</b>';
 
 		$template = Smr\Template::getInstance();

src/engine/Default/hall_of_fame_new.php

Spacing +2 added lines, -2 removed lines

@@ -30,13 +30,13 @@
 const USER_SCORE_NAME = 'User Score';
 $hofTypes = array(DONATION_NAME=>true, USER_SCORE_NAME=>true);
 foreach ($dbResult->records() as $dbRecord) {
-	$hof =& $hofTypes;
+	$hof = & $hofTypes;
 	$typeList = explode(':', $dbRecord->getString('type'));
 	foreach ($typeList as $type) {
 		if (!isset($hof[$type])) {
 			$hof[$type] = array();
 		}
-		$hof =& $hof[$type];
+		$hof = & $hof[$type];
 	}
 	$hof = true;
 }

src/lib/Default/AbstractSmrAccount.class.php

Spacing +2 added lines, -2 removed lines

@@ -387,13 +387,13 @@
 			$dbResult = $this->db->read('SELECT type,sum(amount) as amount FROM player_hof WHERE ' . $this->SQL . ' AND game_id IN (SELECT game_id FROM game WHERE ignore_stats = \'FALSE\') GROUP BY type');
 			$this->HOF = array();
 			foreach ($dbResult->records() as $dbRecord) {
-				$hof =& $this->HOF;
+				$hof = & $this->HOF;
 				$typeList = explode(':', $dbRecord->getString('type'));
 				foreach ($typeList as $type) {
 					if (!isset($hof[$type])) {
 						$hof[$type] = array();
 					}
-					$hof =& $hof[$type];
+					$hof = & $hof[$type];
 				}
 				$hof = $dbRecord->getFloat('amount');
 			}

src/engine/Default/hall_of_fame_player_detail.php

Spacing +2 added lines, -2 removed lines

@@ -30,13 +30,13 @@
 const USER_SCORE_NAME = 'User Score';
 $hofTypes = array(DONATION_NAME=>true, USER_SCORE_NAME=>true);
 foreach ($dbResult->records() as $dbRecord) {
-	$hof =& $hofTypes;
+	$hof = & $hofTypes;
 	$typeList = explode(':', $dbRecord->getString('type'));
 	foreach ($typeList as $type) {
 		if (!isset($hof[$type])) {
 			$hof[$type] = array();
 		}
-		$hof =& $hof[$type];
+		$hof = & $hof[$type];
 	}
 	$hof = true;
 }

src/engine/Default/message_view.php

Spacing +1 added lines, -1 removed lines

@@ -128,7 +128,7 @@
 					AND receiver_delete = ' . $db->escapeBoolean(false) . '
 					ORDER BY send_time DESC');
 	foreach ($dbResult->records() as $dbRecord) {
-		$groupBox =& $messageBox['GroupedMessages'][$dbRecord->getInt('sender_id')];
+		$groupBox = & $messageBox['GroupedMessages'][$dbRecord->getInt('sender_id')];
 		// Limit the number of messages in each group
 		if (!isset($groupBox['Messages']) || count($groupBox['Messages']) < MESSAGE_SCOUT_GROUP_LIMIT) {
 			$groupBox['Messages'][] = displayMessage($dbRecord->getInt('message_id'), $dbRecord->getInt('account_id'), $dbRecord->getInt('sender_id'), $player->getGameID(), $dbRecord->getString('message_text'), $dbRecord->getInt('send_time'), $dbRecord->getBoolean('msg_read'), MSG_SCOUT, $player->getAccount());

test/SmrTest/lib/DefaultGame/SmrPlanetIntegrationTest.php

Spacing +2 added lines, -2 removed lines

@@ -229,13 +229,13 @@
 		$planet->increaseBuilding(PLANET_HANGAR, 4);
 		$this->assertTrue($planet->hasBuilding(PLANET_HANGAR));
 		$this->assertSame(4, $planet->getBuilding(PLANET_HANGAR));
-		$this->assertSame(4/3, $planet->getLevel());
+		$this->assertSame(4 / 3, $planet->getLevel());
 
 		// Destroy some hangars
 		$planet->destroyBuilding(PLANET_HANGAR, 2);
 		$this->assertTrue($planet->hasBuilding(PLANET_HANGAR));
 		$this->assertSame(2, $planet->getBuilding(PLANET_HANGAR));
-		$this->assertSame(2/3, $planet->getLevel());
+		$this->assertSame(2 / 3, $planet->getLevel());
 	}
 
 	public function test_defenses() : void {

src/lib/Default/AbstractSmrPlayer.class.php

Spacing +9 added lines, -9 removed lines

@@ -1678,7 +1678,7 @@ 
 			throw new Smr\Exceptions\UserError('The saved sector must be in the box!');
 		}
 
-		$storedDestinations =& $this->getStoredDestinations();
+		$storedDestinations = & $this->getStoredDestinations();
 		foreach ($storedDestinations as &$sd) {
 			if ($sd['SectorID'] == $sectorID) {
 				$sd['OffsetTop'] = $offsetTop;
@@ -2005,13 +2005,13 @@ 
 			$dbResult = $this->db->read('SELECT type,amount FROM player_hof WHERE ' . $this->SQL);
 			$this->HOF = array();
 			foreach ($dbResult->records() as $dbRecord) {
-				$hof =& $this->HOF;
+				$hof = & $this->HOF;
 				$typeList = explode(':', $dbRecord->getString('type'));
 				foreach ($typeList as $type) {
 					if (!isset($hof[$type])) {
 						$hof[$type] = array();
 					}
-					$hof =& $hof[$type];
+					$hof = & $hof[$type];
 				}
 				$hof = $dbRecord->getFloat('amount');
 			}
@@ -2090,8 +2090,8 @@ 
 		}
 		self::$HOFVis[$hofType] = $visibility;
 
-		$hof =& $this->HOF;
-		$hofChanged =& $this->hasHOFChanged;
+		$hof = & $this->HOF;
+		$hofChanged = & $this->hasHOFChanged;
 		$new = false;
 		foreach ($typeList as $type) {
 			if (!isset($hofChanged[$type])) {
@@ -2101,8 +2101,8 @@ 
 				$hof[$type] = array();
 				$new = true;
 			}
-			$hof =& $hof[$type];
-			$hofChanged =& $hofChanged[$type];
+			$hof = & $hof[$type];
+			$hofChanged = & $hofChanged[$type];
 		}
 		if ($hofChanged == null) {
 			$hofChanged = self::HOF_CHANGED;
@@ -2741,7 +2741,7 @@ 
 			'Starting Sector' => $this->getSectorID()
 		);
 
-		$this->missions[$missionID] =& $mission;
+		$this->missions[$missionID] = & $mission;
 		$this->setupMissionStep($missionID);
 		$this->rebuildMission($missionID);
 
@@ -2791,7 +2791,7 @@ 
 
 	public function claimMissionReward(int $missionID) : string {
 		$this->getMissions();
-		$mission =& $this->missions[$missionID];
+		$mission = & $this->missions[$missionID];
 		if ($mission === false) {
 			throw new Exception('Unknown mission: ' . $missionID);
 		}

src/lib/Smr/VoteSite.php

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
  */
 class VoteSite {
 
-	private static ?array $CACHE_TIMEOUTS = null;
+	private static ? array $CACHE_TIMEOUTS = null;
 
 	// NOTE: link IDs should never be changed!
 	const LINK_ID_TWG = 3;