Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Failed Conditions
Pull Request — master (#817)
by Dan
03:42
created
admin/Default/1.6/game_edit_processing.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@
 block discarded – undo
3 3
 // Get the dates ("|" sets hr/min/sec to 0)
4 4
 $join = DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_join']);
5 5
 $start = empty($_REQUEST['game_start']) ? $join :
6
-         DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_start']);
6
+		 DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_start']);
7 7
 $end = DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_end']);
8 8
 
9 9
 $game = SmrGame::getGame($var['game_id']);
Please login to merge, or discard this patch.
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,7 @@
 block discarded – undo
2 2
 
3 3
 // Get the dates ("|" sets hr/min/sec to 0)
4 4
 $join = DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_join']);
5
-$start = empty($_REQUEST['game_start']) ? $join :
6
-         DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_start']);
5
+$start = empty($_REQUEST['game_start']) ? $join : DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_start']);
7 6
 $end = DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_end']);
8 7
 
9 8
 $game = SmrGame::getGame($var['game_id']);
Please login to merge, or discard this patch.
admin/Default/1.6/game_create_processing.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
 // Get the dates ("|" sets hr/min/sec to 0)
19 19
 $join = DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_join']);
20 20
 $start = empty($_REQUEST['game_start']) ? $join :
21
-         DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_start']);
21
+		 DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_start']);
22 22
 $end = DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_end']);
23 23
 
24 24
 $game = SmrGame::createGame($newID);
Please login to merge, or discard this patch.
Spacing   +3 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,22 +1,21 @@
 block discarded – undo
1 1
 <?php declare(strict_types=1);
2 2
 
3 3
 //first create the game
4
-$db->query('SELECT game_id FROM game WHERE game_name='.$db->escapeString($_REQUEST['game_name']).' LIMIT 1');
4
+$db->query('SELECT game_id FROM game WHERE game_name=' . $db->escapeString($_REQUEST['game_name']) . ' LIMIT 1');
5 5
 if ($db->nextRecord()) {
6 6
 	create_error('That game name is already taken.');
7 7
 }
8 8
 
9 9
 $db->query('SELECT game_id FROM game ORDER BY game_id DESC LIMIT 1');
10 10
 if ($db->nextRecord()) {
11
-	$newID = $db->getInt('game_id')+1;
11
+	$newID = $db->getInt('game_id') + 1;
12 12
 } else {
13 13
 	$newID = 1;
14 14
 }
15 15
 
16 16
 // Get the dates ("|" sets hr/min/sec to 0)
17 17
 $join = DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_join']);
18
-$start = empty($_REQUEST['game_start']) ? $join :
19
-         DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_start']);
18
+$start = empty($_REQUEST['game_start']) ? $join : DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_start']);
20 19
 $end = DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_end']);
21 20
 
22 21
 $game = SmrGame::createGame($newID);
Please login to merge, or discard this patch.
admin/Default/manage_draft_leaders.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -7,7 +7,7 @@  discard block
 block discarded – undo
7 7
 $db->query('SELECT game_id, game_name FROM game WHERE game_type=' . $db->escapeNumber(SmrGame::GAME_TYPE_DRAFT) . ' AND join_time < ' . $db->escapeNumber(TIME) . ' AND end_time > ' . $db->escapeNumber(TIME) . ' ORDER BY start_time DESC');
8 8
 while ($db->nextRecord()) {
9 9
 	$activeGames[] = array('game_name' => $db->getField('game_name'),
10
-	                       'game_id' => $db->getInt('game_id'));
10
+						   'game_id' => $db->getInt('game_id'));
11 11
 }
12 12
 $template->assign('ActiveGames', $activeGames);
13 13
 
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
 	$db->query('SELECT account_id FROM draft_leaders WHERE game_id=' . $db->escapeNumber($var['selected_game_id']));
27 27
 	while ($db->nextRecord()) {
28 28
 		$editor = SmrPlayer::getPlayer($db->getInt('account_id'),
29
-		                               $var['selected_game_id']);
29
+									   $var['selected_game_id']);
30 30
 		$currentLeaders[] = $editor->getDisplayName();
31 31
 	}
32 32
 	$template->assign('CurrentLeaders', $currentLeaders);
Please login to merge, or discard this patch.
admin/Default/manage_post_editors.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -7,7 +7,7 @@
 block discarded – undo
7 7
 $db->query('SELECT game_id, game_name FROM game WHERE join_time < ' . $db->escapeNumber(TIME) . ' AND end_time > ' . $db->escapeNumber(TIME) . ' ORDER BY start_time DESC');
8 8
 while ($db->nextRecord()) {
9 9
 	$activeGames[] = array('game_name' => $db->getField('game_name'),
10
-	                       'game_id' => $db->getInt('game_id'));
10
+						   'game_id' => $db->getInt('game_id'));
11 11
 }
12 12
 $template->assign('ActiveGames', $activeGames);
13 13
 
Please login to merge, or discard this patch.
admin/Default/permission_manage.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,5 +46,5 @@
 block discarded – undo
46 46
 	$template->assign('ProcessingHREF', $processingHREF);
47 47
 
48 48
 	$template->assign('PermissionCategories',
49
-	                  AdminPermissions::getPermissionsByCategory());
49
+					  AdminPermissions::getPermissionsByCategory());
50 50
 }
Please login to merge, or discard this patch.
engine/Default/council_embassy_processing.php 1 patch
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 // Send vote announcement to members of the player's council (war votes)
40 40
 // or both races' councils (peace votes).
41 41
 $councilMembers = Council::getRaceCouncil($player->getGameID(),
42
-                                          $player->getRaceID());
42
+										  $player->getRaceID());
43 43
 if ($type == 'PEACE') {
44 44
 	$otherCouncil = Council::getRaceCouncil($player->getGameID(), $race_id);
45 45
 	$councilMembers = array_merge($councilMembers, $otherCouncil);
@@ -49,16 +49,16 @@  discard block
 block discarded – undo
49 49
 $color = ($type == 'PEACE' ? 'dgreen' : 'red');
50 50
 $type_fancy = "<span class=\"$color\">$type</span>";
51 51
 $message = $player->getLevelName() . " " . $player->getBBLink()
52
-           . " has initiated a vote for $type_fancy with the "
53
-           . Globals::getRaceName($race_id)
54
-           . "! You have " . format_time(TIME_FOR_COUNCIL_VOTE)
55
-           . " to cast your vote.";
52
+		   . " has initiated a vote for $type_fancy with the "
53
+		   . Globals::getRaceName($race_id)
54
+		   . "! You have " . format_time(TIME_FOR_COUNCIL_VOTE)
55
+		   . " to cast your vote.";
56 56
 
57 57
 foreach ($councilMembers as $accountID) {
58 58
 	// don't send to the player who started the vote
59 59
 	if ($player->getAccountID() != $accountID) {
60 60
 		SmrPlayer::sendMessageFromRace($player->getRaceID(), $player->getGameID(),
61
-		                               $accountID, $message, $time);
61
+									   $accountID, $message, $time);
62 62
   }
63 63
 }
64 64
 
Please login to merge, or discard this patch.
engine/Default/planet_attack_processing.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -49,12 +49,12 @@
 block discarded – undo
49 49
 }
50 50
 
51 51
 foreach ($attackers as $attacker) {
52
-	$playerResults =& $attacker->shootPlanet($planet, false);
53
-	$results['Attackers']['Traders'][$attacker->getAccountID()] =& $playerResults;
52
+	$playerResults = & $attacker->shootPlanet($planet, false);
53
+	$results['Attackers']['Traders'][$attacker->getAccountID()] = & $playerResults;
54 54
 	$results['Attackers']['TotalDamage'] += $playerResults['TotalDamage'];
55 55
 }
56 56
 $results['Attackers']['Downgrades'] = $planet->checkForDowngrade($results['Attackers']['TotalDamage']);
57
-$results['Planet'] =& $planet->shootPlayers($attackers);
57
+$results['Planet'] = & $planet->shootPlayers($attackers);
58 58
 
59 59
 $account->log(LOG_TYPE_PLANET_BUSTING, 'Player attacks planet, the planet does ' . $results['Planet']['TotalDamage'] . ', their team does ' . $results['Attackers']['TotalDamage'] . ' and downgrades: ' . var_export($results['Attackers']['Downgrades'], true), $planet->getSectorID());
60 60
 
Please login to merge, or discard this patch.
engine/Default/port_attack_processing.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -45,12 +45,12 @@
 block discarded – undo
45 45
 }
46 46
 
47 47
 foreach ($attackers as $attacker) {
48
-	$playerResults =& $attacker->shootPort($port);
49
-	$results['Attackers']['Traders'][$attacker->getAccountID()] =& $playerResults;
48
+	$playerResults = & $attacker->shootPort($port);
49
+	$results['Attackers']['Traders'][$attacker->getAccountID()] = & $playerResults;
50 50
 	$results['Attackers']['TotalDamage'] += $playerResults['TotalDamage'];
51 51
 }
52 52
 $results['Attackers']['Downgrades'] = $port->checkForDowngrade($results['Attackers']['TotalDamage']);
53
-$results['Port'] =& $port->shootPlayers($attackers);
53
+$results['Port'] = & $port->shootPlayers($attackers);
54 54
 
55 55
 $account->log(LOG_TYPE_PORT_RAIDING, 'Player attacks port, the port does ' . $results['Port']['TotalDamage'] . ', their team does ' . $results['Attackers']['TotalDamage'] . ' and downgrades ' . $results['Attackers']['Downgrades'] . ' levels.', $port->getSectorID());
56 56
 
Please login to merge, or discard this patch.
htdocs/manual.php 1 patch
Braces   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -5,8 +5,9 @@  discard block
 block discarded – undo
5 5
 	require_once(ENGINE . 'Default/help.inc');
6 6
 
7 7
 	$topic_id = $_SERVER['QUERY_STRING'];
8
-	if (empty($topic_id) || !is_numeric($topic_id))
9
-		$topic_id = 1;
8
+	if (empty($topic_id) || !is_numeric($topic_id)) {
9
+			$topic_id = 1;
10
+	}
10 11
 	?>
11 12
 <!DOCTYPE html>
12 13
 
@@ -48,8 +49,7 @@  discard block
 block discarded – undo
48 49
 
49 50
 	</body>
50 51
 	</html><?php
51
-}
52
-catch (Throwable $e) {
52
+} catch (Throwable $e) {
53 53
 	handleException($e);
54 54
 }
55 55
 ?>
Please login to merge, or discard this patch.