We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 153 |
| Code Lines | 104 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php declare(strict_types=1); |
||
| 193 | public function dataProvider_takeDamage(): array { |
||
| 194 | return [ |
||
| 195 | [ |
||
| 196 | 'Do overkill damage (e.g. 1000 drone damage)', |
||
| 197 | [ |
||
| 198 | 'Shield' => 1000, |
||
| 199 | 'Armour' => 1000, |
||
| 200 | 'Rollover' => true, |
||
| 201 | ], |
||
| 202 | [ |
||
| 203 | 'KillingShot' => true, |
||
| 204 | 'TargetAlreadyDead' => false, |
||
| 205 | 'Shield' => 100, |
||
| 206 | 'CDs' => 30, |
||
| 207 | 'NumCDs' => 10, |
||
| 208 | 'HasCDs' => false, |
||
| 209 | 'Armour' => 100, |
||
| 210 | 'TotalDamage' => 230, |
||
| 211 | ], |
||
| 212 | 100, 10, 100, |
||
| 213 | ], |
||
| 214 | [ |
||
| 215 | 'Do exactly lethal damage (e.g. 230 drone damage)', |
||
| 216 | [ |
||
| 217 | 'Shield' => 230, |
||
| 218 | 'Armour' => 230, |
||
| 219 | 'Rollover' => true, |
||
| 220 | ], |
||
| 221 | [ |
||
| 222 | 'KillingShot' => true, |
||
| 223 | 'TargetAlreadyDead' => false, |
||
| 224 | 'Shield' => 100, |
||
| 225 | 'CDs' => 30, |
||
| 226 | 'NumCDs' => 10, |
||
| 227 | 'HasCDs' => false, |
||
| 228 | 'Armour' => 100, |
||
| 229 | 'TotalDamage' => 230, |
||
| 230 | ], |
||
| 231 | 100, 10, 100, |
||
| 232 | ], |
||
| 233 | [ |
||
| 234 | 'Do damage to drones behind shields (e.g. armour-only weapon)', |
||
| 235 | [ |
||
| 236 | 'Shield' => 0, |
||
| 237 | 'Armour' => 100, |
||
| 238 | 'Rollover' => false, |
||
| 239 | ], |
||
| 240 | [ |
||
| 241 | 'KillingShot' => false, |
||
| 242 | 'TargetAlreadyDead' => false, |
||
| 243 | 'Shield' => 0, |
||
| 244 | 'CDs' => 18, |
||
| 245 | 'NumCDs' => 6, |
||
| 246 | 'HasCDs' => true, |
||
| 247 | 'Armour' => 0, |
||
| 248 | 'TotalDamage' => 18, |
||
| 249 | ], |
||
| 250 | 100, 10, 100, |
||
| 251 | ], |
||
| 252 | [ |
||
| 253 | 'Do NOT do damage to armour behind shields (e.g. armour-only weapon)', |
||
| 254 | [ |
||
| 255 | 'Shield' => 0, |
||
| 256 | 'Armour' => 100, |
||
| 257 | 'Rollover' => false, |
||
| 258 | ], |
||
| 259 | [ |
||
| 260 | 'KillingShot' => false, |
||
| 261 | 'TargetAlreadyDead' => false, |
||
| 262 | 'Shield' => 0, |
||
| 263 | 'CDs' => 0, |
||
| 264 | 'NumCDs' => 0, |
||
| 265 | 'HasCDs' => false, |
||
| 266 | 'Armour' => 0, |
||
| 267 | 'TotalDamage' => 0, |
||
| 268 | ], |
||
| 269 | 100, 0, 100, |
||
| 270 | ], |
||
| 271 | [ |
||
| 272 | 'Overkill shield damage only (e.g. shield/armour weapon)', |
||
| 273 | [ |
||
| 274 | 'Shield' => 150, |
||
| 275 | 'Armour' => 150, |
||
| 276 | 'Rollover' => false, |
||
| 277 | ], |
||
| 278 | [ |
||
| 279 | 'KillingShot' => false, |
||
| 280 | 'TargetAlreadyDead' => false, |
||
| 281 | 'Shield' => 100, |
||
| 282 | 'CDs' => 0, |
||
| 283 | 'NumCDs' => 0, |
||
| 284 | 'HasCDs' => true, |
||
| 285 | 'Armour' => 0, |
||
| 286 | 'TotalDamage' => 100, |
||
| 287 | ], |
||
| 288 | 100, 10, 100, |
||
| 289 | ], |
||
| 290 | [ |
||
| 291 | 'Overkill CD damage only (e.g. shield/armour weapon)', |
||
| 292 | [ |
||
| 293 | 'Shield' => 150, |
||
| 294 | 'Armour' => 150, |
||
| 295 | 'Rollover' => false, |
||
| 296 | ], |
||
| 297 | [ |
||
| 298 | 'KillingShot' => false, |
||
| 299 | 'TargetAlreadyDead' => false, |
||
| 300 | 'Shield' => 0, |
||
| 301 | 'CDs' => 30, |
||
| 302 | 'NumCDs' => 10, |
||
| 303 | 'HasCDs' => false, |
||
| 304 | 'Armour' => 0, |
||
| 305 | 'TotalDamage' => 30, |
||
| 306 | ], |
||
| 307 | 0, 10, 100, |
||
| 308 | ], |
||
| 309 | [ |
||
| 310 | 'Overkill armour damage only (e.g. shield/armour weapon)', |
||
| 311 | [ |
||
| 312 | 'Shield' => 150, |
||
| 313 | 'Armour' => 150, |
||
| 314 | 'Rollover' => false, |
||
| 315 | ], |
||
| 316 | [ |
||
| 317 | 'KillingShot' => true, |
||
| 318 | 'TargetAlreadyDead' => false, |
||
| 319 | 'Shield' => 0, |
||
| 320 | 'CDs' => 0, |
||
| 321 | 'NumCDs' => 0, |
||
| 322 | 'HasCDs' => false, |
||
| 323 | 'Armour' => 100, |
||
| 324 | 'TotalDamage' => 100, |
||
| 325 | ], |
||
| 326 | 0, 0, 100, |
||
| 327 | ], |
||
| 328 | [ |
||
| 329 | 'Target is already dead', |
||
| 330 | [ |
||
| 331 | 'Shield' => 100, |
||
| 332 | 'Armour' => 100, |
||
| 333 | 'Rollover' => true, |
||
| 334 | ], |
||
| 335 | [ |
||
| 336 | 'KillingShot' => false, |
||
| 337 | 'TargetAlreadyDead' => true, |
||
| 338 | 'Shield' => 0, |
||
| 339 | 'CDs' => 0, |
||
| 340 | 'NumCDs' => 0, |
||
| 341 | 'HasCDs' => false, |
||
| 342 | 'Armour' => 0, |
||
| 343 | 'TotalDamage' => 0, |
||
| 344 | ], |
||
| 345 | 0, 0, 0, |
||
| 346 | ], |
||
| 391 |