We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
| @@ -2,8 +2,7 @@ | ||
| 2 | 2 | |
| 3 | 3 |  // Get the dates ("|" sets hr/min/sec to 0) | 
| 4 | 4 |  $join = DateTime::createFromFormat('d/m/Y|', Request::get('game_join')); | 
| 5 | -$start = empty(Request::get('game_start')) ? $join : | |
| 6 | -         DateTime::createFromFormat('d/m/Y|', Request::get('game_start')); | |
| 5 | +$start = empty(Request::get('game_start')) ? $join : DateTime::createFromFormat('d/m/Y|', Request::get('game_start')); | |
| 7 | 6 |  $end = DateTime::createFromFormat('d/m/Y|', Request::get('game_end')); | 
| 8 | 7 | |
| 9 | 8 | $game = SmrGame::getGame($var['game_id']); | 
| @@ -19,8 +19,7 @@ discard block | ||
| 19 | 19 | $shareFrom[$fromAccountId] = array( | 
| 20 | 20 | 'Player ID' => $otherPlayer == null ? '-' : $otherPlayer->getPlayerID(), | 
| 21 | 21 | 'Player Name' => $otherPlayer == null ? | 
| 22 | - '<b>Account</b>: ' . SmrAccount::getAccount($fromAccountId)->getHofDisplayName() : | |
| 23 | - $otherPlayer->getDisplayName(), | |
| 22 | + '<b>Account</b>: ' . SmrAccount::getAccount($fromAccountId)->getHofDisplayName() : $otherPlayer->getDisplayName(), | |
| 24 | 23 | 'All Games' => $gameId == 0 ? '<span class="green">YES</span>' : '<span class="red">NO</span>', | 
| 25 | 24 | 'Game ID' => $gameId, | 
| 26 | 25 | ); | 
| @@ -40,8 +39,7 @@ discard block | ||
| 40 | 39 | $shareTo[$toAccountId] = array( | 
| 41 | 40 | 'Player ID' => $otherPlayer == null ? '-' : $otherPlayer->getPlayerID(), | 
| 42 | 41 | 'Player Name' => $otherPlayer == null ? | 
| 43 | - '<b>Account</b>: ' . SmrAccount::getAccount($toAccountId)->getHofDisplayName() : | |
| 44 | - $otherPlayer->getDisplayName(), | |
| 42 | + '<b>Account</b>: ' . SmrAccount::getAccount($toAccountId)->getHofDisplayName() : $otherPlayer->getDisplayName(), | |
| 45 | 43 | 'All Games' => $gameId == 0 ? '<span class="green">YES</span>' : '<span class="red">NO</span>', | 
| 46 | 44 | 'Game ID' => $gameId, | 
| 47 | 45 | ); | 
| @@ -18,8 +18,7 @@ | ||
| 18 | 18 |  if ($join === false) { | 
| 19 | 19 |  	create_error('Join Date is not valid!'); | 
| 20 | 20 | } | 
| 21 | -$start = empty(Request::get('game_start')) ? $join : | |
| 22 | -         DateTime::createFromFormat('d/m/Y|', Request::get('game_start')); | |
| 21 | +$start = empty(Request::get('game_start')) ? $join : DateTime::createFromFormat('d/m/Y|', Request::get('game_start')); | |
| 23 | 22 |  if ($start === false) { | 
| 24 | 23 |  	create_error('Start Date is not valid!'); | 
| 25 | 24 | } | 
| @@ -230,13 +230,13 @@ | ||
| 230 | 230 | $planet->increaseBuilding(PLANET_HANGAR, 4); | 
| 231 | 231 | $this->assertTrue($planet->hasBuilding(PLANET_HANGAR)); | 
| 232 | 232 | $this->assertSame(4, $planet->getBuilding(PLANET_HANGAR)); | 
| 233 | - $this->assertSame(4/3, $planet->getLevel()); | |
| 233 | + $this->assertSame(4 / 3, $planet->getLevel()); | |
| 234 | 234 | |
| 235 | 235 | // Destroy some hangars | 
| 236 | 236 | $planet->destroyBuilding(PLANET_HANGAR, 2); | 
| 237 | 237 | $this->assertTrue($planet->hasBuilding(PLANET_HANGAR)); | 
| 238 | 238 | $this->assertSame(2, $planet->getBuilding(PLANET_HANGAR)); | 
| 239 | - $this->assertSame(2/3, $planet->getLevel()); | |
| 239 | + $this->assertSame(2 / 3, $planet->getLevel()); | |
| 240 | 240 | } | 
| 241 | 241 | |
| 242 | 242 | } | 
| @@ -40,7 +40,7 @@ discard block | ||
| 40 | 40 |  		$menuItems[] = array('Link'=>Globals::getPlanetListHREF($alliance_id), 'Text'=>'Defense'); | 
| 41 | 41 |  		$menuItems[] = array('Link'=>Globals::getPlanetListFinancialHREF($alliance_id), 'Text'=>'Financial'); | 
| 42 | 42 | // make the selected index bold | 
| 43 | - $boldItem =& $menuItems[$selected_index]['Text']; | |
| 43 | + $boldItem = & $menuItems[$selected_index]['Text']; | |
| 44 | 44 | $boldItem = '<span class="bold">' . $boldItem . '</span>'; | 
| 45 | 45 | |
| 46 | 46 | $template = Smr\Template::getInstance(); | 
| @@ -146,7 +146,7 @@ discard block | ||
| 146 | 146 | 'Text' => 'Game News', | 
| 147 | 147 | ]; | 
| 148 | 148 | // make the selected index bold | 
| 149 | - $boldItem =& $menuItems[$selected_index]['Text']; | |
| 149 | + $boldItem = & $menuItems[$selected_index]['Text']; | |
| 150 | 150 | $boldItem = '<b>' . $boldItem . '</b>'; | 
| 151 | 151 | |
| 152 | 152 | $template = Smr\Template::getInstance(); | 
| @@ -163,7 +163,7 @@ | ||
| 163 | 163 | |
| 164 | 164 | // transfer this value to next container | 
| 165 | 165 |  		if (!isset($var[$source])) { | 
| 166 | -			throw new Exception('Could not find "' . $source. '" in var!'); | |
| 166 | +			throw new Exception('Could not find "' . $source . '" in var!'); | |
| 167 | 167 | } | 
| 168 | 168 |  		if ($dest === null) { | 
| 169 | 169 | $dest = $source; | 
| @@ -5,7 +5,7 @@ | ||
| 5 | 5 | */ | 
| 6 | 6 | class GameLink | 
| 7 | 7 |  { | 
| 8 | - public bool $valid = false; // identifies if the message is linked to game data | |
| 8 | + public bool $valid = false; // identifies if the message is linked to game data | |
| 9 | 9 | public SmrPlayer $player; | 
| 10 | 10 | |
| 11 | 11 |  	function __construct(Discord\Parts\Channel\Message $message) { | 
| @@ -30,13 +30,13 @@ | ||
| 30 | 30 | const USER_SCORE_NAME = 'User Score'; | 
| 31 | 31 | $hofTypes = array(DONATION_NAME=>true, USER_SCORE_NAME=>true); | 
| 32 | 32 |  foreach ($dbResult->records() as $dbRecord) { | 
| 33 | - $hof =& $hofTypes; | |
| 33 | + $hof = & $hofTypes; | |
| 34 | 34 |  	$typeList = explode(':', $dbRecord->getString('type')); | 
| 35 | 35 |  	foreach ($typeList as $type) { | 
| 36 | 36 |  		if (!isset($hof[$type])) { | 
| 37 | 37 | $hof[$type] = array(); | 
| 38 | 38 | } | 
| 39 | - $hof =& $hof[$type]; | |
| 39 | + $hof = & $hof[$type]; | |
| 40 | 40 | } | 
| 41 | 41 | $hof = true; | 
| 42 | 42 | } | 
| @@ -1692,7 +1692,7 @@ discard block | ||
| 1692 | 1692 |  			create_error('The saved sector must be in the box!'); | 
| 1693 | 1693 | } | 
| 1694 | 1694 | |
| 1695 | - $storedDestinations =& $this->getStoredDestinations(); | |
| 1695 | + $storedDestinations = & $this->getStoredDestinations(); | |
| 1696 | 1696 |  		foreach ($storedDestinations as &$sd) { | 
| 1697 | 1697 |  			if ($sd['SectorID'] == $sectorID) { | 
| 1698 | 1698 | $sd['OffsetTop'] = $offsetTop; | 
| @@ -2019,13 +2019,13 @@ discard block | ||
| 2019 | 2019 |  			$dbResult = $this->db->read('SELECT type,amount FROM player_hof WHERE ' . $this->SQL); | 
| 2020 | 2020 | $this->HOF = array(); | 
| 2021 | 2021 |  			foreach ($dbResult->records() as $dbRecord) { | 
| 2022 | - $hof =& $this->HOF; | |
| 2022 | + $hof = & $this->HOF; | |
| 2023 | 2023 |  				$typeList = explode(':', $dbRecord->getString('type')); | 
| 2024 | 2024 |  				foreach ($typeList as $type) { | 
| 2025 | 2025 |  					if (!isset($hof[$type])) { | 
| 2026 | 2026 | $hof[$type] = array(); | 
| 2027 | 2027 | } | 
| 2028 | - $hof =& $hof[$type]; | |
| 2028 | + $hof = & $hof[$type]; | |
| 2029 | 2029 | } | 
| 2030 | 2030 |  				$hof = $dbRecord->getFloat('amount'); | 
| 2031 | 2031 | } | 
| @@ -2104,8 +2104,8 @@ discard block | ||
| 2104 | 2104 | } | 
| 2105 | 2105 | self::$HOFVis[$hofType] = $visibility; | 
| 2106 | 2106 | |
| 2107 | - $hof =& $this->HOF; | |
| 2108 | - $hofChanged =& $this->hasHOFChanged; | |
| 2107 | + $hof = & $this->HOF; | |
| 2108 | + $hofChanged = & $this->hasHOFChanged; | |
| 2109 | 2109 | $new = false; | 
| 2110 | 2110 |  		foreach ($typeList as $type) { | 
| 2111 | 2111 |  			if (!isset($hofChanged[$type])) { | 
| @@ -2115,8 +2115,8 @@ discard block | ||
| 2115 | 2115 | $hof[$type] = array(); | 
| 2116 | 2116 | $new = true; | 
| 2117 | 2117 | } | 
| 2118 | - $hof =& $hof[$type]; | |
| 2119 | - $hofChanged =& $hofChanged[$type]; | |
| 2118 | + $hof = & $hof[$type]; | |
| 2119 | + $hofChanged = & $hofChanged[$type]; | |
| 2120 | 2120 | } | 
| 2121 | 2121 |  		if ($hofChanged == null) { | 
| 2122 | 2122 | $hofChanged = self::HOF_CHANGED; | 
| @@ -2784,7 +2784,7 @@ discard block | ||
| 2784 | 2784 | 'Starting Sector' => $this->getSectorID() | 
| 2785 | 2785 | ); | 
| 2786 | 2786 | |
| 2787 | - $this->missions[$missionID] =& $mission; | |
| 2787 | + $this->missions[$missionID] = & $mission; | |
| 2788 | 2788 | $this->setupMissionStep($missionID); | 
| 2789 | 2789 | $this->rebuildMission($missionID); | 
| 2790 | 2790 | |
| @@ -2834,7 +2834,7 @@ discard block | ||
| 2834 | 2834 | |
| 2835 | 2835 |  	public function claimMissionReward(int $missionID) : string { | 
| 2836 | 2836 | $this->getMissions(); | 
| 2837 | - $mission =& $this->missions[$missionID]; | |
| 2837 | + $mission = & $this->missions[$missionID]; | |
| 2838 | 2838 |  		if ($mission === false) { | 
| 2839 | 2839 |  			throw new Exception('Unknown mission: ' . $missionID); | 
| 2840 | 2840 | } |