Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#812)
by Dan
04:13
created
templates/Default/engine/Default/includes/PortTraderTeamCombatResults.inc 1 patch
Spacing   +50 added lines, -50 removed lines patch added patch discarded remove patch
@@ -1,10 +1,10 @@  discard block
 block discarded – undo
1 1
 <?php
2
-foreach($TraderTeamCombatResults['Traders'] as $AccountID => $TraderResults) {
3
-	$ShootingPlayer =& $TraderResults['Player'];
4
-	$TotalDamage =& $TraderResults['TotalDamage'];
5
-	if($MinimalDisplay && !$ThisPlayer->equals($ShootingPlayer)) {
2
+foreach ($TraderTeamCombatResults['Traders'] as $AccountID => $TraderResults) {
3
+	$ShootingPlayer = & $TraderResults['Player'];
4
+	$TotalDamage = & $TraderResults['TotalDamage'];
5
+	if ($MinimalDisplay && !$ThisPlayer->equals($ShootingPlayer)) {
6 6
 		echo $ShootingPlayer->getDisplayName();
7
-		if($TotalDamage > 0) {
7
+		if ($TotalDamage > 0) {
8 8
 			?> hits for a total of <span class="red"><?php echo $TotalDamage ?></span> damage in this round of combat<?php
9 9
 		} else {
10 10
 			?> does no damage this round<?php
@@ -12,29 +12,29 @@  discard block
 block discarded – undo
12 12
 		continue;
13 13
 	}
14 14
 
15
-	if($TraderResults['DeadBeforeShot']) {
15
+	if ($TraderResults['DeadBeforeShot']) {
16 16
 		echo $ShootingPlayer->getDisplayName() ?> died before they were able to attack!<br /><?php
17 17
 	} else {
18
-		if(isset($TraderResults['Weapons']) && is_array($TraderResults['Weapons'])) {
19
-			foreach($TraderResults['Weapons'] as $WeaponResults) {
20
-				$ShootingWeapon =& $WeaponResults['Weapon'];
21
-				$ShotHit =& $WeaponResults['Hit'];
22
-				$ActualDamage =& $WeaponResults['ActualDamage'];
23
-				$WeaponDamage =& $WeaponResults['WeaponDamage'];
24
-				$TargetPort =& $WeaponResults['TargetPort'];
18
+		if (isset($TraderResults['Weapons']) && is_array($TraderResults['Weapons'])) {
19
+			foreach ($TraderResults['Weapons'] as $WeaponResults) {
20
+				$ShootingWeapon = & $WeaponResults['Weapon'];
21
+				$ShotHit = & $WeaponResults['Hit'];
22
+				$ActualDamage = & $WeaponResults['ActualDamage'];
23
+				$WeaponDamage = & $WeaponResults['WeaponDamage'];
24
+				$TargetPort = & $WeaponResults['TargetPort'];
25 25
 				
26
-				echo $ShootingPlayer->getDisplayName() ?> fires their <?php echo $ShootingWeapon->getName() ?> at <?php if($ShotHit && $ActualDamage['TargetAlreadyDead']){ ?>the remnants of <?php } echo $TargetPort->getDisplayName();
26
+				echo $ShootingPlayer->getDisplayName() ?> fires their <?php echo $ShootingWeapon->getName() ?> at <?php if ($ShotHit && $ActualDamage['TargetAlreadyDead']) { ?>the remnants of <?php } echo $TargetPort->getDisplayName();
27 27
 				if (!$ShotHit || !$ActualDamage['TargetAlreadyDead']) {
28
-					if(!$ShotHit) {
28
+					if (!$ShotHit) {
29 29
 						?> and misses every critical system<?php
30
-					} else if($ActualDamage['TotalDamage'] == 0) {
31
-						if($WeaponDamage['Shield'] > 0) {
32
-							if($ActualDamage['HasCDs']) {
30
+					} else if ($ActualDamage['TotalDamage'] == 0) {
31
+						if ($WeaponDamage['Shield'] > 0) {
32
+							if ($ActualDamage['HasCDs']) {
33 33
 								?> which proves ineffective against their combat drones<?php
34 34
 							} else {
35 35
 								?> which proves ineffective against it's armour<?php
36 36
 							}
37
-						} else if($WeaponDamage['Armour'] > 0) {
37
+						} else if ($WeaponDamage['Armour'] > 0) {
38 38
 							?> which is deflected by their shields<?php
39 39
 						} else {
40 40
 							?> but it cannot do any damage<?php
@@ -42,55 +42,55 @@  discard block
 block discarded – undo
42 42
 					} else {
43 43
 						?> destroying <?php
44 44
 						$DamageTypes = 0;
45
-						if($ActualDamage['Shield'] > 0){ $DamageTypes = $DamageTypes+1; }
46
-						if($ActualDamage['NumCDs'] > 0){ $DamageTypes = $DamageTypes+1; }
47
-						if($ActualDamage['Armour'] > 0){ $DamageTypes = $DamageTypes+1; }
45
+						if ($ActualDamage['Shield'] > 0) { $DamageTypes = $DamageTypes + 1; }
46
+						if ($ActualDamage['NumCDs'] > 0) { $DamageTypes = $DamageTypes + 1; }
47
+						if ($ActualDamage['Armour'] > 0) { $DamageTypes = $DamageTypes + 1; }
48 48
 
49
-						if($ActualDamage['Shield'] > 0) {
49
+						if ($ActualDamage['Shield'] > 0) {
50 50
 							?><span class="shields"><?php echo number_format($ActualDamage['Shield']) ?></span> shields<?php
51 51
 							$this->doDamageTypeReductionDisplay($DamageTypes);
52 52
 						}
53
-						if($ActualDamage['NumCDs'] > 0) {
53
+						if ($ActualDamage['NumCDs'] > 0) {
54 54
 							?><span class="cds"><?php echo number_format($ActualDamage['NumCDs']) ?></span> combat drones<?php
55 55
 							$this->doDamageTypeReductionDisplay($DamageTypes);
56 56
 						}
57
-						if($ActualDamage['Armour'] > 0) {
57
+						if ($ActualDamage['Armour'] > 0) {
58 58
 							?><span class="red"><?php echo number_format($ActualDamage['Armour']) ?></span> plates of armour<?php
59 59
 						}
60 60
 					}
61 61
 				} ?>.
62 62
 				<br /><?php
63 63
 				if ($ShotHit && $ActualDamage['KillingShot']) {
64
-					$this->includeTemplate('includes/PortKillMessage.inc',array('KillResults'=>$WeaponResults['KillResults'],'TargetPort'=>$TargetPort,'ShootingPlayer'=>$ShootingPlayer));
64
+					$this->includeTemplate('includes/PortKillMessage.inc', array('KillResults'=>$WeaponResults['KillResults'], 'TargetPort'=>$TargetPort, 'ShootingPlayer'=>$ShootingPlayer));
65 65
 				}
66 66
 			}
67 67
 		}
68
-		if(isset($TraderResults['Drones'])) {
69
-			$Drones =& $TraderResults['Drones'];
70
-			$ActualDamage =& $Drones['ActualDamage'];
71
-			$WeaponDamage =& $Drones['WeaponDamage'];
72
-			$TargetPort =& $Drones['TargetPort'];
68
+		if (isset($TraderResults['Drones'])) {
69
+			$Drones = & $TraderResults['Drones'];
70
+			$ActualDamage = & $Drones['ActualDamage'];
71
+			$WeaponDamage = & $Drones['WeaponDamage'];
72
+			$TargetPort = & $Drones['TargetPort'];
73 73
 			
74 74
 			echo $ShootingPlayer->getDisplayName();
75
-			if($WeaponDamage['Launched'] == 0) {
75
+			if ($WeaponDamage['Launched'] == 0) {
76 76
 				?> fails to launch their combat drones<?php
77 77
 			} else {
78 78
 				?> launches <span class="cds"><?php echo $WeaponDamage['Launched'] ?></span> combat drones at <?php
79
-				if($ActualDamage['TargetAlreadyDead']) {
79
+				if ($ActualDamage['TargetAlreadyDead']) {
80 80
 					?>the debris that was once <?php
81 81
 				}
82 82
 				echo $TargetPort->getDisplayName();
83 83
 				
84
-				if(!$ActualDamage['TargetAlreadyDead']) {
85
-					if($ActualDamage['TotalDamage'] == 0) {
86
-						if($WeaponDamage['Shield'] > 0) {
87
-							if($ActualDamage['HasCDs']) {
84
+				if (!$ActualDamage['TargetAlreadyDead']) {
85
+					if ($ActualDamage['TotalDamage'] == 0) {
86
+						if ($WeaponDamage['Shield'] > 0) {
87
+							if ($ActualDamage['HasCDs']) {
88 88
 								?> which prove ineffective against their combat drones<?php
89 89
 							} else {
90 90
 								?> which proves ineffective against it's armour<?php
91 91
 							}
92 92
 						}
93
-						if($ActualDamage['Armour'] > 0) {
93
+						if ($ActualDamage['Armour'] > 0) {
94 94
 							?> which is deflected by their shields<?php
95 95
 						} else {
96 96
 							?> but they cannot do any damage<?php
@@ -98,45 +98,45 @@  discard block
 block discarded – undo
98 98
 					} else {
99 99
 						?> destroying <?php
100 100
 						$DamageTypes = 0;
101
-						if($ActualDamage['Shield'] > 0){ $DamageTypes = $DamageTypes+1; }
102
-						if($ActualDamage['NumCDs'] > 0){ $DamageTypes = $DamageTypes+1; }
103
-						if($ActualDamage['Armour'] > 0){ $DamageTypes = $DamageTypes+1; }
101
+						if ($ActualDamage['Shield'] > 0) { $DamageTypes = $DamageTypes + 1; }
102
+						if ($ActualDamage['NumCDs'] > 0) { $DamageTypes = $DamageTypes + 1; }
103
+						if ($ActualDamage['Armour'] > 0) { $DamageTypes = $DamageTypes + 1; }
104 104
 
105
-						if($ActualDamage['Shield'] > 0) {
105
+						if ($ActualDamage['Shield'] > 0) {
106 106
 							?><span class="shields"><?php echo number_format($ActualDamage['Shield']) ?></span> shields<?php
107 107
 							$this->doDamageTypeReductionDisplay($DamageTypes);
108 108
 						}
109
-						if($ActualDamage['NumCDs'] > 0) {
109
+						if ($ActualDamage['NumCDs'] > 0) {
110 110
 							?><span class="cds"><?php echo number_format($ActualDamage['NumCDs']) ?></span> combat drones<?php
111 111
 							$this->doDamageTypeReductionDisplay($DamageTypes);
112 112
 						}
113
-						if($ActualDamage['Armour'] > 0) {
113
+						if ($ActualDamage['Armour'] > 0) {
114 114
 							?><span class="red"><?php echo number_format($ActualDamage['Armour']) ?></span> plates of armour<?php
115 115
 						}
116 116
 					}
117 117
 				}
118 118
 			} ?>.
119 119
 			<br /><?php
120
-			if($ActualDamage['KillingShot']) {
121
-				$this->includeTemplate('includes/PortKillMessage.inc',array('KillResults'=>$Drones['KillResults'],'TargetPort'=>$TargetPort,'ShootingPlayer'=>$ShootingPlayer));
120
+			if ($ActualDamage['KillingShot']) {
121
+				$this->includeTemplate('includes/PortKillMessage.inc', array('KillResults'=>$Drones['KillResults'], 'TargetPort'=>$TargetPort, 'ShootingPlayer'=>$ShootingPlayer));
122 122
 			}
123 123
 		}
124 124
 	}
125 125
 	echo $ShootingPlayer->getDisplayName();
126
-	if($TotalDamage > 0) {
126
+	if ($TotalDamage > 0) {
127 127
 		?> hits for a total of <span class="red"><?php echo $TotalDamage ?></span> damage in this round of combat<?php
128 128
 	} else {
129 129
 		?> does no damage this round<?php
130
-		if(!$TraderResults['DeadBeforeShot']) {
130
+		if (!$TraderResults['DeadBeforeShot']) {
131 131
 			?>. Maybe they should go back to the academy<?php
132 132
 		}
133 133
 	} ?>.<br /><br /><?php
134 134
 }
135 135
 $TotalDamage = $TraderTeamCombatResults['TotalDamage']; ?>
136
-This fleet <?php if($TotalDamage > 0){ ?>hits for a total of <span class="red"><?php echo $TotalDamage ?></span> damage in this round of combat<?php } else{ ?>does no damage this round. You call that a fleet? They need a better recruiter<?php } ?>.<br />
136
+This fleet <?php if ($TotalDamage > 0) { ?>hits for a total of <span class="red"><?php echo $TotalDamage ?></span> damage in this round of combat<?php } else { ?>does no damage this round. You call that a fleet? They need a better recruiter<?php } ?>.<br />
137 137
 
138 138
 <?php
139 139
 $Downgrades = $TraderTeamCombatResults['Downgrades'];
140
-if ($Downgrades != 0 ) {
140
+if ($Downgrades != 0) {
141 141
 	?>The port has lost <?php echo $Downgrades . ' ' . pluralise('level', $Downgrades); ?>.<?php
142 142
 } ?>
Please login to merge, or discard this patch.
templates/Default/engine/Default/includes/ForcesCombatResults.inc 1 patch
Spacing   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -1,34 +1,34 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if(isset($ForcesCombatResults['Results']) && is_array($ForcesCombatResults['Results'])) {
3
-	foreach($ForcesCombatResults['Results'] as $ForceType => $ForceResults) {
4
-		$ShootingWeapon =& $ForceResults['Weapon'];
5
-		$ShotHit =& $ForceResults['Hit'];
6
-		$ActualDamage =& $ForceResults['ActualDamage'];
7
-		$WeaponDamage =& $ForceResults['WeaponDamage'];
8
-		$TargetPlayer =& $ForceResults['TargetPlayer'];
2
+if (isset($ForcesCombatResults['Results']) && is_array($ForcesCombatResults['Results'])) {
3
+	foreach ($ForcesCombatResults['Results'] as $ForceType => $ForceResults) {
4
+		$ShootingWeapon = & $ForceResults['Weapon'];
5
+		$ShotHit = & $ForceResults['Hit'];
6
+		$ActualDamage = & $ForceResults['ActualDamage'];
7
+		$WeaponDamage = & $ForceResults['WeaponDamage'];
8
+		$TargetPlayer = & $ForceResults['TargetPlayer'];
9 9
 		?>
10 10
 		<span class="cds"><?php echo isset($ActualDamage['Launched']) ? $ActualDamage['Launched'] : $WeaponDamage['Launched']; ?></span><?php
11
-		if($ForceType == 'Mines') {
11
+		if ($ForceType == 'Mines') {
12 12
 			?> mines kamikaze themselves against <?php
13
-		} else if($ForceType == 'Drones') {
13
+		} else if ($ForceType == 'Drones') {
14 14
 			?> combat drones launch at <?php
15
-		} else if($ForceType == 'Scouts') {
15
+		} else if ($ForceType == 'Scouts') {
16 16
 			?> scout drones kamikaze themselves against <?php
17 17
 		}
18 18
 		
19
-		if($ShotHit && $ActualDamage['TargetAlreadyDead']){ ?> the debris that was once <?php }
19
+		if ($ShotHit && $ActualDamage['TargetAlreadyDead']) { ?> the debris that was once <?php }
20 20
 		echo $TargetPlayer->getDisplayName();
21 21
 		if (!$ShotHit || !$ActualDamage['TargetAlreadyDead']) {
22
-			if(!$ShotHit) {
22
+			if (!$ShotHit) {
23 23
 				?> and misses<?php
24
-			} else if($ActualDamage['TotalDamage'] == 0) {
25
-				if($WeaponDamage['Shield'] > 0) {
26
-					if($ActualDamage['HasCDs']) {
24
+			} else if ($ActualDamage['TotalDamage'] == 0) {
25
+				if ($WeaponDamage['Shield'] > 0) {
26
+					if ($ActualDamage['HasCDs']) {
27 27
 						?> which proves ineffective against their combat drones<?php
28 28
 					} else {
29 29
 						?> which washes harmlessly over their hull<?php
30 30
 					}
31
-				} else if($WeaponDamage['Armour'] > 0) {
31
+				} else if ($WeaponDamage['Armour'] > 0) {
32 32
 					?> which is deflected by their shields<?php
33 33
 				} else {
34 34
 					?> but it cannot do any damage<?php
@@ -37,31 +37,31 @@  discard block
 block discarded – undo
37 37
 				?> destroying <?php
38 38
 			}
39 39
 			$DamageTypes = 0;
40
-			if($ActualDamage['Shield'] > 0){ $DamageTypes = $DamageTypes+1; }
41
-			if($ActualDamage['NumCDs'] > 0){ $DamageTypes = $DamageTypes+1; }
42
-			if($ActualDamage['Armour'] > 0){ $DamageTypes = $DamageTypes+1; }
40
+			if ($ActualDamage['Shield'] > 0) { $DamageTypes = $DamageTypes + 1; }
41
+			if ($ActualDamage['NumCDs'] > 0) { $DamageTypes = $DamageTypes + 1; }
42
+			if ($ActualDamage['Armour'] > 0) { $DamageTypes = $DamageTypes + 1; }
43 43
 
44
-			if($ActualDamage['Shield'] > 0) {
44
+			if ($ActualDamage['Shield'] > 0) {
45 45
 				?><span class="shields"><?php echo number_format($ActualDamage['Shield']) ?></span> shields<?php
46 46
 				$this->doDamageTypeReductionDisplay($DamageTypes);
47 47
 			}
48
-			if($ActualDamage['NumCDs'] > 0) {
48
+			if ($ActualDamage['NumCDs'] > 0) {
49 49
 				?><span class="cds"><?php echo number_format($ActualDamage['NumCDs']) ?></span> drones<?php
50 50
 				$this->doDamageTypeReductionDisplay($DamageTypes);
51 51
 			}
52
-			if($ActualDamage['Armour'] > 0) {
52
+			if ($ActualDamage['Armour'] > 0) {
53 53
 				?><span class="red"><?php echo number_format($ActualDamage['Armour']) ?></span> plates of armour<?php
54 54
 			}
55 55
 		} ?>.
56 56
 		<br /><?php
57 57
 		if ($ShotHit && $ActualDamage['KillingShot']) {
58
-			$this->includeTemplate('includes/TraderCombatKillMessage.inc',array('KillResults'=>$ForceResults['KillResults'],'TargetPlayer'=>$TargetPlayer));
58
+			$this->includeTemplate('includes/TraderCombatKillMessage.inc', array('KillResults'=>$ForceResults['KillResults'], 'TargetPlayer'=>$TargetPlayer));
59 59
 		}
60 60
 	}
61 61
 }
62
-if(isset($ForcesCombatResults['ForcesDestroyed']) && $ForcesCombatResults['ForcesDestroyed']) {
62
+if (isset($ForcesCombatResults['ForcesDestroyed']) && $ForcesCombatResults['ForcesDestroyed']) {
63 63
 	?>Forces are <span class="red">DESTROYED!</span><br /><?php
64 64
 }
65 65
 
66
-$TotalDamage =& $ForcesCombatResults['TotalDamage'] ?>
67
-The forces <?php if($TotalDamage > 0){ ?>hit for a total of <span class="red"><?php echo number_format($TotalDamage) ?></span> damage in this round of combat<?php } else{ ?>do no damage this round<?php } ?>.
66
+$TotalDamage = & $ForcesCombatResults['TotalDamage'] ?>
67
+The forces <?php if ($TotalDamage > 0) { ?>hit for a total of <span class="red"><?php echo number_format($TotalDamage) ?></span> damage in this round of combat<?php } else { ?>do no damage this round<?php } ?>.
Please login to merge, or discard this patch.
templates/Default/engine/Default/includes/TraderTeamCombatResults.inc 1 patch
Spacing   +48 added lines, -48 removed lines patch added patch discarded remove patch
@@ -1,36 +1,36 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if(is_array($TraderTeamCombatResults['Traders'])) {
3
-	foreach($TraderTeamCombatResults['Traders'] as $AccountID => $TraderResults) {
4
-		$ShootingPlayer =& $TraderResults['Player'];
5
-		$TotalDamage =& $TraderResults['TotalDamage'];
2
+if (is_array($TraderTeamCombatResults['Traders'])) {
3
+	foreach ($TraderTeamCombatResults['Traders'] as $AccountID => $TraderResults) {
4
+		$ShootingPlayer = & $TraderResults['Player'];
5
+		$TotalDamage = & $TraderResults['TotalDamage'];
6 6
 	
7
-		if($TraderResults['DeadBeforeShot']) {
7
+		if ($TraderResults['DeadBeforeShot']) {
8 8
 			echo $ShootingPlayer->getDisplayName() ?> died before they were able to attack!<br /><?php
9 9
 		} else {
10
-			if(isset($TraderResults['Weapons']) && is_array($TraderResults['Weapons'])) {
11
-				foreach($TraderResults['Weapons'] as $WeaponResults) {
12
-					$ShootingWeapon =& $WeaponResults['Weapon'];
13
-					$ShotHit =& $WeaponResults['Hit'];
14
-					$ActualDamage =& $WeaponResults['ActualDamage'];
15
-					$WeaponDamage =& $WeaponResults['WeaponDamage'];
16
-					$TargetPlayer =& $WeaponResults['TargetPlayer'];
10
+			if (isset($TraderResults['Weapons']) && is_array($TraderResults['Weapons'])) {
11
+				foreach ($TraderResults['Weapons'] as $WeaponResults) {
12
+					$ShootingWeapon = & $WeaponResults['Weapon'];
13
+					$ShotHit = & $WeaponResults['Hit'];
14
+					$ActualDamage = & $WeaponResults['ActualDamage'];
15
+					$WeaponDamage = & $WeaponResults['WeaponDamage'];
16
+					$TargetPlayer = & $WeaponResults['TargetPlayer'];
17 17
 					
18 18
 					echo $ShootingPlayer->getDisplayName() ?> fires their <?php echo $ShootingWeapon->getName() ?> at <?php
19
-					if($ShotHit && $ActualDamage['TargetAlreadyDead']) {
19
+					if ($ShotHit && $ActualDamage['TargetAlreadyDead']) {
20 20
 						?>the debris that was once <?php
21 21
 					}
22 22
 					echo $TargetPlayer->getDisplayName();
23 23
 					if (!$ShotHit || !$ActualDamage['TargetAlreadyDead']) {
24
-						if(!$ShotHit) {
24
+						if (!$ShotHit) {
25 25
 							?> and misses<?php
26
-						} else if($ActualDamage['TotalDamage'] == 0) {
27
-							if($WeaponDamage['Shield'] > 0) {
28
-								if($ActualDamage['HasCDs']) {
26
+						} else if ($ActualDamage['TotalDamage'] == 0) {
27
+							if ($WeaponDamage['Shield'] > 0) {
28
+								if ($ActualDamage['HasCDs']) {
29 29
 									?> which proves ineffective against their combat drones<?php
30 30
 								} else {
31 31
 									?> which washes harmlessly over their hull<?php
32 32
 								}
33
-							} else if($WeaponDamage['Armour'] > 0) {
33
+							} else if ($WeaponDamage['Armour'] > 0) {
34 34
 								?> which is deflected by their shields<?php
35 35
 							} else {
36 36
 								?> but it cannot do any damage<?php
@@ -38,94 +38,94 @@  discard block
 block discarded – undo
38 38
 						} else {
39 39
 							?> destroying <?php
40 40
 							$DamageTypes = 0;
41
-							if($ActualDamage['Shield'] > 0){ $DamageTypes = $DamageTypes+1; }
42
-							if($ActualDamage['NumCDs'] > 0){ $DamageTypes = $DamageTypes+1; }
43
-							if($ActualDamage['Armour'] > 0){ $DamageTypes = $DamageTypes+1; }
41
+							if ($ActualDamage['Shield'] > 0) { $DamageTypes = $DamageTypes + 1; }
42
+							if ($ActualDamage['NumCDs'] > 0) { $DamageTypes = $DamageTypes + 1; }
43
+							if ($ActualDamage['Armour'] > 0) { $DamageTypes = $DamageTypes + 1; }
44 44
 
45
-							if($ActualDamage['Shield'] > 0) {
45
+							if ($ActualDamage['Shield'] > 0) {
46 46
 								?><span class="shields"><?php echo number_format($ActualDamage['Shield']) ?></span> shields<?php
47 47
 								$this->doDamageTypeReductionDisplay($DamageTypes);
48 48
 							}
49
-							if($ActualDamage['NumCDs'] > 0) {
49
+							if ($ActualDamage['NumCDs'] > 0) {
50 50
 								?><span class="cds"><?php echo number_format($ActualDamage['NumCDs']) ?></span> combat drones<?php
51 51
 								$this->doDamageTypeReductionDisplay($DamageTypes);
52 52
 							}
53
-							if($ActualDamage['Armour'] > 0) {
53
+							if ($ActualDamage['Armour'] > 0) {
54 54
 								?><span class="red"><?php echo number_format($ActualDamage['Armour']) ?></span> plates of armour<?php
55 55
 							}
56 56
 						}
57 57
 					} ?>.
58 58
 					<br /><?php
59 59
 					if ($ShotHit && $ActualDamage['KillingShot']) {
60
-						$this->includeTemplate('includes/TraderCombatKillMessage.inc',array('KillResults'=>$WeaponResults['KillResults'],'TargetPlayer'=>$TargetPlayer,'ShootingPlayer'=>$ShootingPlayer));
60
+						$this->includeTemplate('includes/TraderCombatKillMessage.inc', array('KillResults'=>$WeaponResults['KillResults'], 'TargetPlayer'=>$TargetPlayer, 'ShootingPlayer'=>$ShootingPlayer));
61 61
 					}
62 62
 				}
63 63
 			}
64
-			if(isset($TraderResults['Drones'])) {
65
-				$Drones =& $TraderResults['Drones'];
66
-				$ActualDamage =& $Drones['ActualDamage'];
67
-				$WeaponDamage =& $Drones['WeaponDamage'];
68
-				$TargetPlayer =& $Drones['TargetPlayer'];
64
+			if (isset($TraderResults['Drones'])) {
65
+				$Drones = & $TraderResults['Drones'];
66
+				$ActualDamage = & $Drones['ActualDamage'];
67
+				$WeaponDamage = & $Drones['WeaponDamage'];
68
+				$TargetPlayer = & $Drones['TargetPlayer'];
69 69
 				$DamageTypes = 0;
70
-				if($ActualDamage['Shield'] > 0){ $DamageTypes = $DamageTypes+1; }
71
-				if($ActualDamage['NumCDs'] > 0){ $DamageTypes = $DamageTypes+1; }
72
-				if($ActualDamage['Armour'] > 0){ $DamageTypes = $DamageTypes+1; }
70
+				if ($ActualDamage['Shield'] > 0) { $DamageTypes = $DamageTypes + 1; }
71
+				if ($ActualDamage['NumCDs'] > 0) { $DamageTypes = $DamageTypes + 1; }
72
+				if ($ActualDamage['Armour'] > 0) { $DamageTypes = $DamageTypes + 1; }
73 73
 	
74 74
 				echo $ShootingPlayer->getDisplayName();
75
-				if($WeaponDamage['Launched'] == 0) {
75
+				if ($WeaponDamage['Launched'] == 0) {
76 76
 					?> fails to launch their combat drones<?php
77 77
 				} else {
78 78
 					?> launches <span class="cds"><?php echo $WeaponDamage['Launched'] ?></span> combat drones at <?php
79
-					if($ActualDamage['TargetAlreadyDead']) {
79
+					if ($ActualDamage['TargetAlreadyDead']) {
80 80
 						?>the debris that was once <?php
81 81
 					}
82 82
 					echo $TargetPlayer->getDisplayName();
83
-					if(!$ActualDamage['TargetAlreadyDead']) {
84
-						if($ActualDamage['TotalDamage'] == 0) {
85
-							if($WeaponDamage['Shield'] > 0) {
86
-								if($ActualDamage['HasCDs']) {
83
+					if (!$ActualDamage['TargetAlreadyDead']) {
84
+						if ($ActualDamage['TotalDamage'] == 0) {
85
+							if ($WeaponDamage['Shield'] > 0) {
86
+								if ($ActualDamage['HasCDs']) {
87 87
 									?> which prove ineffective against their combat drones<?php
88 88
 								} else {
89 89
 									?> which washes harmlessly over their hull<?php
90 90
 								}
91 91
 							}
92
-							if($ActualDamage['Armour'] > 0) {
92
+							if ($ActualDamage['Armour'] > 0) {
93 93
 								?> which is deflected by their shields<?php
94 94
 							} else {
95 95
 								?> but they cannot do any damage<?php
96 96
 							}
97 97
 						} else {
98 98
 							?> destroying <?php
99
-							if($ActualDamage['Shield'] > 0) {
99
+							if ($ActualDamage['Shield'] > 0) {
100 100
 								?><span class="shields"><?php echo number_format($ActualDamage['Shield']) ?></span> shields<?php
101 101
 								$this->doDamageTypeReductionDisplay($DamageTypes);
102 102
 							}
103
-							if($ActualDamage['NumCDs'] > 0) {
103
+							if ($ActualDamage['NumCDs'] > 0) {
104 104
 								?><span class="cds"><?php echo number_format($ActualDamage['NumCDs']) ?></span> combat drones<?php
105 105
 								$this->doDamageTypeReductionDisplay($DamageTypes);
106 106
 							}
107
-							if($ActualDamage['Armour'] > 0) {
107
+							if ($ActualDamage['Armour'] > 0) {
108 108
 								?><span class="red"><?php echo number_format($ActualDamage['Armour']) ?></span> plates of armour<?php
109 109
 							}
110 110
 						}
111 111
 					}
112 112
 				} ?>.
113 113
 				<br /><?php
114
-				if($ActualDamage['KillingShot']) {
115
-					$this->includeTemplate('includes/TraderCombatKillMessage.inc',array('KillResults'=>$Drones['KillResults'],'TargetPlayer'=>$TargetPlayer,'ShootingPlayer'=>$ShootingPlayer));
114
+				if ($ActualDamage['KillingShot']) {
115
+					$this->includeTemplate('includes/TraderCombatKillMessage.inc', array('KillResults'=>$Drones['KillResults'], 'TargetPlayer'=>$TargetPlayer, 'ShootingPlayer'=>$ShootingPlayer));
116 116
 				}
117 117
 			}
118 118
 		}
119 119
 		echo $ShootingPlayer->getDisplayName();
120
-		if($TotalDamage > 0) {
120
+		if ($TotalDamage > 0) {
121 121
 			?> hits for a total of <span class="red"><?php echo $TotalDamage ?></span> damage in this round of combat<?php
122 122
 		} else {
123 123
 			?> does no damage this round.<?php
124
-			if(!$TraderResults['DeadBeforeShot']) {
124
+			if (!$TraderResults['DeadBeforeShot']) {
125 125
 				?> Maybe they should go back to the academy<?php
126 126
 			}
127 127
 		} ?>.<br /><br /><?php
128 128
 	}
129 129
 }
130 130
 $TotalDamage = $TraderTeamCombatResults['TotalDamage']; ?>
131
-This fleet <?php if($TotalDamage > 0){ ?>hits for a total of <span class="red"><?php echo $TotalDamage ?></span> damage in this round of combat<?php } else{ ?>does no damage this round. You call that a fleet? They need a better recruiter<?php } ?>.<br />
131
+This fleet <?php if ($TotalDamage > 0) { ?>hits for a total of <span class="red"><?php echo $TotalDamage ?></span> damage in this round of combat<?php } else { ?>does no damage this round. You call that a fleet? They need a better recruiter<?php } ?>.<br />
Please login to merge, or discard this patch.
engine/Default/cargo_dump_processing.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
 
47 47
 	// Don't lose more exp than you have
48 48
 	$lost_xp = min($player->getExperience(),
49
-	               IRound(SmrPort::getBaseExperience($amount, $good_distance)));
49
+				   IRound(SmrPort::getBaseExperience($amount, $good_distance)));
50 50
 	$player->decreaseExperience($lost_xp);
51 51
 	$player->increaseHOF($lost_xp, array('Trade', 'Experience', 'Jettisoned'), HOF_PUBLIC);
52 52
 
Please login to merge, or discard this patch.
lib/Default/SmrMines.class.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 			$return = array('MaxDamage' => 0, 'Shield' => 0, 'Armour' => 0, 'Rollover' => $this->isDamageRollover());
95 95
 			return $return;
96 96
 		}
97
-		$damage =& $this->getModifiedDamage();
97
+		$damage = & $this->getModifiedDamage();
98 98
 		if ($targetPlayer->getShip()->isFederal()) { // do less damage to fed ships 
99 99
 			$damage['MaxDamage'] = IRound($damage['MaxDamage'] * self::FED_SHIP_DAMAGE_MODIFIER);
100 100
 			$damage['Shield'] = IRound($damage['Shield'] * self::FED_SHIP_DAMAGE_MODIFIER);
@@ -131,12 +131,12 @@  discard block
 block discarded – undo
131 131
 	}
132 132
 	
133 133
 	protected function &doForceDamageToPlayer(array &$return, SmrForce $forces, AbstractSmrPlayer $targetPlayer, $minesAreAttacker = false) {
134
-		$return['WeaponDamage'] =& $this->getModifiedForceDamageAgainstPlayer($forces, $targetPlayer, $minesAreAttacker);
135
-		$return['ActualDamage'] =& $targetPlayer->getShip()->doMinesDamage($return['WeaponDamage']);
134
+		$return['WeaponDamage'] = & $this->getModifiedForceDamageAgainstPlayer($forces, $targetPlayer, $minesAreAttacker);
135
+		$return['ActualDamage'] = & $targetPlayer->getShip()->doMinesDamage($return['WeaponDamage']);
136 136
 		$return['ActualDamage']['Launched'] = ICeil($return['WeaponDamage']['Launched'] * $return['ActualDamage']['TotalDamage'] / $return['WeaponDamage']['MaxDamage']);
137 137
 
138 138
 		if ($return['ActualDamage']['KillingShot']) {
139
-			$return['KillResults'] =& $targetPlayer->killPlayerByForces($forces);
139
+			$return['KillResults'] = & $targetPlayer->killPlayerByForces($forces);
140 140
 		}
141 141
 		return $return;
142 142
 	}
Please login to merge, or discard this patch.
lib/Default/SmrScoutDrones.class.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@
 block discarded – undo
80 80
 			$return = array('MaxDamage' => 0, 'Shield' => 0, 'Armour' => 0, 'Rollover' => $this->isDamageRollover());
81 81
 			return $return;
82 82
 		}
83
-		$damage =& $this->getModifiedDamage();
83
+		$damage = & $this->getModifiedDamage();
84 84
 		$damage['Launched'] = ICeil($this->getNumberOfSDs() * $this->getModifiedForceAccuracyAgainstPlayer($forces, $targetPlayer) / 100);
85 85
 		$damage['MaxDamage'] = ICeil($damage['Launched'] * $damage['MaxDamage']);
86 86
 		$damage['Shield'] = ICeil($damage['Launched'] * $damage['Shield']);
Please login to merge, or discard this patch.
admin/Default/1.6/check_map.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
 	}
21 21
 }
22 22
 $missingLocs = array_diff(array_keys(SmrLocation::getAllLocations()),
23
-                          array_keys($existingLocs));
23
+						  array_keys($existingLocs));
24 24
 $missingLocNames = [];
25 25
 foreach ($missingLocs as $locID) {
26 26
 	$missingLocNames[] = SmrLocation::getLocation($locID)->getName();
Please login to merge, or discard this patch.
engine/Default/shop_hardware_processing.php 1 patch
Braces   +11 added lines, -7 removed lines patch added patch discarded remove patch
@@ -32,11 +32,16 @@  discard block
 block discarded – undo
32 32
 	$ship->increaseHardware($hardware_id, $amount);
33 33
 
34 34
 	//HoF
35
-	if ($hardware_id == HARDWARE_COMBAT) $player->increaseHOF($amount, array('Forces', 'Bought', 'Combat Drones'), HOF_ALLIANCE);
36
-	if ($hardware_id == HARDWARE_SCOUT) $player->increaseHOF($amount, array('Forces', 'Bought', 'Scout Drones'), HOF_ALLIANCE);
37
-	if ($hardware_id == HARDWARE_MINE) $player->increaseHOF($amount, array('Forces', 'Bought', 'Mines'), HOF_ALLIANCE);
38
-}
39
-else if ($action == 'Sell') {
35
+	if ($hardware_id == HARDWARE_COMBAT) {
36
+		$player->increaseHOF($amount, array('Forces', 'Bought', 'Combat Drones'), HOF_ALLIANCE);
37
+	}
38
+	if ($hardware_id == HARDWARE_SCOUT) {
39
+		$player->increaseHOF($amount, array('Forces', 'Bought', 'Scout Drones'), HOF_ALLIANCE);
40
+	}
41
+	if ($hardware_id == HARDWARE_MINE) {
42
+		$player->increaseHOF($amount, array('Forces', 'Bought', 'Mines'), HOF_ALLIANCE);
43
+	}
44
+	} else if ($action == 'Sell') {
40 45
 	// We only allow selling combat drones
41 46
 	if ($hardware_id != HARDWARE_COMBAT) {
42 47
 		throw new Exception('This item cannot be sold!');
@@ -49,8 +54,7 @@  discard block
 block discarded – undo
49 54
 
50 55
 	$player->increaseCredits(IRound($cost * CDS_REFUND_PERCENT) * $amount);
51 56
 	$ship->decreaseCDs($amount, true); // 2nd arg avoids under attack warning
52
-}
53
-else {
57
+} else {
54 58
 	throw new Exception('Action must be either Buy or Sell.');
55 59
 }
56 60
 
Please login to merge, or discard this patch.
lib/Default/AbstractSmrCombatWeapon.class.php 1 patch
Spacing   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
 	protected $maxDamage;
13 13
 	protected $shieldDamage;
14 14
 	protected $armourDamage;
15
-	protected $empDamage=0;
15
+	protected $empDamage = 0;
16 16
 	protected $accuracy;
17 17
 	protected $damageRollover;
18 18
 	protected $raidWeapon;
@@ -85,68 +85,68 @@  discard block
 block discarded – undo
85 85
 	abstract public function &getModifiedForceDamageAgainstPlayer(SmrForce $forces, AbstractSmrPlayer $targetPlayer);
86 86
 	
87 87
 	protected function &doPlayerDamageToForce(array &$return, AbstractSmrPlayer $weaponPlayer, SmrForce $forces) {
88
-		$return['WeaponDamage'] =& $this->getModifiedDamageAgainstForces($weaponPlayer,$forces);
89
-		$return['ActualDamage'] =& $forces->doWeaponDamage($return['WeaponDamage']);
90
-		if($return['ActualDamage']['KillingShot']) {
91
-			$return['KillResults'] =& $forces->killForcesByPlayer($weaponPlayer);
88
+		$return['WeaponDamage'] = & $this->getModifiedDamageAgainstForces($weaponPlayer, $forces);
89
+		$return['ActualDamage'] = & $forces->doWeaponDamage($return['WeaponDamage']);
90
+		if ($return['ActualDamage']['KillingShot']) {
91
+			$return['KillResults'] = & $forces->killForcesByPlayer($weaponPlayer);
92 92
 		}
93 93
 		return $return;
94 94
 	}
95 95
 	
96 96
 	protected function &doPlayerDamageToPlayer(array &$return, AbstractSmrPlayer $weaponPlayer, AbstractSmrPlayer $targetPlayer) {
97
-		$return['WeaponDamage'] =& $this->getModifiedDamageAgainstPlayer($weaponPlayer,$targetPlayer);
98
-		$return['ActualDamage'] =& $targetPlayer->getShip()->doWeaponDamage($return['WeaponDamage']);
97
+		$return['WeaponDamage'] = & $this->getModifiedDamageAgainstPlayer($weaponPlayer, $targetPlayer);
98
+		$return['ActualDamage'] = & $targetPlayer->getShip()->doWeaponDamage($return['WeaponDamage']);
99 99
 
100
-		if($return['ActualDamage']['KillingShot']) {
101
-			$return['KillResults'] =& $targetPlayer->killPlayerByPlayer($weaponPlayer);
100
+		if ($return['ActualDamage']['KillingShot']) {
101
+			$return['KillResults'] = & $targetPlayer->killPlayerByPlayer($weaponPlayer);
102 102
 		}
103 103
 		return $return;
104 104
 	}
105 105
 	
106 106
 	protected function &doPlayerDamageToPort(array &$return, AbstractSmrPlayer $weaponPlayer, SmrPort $port) {
107
-		$return['WeaponDamage'] =& $this->getModifiedDamageAgainstPort($weaponPlayer,$port);
108
-		$return['ActualDamage'] =& $port->doWeaponDamage($return['WeaponDamage']);
109
-		if($return['ActualDamage']['KillingShot']) {
110
-			$return['KillResults'] =& $port->killPortByPlayer($weaponPlayer);
107
+		$return['WeaponDamage'] = & $this->getModifiedDamageAgainstPort($weaponPlayer, $port);
108
+		$return['ActualDamage'] = & $port->doWeaponDamage($return['WeaponDamage']);
109
+		if ($return['ActualDamage']['KillingShot']) {
110
+			$return['KillResults'] = & $port->killPortByPlayer($weaponPlayer);
111 111
 		}
112 112
 		return $return;
113 113
 	}
114 114
 	
115 115
 	protected function &doPlayerDamageToPlanet(array &$return, AbstractSmrPlayer $weaponPlayer, SmrPlanet $planet, $delayed) {
116
-		$return['WeaponDamage'] =& $this->getModifiedDamageAgainstPlanet($weaponPlayer,$planet);
117
-		$return['ActualDamage'] =& $planet->doWeaponDamage($return['WeaponDamage'],$delayed);
118
-		if($return['ActualDamage']['KillingShot']) {
119
-			$return['KillResults'] =& $planet->killPlanetByPlayer($weaponPlayer);
116
+		$return['WeaponDamage'] = & $this->getModifiedDamageAgainstPlanet($weaponPlayer, $planet);
117
+		$return['ActualDamage'] = & $planet->doWeaponDamage($return['WeaponDamage'], $delayed);
118
+		if ($return['ActualDamage']['KillingShot']) {
119
+			$return['KillResults'] = & $planet->killPlanetByPlayer($weaponPlayer);
120 120
 		}
121 121
 		return $return;
122 122
 	}
123 123
 	
124 124
 	protected function &doPortDamageToPlayer(array &$return, SmrPort $port, AbstractSmrPlayer $targetPlayer) {
125
-		$return['WeaponDamage'] =& $this->getModifiedPortDamageAgainstPlayer($port,$targetPlayer);
126
-		$return['ActualDamage'] =& $targetPlayer->getShip()->doWeaponDamage($return['WeaponDamage']);
125
+		$return['WeaponDamage'] = & $this->getModifiedPortDamageAgainstPlayer($port, $targetPlayer);
126
+		$return['ActualDamage'] = & $targetPlayer->getShip()->doWeaponDamage($return['WeaponDamage']);
127 127
 
128
-		if($return['ActualDamage']['KillingShot']) {
129
-			$return['KillResults'] =& $targetPlayer->killPlayerByPort($port);
128
+		if ($return['ActualDamage']['KillingShot']) {
129
+			$return['KillResults'] = & $targetPlayer->killPlayerByPort($port);
130 130
 		}
131 131
 		return $return;
132 132
 	}
133 133
 	
134 134
 	protected function &doPlanetDamageToPlayer(array &$return, SmrPlanet $planet, AbstractSmrPlayer $targetPlayer) {
135
-		$return['WeaponDamage'] =& $this->getModifiedPlanetDamageAgainstPlayer($planet,$targetPlayer);
136
-		$return['ActualDamage'] =& $targetPlayer->getShip()->doWeaponDamage($return['WeaponDamage']);
135
+		$return['WeaponDamage'] = & $this->getModifiedPlanetDamageAgainstPlayer($planet, $targetPlayer);
136
+		$return['ActualDamage'] = & $targetPlayer->getShip()->doWeaponDamage($return['WeaponDamage']);
137 137
 
138
-		if($return['ActualDamage']['KillingShot']) {
139
-			$return['KillResults'] =& $targetPlayer->killPlayerByPlanet($planet);
138
+		if ($return['ActualDamage']['KillingShot']) {
139
+			$return['KillResults'] = & $targetPlayer->killPlayerByPlanet($planet);
140 140
 		}
141 141
 		return $return;
142 142
 	}
143 143
 	
144 144
 	protected function &doForceDamageToPlayer(array &$return, SmrForce $forces, AbstractSmrPlayer $targetPlayer) {
145
-		$return['WeaponDamage'] =& $this->getModifiedForceDamageAgainstPlayer($forces,$targetPlayer);
146
-		$return['ActualDamage'] =& $targetPlayer->getShip()->doWeaponDamage($return['WeaponDamage']);
145
+		$return['WeaponDamage'] = & $this->getModifiedForceDamageAgainstPlayer($forces, $targetPlayer);
146
+		$return['ActualDamage'] = & $targetPlayer->getShip()->doWeaponDamage($return['WeaponDamage']);
147 147
 
148
-		if($return['ActualDamage']['KillingShot']) {
149
-			$return['KillResults'] =& $targetPlayer->killPlayerByForces($forces);
148
+		if ($return['ActualDamage']['KillingShot']) {
149
+			$return['KillResults'] = & $targetPlayer->killPlayerByForces($forces);
150 150
 		}
151 151
 		return $return;
152 152
 	}
Please login to merge, or discard this patch.