Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Branch master (287493)
by Dan
06:08
created
tools/irc/channel.php 1 patch
Braces   +9 added lines, -6 removed lines patch added patch discarded remove patch
@@ -14,12 +14,15 @@
 block discarded – undo
14 14
 
15 15
 //		if ($nick == 'MrSpock' && $user == 'mrspock')
16 16
 //			fputs($fp, 'PRIVMSG ' . $channel . ' :The creator! The God! He\'s among us! Praise him!' . EOL);
17
-		if ($nick == 'Holti' && $user == 'Holti')
18
-			fputs($fp, 'PRIVMSG ' . $channel . ' :' . chr(1) . 'ACTION hands ' . $nick . ' a ' . chr(3) . '4@' . chr(3) . '3' . chr(2) . '}' . chr(2) . '-,`--' . chr(1) . EOL);
19
-		if ($nick == 'kiNky' && $user == 'cicika')
20
-			fputs($fp, 'PRIVMSG ' . $channel . ' :' . chr(1) . 'ACTION hands ' . $nick . ' a ' . chr(3) . '4@' . chr(3) . '3' . chr(2) . '}' . chr(2) . '-,`--' . chr(1) . EOL);
21
-		if ($nick == 'River' && $user == 'Serenity')
22
-			fputs($fp, 'PRIVMSG ' . $channel . ' :' . chr(1) . 'ACTION hands ' . $nick . ' a ' . chr(3) . '8@' . chr(3) . '3' . chr(2) . '}' . chr(2) . '-,`--' . chr(1) . EOL);
17
+		if ($nick == 'Holti' && $user == 'Holti') {
18
+					fputs($fp, 'PRIVMSG ' . $channel . ' :' . chr(1) . 'ACTION hands ' . $nick . ' a ' . chr(3) . '4@' . chr(3) . '3' . chr(2) . '}' . chr(2) . '-,`--' . chr(1) . EOL);
19
+		}
20
+		if ($nick == 'kiNky' && $user == 'cicika') {
21
+					fputs($fp, 'PRIVMSG ' . $channel . ' :' . chr(1) . 'ACTION hands ' . $nick . ' a ' . chr(3) . '4@' . chr(3) . '3' . chr(2) . '}' . chr(2) . '-,`--' . chr(1) . EOL);
22
+		}
23
+		if ($nick == 'River' && $user == 'Serenity') {
24
+					fputs($fp, 'PRIVMSG ' . $channel . ' :' . chr(1) . 'ACTION hands ' . $nick . ' a ' . chr(3) . '8@' . chr(3) . '3' . chr(2) . '}' . chr(2) . '-,`--' . chr(1) . EOL);
25
+		}
23 26
 
24 27
 		$db = new SmrMySqlDatabase();
25 28
 
Please login to merge, or discard this patch.
tools/irc/channel_msg.php 1 patch
Braces   +49 added lines, -34 removed lines patch added patch discarded remove patch
@@ -47,8 +47,7 @@  discard block
 block discarded – undo
47 47
 	// get smr player
48 48
 	try {
49 49
 		$player = SmrPlayer::getPlayer($account->getAccountID(), $alliance->getGameId(), true);
50
-	}
51
-	catch(PlayerNotFoundException $e) {
50
+	} catch(PlayerNotFoundException $e) {
52 51
 		if($validationMessages === true) {
53 52
 			fputs($fp, 'PRIVMSG ' . $channel . ' :' . $nick . ', you have not joined the game that this channel belongs to.' . EOL);
54 53
 		}
@@ -85,36 +84,50 @@  discard block
 block discarded – undo
85 84
 			return true;
86 85
 		}
87 86
 
88
-		if (channel_msg_money($fp, $rdata, $account, $player))
89
-			return true;
90
-		if (channel_msg_forces($fp, $rdata, $account, $player))
91
-			return true;
87
+		if (channel_msg_money($fp, $rdata, $account, $player)) {
88
+					return true;
89
+		}
90
+		if (channel_msg_forces($fp, $rdata, $account, $player)) {
91
+					return true;
92
+		}
92 93
 
93
-		if (channel_msg_seed($fp, $rdata, $account, $player))
94
-			return true;
95
-		if (channel_msg_seedlist_add($fp, $rdata, $account, $player))
96
-			return true;
97
-		if (channel_msg_seedlist_del($fp, $rdata, $account, $player))
98
-			return true;
94
+		if (channel_msg_seed($fp, $rdata, $account, $player)) {
95
+					return true;
96
+		}
97
+		if (channel_msg_seedlist_add($fp, $rdata, $account, $player)) {
98
+					return true;
99
+		}
100
+		if (channel_msg_seedlist_del($fp, $rdata, $account, $player)) {
101
+					return true;
102
+		}
99 103
 
100
-		if (channel_msg_op_info($fp, $rdata, $account, $player))
101
-			return true;
102
-		if (channel_msg_op_cancel($fp, $rdata, $account, $player))
103
-			return true;
104
-		if (channel_msg_op_set($fp, $rdata, $account, $player))
105
-			return true;
106
-		if (channel_msg_op_turns($fp, $rdata, $account, $player))
107
-			return true;
108
-		if (channel_msg_op_response($fp, $rdata, $account, $player))
109
-			return true;
110
-		if (channel_msg_op_list($fp, $rdata, $account, $player))
111
-			return true;
112
-		if (channel_msg_sd_set($fp, $rdata, $account, $player))
113
-			return true;
114
-		if (channel_msg_sd_del($fp, $rdata, $account, $player))
115
-			return true;
116
-		if (channel_msg_sd_list($fp, $rdata, $account, $player))
117
-			return true;
104
+		if (channel_msg_op_info($fp, $rdata, $account, $player)) {
105
+					return true;
106
+		}
107
+		if (channel_msg_op_cancel($fp, $rdata, $account, $player)) {
108
+					return true;
109
+		}
110
+		if (channel_msg_op_set($fp, $rdata, $account, $player)) {
111
+					return true;
112
+		}
113
+		if (channel_msg_op_turns($fp, $rdata, $account, $player)) {
114
+					return true;
115
+		}
116
+		if (channel_msg_op_response($fp, $rdata, $account, $player)) {
117
+					return true;
118
+		}
119
+		if (channel_msg_op_list($fp, $rdata, $account, $player)) {
120
+					return true;
121
+		}
122
+		if (channel_msg_sd_set($fp, $rdata, $account, $player)) {
123
+					return true;
124
+		}
125
+		if (channel_msg_sd_del($fp, $rdata, $account, $player)) {
126
+					return true;
127
+		}
128
+		if (channel_msg_sd_list($fp, $rdata, $account, $player)) {
129
+					return true;
130
+		}
118 131
 
119 132
 	}
120 133
 
@@ -253,8 +266,9 @@  discard block
 block discarded – undo
253 266
 		$countdown = intval($msg[5]);
254 267
 		$message = 'ALERT! ALERT! ALERT!';
255 268
 
256
-		if (isset($msg[6]))
257
-			$message .= ' ' . $msg[6];
269
+		if (isset($msg[6])) {
270
+					$message .= ' ' . $msg[6];
271
+		}
258 272
 
259 273
 		echo_r('[TIMER] ' . $nick . ' started a timer with ' . $countdown . ' minute(s) (' . $message . ') in ' . $channel);
260 274
 
@@ -364,8 +378,9 @@  discard block
 block discarded – undo
364 378
 		if ($topic == 'seen') {
365 379
 			fputs($fp, 'NOTICE ' . $nick . ' :Syntax !seen <nickname>' . EOL);
366 380
 			fputs($fp, 'NOTICE ' . $nick . ' :   Displays the last time <nickname> was seen' . EOL);
367
-		} else
368
-			fputs($fp, 'NOTICE ' . $nick . ' :There is no help available for this command! Try !help' . EOL);
381
+		} else {
382
+					fputs($fp, 'NOTICE ' . $nick . ' :There is no help available for this command! Try !help' . EOL);
383
+		}
369 384
 
370 385
 		//		if ($topic == 'login')
371 386
 		//			fputs($fp, 'NOTICE '.$nick.' :No help available yet! Ask MrSpock!'.EOL);
Please login to merge, or discard this patch.
tools/testRouteGen.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -31,10 +31,11 @@
 block discarded – undo
31 31
 $routesForPort=-1;
32 32
 $numberOfRoutes=5;
33 33
 
34
-if ($maxNumberOfPorts == 1)
34
+if ($maxNumberOfPorts == 1) {
35 35
 	$allRoutes = RouteGenerator::generateOneWayRoutes($allSectors, $distances, $goods, $races, $routesForPort);
36
-else
36
+} else {
37 37
 	$allRoutes = RouteGenerator::generateMultiPortRoutes($maxNumberOfPorts, $allSectors, $goods, $races, $distances, $routesForPort, $numberOfRoutes);
38
+}
38 39
 
39 40
 //var_dump($allRoutes);
40 41
 
Please login to merge, or discard this patch.
tools/testDistancePlotters.php 1 patch
Braces   +20 added lines, -13 removed lines patch added patch discarded remove patch
@@ -18,8 +18,9 @@  discard block
 block discarded – undo
18 18
 	{
19 19
 		foreach($galaxySectors as &$galaxySector)
20 20
 		{
21
-			if($galaxySector->hasPort())
22
-				$galaxySector->getPort();
21
+			if($galaxySector->hasPort()) {
22
+							$galaxySector->getPort();
23
+			}
23 24
 		} unset($galaxySector);
24 25
 	} unset($galaxySectors);
25 26
 	//Test plotters
@@ -78,8 +79,9 @@  discard block
 block discarded – undo
78 79
 			$x['TransactionType'] = 'Buy';
79 80
 	}
80 81
 	$di = Plotter::findDistanceToX($x, $sector, true);
81
-	if(is_object($di))
82
-		$di = $di->getRelativeDistance();
82
+	if(is_object($di)) {
83
+			$di = $di->getRelativeDistance();
84
+	}
83 85
 	$container['good_distance'] = $di;
84 86
 	return $di;
85 87
 }
@@ -87,10 +89,11 @@  discard block
 block discarded – undo
87 89
 function getGoodDistanceOld(SmrSector &$sector, $goodID, $transaction)
88 90
 {
89 91
 	// if we buy a good we're looking for the nearest sector that sells that good
90
-	if ($transaction == 'Buy')
91
-		$neg_transaction = 'Sell';
92
-	elseif ($transaction == 'Sell')
93
-		$neg_transaction = 'Buy';
92
+	if ($transaction == 'Buy') {
93
+			$neg_transaction = 'Sell';
94
+	} elseif ($transaction == 'Sell') {
95
+			$neg_transaction = 'Buy';
96
+	}
94 97
 
95 98
 	// initialize the queue. all sectors we have to visit are in here
96 99
 	$sector_queue = array();
@@ -118,16 +121,20 @@  discard block
 block discarded – undo
118 121
 
119 122
 		// does the current sector buy/sell the good we're looking for?
120 123
         if ($good_distance != 0) {
121
-			if ($curr_sector->hasPort() && $curr_sector->getPort()->hasGood($goodID, $neg_transaction) && $distance < $good_distance)
122
-				$good_distance = $distance;
124
+			if ($curr_sector->hasPort() && $curr_sector->getPort()->hasGood($goodID, $neg_transaction) && $distance < $good_distance) {
125
+							$good_distance = $distance;
126
+			}
123 127
         } else {
124
-			if ($curr_sector->hasPort() && $curr_sector->getPort()->hasGood($goodID, $neg_transaction))
125
-				$good_distance = $distance;
128
+			if ($curr_sector->hasPort() && $curr_sector->getPort()->hasGood($goodID, $neg_transaction)) {
129
+							$good_distance = $distance;
130
+			}
126 131
         }
127 132
 
128 133
 		// if we already found a port that buy or sell our product we don't need
129 134
 		// to go further than this one.
130
-		if ($good_distance != 0 && $good_distance <= $distance) continue;
135
+		if ($good_distance != 0 && $good_distance <= $distance) {
136
+			continue;
137
+		}
131 138
 
132 139
 		// enqueue all neighbours
133 140
 		if ($curr_sector->getLinkUp() > 0 && (!isset($sector_distance[$curr_sector->getLinkUp()]) || $sector_distance[$curr_sector->getLinkUp()] > $distance + 1)) {
Please login to merge, or discard this patch.
lib/Default/DummyPlayer.class.inc 1 patch
Braces   +16 added lines, -14 removed lines patch added patch discarded remove patch
@@ -70,8 +70,9 @@  discard block
 block discarded – undo
70 70
 		$newCredits = round($this->getShip()->getCost() / 4);
71 71
 		$old_speed = $this->getShip()->getSpeed();
72 72
 			
73
-		if ($newCredits < 100000)
74
-			$newCredits = 100000;
73
+		if ($newCredits < 100000) {
74
+					$newCredits = 100000;
75
+		}
75 76
 		$this->setCredits($newCredits);
76 77
 
77 78
 		// speed for pod
@@ -90,8 +91,9 @@  discard block
 block discarded – undo
90 91
 	}
91 92
 	
92 93
 	public function setAllianceID($ID) {
93
-		if($this->allianceID == $ID)
94
-			return;
94
+		if($this->allianceID == $ID) {
95
+					return;
96
+		}
95 97
 		$this->allianceID=$ID;
96 98
 	}
97 99
 	
@@ -152,15 +154,17 @@  discard block
 block discarded – undo
152 154
 		$relation = $relations[$killer->getRaceID()];
153 155
 
154 156
 		$alignChangePerRelation = 0.1;
155
-		if($relation >= RELATIONS_PEACE || $relation <= RELATIONS_WAR)
156
-			$alignChangePerRelation = 0.04;
157
+		if($relation >= RELATIONS_PEACE || $relation <= RELATIONS_WAR) {
158
+					$alignChangePerRelation = 0.04;
159
+		}
157 160
 
158 161
 		$alignChange = $relation * $alignChangePerRelation;
159 162
 		$return['KillerAlign'] = $alignChange;
160
-		if($alignChange>0)
161
-			$killer->increaseAlignment($alignChange);
162
-		else
163
-			$killer->decreaseAlignment(-$alignChange);
163
+		if($alignChange>0) {
164
+					$killer->increaseAlignment($alignChange);
165
+		} else {
166
+					$killer->decreaseAlignment(-$alignChange);
167
+		}
164 168
 		// War setting gives them military pay
165 169
 		if($relation <= RELATIONS_WAR) {
166 170
 			$killer->increaseMilitaryPayment(-floor($relation * 100 * (pow($gainedExp/2,0.25))));
@@ -196,8 +200,7 @@  discard block
 block discarded – undo
196 200
 			// If the podded players alignment makes them deputy or member then set bounty
197 201
 			if($this->getAlignment() >= 100) {
198 202
 				$bounty_type = 'HQ';
199
-			}
200
-			else if ($this->getAlignment() <= 100) {
203
+			} else if ($this->getAlignment() <= 100) {
201 204
 				$bounty_type = 'UG';
202 205
 			}
203 206
 
@@ -262,8 +265,7 @@  discard block
 block discarded – undo
262 265
 		if($db->nextRecord()) {
263 266
 			$return = unserialize($db->getField('info'));
264 267
 			return $return;
265
-		}
266
-		else {
268
+		} else {
267 269
 			$return = new DummyPlayer();
268 270
 			return $return;
269 271
 		}
Please login to merge, or discard this patch.
lib/Default/SmrSession.class.inc 1 patch
Braces   +28 added lines, -31 removed lines patch added patch discarded remove patch
@@ -1,7 +1,8 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if(!defined('USING_AJAX'))
3
+if(!defined('USING_AJAX')) {
4 4
 	define('USING_AJAX',false);
5
+}
5 6
 class SmrSession {
6 7
 	const ALWAYS_AVAILABLE = 999999;
7 8
 	const TIME_BEFORE_EXPIRY = 3600;
@@ -149,8 +150,7 @@  discard block
 block discarded – undo
149 150
 		// now try the cookie
150 151
 		if (isset($_COOKIE['session_id'])) {
151 152
 			self::$session_id = $_COOKIE['session_id'];
152
-		}
153
-		else {
153
+		} else {
154 154
 			// create a new session id
155 155
 			do {
156 156
 				self::$session_id = md5 (uniqid (mt_rand()) );
@@ -199,18 +199,15 @@  discard block
 block discarded – undo
199 199
 				self::$account_id	= 0;
200 200
 				self::$game_id		= 0;
201 201
 				self::$var			= array();
202
-			}
203
-			else {
202
+			} else {
204 203
 				foreach(self::$var as $key => &$value) {
205 204
 					if ($value['Expires'] > 0 && $value['Expires'] <= TIME) { // Use 0 for infinity
206 205
 						//This link is no longer valid
207 206
 						unset(self::$var[$key]);
208
-					}
209
-					else if ($value['RemainingPageLoads'] < 0) {
207
+					} else if ($value['RemainingPageLoads'] < 0) {
210 208
 						//This link is no longer valid
211 209
 						unset(self::$var[$key]);
212
-					}
213
-					else {
210
+					} else {
214 211
 						--$value['RemainingPageLoads'];
215 212
 						if(isset($value['CommonID'])) {
216 213
 							self::$commonIDs[$value['CommonID']] = $key;
@@ -218,8 +215,7 @@  discard block
 block discarded – undo
218 215
 					}
219 216
 				} unset($value);
220 217
 			}
221
-		}
222
-		else {
218
+		} else {
223 219
 			self::$generate = true;
224 220
 			self::$account_id	= 0;
225 221
 			self::$game_id		= 0;
@@ -240,8 +236,7 @@  discard block
 block discarded – undo
240 236
 			self::$db->query('UPDATE active_session SET account_id=' . self::$db->escapeNumber(self::$account_id) . ',game_id=' . self::$db->escapeNumber(self::$game_id) . (!USING_AJAX ? ',last_accessed=' . self::$db->escapeNumber(TIME) : '') . ',session_var=' . self::$db->escapeBinary($compressed) .
241 237
 					',last_sn='.self::$db->escapeString(self::$SN).
242 238
 					' WHERE session_id=' . self::$db->escapeString(self::$session_id) . (USING_AJAX ? ' AND last_sn='.self::$db->escapeString(self::$lastSN) : '') . ' LIMIT 1');
243
-		}
244
-		else {
239
+		} else {
245 240
 			self::$db->query('DELETE FROM active_session WHERE account_id = ' . self::$db->escapeNumber(self::$account_id) . ' AND game_id = ' . self::$db->escapeNumber(self::$game_id));
246 241
 			self::$db->query('INSERT INTO active_session (session_id, account_id, game_id, last_accessed, session_var) VALUES(' . self::$db->escapeString(self::$session_id) . ',' . self::$db->escapeNumber(self::$account_id) . ',' . self::$db->escapeNumber(self::$game_id) . ',' . self::$db->escapeNumber(TIME) . ',' . self::$db->escapeBinary($compressed) . ')');
247 242
 			self::$generate = false;
@@ -276,9 +271,10 @@  discard block
 block discarded – undo
276 271
 	}
277 272
 
278 273
 	public static function updateSN() {
279
-		if(!USING_AJAX)
280
-			self::$db->query('UPDATE active_session SET last_sn='.self::$db->escapeString(self::$SN).
274
+		if(!USING_AJAX) {
275
+					self::$db->query('UPDATE active_session SET last_sn='.self::$db->escapeString(self::$SN).
281 276
 				' WHERE session_id=' . self::$db->escapeString(self::$session_id) . ' LIMIT 1');
277
+		}
282 278
 	}
283 279
 
284 280
 	public static function destroy() {
@@ -289,8 +285,9 @@  discard block
 block discarded – undo
289 285
 	}
290 286
 
291 287
 	public static function retrieveVar($sn) {
292
-		if(!isset(self::$var[$sn]) || empty(self::$var[$sn]))
293
-			return false;
288
+		if(!isset(self::$var[$sn]) || empty(self::$var[$sn])) {
289
+					return false;
290
+		}
294 291
 		self::$SN = $sn;
295 292
 		SmrSession::updateSN();
296 293
 		if(isset(self::$var[$sn]['body']) && isset(self::$var[$sn]['CommonID'])) {
@@ -342,8 +339,9 @@  discard block
 block discarded – undo
342 339
 		}
343 340
 
344 341
 		self::$var[$sn] = $container;
345
-		if(!$lock && !USING_AJAX)
346
-			self::update();
342
+		if(!$lock && !USING_AJAX) {
343
+					self::update();
344
+		}
347 345
 		return $sn;
348 346
 	}
349 347
 
@@ -352,8 +350,7 @@  discard block
 block discarded – undo
352 350
 		if($value===null) {
353 351
 			unset($var[$key]);
354 352
 			unset(self::$var[self::$SN][$key]);
355
-		}
356
-		else {
353
+		} else {
357 354
 			$var[$key] = $value;
358 355
 			self::$var[self::$SN][$key] = $value;
359 356
 		}
@@ -375,8 +372,7 @@  discard block
 block discarded – undo
375 372
 
376 373
 		if($sn === false) {
377 374
 			$sn = self::generateSN($container);
378
-		}
379
-		else {
375
+		} else {
380 376
 			// If we've been provided an SN to use then copy over the existing 'PreviousRequestTime'
381 377
 			$container['PreviousRequestTime'] = self::$var[$sn]['PreviousRequestTime'];
382 378
 		}
@@ -389,8 +385,7 @@  discard block
 block discarded – undo
389 385
 		if(isset(self::$commonIDs[$container['CommonID']])) {
390 386
 			$sn = self::$commonIDs[$container['CommonID']];
391 387
 			$container['PreviousRequestTime'] = isset(self::$var[$sn]) ? self::$var[$sn]['PreviousRequestTime'] : MICRO_TIME;
392
-		}
393
-		else {
388
+		} else {
394 389
 			do {
395 390
 				$sn = substr(md5(mt_rand()),0,8);
396 391
 			} while(isset(self::$var[$sn]));
@@ -410,10 +405,11 @@  discard block
 block discarded – undo
410 405
 
411 406
 	public static function getNewHREF($container, $forceFullURL=false) {
412 407
 		$sn = self::addLink($container) . (isset($container['AJAX']) && $container['AJAX'] == true ? '&ajax=1':'');
413
-		if($forceFullURL===true||stripos($_SERVER['REQUEST_URI'],'loader.php')===false)
414
-			return '/loader.php?sn=' . $sn;
415
-		else
416
-			return '?sn=' . $sn;
408
+		if($forceFullURL===true||stripos($_SERVER['REQUEST_URI'],'loader.php')===false) {
409
+					return '/loader.php?sn=' . $sn;
410
+		} else {
411
+					return '?sn=' . $sn;
412
+		}
417 413
 	}
418 414
 
419 415
 	public static function addAjaxReturns($element,$contents) {
@@ -422,8 +418,9 @@  discard block
 block discarded – undo
422 418
 	}
423 419
 
424 420
 	public static function saveAjaxReturns() {
425
-		if(empty(self::$ajaxReturns))
426
-			return;
421
+		if(empty(self::$ajaxReturns)) {
422
+					return;
423
+		}
427 424
 		$compressed = gzcompress(serialize(self::$ajaxReturns));
428 425
 		self::$db->query('UPDATE active_session SET ajax_returns=' . self::$db->escapeBinary($compressed) .
429 426
 				' WHERE session_id=' . self::$db->escapeString(self::$session_id) . ' LIMIT 1');
Please login to merge, or discard this patch.
lib/Default/Council.class.inc 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -9,8 +9,9 @@
 block discarded – undo
9 9
 	}
10 10
 
11 11
 	protected static function initialiseDatabase() {
12
-		if(self::$db==null)
13
-			self::$db = new SmrMySqlDatabase();
12
+		if(self::$db==null) {
13
+					self::$db = new SmrMySqlDatabase();
14
+		}
14 15
 	}
15 16
 
16 17
 	/**
Please login to merge, or discard this patch.
lib/Default/SmrGame.class.inc 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -90,13 +90,11 @@  discard block
 block discarded – undo
90 90
 			$this->allianceMaxPlayers	= $this->db->getInt('alliance_max_players');
91 91
 			$this->allianceMaxVets		= $this->db->getInt('alliance_max_vets');
92 92
 			$this->startingCredits		= $this->db->getInt('starting_credits');
93
-		}
94
-		else if($create===true) {
93
+		} else if($create===true) {
95 94
 			$this->gameID		= (int)$gameID;
96 95
 			$this->isNew		= true;
97 96
 			return;
98
-		}
99
-		else {
97
+		} else {
100 98
 			throw new GameNotFoundException('No such game: ' . $gameID);
101 99
 		}
102 100
 	}
@@ -121,8 +119,7 @@  discard block
 block discarded – undo
121 119
 										', alliance_max_vets = ' . $this->db->escapeNumber($this->getAllianceMaxVets()) .
122 120
 										', starting_credits = ' . $this->db->escapeNumber($this->getStartingCredits()) .
123 121
 									' WHERE game_id = ' . $this->db->escapeNumber($this->getGameID()) . ' LIMIT 1');
124
-			}
125
-			else {
122
+			} else {
126 123
 				$this->db->query('INSERT INTO game (game_id,game_name,game_description,start_date,start_turns_date,end_date,max_players,max_turns,start_turns,game_type,credits_needed,game_speed,enabled,ignore_stats,alliance_max_players,alliance_max_vets,starting_credits)
127 124
 									VALUES
128 125
 									(' . $this->db->escapeNumber($this->getGameID()) .
Please login to merge, or discard this patch.
lib/Default/Template.class.inc 1 patch
Braces   +16 added lines, -32 removed lines patch added patch discarded remove patch
@@ -78,52 +78,39 @@  discard block
 block discarded – undo
78 78
 		$templateDir = TEMPLATES_DIR;
79 79
 		if (isset($this->data['ThisAccount']) && is_object($this->data['ThisAccount']) && $this->data['ThisAccount'] instanceof SmrAccount) {
80 80
 			$templateDir .= $this->data['ThisAccount']->getTemplate() . '/';
81
-		}
82
-		else {
81
+		} else {
83 82
 			$templateDir .= 'Default/';
84 83
 		}
85 84
 
86 85
 		if (SmrSession::hasGame()) {
87 86
 			$gameDir = Globals::getGameType(SmrSession::getGameID()) . '/';
88
-		}
89
-		else {
87
+		} else {
90 88
 			$gameDir = 'Default/';
91 89
 		}
92 90
 
93 91
 		if (file_exists($templateDir . 'engine/' . $gameDir . $templateName)) {
94 92
 			return $templateDir . 'engine/' . $gameDir . $templateName;
95
-		}
96
-		elseif (file_exists($templateDir . 'engine/Default/' . $templateName)) {
93
+		} elseif (file_exists($templateDir . 'engine/Default/' . $templateName)) {
97 94
 			return $templateDir . 'engine/Default/' . $templateName;
98
-		}
99
-		elseif (file_exists(TEMPLATES_DIR . 'Default/engine/' . $gameDir . $templateName)) {
95
+		} elseif (file_exists(TEMPLATES_DIR . 'Default/engine/' . $gameDir . $templateName)) {
100 96
 			return TEMPLATES_DIR . 'Default/engine/' . $gameDir . $templateName;
101
-		}
102
-		elseif (file_exists(TEMPLATES_DIR . 'Default/engine/Default/' . $templateName)) {
97
+		} elseif (file_exists(TEMPLATES_DIR . 'Default/engine/Default/' . $templateName)) {
103 98
 			return TEMPLATES_DIR . 'Default/engine/Default/' . $templateName;
104
-		}
105
-		elseif (file_exists($templateDir . 'admin/' . $gameDir . $templateName)) {
99
+		} elseif (file_exists($templateDir . 'admin/' . $gameDir . $templateName)) {
106 100
 			return $templateDir . 'admin/' . $gameDir . $templateName;
107
-		}
108
-		elseif (file_exists($templateDir . 'admin/Default/' . $templateName)) {
101
+		} elseif (file_exists($templateDir . 'admin/Default/' . $templateName)) {
109 102
 			return $templateDir . 'admin/Default/' . $templateName;
110
-		}
111
-		elseif (file_exists(TEMPLATES_DIR . 'Default/admin/' . $gameDir . $templateName)) {
103
+		} elseif (file_exists(TEMPLATES_DIR . 'Default/admin/' . $gameDir . $templateName)) {
112 104
 			return TEMPLATES_DIR . 'Default/admin/' . $gameDir . $templateName;
113
-		}
114
-		elseif (file_exists(TEMPLATES_DIR . 'Default/admin/Default/' . $templateName)) {
105
+		} elseif (file_exists(TEMPLATES_DIR . 'Default/admin/Default/' . $templateName)) {
115 106
 			return TEMPLATES_DIR . 'Default/admin/Default/' . $templateName;
116
-		}
117
-		elseif (file_exists($templateDir . $templateName)) {
107
+		} elseif (file_exists($templateDir . $templateName)) {
118 108
 			return $templateDir . $templateName;
119
-		}
120
-		elseif (file_exists(TEMPLATES_DIR . 'Default/' . $templateName)) {
109
+		} elseif (file_exists(TEMPLATES_DIR . 'Default/' . $templateName)) {
121 110
 			return TEMPLATES_DIR . 'Default/' . $templateName;
122
-		}
123
-		elseif (file_exists($templateDir . 'default.inc')) {
111
+		} elseif (file_exists($templateDir . 'default.inc')) {
124 112
 			return $templateDir.'default.inc';
125
-		}
126
-		else {
113
+		} else {
127 114
 			return TEMPLATES_DIR.'Default/default.inc';//return $file_name;
128 115
 		}
129 116
 	}
@@ -239,8 +226,7 @@  discard block
 block discarded – undo
239 226
 		for ($_i=0, $_count=count($replace); $_i<$_count; $_i++) {
240 227
 			if (($_pos=strpos($subject, $search_str, $_pos))!==false) {
241 228
 				$subject = substr_replace($subject, $replace[$_i], $_pos, $_len);
242
-			}
243
-			else {
229
+			} else {
244 230
 				break;
245 231
 			}
246 232
 		}
@@ -249,8 +235,7 @@  discard block
 block discarded – undo
249 235
 	protected function doDamageTypeReductionDisplay(&$damageTypes) {
250 236
 		if($damageTypes == 3) {
251 237
 			echo ', ';
252
-		}
253
-		else if($damageTypes == 2) {
238
+		} else if($damageTypes == 2) {
254 239
 			echo ' and ';
255 240
 		}
256 241
 		$damageTypes--;
@@ -260,8 +245,7 @@  discard block
 block discarded – undo
260 245
 		$char = strtoupper($wordAfter[0]);
261 246
 		if($char == 'A' || $char == 'E' || $char == 'I' || $char == 'O' || $char == 'U') {
262 247
 			echo 'an';
263
-		}
264
-		else {
248
+		} else {
265 249
 			echo 'a';
266 250
 		}
267 251
 	}
Please login to merge, or discard this patch.