Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Branch master (287493)
by Dan
06:08
created
engine/Default/rankings_race.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-$template->assign('PageTopic','Racial Standings');
3
+$template->assign('PageTopic', 'Racial Standings');
4 4
 
5 5
 Menu::rankings(2, 0);
6 6
 
Please login to merge, or discard this patch.
engine/Default/alliance_message_delete_processing.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@
 block discarded – undo
4 4
 }
5 5
 $alliance_id = $var['alliance_id'];
6 6
 
7
-if(isset($var['reply_id'])) {
7
+if (isset($var['reply_id'])) {
8 8
 	$db->query('DELETE FROM alliance_thread
9 9
 				WHERE game_id = ' . $db->escapeNumber($player->getGameID()) . '
10 10
 				AND alliance_id = ' . $db->escapeNumber($alliance_id) . '
Please login to merge, or discard this patch.
engine/Default/bounty_place.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-$template->assign('PageTopic','Place a Bounty');
3
+$template->assign('PageTopic', 'Place a Bounty');
4 4
 
5 5
 require_once(get_file_loc('menu_hq.inc'));
6 6
 if ($sector->hasHQ()) {
@@ -10,13 +10,13 @@  discard block
 block discarded – undo
10 10
 	create_ug_menu();
11 11
 }
12 12
 
13
-$container = create_container('skeleton.php','bounty_place_confirm.php');
13
+$container = create_container('skeleton.php', 'bounty_place_confirm.php');
14 14
 transfer('LocationID');
15 15
 $template->assign('SubmitHREF', SmrSession::getNewHREF($container));
16 16
 
17 17
 $bountyPlayers = [];
18 18
 $db->query('SELECT player_id, player_name FROM player JOIN account USING(account_id) WHERE game_id = ' . $db->escapeNumber($player->getGameID()) . ' AND account_id != ' . $db->escapeNumber($player->getAccountID()) . ' ORDER BY player_name');
19
-while($db->nextRecord()) {
19
+while ($db->nextRecord()) {
20 20
 	$bountyPlayers[$db->getInt('player_id')] = $db->getField('player_name');
21 21
 }
22 22
 $template->assign('BountyPlayers', $bountyPlayers);
Please login to merge, or discard this patch.
engine/Default/planet_attack.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -1,15 +1,15 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-if(isset($var['results'])) {
3
+if (isset($var['results'])) {
4 4
 	$results = unserialize($var['results']);
5
-	$template->assign('FullPlanetCombatResults',$results);
6
-	$template->assign('AlreadyDestroyed',false);
5
+	$template->assign('FullPlanetCombatResults', $results);
6
+	$template->assign('AlreadyDestroyed', false);
7 7
 }
8 8
 else
9
-	$template->assign('AlreadyDestroyed',true);
10
-$template->assign('MinimalDisplay',false);
11
-if(isset($var['override_death']))
12
-	$template->assign('OverrideDeath',true);
9
+	$template->assign('AlreadyDestroyed', true);
10
+$template->assign('MinimalDisplay', false);
11
+if (isset($var['override_death']))
12
+	$template->assign('OverrideDeath', true);
13 13
 else
14
-	$template->assign('OverrideDeath',false);
15
-$template->assign('Planet',SmrPlanet::getPlanet($player->getGameID(),$var['sector_id']));
14
+	$template->assign('OverrideDeath', false);
15
+$template->assign('Planet', SmrPlanet::getPlanet($player->getGameID(), $var['sector_id']));
Please login to merge, or discard this patch.
engine/Default/contact.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-$template->assign('PageTopic','Contact Form');
3
+$template->assign('PageTopic', 'Contact Form');
4 4
 
5 5
 $container = create_container('contact_processing.php');
6 6
 $template->assign('ProcessingHREF', SmrSession::getNewHREF($container));
Please login to merge, or discard this patch.
engine/Default/shop_ship.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@  discard block
 block discarded – undo
5 5
 
6 6
 $shipsSold = $location->getShipsSold();
7 7
 if ($shipsSold) {
8
-	$container = create_container('skeleton.php','shop_ship.php');
8
+	$container = create_container('skeleton.php', 'shop_ship.php');
9 9
 	transfer('LocationID');
10 10
 
11 11
 	foreach (array_keys($shipsSold) as $shipTypeID) {
@@ -13,18 +13,18 @@  discard block
 block discarded – undo
13 13
 		$shipsSoldHREF[$shipTypeID] = SmrSession::getNewHREF($container);
14 14
 	}
15 15
 }
16
-$template->assign('ShipsSold',$shipsSold);
17
-$template->assign('ShipsSoldHREF',$shipsSoldHREF);
16
+$template->assign('ShipsSold', $shipsSold);
17
+$template->assign('ShipsSoldHREF', $shipsSoldHREF);
18 18
 
19 19
 if (isset($var['ship_id'])) {
20 20
 	$compareShip = $shipsSold[$var['ship_id']];
21 21
 	$compareShip['RealSpeed'] = $compareShip['Speed'] * Globals::getGameSpeed($player->getGameID());
22
-	$compareShip['Turns'] = round($player->getTurns()*$compareShip['Speed']/$ship->getSpeed());
22
+	$compareShip['Turns'] = round($player->getTurns() * $compareShip['Speed'] / $ship->getSpeed());
23 23
 
24 24
 	$container = create_container('shop_ship_processing.php');
25 25
 	transfer('LocationID');
26 26
 	transfer('ship_id');
27 27
 	$compareShip['BuyHREF'] = SmrSession::getNewHREF($container);
28 28
 
29
-	$template->assign('CompareShip',$compareShip);
29
+	$template->assign('CompareShip', $compareShip);
30 30
 }
Please login to merge, or discard this patch.
engine/Default/error.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -9,10 +9,10 @@
 block discarded – undo
9 9
 	forward($container);
10 10
 }
11 11
 else {
12
-	$PHP_OUTPUT.=('<h1>ERROR</h1>');
13
-	$PHP_OUTPUT.=('<p><b><big>' . $var['message'] . '</big></b></p>');
14
-	$PHP_OUTPUT.=('<br /><br /><br />');
15
-	$PHP_OUTPUT.=('<p><small>If the error was caused by something you entered, press back and try again.</small></p>');
16
-	$PHP_OUTPUT.=('<p><small>If it was a DB Error, press back and try again, or logoff and log back on.</small></p>');
17
-	$PHP_OUTPUT.=('<p><small>If the error was unrecognizable, please notify the administrators.</small></p>');
12
+	$PHP_OUTPUT .= ('<h1>ERROR</h1>');
13
+	$PHP_OUTPUT .= ('<p><b><big>' . $var['message'] . '</big></b></p>');
14
+	$PHP_OUTPUT .= ('<br /><br /><br />');
15
+	$PHP_OUTPUT .= ('<p><small>If the error was caused by something you entered, press back and try again.</small></p>');
16
+	$PHP_OUTPUT .= ('<p><small>If it was a DB Error, press back and try again, or logoff and log back on.</small></p>');
17
+	$PHP_OUTPUT .= ('<p><small>If the error was unrecognizable, please notify the administrators.</small></p>');
18 18
 }
Please login to merge, or discard this patch.
engine/Default/alliance_stat_processing.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 if (!isset($var['alliance_id'])) {
3
-	SmrSession::updateVar('alliance_id',$player->getAllianceID());
3
+	SmrSession::updateVar('alliance_id', $player->getAllianceID());
4 4
 }
5 5
 $alliance_id = $var['alliance_id'];
6 6
 if (isset($_REQUEST['password'])) {
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 	$url = trim($_REQUEST['url']);
26 26
 }
27 27
 
28
-if(preg_match('/"/',$url)) {
28
+if (preg_match('/"/', $url)) {
29 29
 	create_error('You cannot use a " in the image link!');
30 30
 }
31 31
 
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 		$alliance->setDiscordChannel(null);
49 49
 	} else {
50 50
 		// no duplicates in a given game
51
-		$db->query('SELECT * FROM alliance WHERE discord_channel =' .$db->escapeString($discordChannel) .' AND game_id = '.$db->escapeNumber($alliance->getGameID()).' AND alliance_id != '.$db->escapeNumber($alliance->getAllianceID()).' LIMIT 1');
51
+		$db->query('SELECT * FROM alliance WHERE discord_channel =' . $db->escapeString($discordChannel) . ' AND game_id = ' . $db->escapeNumber($alliance->getGameID()) . ' AND alliance_id != ' . $db->escapeNumber($alliance->getAllianceID()) . ' LIMIT 1');
52 52
 		if ($db->nextRecord()) create_error('Another alliance is already using that Discord Channel ID!');
53 53
 
54 54
 		$alliance->setDiscordChannel($discordChannel);
Please login to merge, or discard this patch.
engine/Default/feature_request_comment_processing.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@
 block discarded – undo
5 5
 
6 6
 // add this feature comment
7 7
 $db->query('INSERT INTO feature_request_comments (feature_request_id, poster_id, posting_time, anonymous, text)
8
-			VALUES(' . $db->escapeNumber($var['RequestID']) . ', ' . $db->escapeNumber($account->getAccountID()) . ',' . $db->escapeNumber(TIME) . ',' . $db->escapeBoolean(isset($_REQUEST['anon'])) . ',' . $db->escapeString(word_filter($_REQUEST['comment'])).')');
8
+			VALUES(' . $db->escapeNumber($var['RequestID']) . ', ' . $db->escapeNumber($account->getAccountID()) . ',' . $db->escapeNumber(TIME) . ',' . $db->escapeBoolean(isset($_REQUEST['anon'])) . ',' . $db->escapeString(word_filter($_REQUEST['comment'])) . ')');
9 9
 
10 10
 $container = $var;
11 11
 $container['url'] = 'skeleton.php';
Please login to merge, or discard this patch.