smrealms / smr

engine/Default/message_notify_confirm.php

Spacing +3 added lines, -3 removed lines

@@ -1,10 +1,10 @@
 <?php
 
-$template->assign('PageTopic','Report a Message');
+$template->assign('PageTopic', 'Report a Message');
 Menu::messages();
 
-if(!isset($var['notified_time']))
-	SmrSession::updateVar('notified_time',TIME);
+if (!isset($var['notified_time']))
+	SmrSession::updateVar('notified_time', TIME);
 
 if (empty($var['message_id']))
 	create_error('Please click the small yellow icon to report a message!');

engine/Default/galactic_post_paper_edit.php

Spacing +8 added lines, -8 removed lines

@@ -1,24 +1,24 @@
 <?php
 
 $db2 = new SmrMySqlDatabase();
-$db->query('SELECT * FROM galactic_post_paper WHERE paper_id = '.$db->escapeNumber($var['id']).' AND game_id = ' . $db->escapeNumber($player->getGameID()));
+$db->query('SELECT * FROM galactic_post_paper WHERE paper_id = ' . $db->escapeNumber($var['id']) . ' AND game_id = ' . $db->escapeNumber($player->getGameID()));
 $db->nextRecord();
 $paper_title = bbifyMessage($db->getField('title'));
-$db->query('SELECT * FROM galactic_post_paper_content WHERE paper_id = '.$db->escapeNumber($var['id']).' AND game_id = ' . $db->escapeNumber($player->getGameID()));
+$db->query('SELECT * FROM galactic_post_paper_content WHERE paper_id = ' . $db->escapeNumber($var['id']) . ' AND game_id = ' . $db->escapeNumber($player->getGameID()));
 Menu::galactic_post();
 
-$PHP_OUTPUT.=($paper_title.'<br /><br /><ul>');
+$PHP_OUTPUT .= ($paper_title . '<br /><br /><ul>');
 while ($db->nextRecord()) {
 	$db2->query('SELECT * FROM galactic_post_article WHERE game_id = ' . $db->escapeNumber($player->getGameID()) . ' AND article_id = ' . $db->escapeNumber($db->getInt('article_id')));
 	$db2->nextRecord();
-	$PHP_OUTPUT.='<li>'.bbifyMessage($db2->getField('title')).'<br /><li>'.bbifyMessage($db2->getField('text')).'<br /></li>';
+	$PHP_OUTPUT .= '<li>' . bbifyMessage($db2->getField('title')) . '<br /><li>' . bbifyMessage($db2->getField('text')) . '<br /></li>';
 	$container = create_container('galactic_post_paper_edit_processing.php');
 	$container['article_id'] = $db->getField('article_id');
 	transfer('id');
-	$PHP_OUTPUT.=create_link($container, 'Remove this article from '.$paper_title.'</li>');
-	$PHP_OUTPUT.=('<br /><br />');
+	$PHP_OUTPUT .= create_link($container, 'Remove this article from ' . $paper_title . '</li>');
+	$PHP_OUTPUT .= ('<br /><br />');
 
 }
-$PHP_OUTPUT.=('</ul>');
+$PHP_OUTPUT .= ('</ul>');
 if (!$db->getNumRows())
-	$PHP_OUTPUT.=('This paper has no articles');
+	$PHP_OUTPUT .= ('This paper has no articles');

engine/Default/shop_gadget.php

Spacing +10 added lines, -10 removed lines

@@ -8,7 +8,7 @@ 
 //////////////////////////////////////////////////
 
 if (!in_array($var['loc_id'], $SECTOR[$THIS_PLAYER->getSectorID()]['Locations'])) {
-	$error .= get_status_message('red','Error','That shop does not exist in this sector!');
+	$error .= get_status_message('red', 'Error', 'That shop does not exist in this sector!');
 	require($GAME_FILES . '/error.php');
 	return;
 }
@@ -18,7 +18,7 @@ 
 foreach ($GADGETS as $gad_name => $gad_arr) $rev_gad[$gad_arr['ID']] = $gad_name;
 
 print_title('Browsing Gadgets');
-$PHP_OUTPUT.= '<br />';
+$PHP_OUTPUT .= '<br />';
 print_error($error);
 
 $this_shop_sells = $SHOP_SELLS_GADGET[$var['loc_id']];
@@ -26,7 +26,7 @@ 
 if (is_array($SHOP_SELLS_GADGET_SPECIAL[$var['loc_id']])) {
 	foreach ($SHOP_SELLS_GADGET_SPECIAL[$var['loc_id']] as $gad_id => $require_array) {
 		
-		if (checkHardwareRequirements($require_array,$THIS_SECTOR,$THIS_PLAYER,$THIS_SHIP))
+		if (checkHardwareRequirements($require_array, $THIS_SECTOR, $THIS_PLAYER, $THIS_SHIP))
 			$this_shop_sells[] = $gad_id;
 	}
 }
@@ -34,11 +34,11 @@ 
 else $special_stock = FALSE;
 
 if (sizeof($this_shop_sells) > 0) {
-	if ($special_stock) $PHP_OUTPUT.= 'It looks like you have access to some of our special stock.<br />';
-	$PHP_OUTPUT.= '<table class="standard"><tr><th>Name</th><th>Cost</th><th>Action</th></tr>';
+	if ($special_stock) $PHP_OUTPUT .= 'It looks like you have access to some of our special stock.<br />';
+	$PHP_OUTPUT .= '<table class="standard"><tr><th>Name</th><th>Cost</th><th>Action</th></tr>';
 	foreach ($this_shop_sells as $gad_id) {
-		$PHP_OUTPUT.= '<tr><td>'.$rev_gad[$gad_id].'</td><td>'.number_format($GADGETS[$rev_gad[$gad_id]]['Cost']).'</td><td>';
-		if ($THIS_PLAYER->getGadget($gad_id)!==false) $PHP_OUTPUT.= 'Already Owned';
+		$PHP_OUTPUT .= '<tr><td>' . $rev_gad[$gad_id] . '</td><td>' . number_format($GADGETS[$rev_gad[$gad_id]]['Cost']) . '</td><td>';
+		if ($THIS_PLAYER->getGadget($gad_id) !== false) $PHP_OUTPUT .= 'Already Owned';
 		else {
 			$link = array();
 			$link['body'] = 'shop_gadget.php';
@@ -49,10 +49,10 @@ 
 			$link['gad_id'] = $gad_id;
 			create_button($link, $id);
 		}
-		$PHP_OUTPUT.= '</td></tr>';
+		$PHP_OUTPUT .= '</td></tr>';
 	}
-	$PHP_OUTPUT.= '</table>';
+	$PHP_OUTPUT .= '</table>';
 }
 else {
-	$PHP_OUTPUT.= 'We\'ve got nothing for you here! Get outta here!<br />';
+	$PHP_OUTPUT .= 'We\'ve got nothing for you here! Get outta here!<br />';
 }

engine/Default/alliance_invite_player_processing.php

Spacing +4 added lines, -4 removed lines

@@ -11,7 +11,7 @@ 
 
 // If sender is mail banned or blacklisted by receiver, omit the custom message
 $db->query('SELECT 1 FROM message_blacklist
-            WHERE account_id='.$db->escapeNumber($receiverID).'
+            WHERE account_id='.$db->escapeNumber($receiverID) . '
               AND blacklisted_id='.$db->escapeNumber($player->getAccountID()));
 if ($db->nextRecord() || $account->isMailBanned()) {
 	$addMessage = '';
@@ -19,10 +19,10 @@ 
 
 // Construct the mail to send to the receiver
 $msg = 'You have been invited to join an alliance!
-This invitation will remain open for '.$expireDays.' '.pluralise('day', $expireDays).' or until you join another alliance.
+This invitation will remain open for '.$expireDays . ' ' . pluralise('day', $expireDays) . ' or until you join another alliance.
 If you are currently in an alliance, you will leave it if you accept this invitation.
 
-[join_alliance='.$player->getAllianceID().']
+[join_alliance='.$player->getAllianceID() . ']
 ';
 if (!empty($addMessage)) {
 	$msg .= '<br />' . $addMessage;
@@ -32,7 +32,7 @@ 
 $player->sendMessage($receiverID, MSG_PLAYER, $msg, false, true, $expires, true);
 
 // Record invitation in the database
-$db->query('INSERT INTO alliance_invites_player (game_id, account_id, alliance_id, invited_by_id, expires) VALUES('.$db->escapeNumber($player->getGameID()).', '.$db->escapeNumber($receiverID).', '.$db->escapeNumber($player->getAllianceID()).', '.$db->escapeNumber($player->getAccountID()).', '.$db->escapeNumber($expires).')');
+$db->query('INSERT INTO alliance_invites_player (game_id, account_id, alliance_id, invited_by_id, expires) VALUES(' . $db->escapeNumber($player->getGameID()) . ', ' . $db->escapeNumber($receiverID) . ', ' . $db->escapeNumber($player->getAllianceID()) . ', ' . $db->escapeNumber($player->getAccountID()) . ', ' . $db->escapeNumber($expires) . ')');
 
 $container = create_container('skeleton.php', 'alliance_invite_player.php');
 forward($container);

engine/Default/history_games.php

Spacing +8 added lines, -8 removed lines

@@ -6,12 +6,12 @@ 
 }
 $game_name = $var['game_name'];
 $game_id = $var['view_game_id'];
-$template->assign('PageTopic','Old SMR Game : '.$game_name);
+$template->assign('PageTopic', 'Old SMR Game : ' . $game_name);
 Menu::history_games(0);
 
 $db = new $var['HistoryDatabase']();
 $db->query('SELECT start_date, type, end_date, game_name, speed, game_id ' .
-           'FROM game WHERE game_id = '.$db->escapeNumber($game_id));
+           'FROM game WHERE game_id = ' . $db->escapeNumber($game_id));
 $db->nextRecord();
 $template->assign('GameName', $game_name);
 $template->assign('Start', date(DATE_DATE_SHORT, $db->getField('start_date')));
@@ -19,7 +19,7 @@ 
 $template->assign('Type', $db->getField('type'));
 $template->assign('Speed', $db->getField('speed'));
 
-$db->query('SELECT count(*), max(experience), max(alignment), min(alignment), max(kills) FROM player WHERE game_id = '.$db->escapeNumber($game_id));
+$db->query('SELECT count(*), max(experience), max(alignment), min(alignment), max(kills) FROM player WHERE game_id = ' . $db->escapeNumber($game_id));
 if ($db->nextRecord()) {
 	$template->assign('NumPlayers', $db->getInt('count(*)'));
 	$template->assign('MaxExp', $db->getInt('max(experience)'));
@@ -27,12 +27,12 @@ 
 	$template->assign('MinAlign', $db->getInt('min(alignment)'));
 	$template->assign('MaxKills', $db->getInt('max(kills)'));
 }
-$db->query('SELECT count(*) FROM alliance WHERE game_id = '.$db->escapeNumber($game_id));
+$db->query('SELECT count(*) FROM alliance WHERE game_id = ' . $db->escapeNumber($game_id));
 $db->nextRecord();
 $template->assign('NumAlliances', $db->getInt('count(*)'));
 
 $playerExp = [];
-$db->query('SELECT * FROM player WHERE game_id = '.$db->escapeNumber($game_id).' ORDER BY experience DESC LIMIT 10');
+$db->query('SELECT * FROM player WHERE game_id = ' . $db->escapeNumber($game_id) . ' ORDER BY experience DESC LIMIT 10');
 while ($db->nextRecord()) {
 	$playerExp[] = [
 		'exp' => $db->getField('experience'),
@@ -42,7 +42,7 @@ 
 $template->assign('PlayerExp', $playerExp);
 
 $playerKills = [];
-$db->query('SELECT * FROM player WHERE game_id = '.$db->escapeNumber($game_id).' ORDER BY kills DESC LIMIT 10');
+$db->query('SELECT * FROM player WHERE game_id = ' . $db->escapeNumber($game_id) . ' ORDER BY kills DESC LIMIT 10');
 while ($db->nextRecord()) {
 	$playerKills[] = [
 		'kills' => $db->getField('kills'),
@@ -59,7 +59,7 @@ 
 $allianceExp = [];
 $db->query('SELECT SUM(experience) as exp, alliance_name, alliance_id
 			FROM player JOIN alliance USING (game_id, alliance_id)
-			WHERE game_id = '.$db->escapeNumber($game_id).' GROUP BY alliance_id ORDER BY exp DESC LIMIT 10');
+			WHERE game_id = '.$db->escapeNumber($game_id) . ' GROUP BY alliance_id ORDER BY exp DESC LIMIT 10');
 while ($db->nextRecord()) {
 	$alliance = stripslashes($db->getField('alliance_name'));
 	$id = $db->getField('alliance_id');
@@ -72,7 +72,7 @@ 
 $template->assign('AllianceExp', $allianceExp);
 
 $allianceKills = [];
-$db->query('SELECT kills, alliance_name, alliance_id FROM alliance WHERE game_id = '.$db->escapeNumber($game_id).' ORDER BY kills DESC LIMIT 10');
+$db->query('SELECT kills, alliance_name, alliance_id FROM alliance WHERE game_id = ' . $db->escapeNumber($game_id) . ' ORDER BY kills DESC LIMIT 10');
 while ($db->nextRecord()) {
 	$alliance = stripslashes($db->getField('alliance_name'));
 	$id = $db->getField('alliance_id');

engine/Default/chess_move_processing.php

Spacing +7 added lines, -7 removed lines

@@ -1,17 +1,17 @@
 <?php
 
-$chessGame =& ChessGame::getChessGame($var['ChessGameID']);
-$template->assign('ChessGame',$chessGame);
-if(is_numeric($_REQUEST['x']) && is_numeric($_REQUEST['y']) && is_numeric($_REQUEST['toX']) && is_numeric($_REQUEST['toY'])) {
+$chessGame = & ChessGame::getChessGame($var['ChessGameID']);
+$template->assign('ChessGame', $chessGame);
+if (is_numeric($_REQUEST['x']) && is_numeric($_REQUEST['y']) && is_numeric($_REQUEST['toX']) && is_numeric($_REQUEST['toY'])) {
 	$x = $_REQUEST['x'];
 	$y = $_REQUEST['y'];
 	$toX = $_REQUEST['toX'];
 	$toY = $_REQUEST['toY'];
-	if(!$chessGame->hasEnded()) {
-		if($chessGame->isCurrentTurn($account->getAccountID())) {
+	if (!$chessGame->hasEnded()) {
+		if ($chessGame->isCurrentTurn($account->getAccountID())) {
 			$board = $chessGame->getBoard();
-			if($board[$y][$x] != null) {
-				switch($chessGame->tryMove($x, $y, $toX, $toY, $account->getAccountID(), ChessPiece::QUEEN)) {
+			if ($board[$y][$x] != null) {
+				switch ($chessGame->tryMove($x, $y, $toX, $toY, $account->getAccountID(), ChessPiece::QUEEN)) {
 					case 0:
 						//Success
 					break;

engine/Default/galactic_post.php

Spacing +25 added lines, -25 removed lines

@@ -1,60 +1,60 @@
 <?php
 
-$template->assign('PageTopic','Galactic Post');
+$template->assign('PageTopic', 'Galactic Post');
 if ($player->isGPEditor()) {
 	$db2 = new SmrMySqlDatabase();
 	Menu::galactic_post();
 
-	$PHP_OUTPUT.=('Welcome '.$player->getPlayerName().', your position is <i>Editor</i><br /><br />');
-	$PHP_OUTPUT.=('<b>EDITOR OPTIONS<br /></b>');
-	$PHP_OUTPUT.=create_link(create_container('skeleton.php', 'galactic_post_view_applications.php'), 'View the applications');
-	$PHP_OUTPUT.=('<br />');
-	$PHP_OUTPUT.=create_link(create_container('skeleton.php', 'galactic_post_view_article.php'), 'View the articles');
-	$PHP_OUTPUT.=('<br />');
-	$PHP_OUTPUT.=create_link(create_container('skeleton.php', 'galactic_post_make_paper.php'), 'Make a paper');
-	$PHP_OUTPUT.=('<br />');
-	$PHP_OUTPUT.=create_link(create_container('skeleton.php', 'galactic_post_view_members.php'), 'View Members');
-	$PHP_OUTPUT.=('<br /><br />');
+	$PHP_OUTPUT .= ('Welcome ' . $player->getPlayerName() . ', your position is <i>Editor</i><br /><br />');
+	$PHP_OUTPUT .= ('<b>EDITOR OPTIONS<br /></b>');
+	$PHP_OUTPUT .= create_link(create_container('skeleton.php', 'galactic_post_view_applications.php'), 'View the applications');
+	$PHP_OUTPUT .= ('<br />');
+	$PHP_OUTPUT .= create_link(create_container('skeleton.php', 'galactic_post_view_article.php'), 'View the articles');
+	$PHP_OUTPUT .= ('<br />');
+	$PHP_OUTPUT .= create_link(create_container('skeleton.php', 'galactic_post_make_paper.php'), 'Make a paper');
+	$PHP_OUTPUT .= ('<br />');
+	$PHP_OUTPUT .= create_link(create_container('skeleton.php', 'galactic_post_view_members.php'), 'View Members');
+	$PHP_OUTPUT .= ('<br /><br />');
 	$db->query('SELECT * FROM galactic_post_paper WHERE game_id = ' . $db->escapeNumber($player->getGameID()));
 	if ($db->getNumRows()) {
-		$PHP_OUTPUT.=('The following papers are already made (papers must have 3-8 articles to go to the press):<br /><br />');
+		$PHP_OUTPUT .= ('The following papers are already made (papers must have 3-8 articles to go to the press):<br /><br />');
 	}
-	while($db->nextRecord()) {
+	while ($db->nextRecord()) {
 		$paper_name = $db->getField('title');
 		$paper_id = $db->getField('paper_id');
 		$published = $db->getInt('online_since');
 
-		$PHP_OUTPUT.=('<span class="red">***</span><i>'.$paper_name.'</i>');
+		$PHP_OUTPUT .= ('<span class="red">***</span><i>' . $paper_name . '</i>');
 		$db2->query('SELECT * FROM galactic_post_paper_content WHERE paper_id = ' . $db2->escapeNumber($paper_id) . ' AND game_id = ' . $db->escapeNumber($player->getGameID()));
 		$hasEnoughArticles = $db2->getNumRows() > 2 && $db2->getNumRows() < 9;
 
 		// Use red/green to show if a paper has enough articles
-		$PHP_OUTPUT.=(' which contains <span class="' . ($hasEnoughArticles ? "green" : "red") . '"> ' . $db2->getNumRows() . ' </span>articles. ');
+		$PHP_OUTPUT .= (' which contains <span class="' . ($hasEnoughArticles ? "green" : "red") . '"> ' . $db2->getNumRows() . ' </span>articles. ');
 		if (!empty($published)) {
-			$PHP_OUTPUT.=('<span class="bold green">PUBLISHED!</span>');
+			$PHP_OUTPUT .= ('<span class="bold green">PUBLISHED!</span>');
 		} else if ($hasEnoughArticles) {
 			$container = array();
 			$container['url'] = 'galactic_post_make_current.php';
 			$container['id'] = $paper_id;
-			$PHP_OUTPUT.=create_link($container, '<b>HIT THE PRESS!</b>');
+			$PHP_OUTPUT .= create_link($container, '<b>HIT THE PRESS!</b>');
 		}
 
-		$PHP_OUTPUT.=('<br />');
+		$PHP_OUTPUT .= ('<br />');
 		$container = array();
 		$container['url'] = 'skeleton.php';
 		$container['body'] = 'galactic_post_delete_confirm.php';
 		$container['paper'] = 'yes';
 		$container['id'] = $paper_id;
-		$PHP_OUTPUT.=create_link($container, 'Delete '.$paper_name);
-		$PHP_OUTPUT.=('<br />');
+		$PHP_OUTPUT .= create_link($container, 'Delete ' . $paper_name);
+		$PHP_OUTPUT .= ('<br />');
 		$container = array();
 		$container['url'] = 'skeleton.php';
 		$container['body'] = 'galactic_post_paper_edit.php';
 		$container['id'] = $paper_id;
-		$PHP_OUTPUT.=create_link($container, 'Edit '.$paper_name);
-		$PHP_OUTPUT.=('<br /><br />');
+		$PHP_OUTPUT .= create_link($container, 'Edit ' . $paper_name);
+		$PHP_OUTPUT .= ('<br /><br />');
 	}
-	$PHP_OUTPUT.=('<br />');
-	$PHP_OUTPUT.=('<span class="blue">If you wish to edit an article you must first view it.</span>');
-	$PHP_OUTPUT.=('<br /><br />');
+	$PHP_OUTPUT .= ('<br />');
+	$PHP_OUTPUT .= ('<span class="blue">If you wish to edit an article you must first view it.</span>');
+	$PHP_OUTPUT .= ('<br /><br />');
 }

engine/Default/port_loot_processing.php

Spacing +3 added lines, -3 removed lines

@@ -23,10 +23,10 @@
 if ($player->getTurns() == 0)
    create_error('You don\'t have enough turns to loot.');
 
-$account->log(LOG_TYPE_TRADING, 'Player Loots '.$amount.' '.$good_name, $player->getSectorID());
+$account->log(LOG_TYPE_TRADING, 'Player Loots ' . $amount . ' ' . $good_name, $player->getSectorID());
 $container = create_container('skeleton.php', 'port_loot.php');
-$ship->increaseCargo($good_id,$amount);
+$ship->increaseCargo($good_id, $amount);
 $ship->updateCargo();
-$port->decreaseGoodAmount($good_id,$amount);
+$port->decreaseGoodAmount($good_id, $amount);
 $port->update();
 forward($container);

engine/Default/donation.php

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-$template->assign('PageTopic','Donations');
+$template->assign('PageTopic', 'Donations');
 $db->query('SELECT SUM(amount) as total_donation FROM account_donated WHERE time > ' . $db->escapeNumber(TIME) . ' - (86400 * 90)');
 if ($db->nextRecord())
 	$template->assign('TotalDonation', $db->getField('total_donation'));