smrealms / smr

engine/Default/combat_log_list_processing.php

Spacing +2 added lines, -2 removed lines

@@ -14,7 +14,7 @@ 
 
 // Do we need to save any logs (or delete any saved logs)?
 if ($submitAction == 'Save' || $submitAction == 'Delete') {
-	if($submitAction == 'Save') {
+	if ($submitAction == 'Save') {
 		//save the logs we checked
 		// Query means people can only save logs that they are allowd to view.
 		$db->query('INSERT IGNORE INTO player_saved_combat_logs (account_id, game_id, log_id)
@@ -32,7 +32,7 @@ 
 						)
 					LIMIT ' . count($logIDs));
 	}
-	else if($submitAction == 'Delete') {
+	else if ($submitAction == 'Delete') {
 		$db->query('DELETE FROM player_saved_combat_logs
 					WHERE log_id IN (' . $db->escapeArray($logIDs) . ')
 						AND account_id = ' . $db->escapeNumber($player->getAccountID()) . '

engine/Default/feature_request_processing.php

Spacing +3 added lines, -3 removed lines

@@ -3,7 +3,7 @@ 
 if (empty($_REQUEST['feature'])) {
 	create_error('We need at least a feature desciption!');
 }
-if(strlen($_REQUEST['feature']) > 500) {
+if (strlen($_REQUEST['feature']) > 500) {
 	create_error('Feature request longer than 500 characters, please be more concise!');
 }
 
@@ -11,9 +11,9 @@ 
 $db->query('INSERT INTO feature_request (feature_request_id) VALUES (NULL)');
 $featureRequestID = $db->getInsertID();
 $db->query('INSERT INTO feature_request_comments (feature_request_id, poster_id, posting_time, anonymous, text) ' .
-								'VALUES(' . $db->escapeNumber($featureRequestID) . ', ' . $db->escapeNumber($account->getAccountID()) . ',' . $db->escapeNumber(TIME) . ',' . $db->escapeBoolean(isset($_REQUEST['anon'])) . ',' . $db->escapeString(word_filter($_REQUEST['feature'])).')');
+								'VALUES(' . $db->escapeNumber($featureRequestID) . ', ' . $db->escapeNumber($account->getAccountID()) . ',' . $db->escapeNumber(TIME) . ',' . $db->escapeBoolean(isset($_REQUEST['anon'])) . ',' . $db->escapeString(word_filter($_REQUEST['feature'])) . ')');
 
 // vote for this feature
-$db->query('INSERT INTO account_votes_for_feature VALUES('.$db->escapeNumber($account->getAccountID()).', '.$db->escapeNumber($featureRequestID).',\'YES\')');
+$db->query('INSERT INTO account_votes_for_feature VALUES(' . $db->escapeNumber($account->getAccountID()) . ', ' . $db->escapeNumber($featureRequestID) . ',\'YES\')');
 
 forward(create_container('skeleton.php', 'feature_request.php'));

engine/Default/bar_lotto_buy_processing.php

Spacing +5 added lines, -5 removed lines

@@ -17,16 +17,16 @@
 
 $db->query('INSERT INTO player_has_ticket (game_id, account_id, time) VALUES (' . $db->escapeNumber($player->getGameID()) . ', ' . $db->escapeNumber($player->getAccountID()) . ', ' . $db->escapeNumber($time) . ')');
 $player->decreaseCredits(1000000);
-$player->increaseHOF(1000000,array('Bar','Lotto', 'Money', 'Spent'), HOF_PUBLIC);
-$player->increaseHOF(1,array('Bar','Lotto', 'Tickets Bought'), HOF_PUBLIC);
+$player->increaseHOF(1000000, array('Bar', 'Lotto', 'Money', 'Spent'), HOF_PUBLIC);
+$player->increaseHOF(1, array('Bar', 'Lotto', 'Tickets Bought'), HOF_PUBLIC);
 $db->query('SELECT count(*) as num FROM player_has_ticket WHERE game_id = ' . $db->escapeNumber($player->getGameID()) . '
 	AND account_id = ' . $db->escapeNumber($player->getAccountID()) . ' AND time > 0 GROUP BY account_id');
 $db->nextRecord();
 $num = $db->getInt('num');
-$message=('<div align=center>Thanks for your purchase and good luck!  You currently');
-$message.=(' own '.$num.' '.pluralise('ticket', $num).'!</div><br />');
+$message = ('<div align=center>Thanks for your purchase and good luck!  You currently');
+$message .= (' own ' . $num . ' ' . pluralise('ticket', $num) . '!</div><br />');
 
-$container=create_container('skeleton.php','bar_main.php');
+$container = create_container('skeleton.php', 'bar_main.php');
 transfer('LocationID');
 $container['message'] = $message;
 forward($container);

engine/Default/bank_anon_detail_processing.php

Spacing +2 added lines, -2 removed lines

@@ -31,7 +31,7 @@ 
 	$player->update();
 
 	// log action
-	$account->log(LOG_TYPE_BANK, 'Deposits '.$amount.' credits in anonymous account #'.$account_num, $player->getSectorID());
+	$account->log(LOG_TYPE_BANK, 'Deposits ' . $amount . ' credits in anonymous account #' . $account_num, $player->getSectorID());
 }
 else {
 	$db->query('SELECT * FROM anon_bank WHERE anon_id = ' . $db->escapeNumber($account_num) . ' AND game_id = ' . $db->escapeNumber($player->getGameID()));
@@ -52,7 +52,7 @@ 
 	$player->update();
 
 	// log action
-	$account->log(LOG_TYPE_BANK, 'Takes '.$amount.' credits from anonymous account #'.$account_num, $player->getSectorID());
+	$account->log(LOG_TYPE_BANK, 'Takes ' . $amount . ' credits from anonymous account #' . $account_num, $player->getSectorID());
 }
 
 $container = create_container('skeleton.php', 'bank_anon_detail.php');

engine/Default/death.php

Spacing +1 added lines, -1 removed lines

@@ -1,2 +1,2 @@
 <?php
-$template->assign('PageTopic','Death');
+$template->assign('PageTopic', 'Death');

engine/Default/history_games_news.php

Spacing +2 added lines, -2 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-$template->assign('PageTopic', 'Game News : '.$var['game_name']);
+$template->assign('PageTopic', 'Game News : ' . $var['game_name']);
 Menu::history_games(3);
 
 if (isset($_REQUEST['min'])) $min = $_REQUEST['min'];
@@ -13,7 +13,7 @@ 
 $template->assign('ShowHREF', SmrSession::getNewHREF($var));
 
 $db = new $var['HistoryDatabase']();
-$db->query('SELECT * FROM news WHERE game_id = '.$db->escapeNumber($var['view_game_id']).' AND news_id >= '.$db->escapeNumber($min).' AND news_id <= '.$db->escapeNumber($max));
+$db->query('SELECT * FROM news WHERE game_id = ' . $db->escapeNumber($var['view_game_id']) . ' AND news_id >= ' . $db->escapeNumber($min) . ' AND news_id <= ' . $db->escapeNumber($max));
 $rows = [];
 while ($db->nextRecord()) {
 	$rows[] = [

engine/Default/history_games_detail.php

Spacing +3 added lines, -3 removed lines

@@ -1,7 +1,7 @@ 
 <?php
 
 $game_id = $var['view_game_id'];
-$template->assign('PageTopic', 'Extended Stats : '.$var['game_name']);
+$template->assign('PageTopic', 'Extended Stats : ' . $var['game_name']);
 Menu::history_games(1);
 
 $container = $var;
@@ -30,7 +30,7 @@ 
 	$db = new $var['HistoryDatabase']();
 	if ($from != 'alliance') {
 		$template->assign('Name', 'Sector ID');
-		$db->query('SELECT '.$sql.' as val, sector_id FROM '.$from.' WHERE game_id = '.$db->escapeNumber($game_id).' ORDER BY val DESC LIMIT 25');
+		$db->query('SELECT ' . $sql . ' as val, sector_id FROM ' . $from . ' WHERE game_id = ' . $db->escapeNumber($game_id) . ' ORDER BY val DESC LIMIT 25');
 		while ($db->nextRecord()) {
 			$rankings[] = [
 				'name' => $db->getInt('sector_id'),
@@ -40,7 +40,7 @@ 
 	}
 	else {
 		$template->assign('Name', 'Alliance');
-		$db->query('SELECT alliance_name, alliance_id, '.$sql.' as val FROM alliance WHERE game_id = '.$db->escapeNumber($game_id).' AND alliance_id > 0 GROUP BY alliance_id ORDER BY val DESC, alliance_id LIMIT 25');
+		$db->query('SELECT alliance_name, alliance_id, ' . $sql . ' as val FROM alliance WHERE game_id = ' . $db->escapeNumber($game_id) . ' AND alliance_id > 0 GROUP BY alliance_id ORDER BY val DESC, alliance_id LIMIT 25');
 		$container = $var;
 		$container['body'] = 'history_alliance_detail.php';
 		$container['selected_index'] = 1;

engine/Default/album_edit.php

Spacing +9 added lines, -9 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-$template->assign('PageTopic','Edit Photo');
+$template->assign('PageTopic', 'Edit Photo');
 
 $db->query('SELECT * FROM album WHERE account_id = ' . $db->escapeNumber($account->getAccountID()));
 if ($db->nextRecord()) {
@@ -13,23 +13,23 @@ 
 	$approved = $db->getField('approved');
 
 	if ($approved == 'TBC') {
-		$albumEntry['Status']=('<span style="color:orange;">Waiting approval</span>');
+		$albumEntry['Status'] = ('<span style="color:orange;">Waiting approval</span>');
 	}
 	elseif ($approved == 'NO') {
-		$albumEntry['Status']=('<span class="red">Approval denied</span>');
+		$albumEntry['Status'] = ('<span class="red">Approval denied</span>');
 	}
 	elseif ($db->getBoolean('disabled')) {
-		$albumEntry['Status']=('<span class="red">Disabled</span>');
+		$albumEntry['Status'] = ('<span class="red">Disabled</span>');
 	}
 	elseif ($approved == 'YES') {
-		$albumEntry['Status']=('<a href="album/?'.$account->getHofName().'" class="dgreen">Online</a>');
+		$albumEntry['Status'] = ('<a href="album/?' . $account->getHofName() . '" class="dgreen">Online</a>');
 	}
 		
-	if(is_readable(UPLOAD . $account->getAccountID())) {
-		$albumEntry['Image'] = '/upload/'.$account->getAccountID();
+	if (is_readable(UPLOAD . $account->getAccountID())) {
+		$albumEntry['Image'] = '/upload/' . $account->getAccountID();
 	}
 	
-	$template->assign('AlbumEntry',$albumEntry);
+	$template->assign('AlbumEntry', $albumEntry);
 }
 
-$template->assign('AlbumEditHref',SmrSession::getNewHREF(create_container('album_edit_processing.php', '')));
+$template->assign('AlbumEditHref', SmrSession::getNewHREF(create_container('album_edit_processing.php', '')));

engine/Default/port_attack_warning.php

Spacing +4 added lines, -4 removed lines

@@ -1,14 +1,14 @@
 <?php
 
-if(!$sector->hasPort()) {
+if (!$sector->hasPort()) {
 	create_error('This sector does not have a port.');
 }
 
-if($sector->getPort()->isDestroyed()) {
+if ($sector->getPort()->isDestroyed()) {
 	forward(create_container('skeleton.php', 'port_attack.php'));
 }
 
-$template->assign('PageTopic','Port Raid');
+$template->assign('PageTopic', 'Port Raid');
 
-$template->assign('PortAttackHREF',SmrSession::getNewHREF(create_container('port_attack_processing.php')));
+$template->assign('PortAttackHREF', SmrSession::getNewHREF(create_container('port_attack_processing.php')));
 $template->assign('Port', $sector->getPort());