Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Branch master (287493)
by Dan
06:08
created
engine/Default/forces_list.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-$template->assign('PageTopic','View Forces');
3
+$template->assign('PageTopic', 'View Forces');
4 4
 
5 5
 $db->query('SELECT *
6 6
 			FROM sector_has_forces
7 7
 			WHERE owner_id = ' . $db->escapeNumber($player->getAccountID()) . '
8 8
 			AND game_id = ' . $db->escapeNumber($player->getGameID()) . '
9
-			AND expire_time >= '.$db->escapeNumber(TIME).'
9
+			AND expire_time >= '.$db->escapeNumber(TIME) . '
10 10
 			ORDER BY sector_id ASC');
11 11
 
12 12
 $forces = array();
Please login to merge, or discard this patch.
engine/Default/alliance_invite_player.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
 // Get list of pending invitations
13 13
 $pendingInvites = array();
14 14
 $db->query('SELECT * FROM alliance_invites_player
15
-            WHERE game_id = '.$db->escapeNumber($player->getGameID()).'
15
+            WHERE game_id = '.$db->escapeNumber($player->getGameID()) . '
16 16
               AND alliance_id = '.$db->escapeNumber($alliance->getAllianceID()));
17 17
 while ($db->nextRecord()) {
18 18
 	$invited = SmrPlayer::getPlayer($db->getInt('account_id'), $player->getGameID());
@@ -30,9 +30,9 @@  discard block
 block discarded – undo
30 30
 $invitePlayers = array();
31 31
 if ($alliance->getNumMembers() < $game->getAllianceMaxPlayers()) {
32 32
 	$db->query('SELECT account_id FROM player
33
-	            WHERE game_id = '.$db->escapeNumber($player->getGameID()).'
34
-	              AND alliance_id != '.$db->escapeNumber($alliance->getAllianceID()).'
35
-	              AND npc = '.$db->escapeBoolean(false).'
33
+	            WHERE game_id = '.$db->escapeNumber($player->getGameID()) . '
34
+	              AND alliance_id != '.$db->escapeNumber($alliance->getAllianceID()) . '
35
+	              AND npc = '.$db->escapeBoolean(false) . '
36 36
 	            ORDER BY player_id DESC');
37 37
 	while ($db->nextRecord()) {
38 38
 		$invitePlayer = SmrPlayer::getPlayer($db->getInt('account_id'), $player->getGameID());
Please login to merge, or discard this patch.
engine/Default/alliance_message_add_processing.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,11 +1,11 @@  discard block
 block discarded – undo
1 1
 <?php
2
-$body = htmlentities(trim($_REQUEST['body']),ENT_COMPAT,'utf-8');
2
+$body = htmlentities(trim($_REQUEST['body']), ENT_COMPAT, 'utf-8');
3 3
 $topic = isset($_REQUEST['topic']) ? $_REQUEST['topic'] : '';
4 4
 $allEyesOnly = isset($_REQUEST['allEyesOnly']);
5 5
 
6
-if($_REQUEST['action'] == 'Preview Thread' || $_REQUEST['action'] == 'Preview Reply') {
6
+if ($_REQUEST['action'] == 'Preview Thread' || $_REQUEST['action'] == 'Preview Reply') {
7 7
 	$container = create_container('skeleton.php', '', $var);
8
-	if(!isset($var['thread_index'])) {
8
+	if (!isset($var['thread_index'])) {
9 9
 		$container['body'] = 'alliance_message.php';
10 10
 	}
11 11
 	else {
@@ -83,14 +83,14 @@  discard block
 block discarded – undo
83 83
 			VALUES(' . $db->escapeNumber($player->getGameID()) . ', ' . $db->escapeNumber($alliance_id) . ', ' . $db->escapeNumber($thread_id) . ', ' . $db->escapeNumber($reply_id) . ', ' . $db->escapeString($body) . ', ' . $db->escapeNumber($player->getAccountID()) . ', ' . $db->escapeNumber(TIME) . ')');
84 84
 $db->query('REPLACE INTO player_read_thread
85 85
 			(account_id, game_id, alliance_id, thread_id, time)
86
-			VALUES(' . $db->escapeNumber($player->getAccountID()) . ', ' . $db->escapeNumber($player->getGameID()) . ', ' . $db->escapeNumber($alliance_id) . ', ' . $db->escapeNumber($thread_id) . ', ' . $db->escapeNumber(TIME+2) . ')');
86
+			VALUES(' . $db->escapeNumber($player->getAccountID()) . ', ' . $db->escapeNumber($player->getGameID()) . ', ' . $db->escapeNumber($alliance_id) . ', ' . $db->escapeNumber($thread_id) . ', ' . $db->escapeNumber(TIME + 2) . ')');
87 87
 
88 88
 $container = create_container('skeleton.php');
89 89
 $container['alliance_id'] = $alliance_id;
90 90
 if (isset($var['alliance_eyes'])) {
91 91
 	$container['alliance_eyes'] = $var['alliance_eyes'];
92 92
 }
93
-if(isset($var['thread_index'])) {
93
+if (isset($var['thread_index'])) {
94 94
 	$container['body'] = 'alliance_message_view.php';
95 95
 	$container['thread_index'] = $thread_index;
96 96
 	$container['thread_ids'] = $var['thread_ids'];
Please login to merge, or discard this patch.
engine/Default/bar_galmap_buy.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if(Globals::getGameStartDate($player->getGameID())+TIME_MAP_BUY_WAIT > TIME) {
3
-	create_error('You cannot buy maps for another '.format_time(Globals::getGameStartDate($player->getGameID())+TIME_MAP_BUY_WAIT-TIME).'!');
2
+if (Globals::getGameStartDate($player->getGameID()) + TIME_MAP_BUY_WAIT > TIME) {
3
+	create_error('You cannot buy maps for another ' . format_time(Globals::getGameStartDate($player->getGameID()) + TIME_MAP_BUY_WAIT - TIME) . '!');
4 4
 }
5 5
 
6 6
 if ($account->getTotalSmrCredits() < CREDITS_PER_GAL_MAP) {
@@ -15,18 +15,18 @@  discard block
 block discarded – undo
15 15
 	}
16 16
 	
17 17
 	//get start sector
18
-	$galaxy = SmrGalaxy::getGalaxy($player->getGameID(),$galaxyID);
18
+	$galaxy = SmrGalaxy::getGalaxy($player->getGameID(), $galaxyID);
19 19
 	$low = $galaxy->getStartSector();
20 20
 	//get end sector
21 21
 	$high = $galaxy->getEndSector();
22 22
 
23 23
 	// Have they already got this map? (Are there any unexplored sectors?
24 24
 	$db->query('SELECT * FROM player_visited_sector WHERE sector_id >= ' . $db->escapeNumber($low) . ' AND sector_id <= ' . $db->escapeNumber($high) . ' AND account_id = ' . $db->escapeNumber($player->getAccountID()) . ' AND game_id = ' . $db->escapeNumber($player->getGameID()) . ' LIMIT 1');
25
-	if(!$db->nextRecord()) {
25
+	if (!$db->nextRecord()) {
26 26
 		create_error('You already have maps of this galaxy!');
27 27
 	}
28 28
 	
29
-	$player->increaseHOF(1,array('Bar','Maps Bought'), HOF_PUBLIC);
29
+	$player->increaseHOF(1, array('Bar', 'Maps Bought'), HOF_PUBLIC);
30 30
 	//take money
31 31
 	$account->decreaseTotalSmrCredits(CREDITS_PER_GAL_MAP);
32 32
 	//now give maps
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 		$port->addCachePort($player->getAccountID());
43 43
 	}
44 44
 	
45
-	$container=create_container('skeleton.php','bar_main.php');
45
+	$container = create_container('skeleton.php', 'bar_main.php');
46 46
 	transfer('LocationID');
47 47
 	$container['message'] = '<div align="center">Galaxy maps have been added. Enjoy!</div><br />';
48 48
 	forward($container);
Please login to merge, or discard this patch.
engine/Default/combat_log_viewer.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -1,9 +1,9 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-$template->assign('PageTopic','Combat Logs');
3
+$template->assign('PageTopic', 'Combat Logs');
4 4
 Menu::combat_log();
5 5
 
6
-if(!isset($var['log_ids']) && !isset($var['current_log'])) {
6
+if (!isset($var['log_ids']) && !isset($var['current_log'])) {
7 7
 	create_error('You must select a combat log to view');
8 8
 }
9 9
 
@@ -11,25 +11,25 @@  discard block
 block discarded – undo
11 11
 // We initialize it with the current $var, then modify it to set
12 12
 // which log to view when we press the next/previous log buttons.
13 13
 $container = create_container('skeleton.php', 'combat_log_viewer.php', $var);
14
-if($var['current_log'] > 0) {
14
+if ($var['current_log'] > 0) {
15 15
 	$container['current_log'] = $var['current_log'] - 1;
16
-	$template->assign('PreviousLogHREF',SmrSession::getNewHREF($container));
16
+	$template->assign('PreviousLogHREF', SmrSession::getNewHREF($container));
17 17
 }
18
-if($var['current_log'] < count($container['log_ids']) - 1) {
18
+if ($var['current_log'] < count($container['log_ids']) - 1) {
19 19
 	$container['current_log'] = $var['current_log'] + 1;
20
-	$template->assign('NextLogHREF',SmrSession::getNewHREF($container));
20
+	$template->assign('NextLogHREF', SmrSession::getNewHREF($container));
21 21
 }
22 22
 
23 23
 // Set properties for the current display page
24 24
 $display_id = $var['log_ids'][$var['current_log']];
25 25
 $db->query('SELECT timestamp,sector_id,result,type FROM combat_logs WHERE log_id=' . $db->escapeNumber($display_id) . ' LIMIT 1');
26 26
 
27
-if($db->nextRecord()) {
28
-	$template->assign('CombatLogSector',$db->getField('sector_id'));
29
-	$template->assign('CombatLogTimestamp',date(DATE_FULL_SHORT,$db->getField('timestamp')));
27
+if ($db->nextRecord()) {
28
+	$template->assign('CombatLogSector', $db->getField('sector_id'));
29
+	$template->assign('CombatLogTimestamp', date(DATE_FULL_SHORT, $db->getField('timestamp')));
30 30
 	$results = unserialize(gzuncompress($db->getField('result')));
31
-	$template->assign('CombatResultsType',$db->getField('type'));
32
-	$template->assign('CombatResults',$results);
31
+	$template->assign('CombatResultsType', $db->getField('type'));
32
+	$template->assign('CombatResults', $results);
33 33
 }
34 34
 else {
35 35
 	create_error('Combat log not found');
Please login to merge, or discard this patch.
engine/Default/note_delete_processing.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -11,18 +11,18 @@
 block discarded – undo
11 11
  * 		Deletes selected notes
12 12
  */
13 13
  
14
-if(isset($_POST['note_id'])) {
14
+if (isset($_POST['note_id'])) {
15 15
 	$note_ids = $_POST['note_id'];
16 16
 	$verified = true;
17
-	foreach($note_ids as $note_id) {
18
-		if(preg_match('/[^0-9]/',$note_id)) {
17
+	foreach ($note_ids as $note_id) {
18
+		if (preg_match('/[^0-9]/', $note_id)) {
19 19
 			$verified = false;
20 20
 		}
21 21
 	}
22
-	if($verified) {
22
+	if ($verified) {
23 23
 		$db->query('DELETE FROM player_has_notes WHERE game_id=' . $db->escapeNumber($player->getGameID()) . '
24 24
 					AND account_id=' . $db->escapeNumber($player->getAccountID()) . '
25
-					AND note_id IN (' . $db->escapeArray($note_ids)  . ')');
25
+					AND note_id IN (' . $db->escapeArray($note_ids) . ')');
26 26
 	}
27 27
 }
28 28
 
Please login to merge, or discard this patch.
engine/Default/alliance_create.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-$template->assign('PageTopic','Create Alliance');
3
+$template->assign('PageTopic', 'Create Alliance');
4 4
 
5 5
 $container = create_container('alliance_create_processing.php');
6 6
 $template->assign('CreateHREF', SmrSession::getNewHREF($container));
Please login to merge, or discard this patch.
engine/Default/galactic_post_delete.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,21 +1,21 @@
 block discarded – undo
1 1
 <?php
2 2
 $db2 = new SmrMySqlDatabase();
3 3
 if (isset($var['article'])) {
4
-	$db->query('DELETE FROM galactic_post_article WHERE game_id = ' . $db->escapeNumber($player->getGameID()) . ' AND article_id = '.$db->escapeNumber($var['id']));
4
+	$db->query('DELETE FROM galactic_post_article WHERE game_id = ' . $db->escapeNumber($player->getGameID()) . ' AND article_id = ' . $db->escapeNumber($var['id']));
5 5
 }
6 6
 else {
7 7
 	//we are deleting an entire paper
8 8
 	//find out which articles need to be deleted as well
9
-	$db->query('SELECT * FROM galactic_post_paper_content WHERE game_id = ' . $db->escapeNumber($player->getGameID()) . ' AND paper_id = '.$db->escapeNumber($var['id']));
10
-	while($db->nextRecord()) {
9
+	$db->query('SELECT * FROM galactic_post_paper_content WHERE game_id = ' . $db->escapeNumber($player->getGameID()) . ' AND paper_id = ' . $db->escapeNumber($var['id']));
10
+	while ($db->nextRecord()) {
11 11
 		//delete this article that is part of this paper
12 12
 		$db2->query('DELETE FROM galactic_post_article WHERE article_id = ' . $db->escapeNumber($db->getInt('article_id')) . ' AND game_id = ' . $db->escapeNumber($player->getGameID()));
13 13
 	}
14 14
 
15 15
 	//we have deleted the articles now delete the paper
16
-	$db->query('DELETE FROM galactic_post_paper WHERE game_id = ' . $db->escapeNumber($player->getGameID()) . ' AND paper_id = '.$db->escapeNumber($var['id']));
16
+	$db->query('DELETE FROM galactic_post_paper WHERE game_id = ' . $db->escapeNumber($player->getGameID()) . ' AND paper_id = ' . $db->escapeNumber($var['id']));
17 17
 	//now delete form the content table
18
-	$db->query('DELETE FROM galactic_post_paper_content WHERE game_id = ' . $db->escapeNumber($player->getGameID()) . ' AND paper_id = '.$db->escapeNumber($var['id']));
18
+	$db->query('DELETE FROM galactic_post_paper_content WHERE game_id = ' . $db->escapeNumber($player->getGameID()) . ' AND paper_id = ' . $db->escapeNumber($var['id']));
19 19
 }
20 20
 
21 21
 $container = create_container('skeleton.php', 'galactic_post.php');
Please login to merge, or discard this patch.
engine/Default/galactic_post_delete_confirm.php 1 patch
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -3,52 +3,52 @@
 block discarded – undo
3 3
 $db2 = new SmrMySqlDatabase();
4 4
 $db3 = new SmrMySqlDatabase();
5 5
 if (isset($var['article'])) {
6
-	$db->query('SELECT * FROM galactic_post_article WHERE article_id = '.$db->escapeNumber($var['id']).' AND game_id = ' . $db->escapeNumber($player->getGameID()));
6
+	$db->query('SELECT * FROM galactic_post_article WHERE article_id = ' . $db->escapeNumber($var['id']) . ' AND game_id = ' . $db->escapeNumber($player->getGameID()));
7 7
 	$db->nextRecord();
8 8
 	$title = $db->getField('title');
9
-	$PHP_OUTPUT.=('Are you sure you want to delete the article named '.$title.'?');
9
+	$PHP_OUTPUT .= ('Are you sure you want to delete the article named ' . $title . '?');
10 10
 	$container = array();
11 11
 	$container['url'] = 'galactic_post_delete.php';
12 12
 	transfer('article');
13 13
 	transfer('id');
14
-	$PHP_OUTPUT.=create_echo_form($container);
15
-	$PHP_OUTPUT.=create_submit('Yes');
16
-	$PHP_OUTPUT.=('</form>');
14
+	$PHP_OUTPUT .= create_echo_form($container);
15
+	$PHP_OUTPUT .= create_submit('Yes');
16
+	$PHP_OUTPUT .= ('</form>');
17 17
 	$container = array();
18 18
 	$container['url'] = 'skeleton.php';
19 19
 	$container['body'] = 'galactic_post_view_article.php';
20 20
 	transfer('id');
21
-	$PHP_OUTPUT.=create_echo_form($container);
22
-	$PHP_OUTPUT.=create_submit('No');
23
-	$PHP_OUTPUT.=('</form>');
21
+	$PHP_OUTPUT .= create_echo_form($container);
22
+	$PHP_OUTPUT .= create_submit('No');
23
+	$PHP_OUTPUT .= ('</form>');
24 24
 }
25 25
 else {
26
-	$db->query('SELECT * FROM galactic_post_paper WHERE game_id = ' . $db->escapeNumber($player->getGameID()) . ' AND paper_id = '.$db->escapeNumber($var['id']));
26
+	$db->query('SELECT * FROM galactic_post_paper WHERE game_id = ' . $db->escapeNumber($player->getGameID()) . ' AND paper_id = ' . $db->escapeNumber($var['id']));
27 27
 	$db->nextRecord();
28 28
 	$title = $db->getField('title');
29
-	$PHP_OUTPUT.=('Are you sure you want to delete the paper titled '.$title.' and the following articles with it<br /><br />');
30
-	$db2->query('SELECT * FROM galactic_post_paper_content WHERE game_id = ' . $db->escapeNumber($player->getGameID()) . ' AND paper_id = '.$db->escapeNumber($var['id']));
31
-	while($db2->nextRecord()) {
29
+	$PHP_OUTPUT .= ('Are you sure you want to delete the paper titled ' . $title . ' and the following articles with it<br /><br />');
30
+	$db2->query('SELECT * FROM galactic_post_paper_content WHERE game_id = ' . $db->escapeNumber($player->getGameID()) . ' AND paper_id = ' . $db->escapeNumber($var['id']));
31
+	while ($db2->nextRecord()) {
32 32
 		$article_id = $db2->getField('article_id');
33
-		$db3->query('SELECT * FROM galactic_post_article WHERE game_id = ' . $db->escapeNumber($player->getGameID()) . ' AND article_id = '.$db->escapeNumber($article_id));
33
+		$db3->query('SELECT * FROM galactic_post_article WHERE game_id = ' . $db->escapeNumber($player->getGameID()) . ' AND article_id = ' . $db->escapeNumber($article_id));
34 34
 		$db3->nextRecord();
35 35
 		$article_title = bbifyMessage($db3->getField('title'));
36
-		$PHP_OUTPUT.=($article_title.'<br />');
36
+		$PHP_OUTPUT .= ($article_title . '<br />');
37 37
 	}
38
-	$PHP_OUTPUT.=('<br />');
38
+	$PHP_OUTPUT .= ('<br />');
39 39
 
40 40
 	$container = array();
41 41
 	$container['url'] = 'galactic_post_delete.php';
42 42
 	transfer('paper');
43 43
 	transfer('id');
44
-	$PHP_OUTPUT.=create_echo_form($container);
45
-	$PHP_OUTPUT.=create_submit('Yes');
46
-	$PHP_OUTPUT.=('</form>');
44
+	$PHP_OUTPUT .= create_echo_form($container);
45
+	$PHP_OUTPUT .= create_submit('Yes');
46
+	$PHP_OUTPUT .= ('</form>');
47 47
 	$container = array();
48 48
 	$container['url'] = 'skeleton.php';
49 49
 	$container['body'] = 'galactic_post_view_article.php';
50 50
 	transfer('id');
51
-	$PHP_OUTPUT.=create_echo_form($container);
52
-	$PHP_OUTPUT.=create_submit('No');
53
-	$PHP_OUTPUT.=('</form>');
51
+	$PHP_OUTPUT .= create_echo_form($container);
52
+	$PHP_OUTPUT .= create_submit('No');
53
+	$PHP_OUTPUT .= ('</form>');
54 54
 }
Please login to merge, or discard this patch.