Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Branch master (287493)
by Dan
06:08
created
engine/Default/alliance_list.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,9 +1,9 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-$template->assign('PageTopic','List Of Alliances');
3
+$template->assign('PageTopic', 'List Of Alliances');
4 4
 
5 5
 if (!$player->hasAlliance()) {
6
-	$container = create_container('skeleton.php','alliance_create.php');
6
+	$container = create_container('skeleton.php', 'alliance_create.php');
7 7
 	$template->assign('CreateAllianceHREF', SmrSession::getNewHREF($container));
8 8
 }
9 9
 
Please login to merge, or discard this patch.
engine/Default/military_payment_claim.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-$template->assign('PageTopic','Military Payment Center');
3
+$template->assign('PageTopic', 'Military Payment Center');
4 4
 
5 5
 require_once(get_file_loc('menu_hq.inc'));
6 6
 if ($sector->hasHQ())
@@ -10,17 +10,17 @@  discard block
 block discarded – undo
10 10
 
11 11
 // We can only claim the payment once, so to prevent clobbering the message
12 12
 // upon AJAX refresh, we store it as a session variable when we first get it.
13
-if(!isset($var['ClaimText'])) {
13
+if (!isset($var['ClaimText'])) {
14 14
 	if ($player->hasMilitaryPayment()) {
15 15
 		$payment = $player->getMilitaryPayment();
16
-		$player->increaseHOF($payment, array('Military Payment','Money','Claimed'), HOF_PUBLIC);
16
+		$player->increaseHOF($payment, array('Military Payment', 'Money', 'Claimed'), HOF_PUBLIC);
17 17
 
18 18
 		// add to our cash
19 19
 		$player->increaseCredits($payment);
20 20
 		$player->setMilitaryPayment(0);
21 21
 		$player->update();
22 22
 
23
-		$claimText = ('For your military activity you have been paid <span class="creds">'.number_format($payment).'</span> credits.');
23
+		$claimText = ('For your military activity you have been paid <span class="creds">' . number_format($payment) . '</span> credits.');
24 24
 	} else {
25 25
 		$claimText = ('You have done nothing worthy of military payment.');
26 26
 	}
Please login to merge, or discard this patch.
engine/Default/shop_goods.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -6,12 +6,12 @@  discard block
 block discarded – undo
6 6
 $port = $player->getSectorPort();
7 7
 $template->assign('Port', $port);
8 8
 
9
-$tradeable = checkPortTradeable($port,$player);
10
-if($tradeable!==true)
9
+$tradeable = checkPortTradeable($port, $player);
10
+if ($tradeable !== true)
11 11
 	create_error($tradeable);
12 12
 
13 13
 // topic
14
-$template->assign('PageTopic','Port In Sector #'.$player->getSectorID());
14
+$template->assign('PageTopic', 'Port In Sector #' . $player->getSectorID());
15 15
 
16 16
 $container = create_container('skeleton.php', 'council_list.php');
17 17
 $container['race_id'] = $port->getRaceID();
@@ -42,10 +42,10 @@  discard block
 block discarded – undo
42 42
 	$rand = mt_rand(1, 100);
43 43
 	if ($rand <= $base_chance) {
44 44
 		$searchedByFeds = true;
45
-		$player->increaseHOF(1,array('Trade','Search','Total'), HOF_PUBLIC);
45
+		$player->increaseHOF(1, array('Trade', 'Search', 'Total'), HOF_PUBLIC);
46 46
 		if ($ship->hasIllegalGoods()) {
47 47
 			$template->assign('IllegalsFound', true);
48
-			$player->increaseHOF(1,array('Trade','Search','Caught','Number Of Times'), HOF_PUBLIC);
48
+			$player->increaseHOF(1, array('Trade', 'Search', 'Caught', 'Number Of Times'), HOF_PUBLIC);
49 49
 			//find the fine
50 50
 			//get base for ports that dont happen to trade that good
51 51
 			$GOODS = Globals::getGoods();
@@ -53,14 +53,14 @@  discard block
 block discarded – undo
53 53
 			    (($ship->getCargo(GOODS_SLAVES) * $GOODS[GOODS_SLAVES]['BasePrice']) +
54 54
 			     ($ship->getCargo(GOODS_WEAPONS) * $GOODS[GOODS_WEAPONS]['BasePrice']) +
55 55
 			     ($ship->getCargo(GOODS_NARCOTICS) * $GOODS[GOODS_NARCOTICS]['BasePrice']));
56
-			$player->increaseHOF($ship->getCargo(GOODS_SLAVES) + $ship->getCargo(GOODS_WEAPONS) + $ship->getCargo(GOODS_NARCOTICS), array('Trade','Search','Caught','Goods Confiscated'), HOF_PUBLIC);
57
-			$player->increaseHOF($totalFine,array('Trade','Search','Caught','Amount Fined'), HOF_PUBLIC);
58
-			if($fine > $player->getCredits()) {
56
+			$player->increaseHOF($ship->getCargo(GOODS_SLAVES) + $ship->getCargo(GOODS_WEAPONS) + $ship->getCargo(GOODS_NARCOTICS), array('Trade', 'Search', 'Caught', 'Goods Confiscated'), HOF_PUBLIC);
57
+			$player->increaseHOF($totalFine, array('Trade', 'Search', 'Caught', 'Amount Fined'), HOF_PUBLIC);
58
+			if ($fine > $player->getCredits()) {
59 59
 				$fine -= $player->getCredits();
60 60
 				$player->decreaseCredits($player->getCredits());
61 61
 				if ($fine > 0) {
62 62
 					// because credits is 0 it will take money from bank
63
-					$player->decreaseBank(min($fine,$player->getBank()));
63
+					$player->decreaseBank(min($fine, $player->getBank()));
64 64
 					// leave insurance
65 65
 					if ($player->getBank() < 5000)
66 66
 						$player->setBank(5000);
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
 		}
82 82
 		else {
83 83
 			$template->assign('IllegalsFound', false);
84
-			$player->increaseHOF(1,array('Trade','Search','Times Found Innocent'), HOF_PUBLIC);
84
+			$player->increaseHOF(1, array('Trade', 'Search', 'Times Found Innocent'), HOF_PUBLIC);
85 85
 			$player->increaseAlignment(1);
86 86
 			$account->log(LOG_TYPE_TRADING, 'Player gains alignment at port', $player->getSectorID());
87 87
 		}
Please login to merge, or discard this patch.
engine/Default/message_blacklist.php 1 patch
Spacing   +30 added lines, -30 removed lines patch added patch discarded remove patch
@@ -1,65 +1,65 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-$template->assign('PageTopic','Player Blacklist');
3
+$template->assign('PageTopic', 'Player Blacklist');
4 4
 
5 5
 Menu::messages();
6 6
  
7
-if(isset($var['error'])) {
8
-	switch($var['error']) {
7
+if (isset($var['error'])) {
8
+	switch ($var['error']) {
9 9
 		case(1):
10
-			$PHP_OUTPUT.= '<span class="red bold">ERROR: </span>Player does not exist.';
10
+			$PHP_OUTPUT .= '<span class="red bold">ERROR: </span>Player does not exist.';
11 11
 			break;
12 12
 		case(2):
13
-			$PHP_OUTPUT.= '<span class="red bold">ERROR: </span>Player is already blacklisted.';
13
+			$PHP_OUTPUT .= '<span class="red bold">ERROR: </span>Player is already blacklisted.';
14 14
 			break;
15 15
 		case(3):
16
-			$PHP_OUTPUT.= '<span class="yellow">' . $_REQUEST['PlayerName'] . '</span> has been added to your blacklist.';
16
+			$PHP_OUTPUT .= '<span class="yellow">' . $_REQUEST['PlayerName'] . '</span> has been added to your blacklist.';
17 17
 			break;
18 18
 		case(4):
19
-			$PHP_OUTPUT.= '<span class="red bold">ERROR: </span>No entries selected for deletion.';
19
+			$PHP_OUTPUT .= '<span class="red bold">ERROR: </span>No entries selected for deletion.';
20 20
 			break;
21 21
 		default:
22
-			$PHP_OUTPUT.= '<span class="red bold">ERROR: </span>Unknown error event.';
22
+			$PHP_OUTPUT .= '<span class="red bold">ERROR: </span>Unknown error event.';
23 23
 			break;
24 24
 	}
25
-	$PHP_OUTPUT.= '<br /><br />';
25
+	$PHP_OUTPUT .= '<br /><br />';
26 26
 }
27
-$PHP_OUTPUT.= '<h2>Blacklisted Players</h2><br />';
27
+$PHP_OUTPUT .= '<h2>Blacklisted Players</h2><br />';
28 28
 
29 29
 $db = new SmrMySqlDatabase();
30 30
 $db->query('SELECT p.player_name, p.game_id, b.entry_id FROM player p JOIN message_blacklist b ON p.account_id = b.blacklisted_id AND b.game_id = p.game_id WHERE b.account_id=' . $db->escapeNumber($player->getAccountID()) . ' ORDER BY p.game_id, p.player_name');
31 31
 
32
-if($db->getNumRows()) {
32
+if ($db->getNumRows()) {
33 33
 	$container = array();
34 34
 	$container['url'] = 'message_blacklist_del.php';
35
-	$form = create_form($container,'Remove Selected');
36
-	$PHP_OUTPUT.= $form['form'];
35
+	$form = create_form($container, 'Remove Selected');
36
+	$PHP_OUTPUT .= $form['form'];
37 37
 	
38
-	$PHP_OUTPUT.= '<table class="standard"><tr><th>Option</th><th>Name</th><th>Game ID</th>';
38
+	$PHP_OUTPUT .= '<table class="standard"><tr><th>Option</th><th>Name</th><th>Game ID</th>';
39 39
 	
40
-	while($db->nextRecord()) {
40
+	while ($db->nextRecord()) {
41 41
 		$row = $db->getRow();		
42
-		$PHP_OUTPUT.= '<tr>';
43
-		$PHP_OUTPUT.= '<td class="center shrink"><input type="checkbox" name="entry_ids[]" value="' . $row['entry_id'] . '"></td>';
44
-		$PHP_OUTPUT.= '<td>' . $row['player_name'] . '</td>';
45
-		$PHP_OUTPUT.= '<td>' . $row['game_id'] . '</td>';
46
-		$PHP_OUTPUT.= '</tr>';
42
+		$PHP_OUTPUT .= '<tr>';
43
+		$PHP_OUTPUT .= '<td class="center shrink"><input type="checkbox" name="entry_ids[]" value="' . $row['entry_id'] . '"></td>';
44
+		$PHP_OUTPUT .= '<td>' . $row['player_name'] . '</td>';
45
+		$PHP_OUTPUT .= '<td>' . $row['game_id'] . '</td>';
46
+		$PHP_OUTPUT .= '</tr>';
47 47
 	}
48 48
 	
49
-	$PHP_OUTPUT.= '</table><br />';
50
-	$PHP_OUTPUT.= $form['submit'];
51
-	$PHP_OUTPUT.= '</form><br />';
49
+	$PHP_OUTPUT .= '</table><br />';
50
+	$PHP_OUTPUT .= $form['submit'];
51
+	$PHP_OUTPUT .= '</form><br />';
52 52
 }
53 53
 else {
54
-	$PHP_OUTPUT.= 'You are currently accepting all communications.<br />';
54
+	$PHP_OUTPUT .= 'You are currently accepting all communications.<br />';
55 55
 }
56 56
 
57
-$PHP_OUTPUT.= '<br /><h2>Blacklist Player</h2><br />';
57
+$PHP_OUTPUT .= '<br /><h2>Blacklist Player</h2><br />';
58 58
 $container = array();
59 59
 $container['url'] = 'message_blacklist_add.php';
60
-$form = create_form($container,'Blacklist');
61
-$PHP_OUTPUT.= $form['form'];
62
-$PHP_OUTPUT.= '
60
+$form = create_form($container, 'Blacklist');
61
+$PHP_OUTPUT .= $form['form'];
62
+$PHP_OUTPUT .= '
63 63
 <table cellspacing="0" cellpadding="0" class="nobord nohpad">
64 64
 	<tr>
65 65
 		<td class="top">Name:&nbsp;</td>
@@ -67,5 +67,5 @@  discard block
 block discarded – undo
67 67
 	</tr>
68 68
 </table><br />
69 69
 ';
70
-$PHP_OUTPUT.= $form['submit'];
71
-$PHP_OUTPUT.= '</form>';
70
+$PHP_OUTPUT .= $form['submit'];
71
+$PHP_OUTPUT .= '</form>';
Please login to merge, or discard this patch.
engine/Default/cargo_dump.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@
 block discarded – undo
1 1
 <?php
2
-$template->assign('PageTopic','Dump Cargo');
2
+$template->assign('PageTopic', 'Dump Cargo');
3 3
 
4 4
 if ($ship->hasCargo()) {
5 5
 
Please login to merge, or discard this patch.
engine/Default/trader_status.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,9 +1,9 @@  discard block
 block discarded – undo
1 1
 <?php
2
-$template->assign('PageTopic','Trader Status');
2
+$template->assign('PageTopic', 'Trader Status');
3 3
 
4 4
 Menu::trader();
5 5
 
6
-$container=array();
6
+$container = array();
7 7
 $container['url'] = 'skeleton.php';
8 8
 
9 9
 if ($player->hasNewbieTurns()) {
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 $template->assign('Hardware', $hardware);
43 43
 
44 44
 $db->query('SELECT level_name,requirement FROM level WHERE requirement>' . $db->escapeNumber($player->getExperience()) . ' ORDER BY requirement ASC LIMIT 1');
45
-if(!$db->nextRecord()) {
45
+if (!$db->nextRecord()) {
46 46
 	$db->query('SELECT level_name,requirement FROM level ORDER BY requirement DESC LIMIT 1');
47 47
 	$db->nextRecord();
48 48
 }
Please login to merge, or discard this patch.
engine/Default/bar_talk_bartender.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
 if (!isset($var['Message'])) {
23 23
 	$db->query('SELECT * FROM bar_tender WHERE game_id = ' . $db->escapeNumber($player->getGameID()) . ' ORDER BY rand() LIMIT 1');
24 24
 	if ($db->nextRecord()) {
25
-		$message = 'I heard... '.$db->getField('message').'<br /><br />Got anything else to tell me?';
25
+		$message = 'I heard... ' . $db->getField('message') . '<br /><br />Got anything else to tell me?';
26 26
 	} else {
27 27
 		$message = 'I havent heard anything recently... got anything to tell me?';
28 28
 	}
Please login to merge, or discard this patch.
engine/Default/newbie_warning.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,2 +1,2 @@
 block discarded – undo
1 1
 <?php
2
-$template->assign('PageTopic','Warning!');
2
+$template->assign('PageTopic', 'Warning!');
Please login to merge, or discard this patch.
engine/Default/trader_relations.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@
 block discarded – undo
1 1
 <?php
2
-$template->assign('PageTopic','Trader Relations');
2
+$template->assign('PageTopic', 'Trader Relations');
3 3
 
4 4
 Menu::trader();
5 5
 
Please login to merge, or discard this patch.