We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
@@ -128,7 +128,7 @@ |
||
128 | 128 | AND receiver_delete = ' . $db->escapeBoolean(false) . ' |
129 | 129 | ORDER BY send_time DESC'); |
130 | 130 | foreach ($dbResult->records() as $dbRecord) { |
131 | - $groupBox =& $messageBox['GroupedMessages'][$dbRecord->getInt('sender_id')]; |
|
131 | + $groupBox = & $messageBox['GroupedMessages'][$dbRecord->getInt('sender_id')]; |
|
132 | 132 | // Limit the number of messages in each group |
133 | 133 | if (!isset($groupBox['Messages']) || count($groupBox['Messages']) < MESSAGE_SCOUT_GROUP_LIMIT) { |
134 | 134 | $groupBox['Messages'][] = displayMessage($dbRecord->getInt('message_id'), $dbRecord->getInt('account_id'), $dbRecord->getInt('sender_id'), $player->getGameID(), $dbRecord->getString('message_text'), $dbRecord->getInt('send_time'), $dbRecord->getBoolean('msg_read'), MSG_SCOUT, $player->getAccount()); |
@@ -38,8 +38,8 @@ discard block |
||
38 | 38 | $shareFrom[$fromAccountId] = [ |
39 | 39 | 'Player ID' => $otherPlayer == null ? '-' : $otherPlayer->getPlayerID(), |
40 | 40 | 'Player Name' => $otherPlayer == null ? |
41 | - '<b>Account</b>: ' . SmrAccount::getAccount($fromAccountId)->getHofDisplayName() : |
|
42 | - $otherPlayer->getDisplayName(), |
|
41 | + '<b>Account</b>: ' . SmrAccount::getAccount($fromAccountId)->getHofDisplayName() : |
|
42 | + $otherPlayer->getDisplayName(), |
|
43 | 43 | 'All Games' => $gameId == 0 ? '<span class="green">YES</span>' : '<span class="red">NO</span>', |
44 | 44 | 'Game ID' => $gameId, |
45 | 45 | ]; |
@@ -59,8 +59,8 @@ discard block |
||
59 | 59 | $shareTo[$toAccountId] = [ |
60 | 60 | 'Player ID' => $otherPlayer == null ? '-' : $otherPlayer->getPlayerID(), |
61 | 61 | 'Player Name' => $otherPlayer == null ? |
62 | - '<b>Account</b>: ' . SmrAccount::getAccount($toAccountId)->getHofDisplayName() : |
|
63 | - $otherPlayer->getDisplayName(), |
|
62 | + '<b>Account</b>: ' . SmrAccount::getAccount($toAccountId)->getHofDisplayName() : |
|
63 | + $otherPlayer->getDisplayName(), |
|
64 | 64 | 'All Games' => $gameId == 0 ? '<span class="green">YES</span>' : '<span class="red">NO</span>', |
65 | 65 | 'Game ID' => $gameId, |
66 | 66 | ]; |
@@ -38,8 +38,7 @@ discard block |
||
38 | 38 | $shareFrom[$fromAccountId] = [ |
39 | 39 | 'Player ID' => $otherPlayer == null ? '-' : $otherPlayer->getPlayerID(), |
40 | 40 | 'Player Name' => $otherPlayer == null ? |
41 | - '<b>Account</b>: ' . SmrAccount::getAccount($fromAccountId)->getHofDisplayName() : |
|
42 | - $otherPlayer->getDisplayName(), |
|
41 | + '<b>Account</b>: ' . SmrAccount::getAccount($fromAccountId)->getHofDisplayName() : $otherPlayer->getDisplayName(), |
|
43 | 42 | 'All Games' => $gameId == 0 ? '<span class="green">YES</span>' : '<span class="red">NO</span>', |
44 | 43 | 'Game ID' => $gameId, |
45 | 44 | ]; |
@@ -59,8 +58,7 @@ discard block |
||
59 | 58 | $shareTo[$toAccountId] = [ |
60 | 59 | 'Player ID' => $otherPlayer == null ? '-' : $otherPlayer->getPlayerID(), |
61 | 60 | 'Player Name' => $otherPlayer == null ? |
62 | - '<b>Account</b>: ' . SmrAccount::getAccount($toAccountId)->getHofDisplayName() : |
|
63 | - $otherPlayer->getDisplayName(), |
|
61 | + '<b>Account</b>: ' . SmrAccount::getAccount($toAccountId)->getHofDisplayName() : $otherPlayer->getDisplayName(), |
|
64 | 62 | 'All Games' => $gameId == 0 ? '<span class="green">YES</span>' : '<span class="red">NO</span>', |
65 | 63 | 'Game ID' => $gameId, |
66 | 64 | ]; |
@@ -81,7 +81,7 @@ |
||
81 | 81 | foreach ($alliance_vs_ids as $id) { |
82 | 82 | $row_alliance = SmrAlliance::getAlliance($id, $player->getGameID()); |
83 | 83 | $showRed = (!$curr_alliance->isNone() && $curr_alliance->hasDisbanded()) || |
84 | - (!$row_alliance->isNone() && $row_alliance->hasDisbanded()); |
|
84 | + (!$row_alliance->isNone() && $row_alliance->hasDisbanded()); |
|
85 | 85 | $showBold = $curr_id == $player->getAllianceID() || $id == $player->getAllianceID(); |
86 | 86 | $style = ''; |
87 | 87 | if ($curr_id == $id && !$row_alliance->isNone()) { |
@@ -65,9 +65,9 @@ |
||
65 | 65 | //get base for ports that dont happen to trade that good |
66 | 66 | $GOODS = Globals::getGoods(); |
67 | 67 | $fine = $totalFine = $port->getLevel() * |
68 | - (($ship->getCargo(GOODS_SLAVES) * $GOODS[GOODS_SLAVES]['BasePrice']) + |
|
69 | - ($ship->getCargo(GOODS_WEAPONS) * $GOODS[GOODS_WEAPONS]['BasePrice']) + |
|
70 | - ($ship->getCargo(GOODS_NARCOTICS) * $GOODS[GOODS_NARCOTICS]['BasePrice'])); |
|
68 | + (($ship->getCargo(GOODS_SLAVES) * $GOODS[GOODS_SLAVES]['BasePrice']) + |
|
69 | + ($ship->getCargo(GOODS_WEAPONS) * $GOODS[GOODS_WEAPONS]['BasePrice']) + |
|
70 | + ($ship->getCargo(GOODS_NARCOTICS) * $GOODS[GOODS_NARCOTICS]['BasePrice'])); |
|
71 | 71 | $player->increaseHOF($ship->getCargo(GOODS_SLAVES) + $ship->getCargo(GOODS_WEAPONS) + $ship->getCargo(GOODS_NARCOTICS), ['Trade', 'Search', 'Caught', 'Goods Confiscated'], HOF_PUBLIC); |
72 | 72 | $player->increaseHOF($totalFine, ['Trade', 'Search', 'Caught', 'Amount Fined'], HOF_PUBLIC); |
73 | 73 | $template->assign('TotalFine', $totalFine); |
@@ -14,7 +14,7 @@ |
||
14 | 14 | * @param array<mixed> $results |
15 | 15 | */ |
16 | 16 | public function __construct( |
17 | - private readonly ?array $results = null, |
|
17 | + private readonly ? array $results = null, |
|
18 | 18 | bool $playerDied = false |
19 | 19 | ) { |
20 | 20 | // If the player died, make sure they see combat results |
@@ -24,8 +24,8 @@ |
||
24 | 24 | private readonly int $gameID, |
25 | 25 | private readonly ?string $submit = null, |
26 | 26 | private readonly ?string $label = null, |
27 | - private readonly ?array $accountIDs = null, |
|
28 | - private readonly ?array $allianceIDs = null, |
|
27 | + private readonly ? array $accountIDs = null, |
|
28 | + private readonly ? array $allianceIDs = null, |
|
29 | 29 | ) {} |
30 | 30 | |
31 | 31 | public function build(SmrAccount $account, Template $template): void { |
@@ -90,7 +90,7 @@ |
||
90 | 90 | $menuItems[] = ['Link' => Globals::getPlanetListHREF($alliance_id), 'Text' => 'Defense']; |
91 | 91 | $menuItems[] = ['Link' => Globals::getPlanetListFinancialHREF($alliance_id), 'Text' => 'Financial']; |
92 | 92 | // make the selected index bold |
93 | - $boldItem =& $menuItems[$selected_index]['Text']; |
|
93 | + $boldItem = & $menuItems[$selected_index]['Text']; |
|
94 | 94 | $boldItem = '<span class="bold">' . $boldItem . '</span>'; |
95 | 95 | |
96 | 96 | $template = Smr\Template::getInstance(); |
@@ -17,9 +17,9 @@ |
||
17 | 17 | */ |
18 | 18 | public function __construct( |
19 | 19 | private readonly ?string $action = null, |
20 | - private readonly ?array $results = null, |
|
20 | + private readonly ? array $results = null, |
|
21 | 21 | private readonly ?int $diffBytes = null, |
22 | - private readonly ?array $endedGames = null |
|
22 | + private readonly ? array $endedGames = null |
|
23 | 23 | ) {} |
24 | 24 | |
25 | 25 | public function build(SmrAccount $account, Template $template): void { |