Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#912)
by Dan
04:13
created
engine/Default/forces_attack_processing.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -81,18 +81,18 @@
 block discarded – undo
81 81
 
82 82
 // If mines are bumped, the forces shoot first. Otherwise player shoots first.
83 83
 if ($bump) {
84
-	$results['Forces'] =& $forces->shootPlayers($attackers, $bump);
84
+	$results['Forces'] = & $forces->shootPlayers($attackers, $bump);
85 85
 }
86 86
 
87 87
 $results['Attackers'] = array('TotalDamage' => 0);
88 88
 foreach ($attackers as $attacker) {
89
-	$playerResults =& $attacker->shootForces($forces);
90
-	$results['Attackers']['Traders'][$attacker->getPlayerID()] =& $playerResults;
89
+	$playerResults = & $attacker->shootForces($forces);
90
+	$results['Attackers']['Traders'][$attacker->getPlayerID()] = & $playerResults;
91 91
 	$results['Attackers']['TotalDamage'] += $playerResults['TotalDamage'];
92 92
 }
93 93
 
94 94
 if (!$bump) {
95
-	$results['Forces'] =& $forces->shootPlayers($attackers, $bump);
95
+	$results['Forces'] = & $forces->shootPlayers($attackers, $bump);
96 96
 	$forces->updateExpire();
97 97
 }
98 98
 
Please login to merge, or discard this patch.
engine/Default/council_embassy_processing.php 1 patch
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 // Send vote announcement to members of the player's council (war votes)
40 40
 // or both races' councils (peace votes).
41 41
 $councilMembers = Council::getRaceCouncil($player->getGameID(),
42
-                                          $player->getRaceID());
42
+										  $player->getRaceID());
43 43
 if ($type == 'PEACE') {
44 44
 	$otherCouncil = Council::getRaceCouncil($player->getGameID(), $race_id);
45 45
 	$councilMembers = array_merge($councilMembers, $otherCouncil);
@@ -49,16 +49,16 @@  discard block
 block discarded – undo
49 49
 $color = ($type == 'PEACE' ? 'dgreen' : 'red');
50 50
 $type_fancy = "<span class=\"$color\">$type</span>";
51 51
 $message = $player->getLevelName() . " " . $player->getBBLink()
52
-           . " has initiated a vote for $type_fancy with the "
53
-           . Globals::getRaceName($race_id)
54
-           . "! You have " . format_time(TIME_FOR_COUNCIL_VOTE)
55
-           . " to cast your vote.";
52
+		   . " has initiated a vote for $type_fancy with the "
53
+		   . Globals::getRaceName($race_id)
54
+		   . "! You have " . format_time(TIME_FOR_COUNCIL_VOTE)
55
+		   . " to cast your vote.";
56 56
 
57 57
 foreach ($councilMembers as $playerID) {
58 58
 	// don't send to the player who started the vote
59 59
 	if ($player->getPlayerID() != $playerID) {
60 60
 		SmrPlayer::sendMessageFromRace($player->getRaceID(), $player->getGameID(),
61
-		                               $playerID, $message, $time);
61
+									   $playerID, $message, $time);
62 62
   }
63 63
 }
64 64
 
Please login to merge, or discard this patch.
engine/Default/port_attack_processing.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -52,12 +52,12 @@
 block discarded – undo
52 52
 }
53 53
 
54 54
 foreach ($attackers as $attacker) {
55
-	$playerResults =& $attacker->shootPort($port);
56
-	$results['Attackers']['Traders'][$attacker->getPlayerID()] =& $playerResults;
55
+	$playerResults = & $attacker->shootPort($port);
56
+	$results['Attackers']['Traders'][$attacker->getPlayerID()] = & $playerResults;
57 57
 	$results['Attackers']['TotalDamage'] += $playerResults['TotalDamage'];
58 58
 }
59 59
 $results['Attackers']['Downgrades'] = $port->checkForDowngrade($results['Attackers']['TotalDamage']);
60
-$results['Port'] =& $port->shootPlayers($attackers);
60
+$results['Port'] = & $port->shootPlayers($attackers);
61 61
 
62 62
 $account->log(LOG_TYPE_PORT_RAIDING, 'Player attacks port, the port does ' . $results['Port']['TotalDamage'] . ', their team does ' . $results['Attackers']['TotalDamage'] . ' and downgrades ' . $results['Attackers']['Downgrades'] . ' levels.', $port->getSectorID());
63 63
 
Please login to merge, or discard this patch.
engine/Default/trader_attack_processing.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -47,8 +47,8 @@
 block discarded – undo
47 47
 
48 48
 function teamAttack(&$results, $fightingPlayers, $attack, $defend) {
49 49
 	foreach ($fightingPlayers[$attack] as $playerID => $teamPlayer) {
50
-		$playerResults =& $teamPlayer->shootPlayers($fightingPlayers[$defend]);
51
-		$results[$attack]['Traders'][$teamPlayer->getPlayerID()] =& $playerResults;
50
+		$playerResults = & $teamPlayer->shootPlayers($fightingPlayers[$defend]);
51
+		$results[$attack]['Traders'][$teamPlayer->getPlayerID()] = & $playerResults;
52 52
 		$results[$attack]['TotalDamage'] += $playerResults['TotalDamage'];
53 53
 
54 54
 		// Award assists (if there are multiple attackers)
Please login to merge, or discard this patch.
engine/Default/message_view.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@
 block discarded – undo
122 122
 					AND receiver_delete = ' . $db->escapeBoolean(false) . '
123 123
 					ORDER BY send_time DESC');
124 124
 	while ($db->nextRecord()) {
125
-		$groupBox =& $messageBox['GroupedMessages'][$db->getInt('sender_player_id')];
125
+		$groupBox = & $messageBox['GroupedMessages'][$db->getInt('sender_player_id')];
126 126
 		// Limit the number of messages in each group
127 127
 		if (!isset($groupBox['Messages']) || count($groupBox['Messages']) < MESSAGE_SCOUT_GROUP_LIMIT) {
128 128
 			displayMessage($groupBox, $db->getInt('message_id'), $db->getInt('player_id'), $db->getInt('sender_player_id'), stripslashes($db->getField('message_text')), $db->getInt('send_time'), $db->getBoolean('msg_read'), MSG_SCOUT);
Please login to merge, or discard this patch.
engine/Default/planet_attack_processing.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -57,12 +57,12 @@
 block discarded – undo
57 57
 }
58 58
 
59 59
 foreach ($attackers as $attacker) {
60
-	$playerResults =& $attacker->shootPlanet($planet, false);
61
-	$results['Attackers']['Traders'][$attacker->getPlayerID()] =& $playerResults;
60
+	$playerResults = & $attacker->shootPlanet($planet, false);
61
+	$results['Attackers']['Traders'][$attacker->getPlayerID()] = & $playerResults;
62 62
 	$results['Attackers']['TotalDamage'] += $playerResults['TotalDamage'];
63 63
 }
64 64
 $results['Attackers']['Downgrades'] = $planet->checkForDowngrade($results['Attackers']['TotalDamage']);
65
-$results['Planet'] =& $planet->shootPlayers($attackers);
65
+$results['Planet'] = & $planet->shootPlayers($attackers);
66 66
 
67 67
 $account->log(LOG_TYPE_PLANET_BUSTING, 'Player attacks planet, the planet does ' . $results['Planet']['TotalDamage'] . ', their team does ' . $results['Attackers']['TotalDamage'] . ' and downgrades: ' . var_export($results['Attackers']['Downgrades'], true), $planet->getSectorID());
68 68
 
Please login to merge, or discard this patch.
engine/Draft/alliance_pick.inc 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -15,11 +15,11 @@
 block discarded – undo
15 15
 			// Special case for leaders who haven't made their own alliance yet,
16 16
 			// or are still in the Newbie Help Alliance.
17 17
 			$teams[$leader->getPlayerID()] = array('Leader'   => $leader,
18
-			                                       'Size'     => 0);
18
+												   'Size'     => 0);
19 19
 		} else {
20 20
 			$teams[$leader->getPlayerID()] = array('Leader'   => $leader,
21
-			                                       'Alliance' => $alliance,
22
-			                                       'Size'     => $alliance->getNumMembers());
21
+												   'Alliance' => $alliance,
22
+												   'Size'     => $alliance->getNumMembers());
23 23
 		}
24 24
 	}
25 25
 
Please login to merge, or discard this patch.
engine/Draft/alliance_pick.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,8 +30,8 @@
 block discarded – undo
30 30
 	$leader = SmrPlayer::getPlayer($db->getInt('leader_player_id'), $player->getGameID());
31 31
 	$pickedPlayer = SmrPlayer::getPlayer($db->getInt('picked_player_id'), $player->getGameID());
32 32
 	$history[] = array('Leader' => $leader,
33
-	                   'Player' => $pickedPlayer,
34
-	                   'Time'   => $db->getInt('time'));
33
+					   'Player' => $pickedPlayer,
34
+					   'Time'   => $db->getInt('time'));
35 35
 }
36 36
 
37 37
 $template->assign('History', $history);
Please login to merge, or discard this patch.