Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Failed Conditions
Pull Request — main (#1456)
by
unknown
21:58 queued 17:10
created
src/engine/Default/message_view.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -128,7 +128,7 @@
 block discarded – undo
128 128
 					AND receiver_delete = ' . $db->escapeBoolean(false) . '
129 129
 					ORDER BY send_time DESC');
130 130
 	foreach ($dbResult->records() as $dbRecord) {
131
-		$groupBox =& $messageBox['GroupedMessages'][$dbRecord->getInt('sender_id')];
131
+		$groupBox = & $messageBox['GroupedMessages'][$dbRecord->getInt('sender_id')];
132 132
 		// Limit the number of messages in each group
133 133
 		if (!isset($groupBox['Messages']) || count($groupBox['Messages']) < MESSAGE_SCOUT_GROUP_LIMIT) {
134 134
 			$groupBox['Messages'][] = displayMessage($dbRecord->getInt('message_id'), $dbRecord->getInt('account_id'), $dbRecord->getInt('sender_id'), $player->getGameID(), $dbRecord->getString('message_text'), $dbRecord->getInt('send_time'), $dbRecord->getBoolean('msg_read'), MSG_SCOUT, $player->getAccount());
Please login to merge, or discard this patch.
src/tools/npc/chess.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -14,8 +14,8 @@
 block discarded – undo
14 14
 		1 => ['pipe', 'w'], // stdout is a pipe that the child will write to
15 15
 	];
16 16
 	$engine = proc_open(UCI_CHESS_ENGINE, $descriptorSpec, $pipes);
17
-	$toEngine =& $pipes[0];
18
-	$fromEngine =& $pipes[1];
17
+	$toEngine = & $pipes[0];
18
+	$fromEngine = & $pipes[1];
19 19
 
20 20
 	function readFromEngine(bool $block = true): void {
21 21
 		global $fromEngine;
Please login to merge, or discard this patch.
src/engine/Default/chat_sharing.php 1 patch
Spacing   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -26,8 +26,7 @@  discard block
 block discarded – undo
26 26
 	$shareFrom[$fromAccountId] = [
27 27
 		'Player ID' => $otherPlayer == null ? '-' : $otherPlayer->getPlayerID(),
28 28
 		'Player Name' => $otherPlayer == null ?
29
-		                 '<b>Account</b>: ' . SmrAccount::getAccount($fromAccountId)->getHofDisplayName() :
30
-		                 $otherPlayer->getDisplayName(),
29
+		                 '<b>Account</b>: ' . SmrAccount::getAccount($fromAccountId)->getHofDisplayName() : $otherPlayer->getDisplayName(),
31 30
 		'All Games' => $gameId == 0 ? '<span class="green">YES</span>' : '<span class="red">NO</span>',
32 31
 		'Game ID' => $gameId,
33 32
 	];
@@ -47,8 +46,7 @@  discard block
 block discarded – undo
47 46
 	$shareTo[$toAccountId] = [
48 47
 		'Player ID' => $otherPlayer == null ? '-' : $otherPlayer->getPlayerID(),
49 48
 		'Player Name' => $otherPlayer == null ?
50
-		                 '<b>Account</b>: ' . SmrAccount::getAccount($toAccountId)->getHofDisplayName() :
51
-		                 $otherPlayer->getDisplayName(),
49
+		                 '<b>Account</b>: ' . SmrAccount::getAccount($toAccountId)->getHofDisplayName() : $otherPlayer->getDisplayName(),
52 50
 		'All Games' => $gameId == 0 ? '<span class="green">YES</span>' : '<span class="red">NO</span>',
53 51
 		'Game ID' => $gameId,
54 52
 	];
Please login to merge, or discard this patch.
src/lib/Default/AbstractMenu.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
 		$menuItems[] = ['Link' => Globals::getPlanetListHREF($alliance_id), 'Text' => 'Defense'];
39 39
 		$menuItems[] = ['Link' => Globals::getPlanetListFinancialHREF($alliance_id), 'Text' => 'Financial'];
40 40
 		// make the selected index bold
41
-		$boldItem =& $menuItems[$selected_index]['Text'];
41
+		$boldItem = & $menuItems[$selected_index]['Text'];
42 42
 		$boldItem = '<span class="bold">' . $boldItem . '</span>';
43 43
 
44 44
 		$template = Smr\Template::getInstance();
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 			'Text' => 'Game News',
146 146
 		];
147 147
 		// make the selected index bold
148
-		$boldItem =& $menuItems[$selected_index]['Text'];
148
+		$boldItem = & $menuItems[$selected_index]['Text'];
149 149
 		$boldItem = '<b>' . $boldItem . '</b>';
150 150
 
151 151
 		$template = Smr\Template::getInstance();
Please login to merge, or discard this patch.
src/lib/Smr/Database.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 	 * Not intended to be used outside the DI context.
27 27
 	 */
28 28
 	public static function mysqliFactory(DatabaseProperties $dbProperties): mysqli {
29
-		if (!mysqli_report(MYSQLI_REPORT_ERROR | MYSQLI_REPORT_STRICT)) {
29
+		if (!mysqli_report(MYSQLI_REPORT_ERROR|MYSQLI_REPORT_STRICT)) {
30 30
 			throw new RuntimeException('Failed to enable mysqli error reporting');
31 31
 		}
32 32
 		$mysql = new mysqli(
Please login to merge, or discard this patch.
src/htdocs/ship_list.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
 		'illusion' => $ship->canHaveIllusion() ? 'Yes' : '',
71 71
 		'jump' => $ship->canHaveJump() ? 'Yes' : '',
72 72
 		'scrambler' => $ship->canHaveDCS() ? 'Yes' : '',
73
-		'locs' => implode('', array_map(fn(string $name): string => '<div>' . $name . '</div>', $shipLocs)),
73
+		'locs' => implode('', array_map(fn(string $name) : string => '<div>' . $name . '</div>', $shipLocs)),
74 74
 	];
75 75
 	return $stat;
76 76
 }
Please login to merge, or discard this patch.
src/lib/Smr/VoteLink.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
 	public const TIME_BETWEEN_VOTING = 84600; // 23.5 hours
15 15
 
16 16
 	/** @var ?array<int, int> */
17
-	private static ?array $CACHE_TIMEOUTS = null;
17
+	private static ? array $CACHE_TIMEOUTS = null;
18 18
 
19 19
 	/** @var array<string, mixed> */
20 20
 	public readonly array $data;
Please login to merge, or discard this patch.
src/lib/Default/AbstractSmrPlayer.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -2886,7 +2886,7 @@  discard block
 block discarded – undo
2886 2886
 			'Starting Sector' => $this->getSectorID(),
2887 2887
 		];
2888 2888
 
2889
-		$this->missions[$missionID] =& $mission;
2889
+		$this->missions[$missionID] = & $mission;
2890 2890
 		$this->setupMissionStep($missionID);
2891 2891
 		$this->rebuildMission($missionID);
2892 2892
 
@@ -2948,7 +2948,7 @@  discard block
 block discarded – undo
2948 2948
 		if (!$this->hasMission($missionID)) {
2949 2949
 			throw new Exception('Unknown mission: ' . $missionID);
2950 2950
 		}
2951
-		$mission =& $this->missions[$missionID];
2951
+		$mission = & $this->missions[$missionID];
2952 2952
 		if ($mission['Task'] === false || $mission['Task']['Step'] != 'Claim') {
2953 2953
 			throw new Exception('Cannot claim mission: ' . $missionID . ', for step: ' . $mission['On Step']);
2954 2954
 		}
Please login to merge, or discard this patch.
src/lib/Default/missions.inc.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -123,7 +123,7 @@
 block discarded – undo
123 123
  *
124 124
  * @param array<string, mixed> $data
125 125
  */
126
-function replaceMissionTemplate(string|int|PlotGroup &$template, string $key, array $data): void {
126
+function replaceMissionTemplate(string|int|PlotGroup&$template, string $key, array $data): void {
127 127
 	if (!is_string($template)) {
128 128
 		return;
129 129
 	}
Please login to merge, or discard this patch.