Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Failed Conditions
Pull Request — main (#1456)
by
unknown
21:58 queued 17:10
created
src/templates/Default/engine/Default/map_local.php 1 patch
Braces   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,10 @@
 block discarded – undo
10 10
 		<td style="width: 80%" class="center">
11 11
 			Local Map of the Known <span class="big bold"><?php echo $GalaxyName ?></span> Galaxy
12 12
 			<br /><br />
13
-			<?php if (isset($Error)) echo $Error; ?>
13
+			<?php if (isset($Error)) {
14
+	echo $Error;
15
+}
16
+?>
14 17
 		</td>
15 18
 		<td style="width: 10%"></td>
16 19
 	</tr>
Please login to merge, or discard this patch.
src/templates/Default/engine/Default/beta_functions.php 1 patch
Braces   +8 added lines, -2 removed lines patch added patch discarded remove patch
@@ -76,7 +76,10 @@  discard block
 block discarded – undo
76 76
 	<input type="number" name="amount" value="0" min="<?php echo MIN_GLOBAL_RELATIONS; ?>" max="<?php echo MAX_GLOBAL_RELATIONS; ?>" style="width:75px" />&nbsp;
77 77
 	<select name="race"><?php
78 78
 		foreach (Smr\Race::getPlayableNames() as $raceID => $raceName) {
79
-			if ($raceID == $ThisPlayer->getRaceID()) continue; ?>
79
+			if ($raceID == $ThisPlayer->getRaceID()) {
80
+				continue;
81
+			}
82
+			?>
80 83
 			<option value="<?php echo $raceID; ?>"><?php echo $raceName; ?></option><?php
81 84
 		} ?>
82 85
 	</select>&nbsp;&nbsp;
@@ -87,7 +90,10 @@  discard block
 block discarded – undo
87 90
 <form method="POST" action="<?php echo $ChangeRaceHREF; ?>">
88 91
 	<select name="race"><?php
89 92
 		foreach (Smr\Race::getPlayableNames() as $raceID => $raceName) {
90
-			if ($raceID == $ThisPlayer->getRaceID()) continue; ?>
93
+			if ($raceID == $ThisPlayer->getRaceID()) {
94
+				continue;
95
+			}
96
+			?>
91 97
 			<option value="<?php echo $raceID; ?>"><?php echo $raceName; ?></option><?php
92 98
 		} ?>
93 99
 	</select>&nbsp;&nbsp;
Please login to merge, or discard this patch.
src/engine/Default/message_view.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -128,7 +128,7 @@
 block discarded – undo
128 128
 					AND receiver_delete = ' . $db->escapeBoolean(false) . '
129 129
 					ORDER BY send_time DESC');
130 130
 	foreach ($dbResult->records() as $dbRecord) {
131
-		$groupBox =& $messageBox['GroupedMessages'][$dbRecord->getInt('sender_id')];
131
+		$groupBox = & $messageBox['GroupedMessages'][$dbRecord->getInt('sender_id')];
132 132
 		// Limit the number of messages in each group
133 133
 		if (!isset($groupBox['Messages']) || count($groupBox['Messages']) < MESSAGE_SCOUT_GROUP_LIMIT) {
134 134
 			$groupBox['Messages'][] = displayMessage($dbRecord->getInt('message_id'), $dbRecord->getInt('account_id'), $dbRecord->getInt('sender_id'), $player->getGameID(), $dbRecord->getString('message_text'), $dbRecord->getInt('send_time'), $dbRecord->getBoolean('msg_read'), MSG_SCOUT, $player->getAccount());
Please login to merge, or discard this patch.
src/templates/Default/engine/Default/admin/unigen/GameDetails.inc.php 1 patch
Braces   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,10 @@
 block discarded – undo
44 44
 		<td>
45 45
 			<select name="game_type"><?php
46 46
 			foreach (SmrGame::GAME_TYPES as $GameTypeID => $GameType) {
47
-				?><option value="<?php echo $GameTypeID; ?>" <?php if ($GameType == $Game['gameType']) echo 'selected'; ?>><?php echo $GameType; ?></option><?php
47
+				?><option value="<?php echo $GameTypeID; ?>" <?php if ($GameType == $Game['gameType']) {
48
+					echo 'selected';
49
+				}
50
+				?>><?php echo $GameType; ?></option><?php
48 51
 			} ?>
49 52
 			</select>
50 53
 		</td>
Please login to merge, or discard this patch.
src/tools/npc/chess.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -14,8 +14,8 @@
 block discarded – undo
14 14
 		1 => ['pipe', 'w'], // stdout is a pipe that the child will write to
15 15
 	];
16 16
 	$engine = proc_open(UCI_CHESS_ENGINE, $descriptorSpec, $pipes);
17
-	$toEngine =& $pipes[0];
18
-	$fromEngine =& $pipes[1];
17
+	$toEngine = & $pipes[0];
18
+	$fromEngine = & $pipes[1];
19 19
 
20 20
 	function readFromEngine(bool $block = true): void {
21 21
 		global $fromEngine;
Please login to merge, or discard this patch.
src/engine/Default/chat_sharing.php 1 patch
Spacing   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -26,8 +26,7 @@  discard block
 block discarded – undo
26 26
 	$shareFrom[$fromAccountId] = [
27 27
 		'Player ID' => $otherPlayer == null ? '-' : $otherPlayer->getPlayerID(),
28 28
 		'Player Name' => $otherPlayer == null ?
29
-		                 '<b>Account</b>: ' . SmrAccount::getAccount($fromAccountId)->getHofDisplayName() :
30
-		                 $otherPlayer->getDisplayName(),
29
+		                 '<b>Account</b>: ' . SmrAccount::getAccount($fromAccountId)->getHofDisplayName() : $otherPlayer->getDisplayName(),
31 30
 		'All Games' => $gameId == 0 ? '<span class="green">YES</span>' : '<span class="red">NO</span>',
32 31
 		'Game ID' => $gameId,
33 32
 	];
@@ -47,8 +46,7 @@  discard block
 block discarded – undo
47 46
 	$shareTo[$toAccountId] = [
48 47
 		'Player ID' => $otherPlayer == null ? '-' : $otherPlayer->getPlayerID(),
49 48
 		'Player Name' => $otherPlayer == null ?
50
-		                 '<b>Account</b>: ' . SmrAccount::getAccount($toAccountId)->getHofDisplayName() :
51
-		                 $otherPlayer->getDisplayName(),
49
+		                 '<b>Account</b>: ' . SmrAccount::getAccount($toAccountId)->getHofDisplayName() : $otherPlayer->getDisplayName(),
52 50
 		'All Games' => $gameId == 0 ? '<span class="green">YES</span>' : '<span class="red">NO</span>',
53 51
 		'Game ID' => $gameId,
54 52
 	];
Please login to merge, or discard this patch.
src/lib/Default/AbstractMenu.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
 		$menuItems[] = ['Link' => Globals::getPlanetListHREF($alliance_id), 'Text' => 'Defense'];
39 39
 		$menuItems[] = ['Link' => Globals::getPlanetListFinancialHREF($alliance_id), 'Text' => 'Financial'];
40 40
 		// make the selected index bold
41
-		$boldItem =& $menuItems[$selected_index]['Text'];
41
+		$boldItem = & $menuItems[$selected_index]['Text'];
42 42
 		$boldItem = '<span class="bold">' . $boldItem . '</span>';
43 43
 
44 44
 		$template = Smr\Template::getInstance();
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 			'Text' => 'Game News',
146 146
 		];
147 147
 		// make the selected index bold
148
-		$boldItem =& $menuItems[$selected_index]['Text'];
148
+		$boldItem = & $menuItems[$selected_index]['Text'];
149 149
 		$boldItem = '<b>' . $boldItem . '</b>';
150 150
 
151 151
 		$template = Smr\Template::getInstance();
Please login to merge, or discard this patch.
src/lib/Smr/Database.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 	 * Not intended to be used outside the DI context.
27 27
 	 */
28 28
 	public static function mysqliFactory(DatabaseProperties $dbProperties): mysqli {
29
-		if (!mysqli_report(MYSQLI_REPORT_ERROR | MYSQLI_REPORT_STRICT)) {
29
+		if (!mysqli_report(MYSQLI_REPORT_ERROR|MYSQLI_REPORT_STRICT)) {
30 30
 			throw new RuntimeException('Failed to enable mysqli error reporting');
31 31
 		}
32 32
 		$mysql = new mysqli(
Please login to merge, or discard this patch.
src/htdocs/ship_list.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
 		'illusion' => $ship->canHaveIllusion() ? 'Yes' : '',
71 71
 		'jump' => $ship->canHaveJump() ? 'Yes' : '',
72 72
 		'scrambler' => $ship->canHaveDCS() ? 'Yes' : '',
73
-		'locs' => implode('', array_map(fn(string $name): string => '<div>' . $name . '</div>', $shipLocs)),
73
+		'locs' => implode('', array_map(fn(string $name) : string => '<div>' . $name . '</div>', $shipLocs)),
74 74
 	];
75 75
 	return $stat;
76 76
 }
Please login to merge, or discard this patch.