Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — master ( 383620...df1759 )
by Dan
03:47
created
templates/Default/engine/Default/includes/ForcesCombatResults.inc 1 patch
Spacing   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -1,34 +1,34 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if(isset($ForcesCombatResults['Results']) && is_array($ForcesCombatResults['Results'])) {
3
-	foreach($ForcesCombatResults['Results'] as $ForceType => $ForceResults) {
4
-		$ShootingWeapon =& $ForceResults['Weapon'];
5
-		$ShotHit =& $ForceResults['Hit'];
6
-		$ActualDamage =& $ForceResults['ActualDamage'];
7
-		$WeaponDamage =& $ForceResults['WeaponDamage'];
8
-		$TargetPlayer =& $ForceResults['TargetPlayer'];
2
+if (isset($ForcesCombatResults['Results']) && is_array($ForcesCombatResults['Results'])) {
3
+	foreach ($ForcesCombatResults['Results'] as $ForceType => $ForceResults) {
4
+		$ShootingWeapon = & $ForceResults['Weapon'];
5
+		$ShotHit = & $ForceResults['Hit'];
6
+		$ActualDamage = & $ForceResults['ActualDamage'];
7
+		$WeaponDamage = & $ForceResults['WeaponDamage'];
8
+		$TargetPlayer = & $ForceResults['TargetPlayer'];
9 9
 		?>
10 10
 		<span class="cds"><?php echo $ActualDamage['Launched'] ?? $WeaponDamage['Launched']; ?></span><?php
11
-		if($ForceType == 'Mines') {
11
+		if ($ForceType == 'Mines') {
12 12
 			?> mines kamikaze themselves against <?php
13
-		} else if($ForceType == 'Drones') {
13
+		} else if ($ForceType == 'Drones') {
14 14
 			?> combat drones launch at <?php
15
-		} else if($ForceType == 'Scouts') {
15
+		} else if ($ForceType == 'Scouts') {
16 16
 			?> scout drones kamikaze themselves against <?php
17 17
 		}
18 18
 		
19
-		if($ShotHit && $ActualDamage['TargetAlreadyDead']){ ?> the debris that was once <?php }
19
+		if ($ShotHit && $ActualDamage['TargetAlreadyDead']) { ?> the debris that was once <?php }
20 20
 		echo $TargetPlayer->getDisplayName();
21 21
 		if (!$ShotHit || !$ActualDamage['TargetAlreadyDead']) {
22
-			if(!$ShotHit) {
22
+			if (!$ShotHit) {
23 23
 				?> and misses<?php
24
-			} else if($ActualDamage['TotalDamage'] == 0) {
25
-				if($WeaponDamage['Shield'] > 0) {
26
-					if($ActualDamage['HasCDs']) {
24
+			} else if ($ActualDamage['TotalDamage'] == 0) {
25
+				if ($WeaponDamage['Shield'] > 0) {
26
+					if ($ActualDamage['HasCDs']) {
27 27
 						?> which proves ineffective against their combat drones<?php
28 28
 					} else {
29 29
 						?> which washes harmlessly over their hull<?php
30 30
 					}
31
-				} else if($WeaponDamage['Armour'] > 0) {
31
+				} else if ($WeaponDamage['Armour'] > 0) {
32 32
 					?> which is deflected by their shields<?php
33 33
 				} else {
34 34
 					?> but it cannot do any damage<?php
@@ -37,31 +37,31 @@  discard block
 block discarded – undo
37 37
 				?> destroying <?php
38 38
 			}
39 39
 			$DamageTypes = 0;
40
-			if($ActualDamage['Shield'] > 0){ $DamageTypes = $DamageTypes+1; }
41
-			if($ActualDamage['NumCDs'] > 0){ $DamageTypes = $DamageTypes+1; }
42
-			if($ActualDamage['Armour'] > 0){ $DamageTypes = $DamageTypes+1; }
40
+			if ($ActualDamage['Shield'] > 0) { $DamageTypes = $DamageTypes + 1; }
41
+			if ($ActualDamage['NumCDs'] > 0) { $DamageTypes = $DamageTypes + 1; }
42
+			if ($ActualDamage['Armour'] > 0) { $DamageTypes = $DamageTypes + 1; }
43 43
 
44
-			if($ActualDamage['Shield'] > 0) {
44
+			if ($ActualDamage['Shield'] > 0) {
45 45
 				?><span class="shields"><?php echo number_format($ActualDamage['Shield']) ?></span> shields<?php
46 46
 				$this->doDamageTypeReductionDisplay($DamageTypes);
47 47
 			}
48
-			if($ActualDamage['NumCDs'] > 0) {
48
+			if ($ActualDamage['NumCDs'] > 0) {
49 49
 				?><span class="cds"><?php echo number_format($ActualDamage['NumCDs']) ?></span> drones<?php
50 50
 				$this->doDamageTypeReductionDisplay($DamageTypes);
51 51
 			}
52
-			if($ActualDamage['Armour'] > 0) {
52
+			if ($ActualDamage['Armour'] > 0) {
53 53
 				?><span class="red"><?php echo number_format($ActualDamage['Armour']) ?></span> plates of armour<?php
54 54
 			}
55 55
 		} ?>.
56 56
 		<br /><?php
57 57
 		if ($ShotHit && $ActualDamage['KillingShot']) {
58
-			$this->includeTemplate('includes/TraderCombatKillMessage.inc',array('KillResults'=>$ForceResults['KillResults'],'TargetPlayer'=>$TargetPlayer));
58
+			$this->includeTemplate('includes/TraderCombatKillMessage.inc', array('KillResults'=>$ForceResults['KillResults'], 'TargetPlayer'=>$TargetPlayer));
59 59
 		}
60 60
 	}
61 61
 }
62
-if(isset($ForcesCombatResults['ForcesDestroyed']) && $ForcesCombatResults['ForcesDestroyed']) {
62
+if (isset($ForcesCombatResults['ForcesDestroyed']) && $ForcesCombatResults['ForcesDestroyed']) {
63 63
 	?>Forces are <span class="red">DESTROYED!</span><br /><?php
64 64
 }
65 65
 
66
-$TotalDamage =& $ForcesCombatResults['TotalDamage'] ?>
67
-The forces <?php if($TotalDamage > 0){ ?>hit for a total of <span class="red"><?php echo number_format($TotalDamage) ?></span> damage in this round of combat<?php } else{ ?>do no damage this round<?php } ?>.
66
+$TotalDamage = & $ForcesCombatResults['TotalDamage'] ?>
67
+The forces <?php if ($TotalDamage > 0) { ?>hit for a total of <span class="red"><?php echo number_format($TotalDamage) ?></span> damage in this round of combat<?php } else { ?>do no damage this round<?php } ?>.
Please login to merge, or discard this patch.
admin/Default/manage_draft_leaders.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -7,7 +7,7 @@
 block discarded – undo
7 7
 $db->query('SELECT game_id, game_name FROM game WHERE game_type=' . $db->escapeNumber(SmrGame::GAME_TYPE_DRAFT) . ' AND join_time < ' . $db->escapeNumber(TIME) . ' AND end_time > ' . $db->escapeNumber(TIME) . ' ORDER BY start_time DESC');
8 8
 while ($db->nextRecord()) {
9 9
 	$activeGames[] = array('game_name' => $db->getField('game_name'),
10
-	                       'game_id' => $db->getInt('game_id'));
10
+						   'game_id' => $db->getInt('game_id'));
11 11
 }
12 12
 $template->assign('ActiveGames', $activeGames);
13 13
 
Please login to merge, or discard this patch.
admin/Default/1.6/game_edit_processing.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@
 block discarded – undo
3 3
 // Get the dates ("|" sets hr/min/sec to 0)
4 4
 $join = DateTime::createFromFormat('d/m/Y|', Request::get('game_join'));
5 5
 $start = empty(Request::get('game_start')) ? $join :
6
-         DateTime::createFromFormat('d/m/Y|', Request::get('game_start'));
6
+		 DateTime::createFromFormat('d/m/Y|', Request::get('game_start'));
7 7
 $end = DateTime::createFromFormat('d/m/Y|', Request::get('game_end'));
8 8
 
9 9
 $game = SmrGame::getGame($var['game_id']);
Please login to merge, or discard this patch.
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,7 @@
 block discarded – undo
2 2
 
3 3
 // Get the dates ("|" sets hr/min/sec to 0)
4 4
 $join = DateTime::createFromFormat('d/m/Y|', Request::get('game_join'));
5
-$start = empty(Request::get('game_start')) ? $join :
6
-         DateTime::createFromFormat('d/m/Y|', Request::get('game_start'));
5
+$start = empty(Request::get('game_start')) ? $join : DateTime::createFromFormat('d/m/Y|', Request::get('game_start'));
7 6
 $end = DateTime::createFromFormat('d/m/Y|', Request::get('game_end'));
8 7
 
9 8
 $game = SmrGame::getGame($var['game_id']);
Please login to merge, or discard this patch.
admin/Default/1.6/game_create_processing.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
 // Get the dates ("|" sets hr/min/sec to 0)
17 17
 $join = DateTime::createFromFormat('d/m/Y|', Request::get('game_join'));
18 18
 $start = empty(Request::get('game_start')) ? $join :
19
-         DateTime::createFromFormat('d/m/Y|', Request::get('game_start'));
19
+		 DateTime::createFromFormat('d/m/Y|', Request::get('game_start'));
20 20
 $end = DateTime::createFromFormat('d/m/Y|', Request::get('game_end'));
21 21
 
22 22
 $game = SmrGame::createGame($newID);
Please login to merge, or discard this patch.
Spacing   +3 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,22 +1,21 @@
 block discarded – undo
1 1
 <?php declare(strict_types=1);
2 2
 
3 3
 //first create the game
4
-$db->query('SELECT game_id FROM game WHERE game_name='.$db->escapeString(Request::get('game_name')).' LIMIT 1');
4
+$db->query('SELECT game_id FROM game WHERE game_name=' . $db->escapeString(Request::get('game_name')) . ' LIMIT 1');
5 5
 if ($db->nextRecord()) {
6 6
 	create_error('That game name is already taken.');
7 7
 }
8 8
 
9 9
 $db->query('SELECT game_id FROM game ORDER BY game_id DESC LIMIT 1');
10 10
 if ($db->nextRecord()) {
11
-	$newID = $db->getInt('game_id')+1;
11
+	$newID = $db->getInt('game_id') + 1;
12 12
 } else {
13 13
 	$newID = 1;
14 14
 }
15 15
 
16 16
 // Get the dates ("|" sets hr/min/sec to 0)
17 17
 $join = DateTime::createFromFormat('d/m/Y|', Request::get('game_join'));
18
-$start = empty(Request::get('game_start')) ? $join :
19
-         DateTime::createFromFormat('d/m/Y|', Request::get('game_start'));
18
+$start = empty(Request::get('game_start')) ? $join : DateTime::createFromFormat('d/m/Y|', Request::get('game_start'));
20 19
 $end = DateTime::createFromFormat('d/m/Y|', Request::get('game_end'));
21 20
 
22 21
 $game = SmrGame::createGame($newID);
Please login to merge, or discard this patch.
admin/Default/1.6/universe_create_save_processing.php 1 patch
Braces   +5 added lines, -3 removed lines patch added patch discarded remove patch
@@ -105,13 +105,15 @@
 block discarded – undo
105 105
 		$numberOfPlanets = Request::getInt('type' . $planetTypeID);
106 106
 		for ($i = 1; $i <= $numberOfPlanets; $i++) {
107 107
 			$galSector = $galSectors[array_rand($galSectors)];
108
-			while ($galSector->hasPlanet()) $galSector = $galSectors[array_rand($galSectors)]; //1 per sector
108
+			while ($galSector->hasPlanet()) {
109
+				$galSector = $galSectors[array_rand($galSectors)];
110
+			}
111
+			//1 per sector
109 112
 			$galSector->createPlanet($planetTypeID);
110 113
 		}
111 114
 	}
112 115
 	$var['message'] = '<span class="green">Success</span> : Succesfully added planets.';
113
-}
114
-elseif ($submit == 'Create Ports') {
116
+} elseif ($submit == 'Create Ports') {
115 117
 	$numLevelPorts = [];
116 118
 	for ($i = 1; $i <= SmrPort::MAX_LEVEL; $i++) {
117 119
 		$numLevelPorts[$i] = Request::getInt('port' . $i);
Please login to merge, or discard this patch.
admin/Default/newsletter_send_processing.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
 
36 36
 // Set the body of the e-mail
37 37
 set_mail_body($mail, $var['newsletter_html'], $var['newsletter_text'],
38
-              Request::get('salutation'));
38
+			  Request::get('salutation'));
39 39
 
40 40
 if (Request::get('to_email') == '*') {
41 41
 	// Send the newsletter to all players.
Please login to merge, or discard this patch.
lib/Default/SocialLogins/Twitter.class.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
 		}
36 36
 		$helper = self::getTwitterObj($_SESSION['TwitterToken']);
37 37
 		$accessToken = $helper->oauth('oauth/access_token',
38
-		                              ['oauth_verifier' => \Request::get('oauth_verifier')]);
38
+									  ['oauth_verifier' => \Request::get('oauth_verifier')]);
39 39
 		$auth = self::getTwitterObj($accessToken);
40 40
 		$userInfo = $auth->get('account/verify_credentials', ['include_email' => 'true']);
41 41
 		if ($auth->getLastHttpCode() == 200) {
Please login to merge, or discard this patch.
lib/Default/AbstractMenu.class.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -100,16 +100,16 @@
 block discarded – undo
100 100
 		$container['view_game_id'] = $var['view_game_id'];
101 101
 		$container['game_name'] = $var['game_name'];
102 102
 		$menuItems[] = ['Link' => SmrSession::getNewHREF($container),
103
-		                'Text' => 'Game Details'];
103
+						'Text' => 'Game Details'];
104 104
 		$container['body'] = 'history_games_detail.php';
105 105
 		$menuItems[] = ['Link' => SmrSession::getNewHREF($container),
106
-		                'Text' => 'Extended Stats'];
106
+						'Text' => 'Extended Stats'];
107 107
 		$container['body'] = 'history_games_hof.php';
108 108
 		$menuItems[] = ['Link' => SmrSession::getNewHREF($container),
109
-		                'Text' => 'Hall of Fame'];
109
+						'Text' => 'Hall of Fame'];
110 110
 		$container['body'] = 'history_games_news.php';
111 111
 		$menuItems[] = ['Link' => SmrSession::getNewHREF($container),
112
-		                'Text' => 'Game News'];
112
+						'Text' => 'Game News'];
113 113
 		// make the selected index bold
114 114
 		$boldItem =& $menuItems[$selected_index]['Text'];
115 115
 		$boldItem = '<b>' . $boldItem . '</b>';
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
 		$menuItems[] = array('Link'=>Globals::getPlanetListHREF($alliance_id), 'Text'=>'Defense');
13 13
 		$menuItems[] = array('Link'=>Globals::getPlanetListFinancialHREF($alliance_id), 'Text'=>'Financial');
14 14
 		// make the selected index bold
15
-		$boldItem =& $menuItems[$selected_index]['Text'];
15
+		$boldItem = & $menuItems[$selected_index]['Text'];
16 16
 		$boldItem = '<span class="bold">' . $boldItem . '</span>';
17 17
 		$template->assign('MenuItems', $menuItems);
18 18
 	}
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 		$menuItems[] = ['Link' => SmrSession::getNewHREF($container),
108 108
 		                'Text' => 'Game News'];
109 109
 		// make the selected index bold
110
-		$boldItem =& $menuItems[$selected_index]['Text'];
110
+		$boldItem = & $menuItems[$selected_index]['Text'];
111 111
 		$boldItem = '<b>' . $boldItem . '</b>';
112 112
 		$template->assign('MenuItems', $menuItems);
113 113
 	}
Please login to merge, or discard this patch.
htdocs/login_processing.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
 			exit;
70 70
 		}
71 71
 		$account->addAuthMethod($_SESSION['socialLogin']->getLoginType(),
72
-		                        $_SESSION['socialLogin']->getUserID());
72
+								$_SESSION['socialLogin']->getUserID());
73 73
 		session_destroy();
74 74
 	}
75 75
 
Please login to merge, or discard this patch.