ShipIllusion::__construct() - Code Metrics - Inspection of "Increase PHPStan level from 6 -> 7" - smrealms/smr - Measure and Improve Code Quality continuously with Scrutinizer

smr

Failed Conditions

Pull Request — main (#1508)

by Dan

created 2023-01-08 20:48 UTC

ShipIllusion::__construct() A

↳ Parent: ShipIllusion

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	0

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	0
nc	1
nop	3
dl	0
loc	5
rs	10
c	1
b	0
f	0

<?php declare(strict_types=1);

namespace Smr;

use SmrShipType;

/**
 * Data storage for the SmrShip::illusionShip property.
 */
class ShipIllusion {

	public function __construct(
		public readonly int $shipTypeID,
		public readonly int $attackRating,
		public readonly int $defenseRating,
	) {}

	public function getName(): string {
		return SmrShipType::get($this->shipTypeID)->getName();
	}

}


1			<?php declare(strict_types=1);
2
3			namespace Smr;
4
5			use SmrShipType;
6
7			/**
8			* Data storage for the SmrShip::illusionShip property.
9			*/
10			class ShipIllusion {
11
12			public function __construct(
13			public readonly int $shipTypeID,
14			public readonly int $attackRating,
15			public readonly int $defenseRating,
16			) {}
17
18			public function getName(): string {
19			return SmrShipType::get($this->shipTypeID)->getName();
20			}
21
22			}
23

smrealms / smr

Scrutinizer GitHub App not installed

Pull Request — main (#1508)

ShipIllusion::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like