HardwareType::getAll() - Code Metrics - Inspection of "Increase PHPStan level from 6 -> 7" - smrealms/smr - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — main (#1508)

by Dan

created 2023-01-08 20:48 UTC

HardwareType::getAll() A

↳ Parent: HardwareType

Complexity

Conditions	3
Paths	2

Size

Total Lines	14
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	10
nc	2
nop	0
dl	0
loc	14
rs	9.9332
c	1
b	0
f	0

<?php declare(strict_types=1);

namespace Smr;

class HardwareType {

	/** @var array<int, self> */
	private static array $CACHE_HARDWARE_TYPES = [];

	public static function clearCache(): void {
		self::$CACHE_HARDWARE_TYPES = [];
	}

	/**
	 * @return array<int, self>
	 */
	public static function getAll(): array {
		if (empty(self::$CACHE_HARDWARE_TYPES)) {
			$db = Database::getInstance();
			$dbResult = $db->read('SELECT * FROM hardware_type');
			foreach ($dbResult->records() as $dbRecord) {
				$typeID = $dbRecord->getInt('hardware_type_id');
				self::$CACHE_HARDWARE_TYPES[$typeID] = new self(
					typeID: $typeID,
					name: $dbRecord->getString('hardware_name'),
					cost: $dbRecord->getInt('cost'),
				);
			}
		}
		return self::$CACHE_HARDWARE_TYPES;
	}

	public static function get(int $hardwareTypeID): self {
		return self::getAll()[$hardwareTypeID];
	}

	public function __construct(
		public readonly int $typeID,
		public readonly string $name,
		public readonly int $cost,
	) {}

}


1			<?php declare(strict_types=1);
2
3			namespace Smr;
4
5			class HardwareType {
6
7			/** @var array<int, self> */
8			private static array $CACHE_HARDWARE_TYPES = [];
9
10			public static function clearCache(): void {
11			self::$CACHE_HARDWARE_TYPES = [];
12			}
13
14			/**
15			* @return array<int, self>
16			*/
17			public static function getAll(): array {
18			if (empty(self::$CACHE_HARDWARE_TYPES)) {
19			$db = Database::getInstance();
20			$dbResult = $db->read('SELECT * FROM hardware_type');
21			foreach ($dbResult->records() as $dbRecord) {
22			$typeID = $dbRecord->getInt('hardware_type_id');
23			self::$CACHE_HARDWARE_TYPES[$typeID] = new self(
24			typeID: $typeID,
25			name: $dbRecord->getString('hardware_name'),
26			cost: $dbRecord->getInt('cost'),
27			);
28			}
29			}
30			return self::$CACHE_HARDWARE_TYPES;
31			}
32
33			public static function get(int $hardwareTypeID): self {
34			return self::getAll()[$hardwareTypeID];
35			}
36
37			public function __construct(
38			public readonly int $typeID,
39			public readonly string $name,
40			public readonly int $cost,
41			) {}
42
43			}
44

smrealms / smr

Scrutinizer GitHub App not installed

Pull Request — main (#1508)

HardwareType::getAll() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like