We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
@@ -242,9 +242,9 @@ |
||
| 242 | 242 | */ |
| 243 | 243 | public function canFight() { |
| 244 | 244 | return !($this->hasNewbieTurns() || |
| 245 | - $this->isDead() || |
|
| 246 | - $this->isLandedOnPlanet() || |
|
| 247 | - $this->hasFederalProtection()); |
|
| 245 | + $this->isDead() || |
|
| 246 | + $this->isLandedOnPlanet() || |
|
| 247 | + $this->hasFederalProtection()); |
|
| 248 | 248 | } |
| 249 | 249 | |
| 250 | 250 | public function setDead($bool) { |
@@ -929,8 +929,8 @@ discard block |
||
| 929 | 929 | } |
| 930 | 930 | self::$HOFVis[$hofType] = $visibility; |
| 931 | 931 | |
| 932 | - $hof =& $this->HOF; |
|
| 933 | - $hofChanged =& $this->hasHOFChanged; |
|
| 932 | + $hof = & $this->HOF; |
|
| 933 | + $hofChanged = & $this->hasHOFChanged; |
|
| 934 | 934 | $new = false; |
| 935 | 935 | foreach ($typeList as $type) { |
| 936 | 936 | if (!isset($hofChanged[$type])) { |
@@ -940,8 +940,8 @@ discard block |
||
| 940 | 940 | $hof[$type] = array(); |
| 941 | 941 | $new = true; |
| 942 | 942 | } |
| 943 | - $hof =& $hof[$type]; |
|
| 944 | - $hofChanged =& $hofChanged[$type]; |
|
| 943 | + $hof = & $hof[$type]; |
|
| 944 | + $hofChanged = & $hofChanged[$type]; |
|
| 945 | 945 | } |
| 946 | 946 | if ($hofChanged == null) { |
| 947 | 947 | $hofChanged = self::HOF_CHANGED; |
@@ -1097,7 +1097,7 @@ discard block |
||
| 1097 | 1097 | } |
| 1098 | 1098 | |
| 1099 | 1099 | private function setupMissionStep($missionID) { |
| 1100 | - $mission =& $this->missions[$missionID]; |
|
| 1100 | + $mission = & $this->missions[$missionID]; |
|
| 1101 | 1101 | if ($mission['On Step'] >= count(MISSIONS[$missionID]['Steps'])) { |
| 1102 | 1102 | // Nothing to do if this mission is already completed |
| 1103 | 1103 | return; |
@@ -1142,7 +1142,7 @@ discard block |
||
| 1142 | 1142 | 'Starting Sector' => $this->getSectorID() |
| 1143 | 1143 | ); |
| 1144 | 1144 | |
| 1145 | - $this->missions[$missionID] =& $mission; |
|
| 1145 | + $this->missions[$missionID] = & $mission; |
|
| 1146 | 1146 | $this->setupMissionStep($missionID); |
| 1147 | 1147 | $this->rebuildMission($missionID); |
| 1148 | 1148 | |
@@ -1201,7 +1201,7 @@ discard block |
||
| 1201 | 1201 | |
| 1202 | 1202 | public function claimMissionReward($missionID) { |
| 1203 | 1203 | $this->getMissions(); |
| 1204 | - $mission =& $this->missions[$missionID]; |
|
| 1204 | + $mission = & $this->missions[$missionID]; |
|
| 1205 | 1205 | if ($mission === false) { |
| 1206 | 1206 | throw new Exception('Unknown mission: ' . $missionID); |
| 1207 | 1207 | } |
@@ -549,7 +549,7 @@ |
||
| 549 | 549 | */ |
| 550 | 550 | public function setWarp(SmrSector $warp) { |
| 551 | 551 | if ($this->getWarp() == $warp->getSectorID() && |
| 552 | - $warp->getWarp() == $this->getSectorID()) { |
|
| 552 | + $warp->getWarp() == $this->getSectorID()) { |
|
| 553 | 553 | // Warps are already set correctly! |
| 554 | 554 | return; |
| 555 | 555 | } |
@@ -446,20 +446,20 @@ |
||
| 446 | 446 | |
| 447 | 447 | if ($this->hasMines()) { |
| 448 | 448 | $thisMines = new SmrMines($this->getGameID(), $this->getMines()); |
| 449 | - $results['Results']['Mines'] =& $thisMines->shootPlayerAsForce($this, $targetPlayers[array_rand($targetPlayers)], $minesAreAttacker); |
|
| 449 | + $results['Results']['Mines'] = & $thisMines->shootPlayerAsForce($this, $targetPlayers[array_rand($targetPlayers)], $minesAreAttacker); |
|
| 450 | 450 | $results['TotalDamage'] += $results['Results']['Mines']['ActualDamage']['TotalDamage']; |
| 451 | 451 | } |
| 452 | 452 | |
| 453 | 453 | if ($this->hasCDs()) { |
| 454 | 454 | $thisCDs = new SmrCombatDrones($this->getGameID(), $this->getCDs()); |
| 455 | - $results['Results']['Drones'] =& $thisCDs->shootPlayerAsForce($this, $targetPlayers[array_rand($targetPlayers)]); |
|
| 455 | + $results['Results']['Drones'] = & $thisCDs->shootPlayerAsForce($this, $targetPlayers[array_rand($targetPlayers)]); |
|
| 456 | 456 | $results['TotalDamage'] += $results['Results']['Drones']['ActualDamage']['TotalDamage']; |
| 457 | 457 | } |
| 458 | 458 | |
| 459 | 459 | if (!$minesAreAttacker) { |
| 460 | 460 | if ($this->hasSDs()) { |
| 461 | 461 | $thisSDs = new SmrScoutDrones($this->getGameID(), $this->getSDs()); |
| 462 | - $results['Results']['Scouts'] =& $thisSDs->shootPlayerAsForce($this, $targetPlayers[array_rand($targetPlayers)]); |
|
| 462 | + $results['Results']['Scouts'] = & $thisSDs->shootPlayerAsForce($this, $targetPlayers[array_rand($targetPlayers)]); |
|
| 463 | 463 | $results['TotalDamage'] += $results['Results']['Scouts']['ActualDamage']['TotalDamage']; |
| 464 | 464 | } |
| 465 | 465 | } |
@@ -100,16 +100,16 @@ |
||
| 100 | 100 | $container['view_game_id'] = $var['view_game_id']; |
| 101 | 101 | $container['game_name'] = $var['game_name']; |
| 102 | 102 | $menuItems[] = ['Link' => SmrSession::getNewHREF($container), |
| 103 | - 'Text' => 'Game Details']; |
|
| 103 | + 'Text' => 'Game Details']; |
|
| 104 | 104 | $container['body'] = 'history_games_detail.php'; |
| 105 | 105 | $menuItems[] = ['Link' => SmrSession::getNewHREF($container), |
| 106 | - 'Text' => 'Extended Stats']; |
|
| 106 | + 'Text' => 'Extended Stats']; |
|
| 107 | 107 | $container['body'] = 'history_games_hof.php'; |
| 108 | 108 | $menuItems[] = ['Link' => SmrSession::getNewHREF($container), |
| 109 | - 'Text' => 'Hall of Fame']; |
|
| 109 | + 'Text' => 'Hall of Fame']; |
|
| 110 | 110 | $container['body'] = 'history_games_news.php'; |
| 111 | 111 | $menuItems[] = ['Link' => SmrSession::getNewHREF($container), |
| 112 | - 'Text' => 'Game News']; |
|
| 112 | + 'Text' => 'Game News']; |
|
| 113 | 113 | // make the selected index bold |
| 114 | 114 | $boldItem =& $menuItems[$selected_index]['Text']; |
| 115 | 115 | $boldItem = '<b>' . $boldItem . '</b>'; |
@@ -12,7 +12,7 @@ discard block |
||
| 12 | 12 | $menuItems[] = array('Link'=>Globals::getPlanetListHREF($alliance_id), 'Text'=>'Defense'); |
| 13 | 13 | $menuItems[] = array('Link'=>Globals::getPlanetListFinancialHREF($alliance_id), 'Text'=>'Financial'); |
| 14 | 14 | // make the selected index bold |
| 15 | - $boldItem =& $menuItems[$selected_index]['Text']; |
|
| 15 | + $boldItem = & $menuItems[$selected_index]['Text']; |
|
| 16 | 16 | $boldItem = '<span class="bold">' . $boldItem . '</span>'; |
| 17 | 17 | $template->assign('MenuItems', $menuItems); |
| 18 | 18 | } |
@@ -107,7 +107,7 @@ discard block |
||
| 107 | 107 | $menuItems[] = ['Link' => SmrSession::getNewHREF($container), |
| 108 | 108 | 'Text' => 'Game News']; |
| 109 | 109 | // make the selected index bold |
| 110 | - $boldItem =& $menuItems[$selected_index]['Text']; |
|
| 110 | + $boldItem = & $menuItems[$selected_index]['Text']; |
|
| 111 | 111 | $boldItem = '<b>' . $boldItem . '</b>'; |
| 112 | 112 | $template->assign('MenuItems', $menuItems); |
| 113 | 113 | } |
@@ -40,7 +40,7 @@ discard block |
||
| 40 | 40 | /** |
| 41 | 41 | * Access properties of structures that this planet type can build. |
| 42 | 42 | */ |
| 43 | - public function structureTypes($structureID=false) { |
|
| 43 | + public function structureTypes($structureID = false) { |
|
| 44 | 44 | if (!isset($this->structures)) { |
| 45 | 45 | foreach (static::STRUCTURES as $ID => $Info) { |
| 46 | 46 | $this->structures[$ID] = new SmrPlanetStructureType($ID, $Info); |
@@ -77,12 +77,12 @@ discard block |
||
| 77 | 77 | 'exp_gain' => 540, |
| 78 | 78 | ], |
| 79 | 79 | ]; |
| 80 | - public function name() { return "Terran Planet"; } |
|
| 81 | - public function imageLink() { return "images/planet1.png"; } |
|
| 82 | - public function description() { return "A lush world, with forests, seas, sweeping meadows, and indigenous lifeforms."; } |
|
| 80 | + public function name() { return "Terran Planet"; } |
|
| 81 | + public function imageLink() { return "images/planet1.png"; } |
|
| 82 | + public function description() { return "A lush world, with forests, seas, sweeping meadows, and indigenous lifeforms."; } |
|
| 83 | 83 | public function maxAttackers() { return 10; } |
| 84 | - public function maxLanded() { return self::MAX_LANDED_UNLIMITED; } |
|
| 85 | - public function menuOptions() { return self::DEFAULT_MENU_OPTIONS; } |
|
| 84 | + public function maxLanded() { return self::MAX_LANDED_UNLIMITED; } |
|
| 85 | + public function menuOptions() { return self::DEFAULT_MENU_OPTIONS; } |
|
| 86 | 86 | } |
| 87 | 87 | |
| 88 | 88 | class AridPlanet extends SmrPlanetType { |
@@ -106,12 +106,12 @@ discard block |
||
| 106 | 106 | 'exp_gain' => 180, |
| 107 | 107 | ], |
| 108 | 108 | ]; |
| 109 | - public function name() { return "Arid Planet"; } |
|
| 110 | - public function imageLink() { return "images/planet2.png"; } |
|
| 111 | - public function description() { return "A world mostly devoid of surface water, but capable of supporting life."; } |
|
| 109 | + public function name() { return "Arid Planet"; } |
|
| 110 | + public function imageLink() { return "images/planet2.png"; } |
|
| 111 | + public function description() { return "A world mostly devoid of surface water, but capable of supporting life."; } |
|
| 112 | 112 | public function maxAttackers() { return 5; } |
| 113 | - public function maxLanded() { return 5; } |
|
| 114 | - public function menuOptions() { return ['CONSTRUCTION', 'DEFENSE', 'STOCKPILE', 'OWNERSHIP']; } |
|
| 113 | + public function maxLanded() { return 5; } |
|
| 114 | + public function menuOptions() { return ['CONSTRUCTION', 'DEFENSE', 'STOCKPILE', 'OWNERSHIP']; } |
|
| 115 | 115 | } |
| 116 | 116 | |
| 117 | 117 | class DwarfPlanet extends SmrPlanetType { |
@@ -135,12 +135,12 @@ discard block |
||
| 135 | 135 | 'exp_gain' => 540, |
| 136 | 136 | ], |
| 137 | 137 | ]; |
| 138 | - public function name() { return "Dwarf Planet"; } |
|
| 139 | - public function imageLink() { return "images/planet3.png"; } |
|
| 140 | - public function description() { return "A smaller than usual planet, with no native life present."; } |
|
| 138 | + public function name() { return "Dwarf Planet"; } |
|
| 139 | + public function imageLink() { return "images/planet3.png"; } |
|
| 140 | + public function description() { return "A smaller than usual planet, with no native life present."; } |
|
| 141 | 141 | public function maxAttackers() { return 5; } |
| 142 | - public function maxLanded() { return self::MAX_LANDED_UNLIMITED; } |
|
| 143 | - public function menuOptions() { return self::DEFAULT_MENU_OPTIONS; } |
|
| 142 | + public function maxLanded() { return self::MAX_LANDED_UNLIMITED; } |
|
| 143 | + public function menuOptions() { return self::DEFAULT_MENU_OPTIONS; } |
|
| 144 | 144 | } |
| 145 | 145 | |
| 146 | 146 | class ProtoPlanet extends SmrPlanetType { |
@@ -170,12 +170,12 @@ discard block |
||
| 170 | 170 | 'exp_gain' => 540, |
| 171 | 171 | ], |
| 172 | 172 | ]; |
| 173 | - public function name() { return "Protoplanet"; } |
|
| 174 | - public function imageLink() { return "images/planet5.png"; } |
|
| 175 | - public function description() { return "A developing planet, not yet able to support the infrastructure of advanced technologies."; } |
|
| 173 | + public function name() { return "Protoplanet"; } |
|
| 174 | + public function imageLink() { return "images/planet5.png"; } |
|
| 175 | + public function description() { return "A developing planet, not yet able to support the infrastructure of advanced technologies."; } |
|
| 176 | 176 | public function maxAttackers() { return 5; } |
| 177 | - public function maxLanded() { return 5; } |
|
| 178 | - public function menuOptions() { return self::DEFAULT_MENU_OPTIONS; } |
|
| 177 | + public function maxLanded() { return 5; } |
|
| 178 | + public function menuOptions() { return self::DEFAULT_MENU_OPTIONS; } |
|
| 179 | 179 | } |
| 180 | 180 | |
| 181 | 181 | class DefenseWorld extends SmrPlanetType { |
@@ -205,10 +205,10 @@ discard block |
||
| 205 | 205 | 'exp_gain' => 9, |
| 206 | 206 | ], |
| 207 | 207 | ]; |
| 208 | - public function name() { return "Defense World"; } |
|
| 209 | - public function imageLink() { return "images/planet4.png"; } |
|
| 210 | - public function description() { return "A fully armed and operational battle station loaded with excessive firepower."; } |
|
| 208 | + public function name() { return "Defense World"; } |
|
| 209 | + public function imageLink() { return "images/planet4.png"; } |
|
| 210 | + public function description() { return "A fully armed and operational battle station loaded with excessive firepower."; } |
|
| 211 | 211 | public function maxAttackers() { return 10; } |
| 212 | - public function maxLanded() { return self::MAX_LANDED_UNLIMITED; } |
|
| 213 | - public function menuOptions() { return self::DEFAULT_MENU_OPTIONS; } |
|
| 212 | + public function maxLanded() { return self::MAX_LANDED_UNLIMITED; } |
|
| 213 | + public function menuOptions() { return self::DEFAULT_MENU_OPTIONS; } |
|
| 214 | 214 | } |
@@ -960,7 +960,7 @@ |
||
| 960 | 960 | |
| 961 | 961 | public function calculateExperiencePercent($idealPrice, $offerPrice, $bargainPrice, $transactionType) { |
| 962 | 962 | if (($transactionType == 'Sell' && $bargainPrice < $offerPrice) || |
| 963 | - ($transactionType == 'Buy' && $bargainPrice > $offerPrice)) { |
|
| 963 | + ($transactionType == 'Buy' && $bargainPrice > $offerPrice)) { |
|
| 964 | 964 | return 0; |
| 965 | 965 | } |
| 966 | 966 | if ($bargainPrice == $idealPrice || $transactionType == 'Steal') { |
@@ -1180,7 +1180,7 @@ discard block |
||
| 1180 | 1180 | do { |
| 1181 | 1181 | $targetPlayer = $targetPlayers[array_rand($targetPlayers)]; |
| 1182 | 1182 | } while ($results['TotalShotsPerTargetPlayer'][$targetPlayer->getAccountID()] > min($results['TotalShotsPerTargetPlayer'])); |
| 1183 | - $results['Weapons'][$orderID] =& $weapon->shootPlayerAsPort($this, $targetPlayer); |
|
| 1183 | + $results['Weapons'][$orderID] = & $weapon->shootPlayerAsPort($this, $targetPlayer); |
|
| 1184 | 1184 | $results['TotalShotsPerTargetPlayer'][$targetPlayer->getAccountID()]++; |
| 1185 | 1185 | if ($results['Weapons'][$orderID]['Hit']) { |
| 1186 | 1186 | $results['TotalDamage'] += $results['Weapons'][$orderID]['ActualDamage']['TotalDamage']; |
@@ -1189,7 +1189,7 @@ discard block |
||
| 1189 | 1189 | } |
| 1190 | 1190 | if ($this->hasCDs()) { |
| 1191 | 1191 | $thisCDs = new SmrCombatDrones($this->getGameID(), $this->getCDs(), true); |
| 1192 | - $results['Drones'] =& $thisCDs->shootPlayerAsPort($this, $targetPlayers[array_rand($targetPlayers)]); |
|
| 1192 | + $results['Drones'] = & $thisCDs->shootPlayerAsPort($this, $targetPlayers[array_rand($targetPlayers)]); |
|
| 1193 | 1193 | $results['TotalDamage'] += $results['Drones']['ActualDamage']['TotalDamage']; |
| 1194 | 1194 | $results['TotalDamagePerTargetPlayer'][$results['Drones']['TargetPlayer']->getAccountID()] += $results['Drones']['ActualDamage']['TotalDamage']; |
| 1195 | 1195 | } |
@@ -13,7 +13,7 @@ |
||
| 13 | 13 | public function __construct($dbName) { |
| 14 | 14 | if (!self::$dbConn) { |
| 15 | 15 | self::$dbConn = new mysqli(self::$host, self::$user, self::$password, |
| 16 | - $dbName, self::$port, self::$socket); |
|
| 16 | + $dbName, self::$port, self::$socket); |
|
| 17 | 17 | if (self::$dbConn->connect_errno) { |
| 18 | 18 | $this->error('Connection failed: ' . self::$dbConn->connect_error); |
| 19 | 19 | } |
@@ -707,7 +707,7 @@ |
||
| 707 | 707 | if ($buildingTypeID === false) { |
| 708 | 708 | $structs = $this->typeInfo::STRUCTURES; |
| 709 | 709 | return array_combine(array_keys($structs), |
| 710 | - array_column($structs, 'max_amount')); |
|
| 710 | + array_column($structs, 'max_amount')); |
|
| 711 | 711 | } |
| 712 | 712 | return $this->getStructureTypes($buildingTypeID)->maxAmount(); |
| 713 | 713 | } |
@@ -1146,7 +1146,7 @@ discard block |
||
| 1146 | 1146 | $results['DeadBeforeShot'] = false; |
| 1147 | 1147 | $weapons = $this->getWeapons(); |
| 1148 | 1148 | foreach ($weapons as $orderID => $weapon) { |
| 1149 | - $results['Weapons'][$orderID] =& $weapon->shootPlayerAsPlanet($this, $targetPlayers[array_rand($targetPlayers)]); |
|
| 1149 | + $results['Weapons'][$orderID] = & $weapon->shootPlayerAsPlanet($this, $targetPlayers[array_rand($targetPlayers)]); |
|
| 1150 | 1150 | if ($results['Weapons'][$orderID]['Hit']) { |
| 1151 | 1151 | $results['TotalDamage'] += $results['Weapons'][$orderID]['ActualDamage']['TotalDamage']; |
| 1152 | 1152 | $results['TotalDamagePerTargetPlayer'][$results['Weapons'][$orderID]['TargetPlayer']->getAccountID()] += $results['Weapons'][$orderID]['ActualDamage']['TotalDamage']; |
@@ -1154,7 +1154,7 @@ discard block |
||
| 1154 | 1154 | } |
| 1155 | 1155 | if ($this->hasCDs()) { |
| 1156 | 1156 | $thisCDs = new SmrCombatDrones($this->getGameID(), $this->getCDs(), true); |
| 1157 | - $results['Drones'] =& $thisCDs->shootPlayerAsPlanet($this, $targetPlayers[array_rand($targetPlayers)]); |
|
| 1157 | + $results['Drones'] = & $thisCDs->shootPlayerAsPlanet($this, $targetPlayers[array_rand($targetPlayers)]); |
|
| 1158 | 1158 | $results['TotalDamage'] += $results['Drones']['ActualDamage']['TotalDamage']; |
| 1159 | 1159 | $results['TotalDamagePerTargetPlayer'][$results['Drones']['TargetPlayer']->getAccountID()] += $results['Drones']['ActualDamage']['TotalDamage']; |
| 1160 | 1160 | } |
@@ -197,7 +197,7 @@ |
||
| 197 | 197 | while ($this->db->nextRecord()) { |
| 198 | 198 | try { |
| 199 | 199 | $otherPlayer = SmrPlayer::getPlayer($this->db->getInt('from_account_id'), |
| 200 | - $this->getGameID(), $forceUpdate); |
|
| 200 | + $this->getGameID(), $forceUpdate); |
|
| 201 | 201 | } catch (PlayerNotFoundException $e) { |
| 202 | 202 | // Skip players that have not joined this game |
| 203 | 203 | continue; |
@@ -207,7 +207,7 @@ discard block |
||
| 207 | 207 | /** |
| 208 | 208 | * Insert a new player into the database. Returns the new player object. |
| 209 | 209 | */ |
| 210 | - public static function createPlayer($accountID, $gameID, $playerName, $raceID, $isNewbie, $npc=false) { |
|
| 210 | + public static function createPlayer($accountID, $gameID, $playerName, $raceID, $isNewbie, $npc = false) { |
|
| 211 | 211 | // Put the player in a sector with an HQ |
| 212 | 212 | $startSectorID = self::getHome($gameID, $raceID); |
| 213 | 213 | |
@@ -1163,13 +1163,13 @@ discard block |
||
| 1163 | 1163 | $this->db->query('SELECT type,amount FROM player_hof WHERE ' . $this->SQL); |
| 1164 | 1164 | $this->HOF = array(); |
| 1165 | 1165 | while ($this->db->nextRecord()) { |
| 1166 | - $hof =& $this->HOF; |
|
| 1166 | + $hof = & $this->HOF; |
|
| 1167 | 1167 | $typeList = explode(':', $this->db->getField('type')); |
| 1168 | 1168 | foreach ($typeList as $type) { |
| 1169 | 1169 | if (!isset($hof[$type])) { |
| 1170 | 1170 | $hof[$type] = array(); |
| 1171 | 1171 | } |
| 1172 | - $hof =& $hof[$type]; |
|
| 1172 | + $hof = & $hof[$type]; |
|
| 1173 | 1173 | } |
| 1174 | 1174 | $hof = $this->db->getFloat('amount'); |
| 1175 | 1175 | } |
@@ -1611,7 +1611,7 @@ discard block |
||
| 1611 | 1611 | create_error('The saved sector must be in the box!'); |
| 1612 | 1612 | } |
| 1613 | 1613 | |
| 1614 | - $storedDestinations =& $this->getStoredDestinations(); |
|
| 1614 | + $storedDestinations = & $this->getStoredDestinations(); |
|
| 1615 | 1615 | foreach ($storedDestinations as &$sd) { |
| 1616 | 1616 | if ($sd['SectorID'] == $sectorID) { |
| 1617 | 1617 | $sd['OffsetTop'] = $offsetTop; |