smrealms /
smr
We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
| Conditions | 23 |
| Paths | 312 |
| Total Lines | 86 |
| Code Lines | 61 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.
There are several approaches to avoid long parameter lists:
| 1 | <?php declare(strict_types=1); |
||
| 88 | public static function findDistanceToX($x, SmrSector $sector, $useFirst, AbstractSmrPlayer $needsToHaveBeenExploredBy = null, AbstractSmrPlayer $player = null, $distanceLimit = 10000, $lowLimit = 0, $highLimit = 100000) { |
||
| 89 | $warpAddIndex = TURNS_WARP_SECTOR_EQUIVALENCE - 1; |
||
| 90 | |||
| 91 | $checkSector = $sector; |
||
| 92 | $gameID = $sector->getGameID(); |
||
| 93 | $distances = array(); |
||
| 94 | $sectorsTravelled = 0; |
||
| 95 | $visitedSectors = array(); |
||
| 96 | $visitedSectors[$checkSector->getSectorID()] = true; |
||
| 97 | if ($x == 'Distance') { |
||
| 98 | $distances[0][$checkSector->getSectorID()] = new Distance($gameID, $checkSector->getSectorID()); |
||
| 99 | } |
||
| 100 | |||
| 101 | $distanceQ = array(); |
||
| 102 | for ($i = 0; $i <= TURNS_WARP_SECTOR_EQUIVALENCE; $i++) { |
||
| 103 | $distanceQ[] = array(); |
||
| 104 | } |
||
| 105 | //Warps first as a slight optimisation due to how visitedSectors is set. |
||
| 106 | if ($checkSector->hasWarp() === true) { |
||
| 107 | $d = new Distance($gameID, $checkSector->getSectorID()); |
||
| 108 | $d->addWarpToPath($checkSector->getWarp(), $checkSector->getSectorID()); |
||
| 109 | $distanceQ[$warpAddIndex][] = $d; |
||
| 110 | } |
||
| 111 | foreach ($checkSector->getLinks() as $nextSector) { |
||
| 112 | if ($nextSector !== 0) { |
||
| 113 | $visitedSectors[$nextSector] = true; |
||
| 114 | $d = new Distance($gameID, $checkSector->getSectorID()); |
||
| 115 | $d->addToPath($nextSector); |
||
| 116 | $distanceQ[0][] = $d; |
||
| 117 | } |
||
| 118 | } |
||
| 119 | $maybeWarps = 0; |
||
| 120 | while ($maybeWarps <= TURNS_WARP_SECTOR_EQUIVALENCE) { |
||
| 121 | $sectorsTravelled++; |
||
| 122 | if ($sectorsTravelled > $distanceLimit) { |
||
| 123 | return $distances; |
||
| 124 | } |
||
| 125 | if ($x == 'Distance') { |
||
| 126 | $distances[$sectorsTravelled] = array(); |
||
| 127 | } |
||
| 128 | $distanceQ[] = array(); |
||
| 129 | if (count($q = array_shift($distanceQ)) === 0) { |
||
| 130 | $maybeWarps++; |
||
| 131 | continue; |
||
| 132 | } |
||
| 133 | $maybeWarps = 0; |
||
| 134 | while (($distance = array_shift($q)) !== null) { |
||
| 135 | $checkSectorID = $distance->getEndSectorID(); |
||
| 136 | $visitedSectors[$checkSectorID] = true; // This is here for warps, because they are delayed visits if we set this before the actual visit we'll get sectors marked as visited long before they are actually visited - causes problems when it's quicker to walk to the warp exit than to warp there. |
||
| 137 | // We still need to mark walked sectors as visited before we go to each one otherwise we get a huge number of paths being checked twice (up then left, left then up are essentially the same but if we set up-left as visited only when we actually check it then it gets queued up twice - nasty) |
||
| 138 | if ($checkSectorID >= $lowLimit && $checkSectorID <= $highLimit) { |
||
| 139 | $checkSector = SmrSector::getSector($gameID, $checkSectorID); |
||
| 140 | if ($x == 'Distance') { |
||
| 141 | $distances[$sectorsTravelled][$checkSector->getSectorID()] = $distance; |
||
| 142 | } elseif (($needsToHaveBeenExploredBy === null || $needsToHaveBeenExploredBy->hasVisitedSector($checkSector->getSectorID())) === true |
||
| 143 | && $checkSector->hasX($x, $player) === true) { |
||
| 144 | if ($useFirst === true) { |
||
| 145 | return $distance; |
||
| 146 | } |
||
| 147 | $distances[$checkSector->getSectorID()] = $distance; |
||
| 148 | } |
||
| 149 | //Warps first as a slight optimisation due to how visitedSectors is set. |
||
| 150 | if ($checkSector->hasWarp() === true) { |
||
| 151 | if (!isset($visitedSectors[$checkSector->getWarp()])) { |
||
| 152 | $cloneDistance = clone($distance); |
||
| 153 | $cloneDistance->addWarpToPath($checkSector->getWarp(), $checkSector->getSectorID()); |
||
| 154 | $distanceQ[$warpAddIndex][] = $cloneDistance; |
||
| 155 | } |
||
| 156 | } |
||
| 157 | foreach ($checkSector->getLinks() as $nextSector) { |
||
| 158 | if (!isset($visitedSectors[$nextSector])) { |
||
| 159 | $visitedSectors[$nextSector] = true; |
||
| 160 | |||
| 161 | $cloneDistance = clone($distance); |
||
| 162 | $cloneDistance->addToPath($nextSector); |
||
| 163 | $distanceQ[0][] = $cloneDistance; |
||
| 164 | } |
||
| 165 | } |
||
| 166 | } |
||
| 167 | } |
||
| 168 | } |
||
| 169 | if ($useFirst === true) { |
||
| 170 | $return = false; |
||
| 171 | return $return; |
||
| 172 | } |
||
| 173 | return $distances; |
||
| 174 | } |
||
| 195 |
