Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#924)
by
unknown
04:36
created
lib/Default/Routes/RouteGenerator.class.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
 				foreach (\Globals::getGoods() as $goodId => $value) {
94 94
 					if ($goods[$goodId] === true) {
95 95
 						if ($sectors[$currentSectorId]->getPort()->getGoodTransaction($goodId) === self::GOOD_SELLS &&
96
-						    $sectors[$targetSectorId]->getPort()->getGoodTransaction($goodId) === self::GOOD_BUYS) {
96
+							$sectors[$targetSectorId]->getPort()->getGoodTransaction($goodId) === self::GOOD_BUYS) {
97 97
 							$rl[] = new OneWayRoute($currentSectorId, $targetSectorId, $raceID, $sectors[$targetSectorId]->getPort()->getRaceID(), $sectors[$currentSectorId]->getPort()->getGoodDistance($goodId), $sectors[$targetSectorId]->getPort()->getGoodDistance($goodId), $distance, $goodId);
98 98
 						}
99 99
 					}
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 				foreach (\Globals::getGoods() as $goodId => $value) {
122 122
 					if ($goods[$goodId] === true) {
123 123
 						if ($sectors[$currentSectorId]->getPort()->getGoodTransaction($goodId) === self::GOOD_SELLS &&
124
-						    $sectors[$targetSectorId]->getPort()->getGoodTransaction($goodId) === self::GOOD_BUYS) {
124
+							$sectors[$targetSectorId]->getPort()->getGoodTransaction($goodId) === self::GOOD_BUYS) {
125 125
 							$owr = new OneWayRoute($currentSectorId, $targetSectorId, $sectors[$currentSectorId]->getPort()->getRaceID(), $sectors[$targetSectorId]->getPort()->getRaceID(), $sectors[$currentSectorId]->getPort()->getGoodDistance($goodId), $sectors[$targetSectorId]->getPort()->getGoodDistance($goodId), $distance, $goodId);
126 126
 							$fakeReturn = new OneWayRoute($targetSectorId, $currentSectorId, $sectors[$targetSectorId]->getPort()->getRaceID(), $sectors[$currentSectorId]->getPort()->getRaceID(), 0, 0, $distance, GOODS_NOTHING);
127 127
 							$mpr = new MultiplePortRoute($owr, $fakeReturn);
Please login to merge, or discard this patch.
tools/discord/GameLink.inc 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -3,10 +3,10 @@
 block discarded – undo
3 3
 // Holds information linking the received message and the game data
4 4
 class GameLink
5 5
 {
6
-	public $valid = false;  // identifies if the message is linked to game data
7
-	public $account;        // SmrAccount instance
8
-	public $alliance;       // SmrAlliance instance
9
-	public $player;         // SmrPlayer instance
6
+	public $valid = false; // identifies if the message is linked to game data
7
+	public $account; // SmrAccount instance
8
+	public $alliance; // SmrAlliance instance
9
+	public $player; // SmrPlayer instance
10 10
 
11 11
 	// $author can be either Discord\Parts\User\{User,Member}
12 12
 	function __construct(Discord\Parts\Channel\Channel $channel, $author) {
Please login to merge, or discard this patch.
test/SmrTest/BaseIntegrationSpec.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
 		$query = "SELECT table_name FROM information_schema.tables WHERE table_rows > 0 AND TABLE_SCHEMA='smr_live'";
34 34
 		$rs = self::$conn->query($query);
35 35
 		$all = $rs->fetch_all();
36
-		array_walk_recursive($all, function ($a) {
36
+		array_walk_recursive($all, function($a) {
37 37
 			self::$defaultPopulatedTables[] = "'" . $a . "'";
38 38
 		});
39 39
 	}
Please login to merge, or discard this patch.
engine/Default/history_games.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@
 block discarded – undo
11 11
 
12 12
 $db->switchDatabases($var['HistoryDatabase']);
13 13
 $db->query('SELECT start_date, type, end_date, game_name, speed, game_id ' .
14
-           'FROM game WHERE game_id = ' . $db->escapeNumber($game_id));
14
+		   'FROM game WHERE game_id = ' . $db->escapeNumber($game_id));
15 15
 $db->requireRecord();
16 16
 $template->assign('GameName', $game_name);
17 17
 $template->assign('Start', date(DATE_DATE_SHORT, $db->getInt('start_date')));
Please login to merge, or discard this patch.
lib/Default/DummyShip.class.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
 		$this->cargo_left = $this->getCargoHolds();
18 18
 	}
19 19
 	protected function doFullUNO() {
20
-		foreach($this->getMaxHardware() as $hardwareTypeID => $max) {
20
+		foreach ($this->getMaxHardware() as $hardwareTypeID => $max) {
21 21
 			$this->hardware[$hardwareTypeID] = $max;
22 22
 			$this->oldHardware[$hardwareTypeID] = $max;
23 23
 		}
@@ -47,8 +47,8 @@  discard block
 block discarded – undo
47 47
 	}
48 48
 
49 49
 	public function getIllusionShip() {
50
-		if(!isset($this->illusionShip)) {
51
-			$this->illusionShip=false;
50
+		if (!isset($this->illusionShip)) {
51
+			$this->illusionShip = false;
52 52
 		}
53 53
 		return $this->illusionShip;
54 54
 	}
@@ -58,20 +58,20 @@  discard block
 block discarded – undo
58 58
 		$db = MySqlDatabase::getInstance();
59 59
 		$db->query('REPLACE INTO cached_dummys ' .
60 60
 					'(type, id, info) ' .
61
-					'VALUES (\'DummyShip\', '.$db->escapeString($this->getPlayer()->getPlayerName()).', '.$db->escapeString($cache).')');
61
+					'VALUES (\'DummyShip\', ' . $db->escapeString($this->getPlayer()->getPlayerName()) . ', ' . $db->escapeString($cache) . ')');
62 62
 		unserialize($cache);
63 63
 	}
64 64
 
65 65
 	public static function getCachedDummyShip(AbstractSmrPlayer $player) {
66
-		if(!isset(self::$CACHED_DUMMY_SHIPS[$player->getPlayerName()])) {
66
+		if (!isset(self::$CACHED_DUMMY_SHIPS[$player->getPlayerName()])) {
67 67
 			$db = MySqlDatabase::getInstance();
68 68
 			$db->query('SELECT info FROM cached_dummys
69 69
 						WHERE type = \'DummyShip\'
70 70
 						AND id = ' . $db->escapeString($player->getPlayerName()) . ' LIMIT 1');
71
-			if($db->nextRecord()) {
71
+			if ($db->nextRecord()) {
72 72
 				$return = unserialize($db->getField('info'));
73 73
 				$return->regenerate($player);
74
-				self::$CACHED_DUMMY_SHIPS[$player->getPlayerName()] =& $return;
74
+				self::$CACHED_DUMMY_SHIPS[$player->getPlayerName()] = & $return;
75 75
 			} else {
76 76
 				self::$CACHED_DUMMY_SHIPS[$player->getPlayerName()] = new DummyShip($player);
77 77
 			}
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 		$db->query('SELECT id FROM cached_dummys
85 85
 					WHERE type = \'DummyShip\'');
86 86
 		$dummyNames = array();
87
-		while($db->nextRecord()) {
87
+		while ($db->nextRecord()) {
88 88
 			$dummyNames[] = $db->getField('id');
89 89
 		}
90 90
 		return $dummyNames;
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
 
94 94
 
95 95
 	public function __sleep() {
96
-		return array('gameID','weapons');
96
+		return array('gameID', 'weapons');
97 97
 	}
98 98
 
99 99
 	public function __wakeup() {
Please login to merge, or discard this patch.
engine/Default/planet_attack_processing.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -58,8 +58,8 @@  discard block
 block discarded – undo
58 58
 
59 59
 $totalShieldDamage = 0;
60 60
 foreach ($attackers as $attacker) {
61
-	$playerResults =& $attacker->shootPlanet($planet, false);
62
-	$results['Attackers']['Traders'][$attacker->getAccountID()] =& $playerResults;
61
+	$playerResults = & $attacker->shootPlanet($planet, false);
62
+	$results['Attackers']['Traders'][$attacker->getAccountID()] = & $playerResults;
63 63
 	$results['Attackers']['TotalDamage'] += $playerResults['TotalDamage'];
64 64
 	foreach ($playerResults['Weapons'] as $weapon) {
65 65
 		if (isset($weapon['ActualDamage'])) { // Only set if the weapon hits
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 $downgradeDamage = $results['Attackers']['TotalDamage'] - $totalShieldDamage;
73 73
 $results['Attackers']['Downgrades'] = $planet->checkForDowngrade($downgradeDamage);
74 74
 
75
-$results['Planet'] =& $planet->shootPlayers($attackers);
75
+$results['Planet'] = & $planet->shootPlayers($attackers);
76 76
 
77 77
 $account->log(LOG_TYPE_PLANET_BUSTING, 'Player attacks planet, the planet does ' . $results['Planet']['TotalDamage'] . ', their team does ' . $results['Attackers']['TotalDamage'] . ' and downgrades: ' . var_export($results['Attackers']['Downgrades'], true), $planet->getSectorID());
78 78
 
Please login to merge, or discard this patch.
engine/Default/port_attack_processing.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -53,8 +53,8 @@  discard block
 block discarded – undo
53 53
 
54 54
 $totalShieldDamage = 0;
55 55
 foreach ($attackers as $attacker) {
56
-	$playerResults =& $attacker->shootPort($port);
57
-	$results['Attackers']['Traders'][$attacker->getAccountID()] =& $playerResults;
56
+	$playerResults = & $attacker->shootPort($port);
57
+	$results['Attackers']['Traders'][$attacker->getAccountID()] = & $playerResults;
58 58
 	$results['Attackers']['TotalDamage'] += $playerResults['TotalDamage'];
59 59
 	foreach ($playerResults['Weapons'] as $weapon) {
60 60
 		if (isset($weapon['ActualDamage'])) { // Only set if the weapon hits
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 $downgradeDamage = $results['Attackers']['TotalDamage'] - $totalShieldDamage;
68 68
 $results['Attackers']['Downgrades'] = $port->checkForDowngrade($downgradeDamage);
69 69
 
70
-$results['Port'] =& $port->shootPlayers($attackers);
70
+$results['Port'] = & $port->shootPlayers($attackers);
71 71
 
72 72
 $account->log(LOG_TYPE_PORT_RAIDING, 'Player attacks port, the port does ' . $results['Port']['TotalDamage'] . ', their team does ' . $results['Attackers']['TotalDamage'] . ' and downgrades ' . $results['Attackers']['Downgrades'] . ' levels.', $port->getSectorID());
73 73
 
Please login to merge, or discard this patch.
lib/Smr/Container/DiContainer.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,10 +36,10 @@
 block discarded – undo
36 36
 			 * The factories themselves are able to use dependency injection as well, so we can provide the MysqlProperties
37 37
 			 * typehint to make sure the container constructs and instance and provides it to the factory.
38 38
 			 */
39
-			mysqli::class => function (MySqlProperties $mysqlProperties): mysqli {
39
+			mysqli::class => function(MySqlProperties $mysqlProperties): mysqli {
40 40
 				return MySqlDatabase::mysqliFactory($mysqlProperties);
41 41
 			},
42
-			Dotenv::class => function (): Dotenv {
42
+			Dotenv::class => function(): Dotenv {
43 43
 				return Dotenv::createArrayBacked(ROOT);
44 44
 			},
45 45
 			// Explicitly name all classes that are autowired, so we can take advantage of
Please login to merge, or discard this patch.
lib/Default/MySqlDatabase.class.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
 	}
52 52
 
53 53
 	public static function mysqliFactory(MySqlProperties $mysqlProperties): mysqli {
54
-		if (!mysqli_report(MYSQLI_REPORT_ERROR | MYSQLI_REPORT_STRICT)) {
54
+		if (!mysqli_report(MYSQLI_REPORT_ERROR|MYSQLI_REPORT_STRICT)) {
55 55
 			throw new RuntimeException('Failed to enable mysqli error reporting');
56 56
 		}
57 57
 		return new mysqli(
Please login to merge, or discard this patch.