We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
@@ -53,9 +53,9 @@ |
||
53 | 53 | //get base for ports that dont happen to trade that good |
54 | 54 | $GOODS = Globals::getGoods(); |
55 | 55 | $fine = $totalFine = $port->getLevel() * |
56 | - (($ship->getCargo(GOODS_SLAVES) * $GOODS[GOODS_SLAVES]['BasePrice']) + |
|
57 | - ($ship->getCargo(GOODS_WEAPONS) * $GOODS[GOODS_WEAPONS]['BasePrice']) + |
|
58 | - ($ship->getCargo(GOODS_NARCOTICS) * $GOODS[GOODS_NARCOTICS]['BasePrice'])); |
|
56 | + (($ship->getCargo(GOODS_SLAVES) * $GOODS[GOODS_SLAVES]['BasePrice']) + |
|
57 | + ($ship->getCargo(GOODS_WEAPONS) * $GOODS[GOODS_WEAPONS]['BasePrice']) + |
|
58 | + ($ship->getCargo(GOODS_NARCOTICS) * $GOODS[GOODS_NARCOTICS]['BasePrice'])); |
|
59 | 59 | $player->increaseHOF($ship->getCargo(GOODS_SLAVES) + $ship->getCargo(GOODS_WEAPONS) + $ship->getCargo(GOODS_NARCOTICS), ['Trade', 'Search', 'Caught', 'Goods Confiscated'], HOF_PUBLIC); |
60 | 60 | $player->increaseHOF($totalFine, ['Trade', 'Search', 'Caught', 'Amount Fined'], HOF_PUBLIC); |
61 | 61 | $template->assign('TotalFine', $totalFine); |
@@ -26,8 +26,8 @@ discard block |
||
26 | 26 | $shareFrom[$fromAccountId] = [ |
27 | 27 | 'Player ID' => $otherPlayer == null ? '-' : $otherPlayer->getPlayerID(), |
28 | 28 | 'Player Name' => $otherPlayer == null ? |
29 | - '<b>Account</b>: ' . SmrAccount::getAccount($fromAccountId)->getHofDisplayName() : |
|
30 | - $otherPlayer->getDisplayName(), |
|
29 | + '<b>Account</b>: ' . SmrAccount::getAccount($fromAccountId)->getHofDisplayName() : |
|
30 | + $otherPlayer->getDisplayName(), |
|
31 | 31 | 'All Games' => $gameId == 0 ? '<span class="green">YES</span>' : '<span class="red">NO</span>', |
32 | 32 | 'Game ID' => $gameId, |
33 | 33 | ]; |
@@ -47,8 +47,8 @@ discard block |
||
47 | 47 | $shareTo[$toAccountId] = [ |
48 | 48 | 'Player ID' => $otherPlayer == null ? '-' : $otherPlayer->getPlayerID(), |
49 | 49 | 'Player Name' => $otherPlayer == null ? |
50 | - '<b>Account</b>: ' . SmrAccount::getAccount($toAccountId)->getHofDisplayName() : |
|
51 | - $otherPlayer->getDisplayName(), |
|
50 | + '<b>Account</b>: ' . SmrAccount::getAccount($toAccountId)->getHofDisplayName() : |
|
51 | + $otherPlayer->getDisplayName(), |
|
52 | 52 | 'All Games' => $gameId == 0 ? '<span class="green">YES</span>' : '<span class="red">NO</span>', |
53 | 53 | 'Game ID' => $gameId, |
54 | 54 | ]; |
@@ -26,8 +26,7 @@ discard block |
||
26 | 26 | $shareFrom[$fromAccountId] = [ |
27 | 27 | 'Player ID' => $otherPlayer == null ? '-' : $otherPlayer->getPlayerID(), |
28 | 28 | 'Player Name' => $otherPlayer == null ? |
29 | - '<b>Account</b>: ' . SmrAccount::getAccount($fromAccountId)->getHofDisplayName() : |
|
30 | - $otherPlayer->getDisplayName(), |
|
29 | + '<b>Account</b>: ' . SmrAccount::getAccount($fromAccountId)->getHofDisplayName() : $otherPlayer->getDisplayName(), |
|
31 | 30 | 'All Games' => $gameId == 0 ? '<span class="green">YES</span>' : '<span class="red">NO</span>', |
32 | 31 | 'Game ID' => $gameId, |
33 | 32 | ]; |
@@ -47,8 +46,7 @@ discard block |
||
47 | 46 | $shareTo[$toAccountId] = [ |
48 | 47 | 'Player ID' => $otherPlayer == null ? '-' : $otherPlayer->getPlayerID(), |
49 | 48 | 'Player Name' => $otherPlayer == null ? |
50 | - '<b>Account</b>: ' . SmrAccount::getAccount($toAccountId)->getHofDisplayName() : |
|
51 | - $otherPlayer->getDisplayName(), |
|
49 | + '<b>Account</b>: ' . SmrAccount::getAccount($toAccountId)->getHofDisplayName() : $otherPlayer->getDisplayName(), |
|
52 | 50 | 'All Games' => $gameId == 0 ? '<span class="green">YES</span>' : '<span class="red">NO</span>', |
53 | 51 | 'Game ID' => $gameId, |
54 | 52 | ]; |
@@ -38,7 +38,7 @@ discard block |
||
38 | 38 | $menuItems[] = ['Link' => Globals::getPlanetListHREF($alliance_id), 'Text' => 'Defense']; |
39 | 39 | $menuItems[] = ['Link' => Globals::getPlanetListFinancialHREF($alliance_id), 'Text' => 'Financial']; |
40 | 40 | // make the selected index bold |
41 | - $boldItem =& $menuItems[$selected_index]['Text']; |
|
41 | + $boldItem = & $menuItems[$selected_index]['Text']; |
|
42 | 42 | $boldItem = '<span class="bold">' . $boldItem . '</span>'; |
43 | 43 | |
44 | 44 | $template = Smr\Template::getInstance(); |
@@ -145,7 +145,7 @@ discard block |
||
145 | 145 | 'Text' => 'Game News', |
146 | 146 | ]; |
147 | 147 | // make the selected index bold |
148 | - $boldItem =& $menuItems[$selected_index]['Text']; |
|
148 | + $boldItem = & $menuItems[$selected_index]['Text']; |
|
149 | 149 | $boldItem = '<b>' . $boldItem . '</b>'; |
150 | 150 | |
151 | 151 | $template = Smr\Template::getInstance(); |
@@ -555,7 +555,7 @@ |
||
555 | 555 | */ |
556 | 556 | public function setWarp(SmrSector $warp): void { |
557 | 557 | if ($this->getWarp() == $warp->getSectorID() && |
558 | - $warp->getWarp() == $this->getSectorID()) { |
|
558 | + $warp->getWarp() == $this->getSectorID()) { |
|
559 | 559 | // Warps are already set correctly! |
560 | 560 | return; |
561 | 561 | } |
@@ -870,9 +870,9 @@ |
||
870 | 870 | */ |
871 | 871 | public function canFight(): bool { |
872 | 872 | return !($this->hasNewbieTurns() || |
873 | - $this->isDead() || |
|
874 | - $this->isLandedOnPlanet() || |
|
875 | - $this->hasFederalProtection()); |
|
873 | + $this->isDead() || |
|
874 | + $this->isLandedOnPlanet() || |
|
875 | + $this->hasFederalProtection()); |
|
876 | 876 | } |
877 | 877 | |
878 | 878 | public function setDead(bool $bool): void { |
@@ -2886,7 +2886,7 @@ discard block |
||
2886 | 2886 | 'Starting Sector' => $this->getSectorID(), |
2887 | 2887 | ]; |
2888 | 2888 | |
2889 | - $this->missions[$missionID] =& $mission; |
|
2889 | + $this->missions[$missionID] = & $mission; |
|
2890 | 2890 | $this->setupMissionStep($missionID); |
2891 | 2891 | $this->rebuildMission($missionID); |
2892 | 2892 | |
@@ -2948,7 +2948,7 @@ discard block |
||
2948 | 2948 | if (!$this->hasMission($missionID)) { |
2949 | 2949 | throw new Exception('Unknown mission: ' . $missionID); |
2950 | 2950 | } |
2951 | - $mission =& $this->missions[$missionID]; |
|
2951 | + $mission = & $this->missions[$missionID]; |
|
2952 | 2952 | if ($mission['Task'] === false || $mission['Task']['Step'] != 'Claim') { |
2953 | 2953 | throw new Exception('Cannot claim mission: ' . $missionID . ', for step: ' . $mission['On Step']); |
2954 | 2954 | } |
@@ -67,9 +67,9 @@ |
||
67 | 67 | $session = Session::getInstance(); |
68 | 68 | $account = $session->getAccount(); |
69 | 69 | if (($vis == HOF_PRIVATE && $account->getAccountID() != $accountID) || |
70 | - ($vis == HOF_ALLIANCE && isset($gameID) && |
|
71 | - !SmrGame::getGame($gameID)->hasEnded() && |
|
72 | - !SmrPlayer::getPlayer($accountID, $gameID)->sameAlliance($session->getPlayer()))) { |
|
70 | + ($vis == HOF_ALLIANCE && isset($gameID) && |
|
71 | + !SmrGame::getGame($gameID)->hasEnded() && |
|
72 | + !SmrPlayer::getPlayer($accountID, $gameID)->sameAlliance($session->getPlayer()))) { |
|
73 | 73 | return '-'; |
74 | 74 | } |
75 | 75 | return $amount; |
@@ -26,7 +26,7 @@ |
||
26 | 26 | * Not intended to be used outside the DI context. |
27 | 27 | */ |
28 | 28 | public static function mysqliFactory(DatabaseProperties $dbProperties): mysqli { |
29 | - if (!mysqli_report(MYSQLI_REPORT_ERROR | MYSQLI_REPORT_STRICT)) { |
|
29 | + if (!mysqli_report(MYSQLI_REPORT_ERROR|MYSQLI_REPORT_STRICT)) { |
|
30 | 30 | throw new RuntimeException('Failed to enable mysqli error reporting'); |
31 | 31 | } |
32 | 32 | $mysql = new mysqli( |
@@ -70,7 +70,7 @@ |
||
70 | 70 | 'illusion' => $ship->canHaveIllusion() ? 'Yes' : '', |
71 | 71 | 'jump' => $ship->canHaveJump() ? 'Yes' : '', |
72 | 72 | 'scrambler' => $ship->canHaveDCS() ? 'Yes' : '', |
73 | - 'locs' => implode('', array_map(fn(string $name): string => '<div>' . $name . '</div>', $shipLocs)), |
|
73 | + 'locs' => implode('', array_map(fn(string $name) : string => '<div>' . $name . '</div>', $shipLocs)), |
|
74 | 74 | ]; |
75 | 75 | return $stat; |
76 | 76 | } |
@@ -14,7 +14,7 @@ |
||
14 | 14 | public const TIME_BETWEEN_VOTING = 84600; // 23.5 hours |
15 | 15 | |
16 | 16 | /** @var ?array<int, int> */ |
17 | - private static ?array $CACHE_TIMEOUTS = null; |
|
17 | + private static ? array $CACHE_TIMEOUTS = null; |
|
18 | 18 | |
19 | 19 | /** @var array<string, mixed> */ |
20 | 20 | public readonly array $data; |