We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
Conditions | 40 |
Paths | > 20000 |
Total Lines | 180 |
Code Lines | 119 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php declare(strict_types=1); |
||
17 | public static function create(int $gameID, ?AbstractSmrPlayer $player, bool $adminCreate = false): never { |
||
18 | // NOTE: If the format of this file is changed in an incompatible way, |
||
19 | // make sure to update the SMR_FILE_VERSION! |
||
20 | |||
21 | $file = ';SMR1.6 Sectors File v' . SMR_FILE_VERSION . ' |
||
22 | ; Created on ' . date(DEFAULT_DATE_TIME_FORMAT) . ' |
||
23 | [Races] |
||
24 | ; Name = ID' . EOL; |
||
25 | foreach (Race::getAllNames() as $raceID => $raceName) { |
||
26 | $file .= inify($raceName) . '=' . $raceID . EOL; |
||
27 | } |
||
28 | |||
29 | $file .= '[Goods] |
||
30 | ; ID = Name, BasePrice' . EOL; |
||
31 | foreach (TradeGood::getAll() as $goodID => $good) { |
||
32 | $file .= $goodID . '=' . inify($good->name) . ',' . $good->basePrice . EOL; |
||
33 | } |
||
34 | |||
35 | $file .= '[Weapons] |
||
36 | ; Weapon = Race,Cost,Shield,Armour,Accuracy,Power level,Restriction |
||
37 | ; Restriction: 0=none, 1=good, 2=evil, 3=newbie, 4=port, 5=planet' . EOL; |
||
38 | foreach (SmrWeaponType::getAllWeaponTypes() as $weapon) { |
||
39 | $file .= inify($weapon->getName()) . '=' . inify($weapon->getRaceName()) . ',' . $weapon->getCost() . ',' . $weapon->getShieldDamage() . ',' . $weapon->getArmourDamage() . ',' . $weapon->getAccuracy() . ',' . $weapon->getPowerLevel() . ',' . $weapon->getBuyerRestriction()->value . EOL; |
||
40 | } |
||
41 | |||
42 | $file .= '[ShipEquipment] |
||
43 | ; Name = Cost' . EOL; |
||
44 | foreach (HardwareType::getAll() as $hardware) { |
||
45 | $file .= inify($hardware->name) . '=' . $hardware->cost . EOL; |
||
46 | } |
||
47 | |||
48 | $file .= '[Ships] |
||
49 | ; Name = Race,Cost,TPH,Hardpoints,Power,Class,+Equipment (Optional),+Restrictions(Optional) |
||
50 | ; Restrictions:Align(Integer)' . EOL; |
||
51 | foreach (SmrShipType::getAll() as $ship) { |
||
52 | $file .= inify($ship->getName()) . '=' . inify($ship->getRaceName()) . ',' . $ship->getCost() . ',' . $ship->getSpeed() . ',' . $ship->getHardpoints() . ',' . $ship->getMaxPower() . ',' . $ship->getClass()->name; |
||
53 | $shipEquip = []; |
||
54 | foreach ($ship->getAllMaxHardware() as $hardwareID => $maxHardware) { |
||
55 | $shipEquip[] = HardwareType::get($hardwareID)->name . '=' . $maxHardware; |
||
56 | } |
||
57 | if (!empty($shipEquip)) { |
||
58 | $file .= ',ShipEquipment=' . implode(';', $shipEquip); |
||
59 | } |
||
60 | $file .= ',Restrictions=' . $ship->getRestriction()->value; |
||
61 | $file .= EOL; |
||
62 | } |
||
63 | |||
64 | $file .= '[Locations] |
||
65 | ; Name = +Sells' . EOL; |
||
66 | foreach (SmrLocation::getAllLocations($gameID) as $location) { |
||
67 | $file .= inify($location->getName()) . '='; |
||
68 | $locSells = ''; |
||
69 | if ($location->isWeaponSold()) { |
||
70 | $locSells .= 'Weapons='; |
||
71 | foreach ($location->getWeaponsSold() as $locWeapon) { |
||
72 | $locSells .= $locWeapon->getName() . ';'; |
||
73 | } |
||
74 | $locSells = substr($locSells, 0, -1) . ','; |
||
75 | } |
||
76 | if ($location->isHardwareSold()) { |
||
77 | $locSells .= 'ShipEquipment='; |
||
78 | foreach ($location->getHardwareSold() as $locHardware) { |
||
79 | $locSells .= $locHardware->name . ';'; |
||
80 | } |
||
81 | $locSells = substr($locSells, 0, -1) . ','; |
||
82 | } |
||
83 | if ($location->isShipSold()) { |
||
84 | $locSells .= 'Ships='; |
||
85 | foreach ($location->getShipsSold() as $locShip) { |
||
86 | $locSells .= $locShip->getName() . ';'; |
||
87 | } |
||
88 | $locSells = substr($locSells, 0, -1) . ','; |
||
89 | } |
||
90 | if ($location->isBank()) { |
||
91 | $locSells .= 'Bank=,'; |
||
92 | } |
||
93 | if ($location->isBar()) { |
||
94 | $locSells .= 'Bar=,'; |
||
95 | } |
||
96 | if ($location->isHQ()) { |
||
97 | $locSells .= 'HQ=,'; |
||
98 | } |
||
99 | if ($location->isUG()) { |
||
100 | $locSells .= 'UG=,'; |
||
101 | } |
||
102 | if ($location->isFed()) { |
||
103 | $locSells .= 'Fed=,'; |
||
104 | } |
||
105 | if ($locSells != '') { |
||
106 | $file .= substr($locSells, 0, -1); |
||
107 | } |
||
108 | $file .= EOL; |
||
109 | } |
||
110 | |||
111 | // Everything below here must be valid INI syntax (safe to parse) |
||
112 | $game = SmrGame::getGame($gameID); |
||
113 | $file .= '[Metadata] |
||
114 | FileVersion=' . SMR_FILE_VERSION . ' |
||
115 | [Game] |
||
116 | Name=' . inify($game->getName()) . ' |
||
117 | [Galaxies] |
||
118 | '; |
||
119 | $galaxies = $game->getGalaxies(); |
||
120 | foreach ($galaxies as $galaxy) { |
||
121 | $file .= $galaxy->getGalaxyID() . '=' . $galaxy->getWidth() . ',' . $galaxy->getHeight() . ',' . $galaxy->getGalaxyType() . ',' . inify($galaxy->getName()) . ',' . $galaxy->getMaxForceTime() . EOL; |
||
122 | } |
||
123 | |||
124 | foreach ($galaxies as $galaxy) { |
||
125 | // Efficiently construct the caches before proceeding |
||
126 | $galaxy->getLocations(); |
||
127 | $galaxy->getPlanets(); |
||
128 | $galaxy->getForces(); |
||
129 | |||
130 | foreach ($galaxy->getSectors() as $sector) { |
||
131 | $file .= '[Sector=' . $sector->getSectorID() . ']' . EOL; |
||
132 | |||
133 | if (!$sector->isVisited($player) && $adminCreate === false) { |
||
134 | continue; |
||
135 | } |
||
136 | |||
137 | foreach ($sector->getLinks() as $linkName => $link) { |
||
138 | $file .= $linkName . '=' . $link . EOL; |
||
139 | } |
||
140 | if ($sector->hasWarp()) { |
||
141 | $file .= 'Warp=' . $sector->getWarp() . EOL; |
||
142 | } |
||
143 | if (($adminCreate !== false && $sector->hasPort()) || $sector->hasCachedPort($player)) { |
||
144 | if ($adminCreate !== false) { |
||
145 | $port = $sector->getPort(); |
||
146 | } else { |
||
147 | $port = $sector->getCachedPort($player); |
||
148 | } |
||
149 | $file .= 'Port Level=' . $port->getLevel() . EOL; |
||
150 | $file .= 'Port Race=' . $port->getRaceID() . EOL; |
||
151 | if (!empty($port->getSellGoodIDs())) { |
||
152 | $file .= 'Buys=' . implode(',', $port->getSellGoodIDs()) . EOL; |
||
153 | } |
||
154 | if (!empty($port->getBuyGoodIDs())) { |
||
155 | $file .= 'Sells=' . implode(',', $port->getBuyGoodIDs()) . EOL; |
||
156 | } |
||
157 | } |
||
158 | if ($sector->hasPlanet()) { |
||
159 | $planetType = $sector->getPlanet()->getTypeID(); |
||
160 | $file .= 'Planet=' . $planetType . EOL; |
||
161 | } |
||
162 | if ($sector->hasLocation()) { |
||
163 | $locationsString = 'Locations='; |
||
164 | foreach ($sector->getLocations() as $location) { |
||
165 | $locationsString .= inify($location->getName()) . ','; |
||
166 | } |
||
167 | $file .= substr($locationsString, 0, -1) . EOL; |
||
168 | } |
||
169 | if ($adminCreate === false && $sector->hasFriendlyForces($player)) { |
||
170 | $forcesString = 'FriendlyForces='; |
||
171 | foreach ($sector->getFriendlyForces($player) as $forces) { |
||
172 | $forcesString .= inify($forces->getOwner()->getPlayerName()) . '=' . inify(HardwareType::get(HARDWARE_MINE)->name) . '=' . $forces->getMines() . ';' . inify(HardwareType::get(HARDWARE_COMBAT)->name) . '=' . $forces->getCDs() . ';' . inify(HardwareType::get(HARDWARE_SCOUT)->name) . '=' . $forces->getSDs() . ','; |
||
173 | } |
||
174 | $file .= substr($forcesString, 0, -1) . EOL; |
||
175 | } |
||
176 | } |
||
177 | SmrPort::clearCache(); |
||
178 | SmrForce::clearCache(); |
||
179 | SmrPlanet::clearCache(); |
||
180 | SmrSector::clearCache(); |
||
181 | } |
||
182 | |||
183 | $size = strlen($file); |
||
184 | |||
185 | header('Pragma: public'); |
||
186 | header('Expires: 0'); |
||
187 | header('Cache-Control: must-revalidate, post-check=0, pre-check=0'); |
||
188 | header('Cache-Control: private', false); |
||
189 | header('Content-Type: application/force-download'); |
||
190 | header('Content-Disposition: attachment; filename="' . $game->getName() . '.smr"'); |
||
191 | header('Content-Transfer-Encoding: binary'); |
||
192 | header('Content-Length: ' . $size); |
||
193 | |||
194 | echo $file; |
||
195 | |||
196 | exit; |
||
|
|||
197 | } |
||
200 |
In general, usage of exit should be done with care and only when running in a scripting context like a CLI script.