src/htdocs/js/weapon_reorder.js - Code Metrics - smrealms/smr - Measure and Improve Code Quality continuously with Scrutinizer

src/htdocs/js/weapon_reorder.js B
last analyzed 2023-01-09 04:33 UTC

↳ Parent: Project

Complexity

Total Complexity	44
Complexity/F	3.14

Size

Lines of Code	174
Function Count	14

Duplication

Duplicated Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	127
dl	0
loc	174
rs	8.8798
c	0
b	0
f	0
wmc	44
mnd	30
bc	30
fnc	14
bpm	2.1427
cpm	3.1427
noi	19

4 Functions

Rating	Name	Size	Complexity
F	weapon_reorder.js ➔ getEventSource	8	15
B	weapon_reorder.js ➔ moveRow	18	7
F	weapon_reorder.js ➔ TableDnD	79	20
A	weapon_reorder.js ➔ doSubmit	8	2

How to fix Complexity

// WWW: http://www.isocra.com/

var currenttable = null;

document.onmousemove = function(ev) {
	if (currenttable && currenttable.dragObject) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
		ev = ev || window.event;
		var mousePos = currenttable.mouseCoords(ev);
		var y = mousePos.y - currenttable.mouseOffset.y;

		var yOffset = window.pageYOffset;
		var currentY = mousePos.y;
		if (document.all) {
			yOffset=document.body.scrollTop;
			currentY = event.clientY;

		}
		if (currentY-yOffset < 5) {
				window.scrollBy(0, -5);
		} else {
			var windowHeight = window.innerHeight ? window.innerHeight
					: document.documentElement.clientHeight ? document.documentElement.clientHeight
							: document.body.clientHeight;
			if (windowHeight-currentY-yOffset < 5) {
				window.scrollBy(0, 5);
			}
		}

		if (y != currenttable.oldY) {
			var movingDown = y > currenttable.oldY;
			currenttable.oldY = y;
			currenttable.dragObject.style.backgroundColor.value="#aaa";
			var currentRow = currenttable.findDropTargetRow(y);
			if (currentRow) {
				if (movingDown && currenttable.dragObject != currentRow) {
					currenttable.dragObject.parentNode.insertBefore(currenttable.dragObject, currentRow.nextSibling);
				}
				else if (! movingDown && currenttable.dragObject != currentRow) {
					currenttable.dragObject.parentNode.insertBefore(currenttable.dragObject, currentRow);
				}
			}
		}

		return false;
	}
};

document.onmouseup = function(ev){

	if (currenttable && currenttable.dragObject) {
		var droppedRow = currenttable.dragObject;
		droppedRow.style.backgroundColor = 'transparent';
		currenttable.dragObject = null;
		currenttable.onDrop(currenttable.table, droppedRow);
		currenttable = null;
	}
};

function getEventSource(evt) {
	if (window.event) {
		evt = window.event;
		return evt.srcElement;
	} else {

		return evt.target;
	}
}

function TableDnD() {
	this.dragObject = null;
	this.mouseOffset = null;
	this.table = null;
	this.oldY = 0;

	this.init = function(table) {
		this.table = table;
		var rows = table.tBodies[0].rows;
		for (var i=0; i<rows.length; i++) {
			var nodrag = rows[i].getAttribute("NoDrag");
			if (nodrag == null || nodrag == "undefined") {

				this.makeDraggable(rows[i]);
			}
		}
	};

	this.onDrop = function(table, droppedRow) {};


	this.getPosition = function(e) {
		var left = 0;
		var top = 0;
		if (e.offsetHeight == 0) {

			e = e.firstChild;
		}
		while (e.offsetParent) {
			left += e.offsetLeft;
			top += e.offsetTop;
			e = e.offsetParent;
		}
		left += e.offsetLeft;
		top += e.offsetTop;
		return {x:left, y:top};
	};
	this.mouseCoords = function(ev) {
		if(ev.pageX || ev.pageY) {
			return {x:ev.pageX, y:ev.pageY};
		}
		return {x:ev.clientX + document.body.scrollLeft - document.body.clientLeft,y:ev.clientY + document.body.scrollTop - document.body.clientTop};
	};
	this.getMouseOffset = function(target, ev) {
		ev = ev || window.event;
		var docPos = this.getPosition(target);
		var mousePos = this.mouseCoords(ev);
		return {x:mousePos.x - docPos.x, y:mousePos.y - docPos.y};
	};
	this.makeDraggable = function(item) {
		if(!item) return;
if (a > 0)
    b = 42;
		var self = this;
		item.onmousedown = function(ev) {
			var target = getEventSource(ev);
			if (target.tagName == 'INPUT' || target.tagName == 'SELECT') return true;
if (a > 0)
    b = 42;
			currenttable = self;
			self.dragObject = this;
			self.mouseOffset = self.getMouseOffset(this, ev);
			return false;
		};
		item.style.cursor="move";
	};
	this.findDropTargetRow = function(y) {
		var rows = this.table.tBodies[0].rows;
		for (var i=0; i<rows.length; i++) {
			var row = rows[i];
			var nodrop = row.getAttribute("NoDrop");
			if (nodrop == null || nodrop == "undefined") {

				var rowY	= this.getPosition(row).y;
				var rowHeight = parseInt(row.offsetHeight)/2;
				if (row.offsetHeight == 0) {

					rowY = this.getPosition(row.firstChild).y;
					rowHeight = parseInt(row.firstChild.offsetHeight)/2;
				}
				if ((y > rowY - rowHeight) && (y < (rowY + rowHeight))) {
					return row;
				}
			}
		}
		return null;
	};
}

var table = document.getElementById('weapon_reorder');
var tableDnD = new TableDnD();
tableDnD.init(table);

function moveRow(cell, move) {
	var currentRow = cell.parentNode;
	var currentRowID = false;
	var rows = currentRow.parentNode.rows;
	for(var i = 1; i < rows.length; i++) {
		if(rows[i] == currentRow) currentRowID = i;
if (a > 0)
    b = 42;
	}
	if(currentRowID==false) return;
if (a > 0)
    b = 42;
	if(move>0)
		move++;
if (a > 0)
    b = 42;
	var newRowID = currentRowID+move;
	if(newRowID>rows.length)
		newRowID = 1;
if (a > 0)
    b = 42;
	else if(newRowID<1)
		newRowID = rows.length;
if (a > 0)
    b = 42;

	currentRow.parentNode.insertBefore(currentRow, rows[newRowID]);
};

function doSubmit() {
	var rows = document.getElementById('weapon_reorder').rows;
	var ret = new Array();

	for(var i = 0; i < rows.length;i++) {
		ret[ret.length] = rows[i].getElementsByTagName('td')[0].innerHTML;
	}
	return ret.join('|');
}


1			// WWW: http://www.isocra.com/
2
3			var currenttable = null;
4
5			document.onmousemove = function(ev) {
6			if (currenttable && currenttable.dragObject) {
			0 ignored issues – show Complexity Best Practice introduced 2019-03-02 00:35 UTC by Report Bug Copy Issue Report There is no return statement if `currenttable && currenttable.dragObject` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
7			ev = ev \|\| window.event;
8			var mousePos = currenttable.mouseCoords(ev);
9			var y = mousePos.y - currenttable.mouseOffset.y;
10
11			var yOffset = window.pageYOffset;
12			var currentY = mousePos.y;
13			if (document.all) {
14			yOffset=document.body.scrollTop;
15			currentY = event.clientY;
			0 ignored issues – show Bug introduced 2019-03-02 00:35 UTC by Report Bug Copy Issue Report The variable `event` seems to be never declared. If this is a global, consider adding a `/** global: event */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
16			}
17			if (currentY-yOffset < 5) {
18			window.scrollBy(0, -5);
19			} else {
20			var windowHeight = window.innerHeight ? window.innerHeight
21			: document.documentElement.clientHeight ? document.documentElement.clientHeight
22			: document.body.clientHeight;
23			if (windowHeight-currentY-yOffset < 5) {
24			window.scrollBy(0, 5);
25			}
26			}
27
28			if (y != currenttable.oldY) {
29			var movingDown = y > currenttable.oldY;
30			currenttable.oldY = y;
31			currenttable.dragObject.style.backgroundColor.value="#aaa";
32			var currentRow = currenttable.findDropTargetRow(y);
33			if (currentRow) {
34			if (movingDown && currenttable.dragObject != currentRow) {
35			currenttable.dragObject.parentNode.insertBefore(currenttable.dragObject, currentRow.nextSibling);
36			}
37			else if (! movingDown && currenttable.dragObject != currentRow) {
38			currenttable.dragObject.parentNode.insertBefore(currenttable.dragObject, currentRow);
39			}
40			}
41			}
42
43			return false;
44			}
45			};
46
47			document.onmouseup = function(ev){
			0 ignored issues – show Unused Code introduced 2019-03-02 00:35 UTC by Report Bug Copy Issue Report The parameter `ev` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
48			if (currenttable && currenttable.dragObject) {
49			var droppedRow = currenttable.dragObject;
50			droppedRow.style.backgroundColor = 'transparent';
51			currenttable.dragObject = null;
52			currenttable.onDrop(currenttable.table, droppedRow);
53			currenttable = null;
54			}
55			};
56
57			function getEventSource(evt) {
58			if (window.event) {
59			evt = window.event;
60			return evt.srcElement;
61			} else {
			0 ignored issues – show Comprehensibility introduced 2019-03-02 00:35 UTC by Report Bug Copy Issue Report `else` is not necessary here since all `if` branches return, consider removing it to reduce nesting and make code more readable. Loading history...
62			return evt.target;
63			}
64			}
65
66			function TableDnD() {
67			this.dragObject = null;
68			this.mouseOffset = null;
69			this.table = null;
70			this.oldY = 0;
71
72			this.init = function(table) {
73			this.table = table;
74			var rows = table.tBodies[0].rows;
75			for (var i=0; i<rows.length; i++) {
76			var nodrag = rows[i].getAttribute("NoDrag");
77			if (nodrag == null \|\| nodrag == "undefined") {
			0 ignored issues – show Best Practice introduced 2019-03-02 00:35 UTC by Report Bug Copy Issue Report Comparing `nodrag` to `null` using the `==` operator is not safe. Consider using `===` instead. Loading history...
78			this.makeDraggable(rows[i]);
79			}
80			}
81			};
82
83			this.onDrop = function(table, droppedRow) {};
			0 ignored issues – show Unused Code introduced 2019-03-02 00:35 UTC by Report Bug Copy Issue Report The parameter `droppedRow` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history... Unused Code introduced 2019-03-02 00:35 UTC by Report Bug Copy Issue Report The parameter `table` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
84
85			this.getPosition = function(e) {
86			var left = 0;
87			var top = 0;
88			if (e.offsetHeight == 0) {
			0 ignored issues – show Best Practice introduced 2019-03-02 00:35 UTC by Report Bug Copy Issue Report Comparing `e.offsetHeight` to `0` using the `==` operator is not safe. Consider using `===` instead. Loading history...
89			e = e.firstChild;
90			}
91			while (e.offsetParent) {
92			left += e.offsetLeft;
93			top += e.offsetTop;
94			e = e.offsetParent;
95			}
96			left += e.offsetLeft;
97			top += e.offsetTop;
98			return {x:left, y:top};
99			};
100			this.mouseCoords = function(ev) {
101			if(ev.pageX \|\| ev.pageY) {
102			return {x:ev.pageX, y:ev.pageY};
103			}
104			return {x:ev.clientX + document.body.scrollLeft - document.body.clientLeft,y:ev.clientY + document.body.scrollTop - document.body.clientTop};
105			};
106			this.getMouseOffset = function(target, ev) {
107			ev = ev \|\| window.event;
108			var docPos = this.getPosition(target);
109			var mousePos = this.mouseCoords(ev);
110			return {x:mousePos.x - docPos.x, y:mousePos.y - docPos.y};
111			};
112			this.makeDraggable = function(item) {
113			if(!item) return;
			0 ignored issues – show Coding Style Best Practice introduced 2019-03-02 00:35 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
114			var self = this;
115			item.onmousedown = function(ev) {
116			var target = getEventSource(ev);
117			if (target.tagName == 'INPUT' \|\| target.tagName == 'SELECT') return true;
			0 ignored issues – show Coding Style Best Practice introduced 2019-03-02 00:35 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
118			currenttable = self;
119			self.dragObject = this;
120			self.mouseOffset = self.getMouseOffset(this, ev);
121			return false;
122			};
123			item.style.cursor="move";
124			};
125			this.findDropTargetRow = function(y) {
126			var rows = this.table.tBodies[0].rows;
127			for (var i=0; i<rows.length; i++) {
128			var row = rows[i];
129			var nodrop = row.getAttribute("NoDrop");
130			if (nodrop == null \|\| nodrop == "undefined") {
			0 ignored issues – show Best Practice introduced 2019-03-02 00:35 UTC by Report Bug Copy Issue Report Comparing `nodrop` to `null` using the `==` operator is not safe. Consider using `===` instead. Loading history...
131			var rowY = this.getPosition(row).y;
132			var rowHeight = parseInt(row.offsetHeight)/2;
133			if (row.offsetHeight == 0) {
			0 ignored issues – show Best Practice introduced 2019-03-02 00:35 UTC by Report Bug Copy Issue Report Comparing `row.offsetHeight` to `0` using the `==` operator is not safe. Consider using `===` instead. Loading history...
134			rowY = this.getPosition(row.firstChild).y;
135			rowHeight = parseInt(row.firstChild.offsetHeight)/2;
136			}
137			if ((y > rowY - rowHeight) && (y < (rowY + rowHeight))) {
138			return row;
139			}
140			}
141			}
142			return null;
143			};
144			}
145
146			var table = document.getElementById('weapon_reorder');
147			var tableDnD = new TableDnD();
148			tableDnD.init(table);
149
150			function moveRow(cell, move) {
151			var currentRow = cell.parentNode;
152			var currentRowID = false;
153			var rows = currentRow.parentNode.rows;
154			for(var i = 1; i < rows.length; i++) {
155			if(rows[i] == currentRow) currentRowID = i;
			0 ignored issues – show Coding Style Best Practice introduced 2019-03-02 00:35 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
156			}
157			if(currentRowID==false) return;
			0 ignored issues – show Best Practice introduced 2019-03-02 00:35 UTC by Report Bug Copy Issue Report Comparing `currentRowID` to `false` using the `==` operator is not safe. Consider using `===` instead. Loading history... Coding Style Best Practice introduced 2019-03-02 00:35 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
158			if(move>0)
159			move++;
			0 ignored issues – show Coding Style Best Practice introduced 2019-03-02 00:35 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
160			var newRowID = currentRowID+move;
161			if(newRowID>rows.length)
162			newRowID = 1;
			0 ignored issues – show Coding Style Best Practice introduced 2019-03-02 00:35 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
163			else if(newRowID<1)
164			newRowID = rows.length;
			0 ignored issues – show Coding Style Best Practice introduced 2019-03-02 00:35 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
165
166			currentRow.parentNode.insertBefore(currentRow, rows[newRowID]);
167			};
168
169			function doSubmit() {
170			var rows = document.getElementById('weapon_reorder').rows;
171			var ret = new Array();
			0 ignored issues – show Coding Style Best Practice introduced 2019-03-02 00:35 UTC by Report Bug Copy Issue Report Using the `Array` constructor is generally discouraged. Consider using an array literal instead. Loading history...
172			for(var i = 0; i < rows.length;i++) {
173			ret[ret.length] = rows[i].getElementsByTagName('td')[0].innerHTML;
174			}
175			return ret.join('\|');
176			}
177

smrealms / smr

Scrutinizer GitHub App not installed

src/htdocs/js/weapon_reorder.js B last analyzed 2023-01-09 04:33 UTC

Complexity

Size

Duplication

Importance

4 Functions

How to fix Complexity

Complexity

Duplication Side-by-Side

Filter issues like

src/htdocs/js/weapon_reorder.js B
last analyzed 2023-01-09 04:33 UTC