sminnee /
silverstripe-framework
| Total Complexity | 46 |
| Total Lines | 280 |
| Duplicated Lines | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Complex classes like EmbedShortcodeProvider often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use EmbedShortcodeProvider, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 28 | class EmbedShortcodeProvider implements ShortcodeHandler |
||
| 29 | { |
||
| 30 | |||
| 31 | /** |
||
| 32 | * Gets the list of shortcodes provided by this handler |
||
| 33 | * |
||
| 34 | * @return mixed |
||
| 35 | */ |
||
| 36 | public static function get_shortcodes() |
||
| 37 | { |
||
| 38 | return ['embed']; |
||
| 39 | } |
||
| 40 | |||
| 41 | /** |
||
| 42 | * Embed shortcode parser from Oembed. This is a temporary workaround. |
||
| 43 | * Oembed class has been replaced with the Embed external service. |
||
| 44 | * |
||
| 45 | * @param array $arguments |
||
| 46 | * @param string $content |
||
| 47 | * @param ShortcodeParser $parser |
||
| 48 | * @param string $shortcode |
||
| 49 | * @param array $extra |
||
| 50 | * |
||
| 51 | * @return string |
||
| 52 | */ |
||
| 53 | public static function handle_shortcode($arguments, $content, $parser, $shortcode, $extra = []) |
||
| 54 | { |
||
| 55 | // Get service URL |
||
| 56 | if (!empty($content)) { |
||
| 57 | $serviceURL = $content; |
||
| 58 | } elseif (!empty($arguments['url'])) { |
||
| 59 | $serviceURL = $arguments['url']; |
||
| 60 | } else { |
||
| 61 | return ''; |
||
| 62 | } |
||
| 63 | |||
| 64 | // Try to use cached result |
||
| 65 | $cache = static::getCache(); |
||
| 66 | $key = static::deriveCacheKey($serviceURL); |
||
| 67 | try { |
||
| 68 | if ($cache->has($key)) { |
||
| 69 | return $cache->get($key); |
||
| 70 | } |
||
| 71 | } catch (InvalidArgumentException $e) { |
||
|
Coding Style
Comprehensibility
introduced
by
|
|||
| 72 | } |
||
| 73 | |||
| 74 | // See https://github.com/oscarotero/Embed#example-with-all-options for service arguments |
||
| 75 | $serviceArguments = []; |
||
| 76 | if (!empty($arguments['width'])) { |
||
| 77 | $serviceArguments['min_image_width'] = $arguments['width']; |
||
| 78 | } |
||
| 79 | if (!empty($arguments['height'])) { |
||
| 80 | $serviceArguments['min_image_height'] = $arguments['height']; |
||
| 81 | } |
||
| 82 | |||
| 83 | /** @var EmbedResource $embed */ |
||
| 84 | $embed = Injector::inst()->create(Embeddable::class, $serviceURL); |
||
| 85 | if (!empty($serviceArguments)) { |
||
| 86 | $embed->setOptions(array_merge($serviceArguments, (array) $embed->getOptions())); |
||
| 87 | } |
||
| 88 | |||
| 89 | // Allow resolver to be mocked |
||
| 90 | $dispatcher = null; |
||
| 91 | if (isset($extra['resolver'])) { |
||
| 92 | $dispatcher = Injector::inst()->create( |
||
| 93 | $extra['resolver']['class'], |
||
| 94 | $serviceURL, |
||
| 95 | $extra['resolver']['config'] |
||
| 96 | ); |
||
| 97 | } elseif (Injector::inst()->has(DispatcherInterface::class)) { |
||
| 98 | $dispatcher = Injector::inst()->get(DispatcherInterface::class); |
||
| 99 | } |
||
| 100 | |||
| 101 | if ($dispatcher) { |
||
| 102 | $embed->setDispatcher($dispatcher); |
||
| 103 | } |
||
| 104 | |||
| 105 | // Process embed |
||
| 106 | try { |
||
| 107 | $embed = $embed->getEmbed(); |
||
| 108 | } catch (InvalidUrlException $e) { |
||
| 109 | $message = (Director::isDev()) |
||
| 110 | ? $e->getMessage() |
||
| 111 | : _t(__CLASS__ . '.INVALID_URL', 'There was a problem loading the media.'); |
||
| 112 | |||
| 113 | $attr = [ |
||
| 114 | 'class' => 'ss-media-exception embed' |
||
| 115 | ]; |
||
| 116 | |||
| 117 | $result = HTML::createTag( |
||
| 118 | 'div', |
||
| 119 | $attr, |
||
| 120 | HTML::createTag('p', [], $message) |
||
| 121 | ); |
||
| 122 | return $result; |
||
| 123 | } |
||
| 124 | |||
| 125 | // Convert embed object into HTML |
||
| 126 | if ($embed && $embed instanceof Adapter) { |
||
| 127 | $result = static::embedForTemplate($embed, $arguments); |
||
| 128 | } |
||
| 129 | // Fallback to link to service |
||
| 130 | if (!$result) { |
||
| 131 | $result = static::linkEmbed($arguments, $serviceURL, $serviceURL); |
||
| 132 | } |
||
| 133 | // Cache result |
||
| 134 | if ($result) { |
||
| 135 | try { |
||
| 136 | $cache->set($key, $result); |
||
| 137 | } catch (InvalidArgumentException $e) { |
||
| 138 | } |
||
| 139 | } |
||
| 140 | return $result; |
||
| 141 | } |
||
| 142 | |||
| 143 | /** |
||
| 144 | * @param Adapter $embed |
||
| 145 | * @param array $arguments Additional shortcode params |
||
| 146 | * @return string |
||
| 147 | */ |
||
| 148 | public static function embedForTemplate($embed, $arguments) |
||
| 149 | { |
||
| 150 | switch ($embed->getType()) { |
||
| 151 | case 'video': |
||
| 152 | case 'rich': |
||
| 153 | // Attempt to inherit width (but leave height auto) |
||
| 154 | if (empty($arguments['width']) && $embed->getWidth()) { |
||
| 155 | $arguments['width'] = $embed->getWidth(); |
||
| 156 | } |
||
| 157 | return static::videoEmbed($arguments, $embed->getCode()); |
||
| 158 | case 'link': |
||
| 159 | return static::linkEmbed($arguments, $embed->getUrl(), $embed->getTitle()); |
||
| 160 | case 'photo': |
||
| 161 | return static::photoEmbed($arguments, $embed->getUrl()); |
||
| 162 | default: |
||
| 163 | return null; |
||
| 164 | } |
||
| 165 | } |
||
| 166 | |||
| 167 | /** |
||
| 168 | * Build video embed tag |
||
| 169 | * |
||
| 170 | * @param array $arguments |
||
| 171 | * @param string $content Raw HTML content |
||
| 172 | * @return string |
||
| 173 | */ |
||
| 174 | protected static function videoEmbed($arguments, $content) |
||
| 175 | { |
||
| 176 | // Ensure outer div has given width (but leave height auto) |
||
| 177 | if (!empty($arguments['width'])) { |
||
| 178 | $arguments['style'] = 'width: ' . intval($arguments['width']) . 'px;'; |
||
| 179 | } |
||
| 180 | |||
| 181 | // override iframe dimension attributes provided by webservice with ones specified in shortcode arguments |
||
| 182 | foreach (['width', 'height'] as $attr) { |
||
| 183 | if (!($value = $arguments[$attr] ?? false)) { |
||
| 184 | continue; |
||
| 185 | } |
||
| 186 | foreach (['"', "'"] as $quote) { |
||
| 187 | $rx = "/(<iframe .*?)$attr=$quote([0-9]+)$quote([^>]+>)/"; |
||
| 188 | $content = preg_replace($rx, "$1{$attr}={$quote}{$value}{$quote}$3", $content); |
||
| 189 | } |
||
| 190 | } |
||
| 191 | |||
| 192 | $data = [ |
||
| 193 | 'Arguments' => $arguments, |
||
| 194 | 'Attributes' => static::buildAttributeListFromArguments($arguments, ['width', 'height', 'url', 'caption']), |
||
| 195 | 'Content' => DBField::create_field('HTMLFragment', $content) |
||
| 196 | ]; |
||
| 197 | |||
| 198 | return ArrayData::create($data)->renderWith(self::class . '_video')->forTemplate(); |
||
| 199 | } |
||
| 200 | |||
| 201 | /** |
||
| 202 | * Build <a> embed tag |
||
| 203 | * |
||
| 204 | * @param array $arguments |
||
| 205 | * @param string $href |
||
| 206 | * @param string $title Default title |
||
| 207 | * @return string |
||
| 208 | */ |
||
| 209 | protected static function linkEmbed($arguments, $href, $title) |
||
| 210 | { |
||
| 211 | $data = [ |
||
| 212 | 'Arguments' => $arguments, |
||
| 213 | 'Attributes' => static::buildAttributeListFromArguments($arguments, ['width', 'height', 'url', 'caption']), |
||
| 214 | 'Href' => $href, |
||
| 215 | 'Title' => !empty($arguments['caption']) ? ($arguments['caption']) : $title |
||
| 216 | ]; |
||
| 217 | |||
| 218 | return ArrayData::create($data)->renderWith(self::class . '_link')->forTemplate(); |
||
| 219 | } |
||
| 220 | |||
| 221 | /** |
||
| 222 | * Build img embed tag |
||
| 223 | * |
||
| 224 | * @param array $arguments |
||
| 225 | * @param string $src |
||
| 226 | * @return string |
||
| 227 | */ |
||
| 228 | protected static function photoEmbed($arguments, $src) |
||
| 229 | { |
||
| 230 | $data = [ |
||
| 231 | 'Arguments' => $arguments, |
||
| 232 | 'Attributes' => static::buildAttributeListFromArguments($arguments, ['url']), |
||
| 233 | 'Src' => $src |
||
| 234 | ]; |
||
| 235 | |||
| 236 | return ArrayData::create($data)->renderWith(self::class . '_photo')->forTemplate(); |
||
| 237 | } |
||
| 238 | |||
| 239 | /** |
||
| 240 | * Build a list of HTML attributes from embed arguments - used to preserve backward compatibility |
||
| 241 | * |
||
| 242 | * @deprecated 4.5.0 Use {$Arguments.name} directly in shortcode templates to access argument values |
||
| 243 | * @param array $arguments List of embed arguments |
||
| 244 | * @param array $exclude List of attribute names to exclude from the resulting list |
||
| 245 | * @return ArrayList |
||
| 246 | */ |
||
| 247 | private static function buildAttributeListFromArguments(array $arguments, array $exclude = []): ArrayList |
||
| 248 | { |
||
| 249 | $attributes = ArrayList::create(); |
||
| 250 | foreach ($arguments as $key => $value) { |
||
| 251 | if (in_array($key, $exclude)) { |
||
| 252 | continue; |
||
| 253 | } |
||
| 254 | |||
| 255 | $attributes->push(ArrayData::create([ |
||
| 256 | 'Name' => $key, |
||
| 257 | 'Value' => Convert::raw2att($value) |
||
| 258 | ])); |
||
| 259 | } |
||
| 260 | |||
| 261 | return $attributes; |
||
| 262 | } |
||
| 263 | |||
| 264 | /** |
||
| 265 | * @param ShortcodeParser $parser |
||
| 266 | * @param string $content |
||
| 267 | */ |
||
| 268 | public static function flushCachedShortcodes(ShortcodeParser $parser, string $content): void |
||
| 288 | } |
||
| 289 | } |
||
| 290 | } |
||
| 291 | |||
| 292 | /** |
||
| 293 | * @return CacheInterface |
||
| 294 | */ |
||
| 295 | private static function getCache(): CacheInterface |
||
| 298 | } |
||
| 299 | |||
| 300 | /** |
||
| 301 | * @param string $url |
||
| 302 | * @return string |
||
| 303 | */ |
||
| 304 | private static function deriveCacheKey(string $url): string |
||
| 308 | } |
||
| 309 | } |
||
| 310 |
Loading history...
