Completed
Push — php7-support ( 4474fe...119dc9 )
by Sam
06:04
created
tests/core/manifest/ManifestFileFinderTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -14,6 +14,10 @@
 block discarded – undo
14 14
 		parent::__construct();
15 15
 	}
16 16
 
17
+	/**
18
+	 * @param ManifestFileFinder $finder
19
+	 * @param string[] $expect
20
+	 */
17 21
 	public function assertFinderFinds($finder, $expect, $message = null) {
18 22
 		$found = $finder->find($this->base);
19 23
 
Please login to merge, or discard this patch.
tests/core/manifest/TemplateLoaderTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -174,12 +174,18 @@
 block discarded – undo
174 174
 		$this->loader->pushManifest($this->manifest);
175 175
 	}
176 176
 
177
+	/**
178
+	 * @param string[] $templates
179
+	 */
177 180
 	protected function createTestTemplates($templates) {
178 181
 		foreach ($templates as $template) {
179 182
 			file_put_contents($template, '');
180 183
 		}
181 184
 	}
182 185
 
186
+	/**
187
+	 * @param string[] $templates
188
+	 */
183 189
 	protected function removeTestTemplates($templates) {
184 190
 		foreach ($templates as $template) {
185 191
 			unlink($template);
Please login to merge, or discard this patch.
tests/core/startup/ErrorControlChainTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -9,6 +9,10 @@
 block discarded – undo
9 9
 class ErrorControlChainTest_Chain extends ErrorControlChain {
10 10
 
11 11
 	// Change function visibility to be testable directly
12
+
13
+	/**
14
+	 * @param string $memstring
15
+	 */
12 16
 	public function translateMemstring($memstring) {
13 17
 		return parent::translateMemstring($memstring);
14 18
 	}
Please login to merge, or discard this patch.
tests/core/startup/ParameterConfirmationTokenTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -23,6 +23,9 @@
 block discarded – undo
23 23
 
24 24
 class ParameterConfirmationTokenTest extends SapphireTest {
25 25
 
26
+	/**
27
+	 * @param string $part
28
+	 */
26 29
 	private function addPart($answer, $slash, $part) {
27 30
 		$bare = str_replace('/', '', $part);
28 31
 
Please login to merge, or discard this patch.
tests/dev/CsvBulkLoaderTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -224,6 +224,9 @@
 block discarded – undo
224 224
 	}
225 225
 
226 226
 
227
+	/**
228
+	 * @param resource $file
229
+	 */
227 230
 	protected function getLineCount(&$file) {
228 231
 		$i = 0;
229 232
 		while(fgets($file) !== false) $i++;
Please login to merge, or discard this patch.
tests/dev/DevAdminControllerTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -47,6 +47,9 @@  discard block
 block discarded – undo
47 47
 
48 48
 
49 49
 
50
+	/**
51
+	 * @param string $url
52
+	 */
50 53
 	protected function getCapture($url){
51 54
 		$this->logInWithPermission('ADMIN');
52 55
 
@@ -58,6 +61,9 @@  discard block
 block discarded – undo
58 61
 		return $r;
59 62
 	}
60 63
 
64
+	/**
65
+	 * @param string $url
66
+	 */
61 67
 	protected function getAndCheckForError($url){
62 68
 		$this->logInWithPermission('ADMIN');
63 69
 
Please login to merge, or discard this patch.
tests/filesystem/AssetStoreTest.php 1 patch
Doc Comments   +11 added lines patch added patch discarded remove patch
@@ -490,15 +490,26 @@
 block discarded – undo
490 490
 		return parent::cleanFilename($filename);
491 491
 	}
492 492
 	
493
+	/**
494
+	 * @param string $filename
495
+	 * @param string $hash
496
+	 * @param string $variant
497
+	 */
493 498
 	public function getFileID($filename, $hash, $variant = null) {
494 499
 		return parent::getFileID($filename, $hash, $variant);
495 500
 	}
496 501
 
497 502
 
503
+	/**
504
+	 * @param string $fileID
505
+	 */
498 506
 	public function getOriginalFilename($fileID, &$variant = '') {
499 507
 		return parent::getOriginalFilename($fileID, $variant);
500 508
 	}
501 509
 
510
+	/**
511
+	 * @param null|string $variant
512
+	 */
502 513
 	public function getDefaultConflictResolution($variant) {
503 514
 		return parent::getDefaultConflictResolution($variant);
504 515
 	}
Please login to merge, or discard this patch.
tests/filesystem/FileFinderTest.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -98,6 +98,11 @@
 block discarded – undo
98 98
 			'The finder respects the max depth setting.');
99 99
 	}
100 100
 
101
+	/**
102
+	 * @param SS_FileFinder $finder
103
+	 * @param string[] $expect
104
+	 * @param string $message
105
+	 */
101 106
 	public function assertFinderFinds($finder, $expect, $message = null) {
102 107
 		$found = $finder->find($this->base);
103 108
 
Please login to merge, or discard this patch.
tests/forms/EmailFieldTest.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -23,6 +23,11 @@
 block discarded – undo
23 23
 		$this->internalCheck("domain.but.no.user", "Invalid, no user part", false);
24 24
 	}
25 25
 
26
+	/**
27
+	 * @param string $email
28
+	 * @param string $checkText
29
+	 * @param boolean $expectSuccess
30
+	 */
26 31
 	public function internalCheck($email, $checkText, $expectSuccess) {
27 32
 		$field = new EmailField("MyEmail");
28 33
 		$field->setValue($email);
Please login to merge, or discard this patch.